Mantis Bugtracker
Main | My View | View Issues | Change Log | Roadmap | Docs
  

Viewing Issue Simple Details [ Jump to Notes ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006720 [CMake] CMake minor always 2008-04-04 13:09 2008-04-23 08:37
Reporter J. Bedouet View Status public  
Assigned To
Priority normal Resolution fixed  
Status closed   Product Version CMake-2-6
Summary 0006720: SOURCE_GROUP and Visual Studio 6
Description Hello,

The macro SOURCE_GROUP doesn't completely work with Visual Studio 6.

It's just the fact that subgroups are not supported.

The 2.6 documentation says
>> The name of the group may contain backslashes to specify subgroups:
>> source_group(outer\\inner ...)

It works for Visual Studio .NET 2003 but not for Visual Studio 6.
Additional Information Tested with CMake 2.4.8 and CMake 2.6.0 RC-6.

No subgroups appear and no source files are included in the Visual Studio 6 project. So, the targets of the project are not compiled.
It only works with groups.
Tags No tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0011199)
Yang Yubo (reporter)
2008-04-09 02:22

 Change following code at cmLocalVisualStudio6Generator.cxx file :

::WriteGroup(const cmSourceGroup *sg, cmTarget& target,
             std::ostream &fout, const char *libName)
{
  const std::vector<const cmSourceFile *> &sourceFiles =
    sg->GetSourceFiles();
  // If the group is empty, don't write it at all.
        
  if(sourceFiles.empty())
    {
    return;
    }

to ---

::WriteGroup(const cmSourceGroup *sg, cmTarget& target,
             std::ostream &fout, const char *libName)
{
  const std::vector<const cmSourceFile *> &sourceFiles =
    sg->GetSourceFiles();
  // If the group is empty, don't write it at all.
        
  if(sourceFiles.empty() && sg->GetGroupChildren().empty())
    {
    return;
    }

Should fix this problem, already tested with CMake 2.6.0 RC-6 .
(0011387)
J. Bedouet (reporter)
2008-04-16 08:48
edited on: 2008-04-16 08:49

 OK, it works for me (tested with the last cvs version).
In which version will this fix be officially released ?
Thanks a lot,
(0011388)
Yang Yubo (reporter)
2008-04-16 08:56

 Well, I'm not the CMake developer, I also hope this patch will be included in next official release.
(0011467)
Bill Hoffman (manager)
2008-04-21 18:25

 I have made the commit, please let me know if it works, and I will move it over to the 2.6 branch:

$ cvs commit -m "BUG: fix for 6720, source groups on vs6 not working" cmLocalVi
sualStudio6Generator.cxx
/cvsroot/CMake/CMake/Source/cmLocalVisualStudio6Generator.cxx,v <-- cmLocalVis
ualStudio6Generator.cxx
new revision: 1.142; previous revision: 1.141
(0011501)
Bill Hoffman (manager)
2008-04-23 08:37

 I have put the recommned patch in CVS and it will be in 2.6.0, it would be nice if one of you tested it... But, I am closing the bug anyway.

- Issue History
Date Modified Username Field Change
2008-04-04 13:09 J. Bedouet New Issue
2008-04-09 02:22 Yang Yubo Note Added: 0011199
2008-04-09 21:27 Yang Yubo Issue Monitored: Yang Yubo
2008-04-16 07:44 J. Bedouet Note Added: 0011386
2008-04-16 07:46 J. Bedouet Note Deleted: 0011386
2008-04-16 08:48 J. Bedouet Note Added: 0011387
2008-04-16 08:49 J. Bedouet Note Edited: 0011387
2008-04-16 08:56 Yang Yubo Note Added: 0011388
2008-04-21 18:25 Bill Hoffman Note Added: 0011467
2008-04-23 08:37 Bill Hoffman Status new => closed
2008-04-23 08:37 Bill Hoffman Note Added: 0011501
2008-04-23 08:37 Bill Hoffman Resolution open => fixed
2008-04-23 21:14 Yang Yubo Issue End Monitor: Yang Yubo

Mantis 1.1.4[^]
Copyright © 2000 - 2008 Mantis Group
Powered by Mantis Bugtracker