Just a quick question, will we have this issue again if we were to upgrade the zlibs? Can we contribute this back?<div><br></div><div>- Wes<br><br><div class="gmail_quote">On Wed, Jan 20, 2010 at 12:41 PM, Dave Partyka <span dir="ltr"><<a href="mailto:dave.partyka@kitware.com">dave.partyka@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Okay, suppression removed and VTK is patched. I don't have ITK write access at the moment though.<div><div></div><div class="h5">
<br><br><div class="gmail_quote">On Wed, Jan 20, 2010 at 12:07 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I agree if it can be fixed it should not be suppressed. David C. I<br>
think we have the same issue with itk.<br>
<br>
Let's remove the suppression and I'll apply David C.'s change to both<br>
vtk and itk.<br>
<font color="#888888"><br>
Bill<br>
</font><div><div></div><div><br>
On Wed, Jan 20, 2010 at 11:35 AM, Dave Partyka <<a href="mailto:dave.partyka@kitware.com" target="_blank">dave.partyka@kitware.com</a>> wrote:<br>
> Dude! That ruins my performance! ;-)<br>
> I agree, I debated making a similar fix a few months ago but decided to<br>
> leave it.<br>
><br>
> On Wed, Jan 20, 2010 at 11:31 AM, David Cole <<a href="mailto:david.cole@kitware.com" target="_blank">david.cole@kitware.com</a>> wrote:<br>
>><br>
>> Or.....<br>
>> .....you could actually fix it as it deserves instead of sweeping it under<br>
>> the rug like the zlib people encourage us to in their faq.<br>
>><br>
>> I fixed it back in November in the CMake code base:<br>
>><br>
>> <a href="http://public.kitware.com/cgi-bin/viewcvs.cgi/Utilities/cmzlib/deflate.c?root=CMake&r1=1.2&r2=1.3" target="_blank">http://public.kitware.com/cgi-bin/viewcvs.cgi/Utilities/cmzlib/deflate.c?root=CMake&r1=1.2&r2=1.3</a><br>
>><br>
>> Things should be *fixed* not *suppressed* when possible.<br>
>><br>
>><br>
>> 2 cents,<br>
>> David C.<br>
>><br>
>><br>
>> On Wed, Jan 20, 2010 at 10:02 AM, Francois Bertel<br>
>> <<a href="mailto:francois.bertel@kitware.com" target="_blank">francois.bertel@kitware.com</a>> wrote:<br>
>>><br>
>>> The valgrind report of today on arkadia will have this suppression rule.<br>
>>><br>
>>> On Wed, Jan 20, 2010 at 8:47 AM, Dave Partyka <<a href="mailto:dave.partyka@kitware.com" target="_blank">dave.partyka@kitware.com</a>><br>
>>> wrote:<br>
>>> > Done.<br>
>>> ><br>
>>> > On Wed, Jan 20, 2010 at 8:28 AM, Bill Lorensen<br>
>>> > <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>><br>
>>> > wrote:<br>
>>> >><br>
>>> >> Could someone add the following valgrind suppression to the<br>
>>> >> suppressions files used by<br>
>>> >><br>
>>> >> amber2.kitware Linux-Valgrind<br>
>>> >> and<br>
>>> >> arkadia.kitware all-debug-g++-valgrind<br>
>>> >><br>
>>> >> {<br>
>>> >> Some zlib suppressions. See <a href="http://www.zlib.net/zlib_faq.html#faq36" target="_blank">www.zlib.net/zlib_faq.html#faq36</a><br>
>>> >> Memcheck:Cond<br>
>>> >> fun:longest_match<br>
>>> >> fun:deflate_slow<br>
>>> >> fun:vtk_zlib_deflate<br>
>>> >> }<br>
>>> >><br>
>>> >> This is responsible for most of the conditional jump errors.<br>
>>> >><br>
>>> >> Thanks,<br>
>>> >><br>
>>> >> Bill<br>
>>> >> _______________________________________________<br>
>>> >> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>> >><br>
>>> >> Visit other Kitware open-source projects at<br>
>>> >> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>> >><br>
>>> >> Follow this link to subscribe/unsubscribe:<br>
>>> >> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>>> >><br>
>>> ><br>
>>> ><br>
>>> > _______________________________________________<br>
>>> > Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>> ><br>
>>> > Visit other Kitware open-source projects at<br>
>>> > <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>> ><br>
>>> > Follow this link to subscribe/unsubscribe:<br>
>>> > <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>>> ><br>
>>> ><br>
>>> ><br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> François Bertel, PhD | Kitware Inc. Suite 204<br>
>>> 1 (518) 371 3971 x113 | 28 Corporate Drive<br>
>>> | Clifton Park NY 12065, USA<br>
>>> _______________________________________________<br>
>>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>>><br>
>>> Visit other Kitware open-source projects at<br>
>>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>>><br>
>>> Follow this link to subscribe/unsubscribe:<br>
>>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>><br>
>> Visit other Kitware open-source projects at<br>
>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
><br>
><br>
><br>
</div></div></blockquote></div><br>
</div></div><br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Wesley D. Turner, Ph.D.<br>Kitware, Inc.<br>Technical Leader<br>28 Corporate Drive<br>Clifton Park, NY 12065-8662<br>Phone: 518-881-4920<br>
</div>