<div>Hi David,</div><div><br></div><div>Thanks for all of the work you have put into this. David Cole is going to look over the topic branch, hopefully at some point today. If he doesn't spot any major issues I would like to merge this into master early next week.</div>
<div><br></div><div>I am certainly excited about the improvements you are bringing to the wrapping in VTK.</div><div><br></div><div>Thanks,</div><div><br></div><div>Marcus</div><br><div class="gmail_quote">On Thu, May 27, 2010 at 4:52 PM, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">I've pushed the last of the changes to my "wrapping" branch on github.<br>
It's ready for merge.<br>
<font color="#888888"><br>
David<br>
</font><div><div></div><div class="h5"><br>
<br>
On Wed, May 26, 2010 at 4:49 PM, David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>> wrote:<br>
> In the new wrappers, there is already full support vtkStdString<br>
> support Tcl and Java, and I've even added string regression test for<br>
> Tcl.<br>
><br>
> Unicode was easy to add to Python (a few hours work), and it should be<br>
> similarly easy for someone to add it for Tcl and Java. There are<br>
> plenty of people who want it, I'm sure.<br>
><br>
> Divergence is a concern, but at least all wrappers use the same<br>
> front-end, so transferring enhancements from one set of wrappers to<br>
> another is that much easier. And Brad King mentioned a wrapper<br>
> utility .cxx that all wrappers use... this would be great, because<br>
> right now there is a huge amount of code duplication.<br>
><br>
> I'll switch over to the branch immediately, and in the future I will<br>
> make branches for any other projects that involve multiple classes.<br>
><br>
> David<br>
><br>
><br>
> On Wed, May 26, 2010 at 3:58 PM, Marcus D. Hanwell<br>
> <<a href="mailto:marcus.hanwell@kitware.com">marcus.hanwell@kitware.com</a>> wrote:<br>
>> Hi David,<br>
>> On Wed, May 26, 2010 at 5:46 PM, David Gobbi <<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>> wrote:<br>
>>><br>
>>> Thanks for doing this! I was not looking forward to doing the<br>
>>> clean-up work myself... when I started it never occurred to me to<br>
>>> create a branch, my plan was to eventually re-base my changes on the<br>
>>> VTK master.<br>
>><br>
>> Topic branches are much easier for us to work with, and if you avoid merging<br>
>> into them/rebasing then the eventual merge into master becomes simpler. Now<br>
>> that we have it you could continue your work in that branch, or we could<br>
>> cherry pick the commits you make.<br>
>>><br>
>>> There are just two minor changes that I can squeeze in over the next<br>
>>> two days, and I will email you when they are done. After that, the<br>
>>> sooner that the branch can be merged into master, the better. In<br>
>>> order for the special-type wrapping to be fully realized, most (or<br>
>>> all) of the BTX's will have to be removed from the code. A change<br>
>>> that big will probably be easier to do in the master than to merge in<br>
>>> from a branch.<br>
>><br>
>> A global change like that is definitely something that would be easier done<br>
>> in master as you say. We can take care of that once it looks ready to go<br>
>> in.<br>
>>><br>
>>> I've already tested VTK (with python, tcl, and java) without BTX/ETX.<br>
>>> The Tcl and Java wrappers compiled and tested cleanly, and so did<br>
>>> Python after I did some small fixes to the way that it does special<br>
>>> type wrapping. It is these python fixes that I need to commit before<br>
>>> the merge.<br>
>>><br>
>> I think one of the remaining concerns is how much the wrapping might<br>
>> diverge, i.e. if Python supports vtkVariant, unicode, vtkStdString etc but<br>
>> other languages did not. I am certainly very pleased with the changes in<br>
>> Python, and can see how much it will improve the Python wrapping in charts<br>
>> and infovis.<br>
>><br>
>>><br>
>>> There are other changes that I'm planning for the Python wrappers<br>
>>> (enums, etc) but for them I'd prefer to wait until after the merge.<br>
>>> I'll put together a wiki page so that they can be reviewed.<br>
>>><br>
>> You could publish them in a topic branch for us to review. The main caveats<br>
>> remain to avoid rebasing/merging from master. Once we are ready to merge<br>
>> into master we can take care of that. Thanks for putting this together, and<br>
>> to Keith for preparing this topic branch.<br>
>> I am very hopeful that we can merge these changes in soon. We have been<br>
>> working away behind the scenes to get this ready to be reviewed and merged<br>
>> in.<br>
>> Thanks,<br>
>> Marcus<br>
>>><br>
>>> On Wed, May 26, 2010 at 2:39 PM, Keith Fieldhouse<br>
>>> <<a href="mailto:keith.fieldhouse@kitware.com">keith.fieldhouse@kitware.com</a>> wrote:<br>
>>> > David<br>
>>> > I've been spending some time looking at your Wrapping work. It appears<br>
>>> > that<br>
>>> > your git tree was built with a mixture of rebasing and merging which<br>
>>> > resulted in a somewhat wonky commit history (duplicated commits<br>
>>> > interspersed<br>
>>> > with commits coming from VTK master).<br>
>>> > In order to get a clean topic branch that will be a little easier for<br>
>>> > folks<br>
>>> > here to look at (and to eventually merge with master) I spent a bit of<br>
>>> > time<br>
>>> > untangling your history (mostly by examining parentage and looking at<br>
>>> > commit<br>
>>> > subjects). In the end, by cherry picking the right commits in what I<br>
>>> > considered the "right" order I was able to build a clean topic branch<br>
>>> > with<br>
>>> > no conflicts. Once I had that, I rebased it against master (as of this<br>
>>> > afternoon sometime when I did it). The result can be found in<br>
>>> > git://<a href="http://github.com/keith-fieldhouse/VTK.git" target="_blank">github.com/keith-fieldhouse/VTK.git</a><br>
>>> > As the topic branch Gobbi/Wrapping.<br>
>>> > The result builds and the tests run so I believe that I've built a a<br>
>>> > representative branch from your work.<br>
>>> > If you plan on doing additional work on this, would it be possible for<br>
>>> > you<br>
>>> > to grab this topic branch and work on that (without rebasing or merging<br>
>>> > for<br>
>>> > now)? That way we'll have a clean topic branch for an eventual merge<br>
>>> > to<br>
>>> > "Next" when we switch to branchy development for VTK. Or if branchy<br>
>>> > development comes later, this clean topic branch will be easier to<br>
>>> > rebase as<br>
>>> > well.<br>
>>> > Thanks again for your work on this.<br>
>>> > Keith<br>
>>> > --<br>
>>> > Keith Fieldhouse<br>
>>> > R&D Engineer, Kitware Inc.<br>
>>> > (518) 836-2190<br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> ><br>
>><br>
>><br>
><br>
</div></div></blockquote></div><br>