arguably the email was more work... <br><br>I know it's now a big deal, but I like compiling with pedantic and I'm always hit with this. Although it's the *only* warning I see (though not very comprehensive coverage) in VTK. So good on all the VTK developers. Thanks.<br>
<br clear="all">-- Trevor<br><br>
<br><br><div class="gmail_quote">On 18 August 2012 03:29, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com" target="_blank">david.gobbi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">On Fri, Aug 17, 2012 at 8:23 PM, John Drescher <<a href="mailto:drescherjm@gmail.com">drescherjm@gmail.com</a>> wrote:<br>
> On Fri, Aug 17, 2012 at 10:19 PM, Trevor Irons <<a href="mailto:trevorirons@gmail.com">trevorirons@gmail.com</a>> wrote:<br>
>> When I compile using gcc on pedantic I've been bothered by a warning for<br>
>> years. Was hoping someone with commit access could spend about 12 seconds<br>
>> and fix this.<br>
>><br>
>> The warning reads<br>
>> In file included from external/matplot/matplot.h:40:0,<br>
>> from<br>
>> /home/tirons/src/Merlin/include/snmrinversion1damp.h:45,<br>
>> from<br>
>> /home/tirons/src/Merlin/unittest/utsnmrinversion1dgmrsimul.cpp:40:<br>
>> /usr/local/include/vtk-6.0/vtkXYPlotActor.h:395:28: warning: comma at end of<br>
>> enumerator list [-pedantic]<br>
>><br>
>> In vtkXYPlotActor.h line 395 there is an extra comma :<br>
>><br>
>> enum Alignment {<br>
>> AlignLeft = 0x1,<br>
>> AlignRight = 0x2,<br>
>> AlignHCenter = 0x4,<br>
>> AlignTop = 0x10,<br>
>> AlignBottom = 0x20,<br>
>> AlignVCenter = 0x40,<br>
>> AlignAxisLeft = 0x100,<br>
>> AlignAxisRight = 0x200,<br>
>> AlignAxisHCenter = 0x400,<br>
>> AlignAxisTop = 0x1000,<br>
>> AlignAxisBottom = 0x2000,<br>
>> AlignAxisVCenter = 0x4000, <-- Extra comma right here<br>
>> };<br>
>><br>
>> I would really appreciate it if someone with commit privileges could remove<br>
>> this.<br>
>><br>
><br>
> Isn't that legal in c++? I intentionally make my enums that way..<br>
<br>
</div></div>It was illegal until C++11, though compilers have been lax about it.<br>
So, yes, the extra comma should be removed but I've already<br>
spent more than 12 seconds just typing this email...<br>
<br>
Trailing commas in initializer lists have always been legal, though.<br>
<span class="HOEnZb"><font color="#888888"><br>
- David<br>
</font></span></blockquote></div><br>