View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013231ParaView(No Category)public2012-06-08 16:022015-01-11 08:29
ReporterLawrence 
Assigned ToUtkarsh Ayachit 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.14.1 
Target VersionFixed in Version3.98.1 
Summary0013231: Heap corruption when vtkTables are deleted but view remains
DescriptionSummary:
The spreadsheet view used to for vtkTable objects (vtkQtTableView? and/or pqSpreadSheetViewModel.cxx) is not well behaved when the vtktable is deleted.

A debug build suggests the heap is corrupted.

Steps to reproduce:
1. Open a csv file, the attached file on Windows debug build of 3.14.1 appears to reliably demonstrate the problem.

The table will load and the table's contents will be displayed.
2. Delete the table (or select Edit Menu>Delete All).


Result: The spreadsheet is still shown.
But the original column names are still shown!

3. Play with the table e.g. resize the column names and scroll -

When the view is repainted the column names change to "__BUG__"
(defined in ./Qt/Core/pqSpreadSheetViewModel.cxx)

4. In debug builds, later when creating new objects Paraview will break inside the system implementation of 'new', suggesting heap corruption.

I'm marking this bug as a crash on the presumption that the system break inside heap allocation and the "__BUG__" are sufficient indicators of a heap corruption and invalid memory access.

Best,
Lawrence.
TagsNo tags attached.
ProjectTBD
Topic Name13231_fix_spreadsheet_view
Typecrash
Attached Filescsv file icon some_table_data.csv [^] (4,143 bytes) 2012-06-08 16:02

 Relationships

  Notes
(0028678)
Lawrence (reporter)
2012-06-08 16:04

FYI Build config:
 64 bit debug build, Qt4.6.4, VS2008 SP1, Python on
(0029793)
Sebastien Jourdain (manager)
2012-11-27 14:47

This is just when the data model became invalid and we need to provide some title to the given column.
The string "__BUG__" has been chosen.
This is not going to crash anything or induce any invalid memory access.
(0029910)
Utkarsh Ayachit (administrator)
2012-12-19 07:54

commit 35eee4eb18b9ebf991ee1a557d21175aad9f96fd
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Wed Dec 19 07:52:24 2012 -0500

    BUG 0013231. Fixed spreadsheet view when data was deleted.
    
    Spreadsheet view would not update to show 0 rows/columns when the data source
    being shown in the view was deleted. This caused misleading text display. This
    fixes that issue. vtkSpreadSheetView needed to report that the data had changed
    otherwise the UI would not reset it self resulting in the bug reported.
    
    Change-Id: I46f81c050b6445bc4c577dc0280cb9169a45b661
(0029927)
Utkarsh Ayachit (administrator)
2012-12-21 11:21

merged into master, if applicable.
(0030058)
Alan Scott (manager)
2013-01-10 19:43

Tested local server, Windows, master.

 Issue History
Date Modified Username Field Change
2012-06-08 16:02 Lawrence New Issue
2012-06-08 16:02 Lawrence File Added: some_table_data.csv
2012-06-08 16:04 Lawrence Note Added: 0028678
2012-11-27 14:47 Sebastien Jourdain Note Added: 0029793
2012-12-19 07:42 Utkarsh Ayachit Assigned To => Utkarsh Ayachit
2012-12-19 07:54 Utkarsh Ayachit Topic Name => 13231_fix_spreadsheet_view
2012-12-19 07:54 Utkarsh Ayachit Note Added: 0029910
2012-12-19 07:54 Utkarsh Ayachit Status backlog => gatekeeper review
2012-12-19 07:54 Utkarsh Ayachit Fixed in Version => git-next
2012-12-19 07:54 Utkarsh Ayachit Resolution open => fixed
2012-12-21 11:20 Utkarsh Ayachit Fixed in Version git-next => git-master
2012-12-21 11:21 Utkarsh Ayachit Status gatekeeper review => customer review
2012-12-21 11:21 Utkarsh Ayachit Note Added: 0029927
2013-01-10 19:43 Alan Scott Note Added: 0030058
2013-01-10 19:43 Alan Scott Status customer review => closed
2013-01-30 10:40 Utkarsh Ayachit Fixed in Version git-master => 3.98.1
2015-01-11 08:29 Utkarsh Ayachit Source_changeset_attached => ParaView master 223ef050
2015-01-11 08:29 Utkarsh Ayachit Source_changeset_attached => ParaView master 35eee4eb


Copyright © 2000 - 2018 MantisBT Team