View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013629ParaView(No Category)public2012-11-07 22:242013-01-30 10:40
ReporterAlan Scott 
Assigned ToUtkarsh Ayachit 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.98.0 
Target VersionFixed in Version3.98.1 
Summary0013629: Variable selection
DescriptionAllow variables to be selected by clicking anywhere on the line, as opposed to only the checkbox. For instance, open can.exo. Click on "DISPL" (not the X). It should be selected.
TagsNo tags attached.
ProjectSandia
Topic Name13739_fix_variable_selection
Typeincorrect functionality
Attached Files

 Relationships
related to 0013739closedUtkarsh Ayachit Group select of variables no longer works 

  Notes
(0029897)
David Thompson (developer)
2012-12-17 13:14

 There was already some code (pqTreeWidgetCheckHelper) to make clicks in any column change one column's checkbox state. This branch just applies it to the pqExodusIIVariableSelectionWidget. Curiously, the helper class does not appear to be used anywhere else in ParaView but Utkarsh created it in 2006...
(0029931)
Utkarsh Ayachit (administrator)
2012-12-21 11:21

 merged into master, if applicable.
(0029973)
Alan Scott (manager)
2013-01-03 16:55

 Waiting for 13739, which impacts this bug.
(0029995)
Alan Scott (manager)
2013-01-07 12:41

 Master as of Friday late afternoon, Windows, local server.

This doesn't work correctly. Do the following:

Load can.exo.
All variables on.
Select the ACCL check box (not the text to the right of the check box).
hold <shift> down
Select the DISPL check box.

Bug - VEL doesn't turn off.

Selecting anywhere on the line should have the same effect.
(0029997)
Alan Scott (manager)
2013-01-07 12:42

 Note that there are two similar bugs here (related to each other). One is owned by Utkarsh and one by Dave.
(0030006)
Utkarsh Ayachit (administrator)
2013-01-08 11:29

 commit 36c9d889af8150faf8b161472684b89c273e1759
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Tue Jan 8 11:24:33 2013 -0500

    BUG 0013739. Fixes issues when user clicked on the check-box itself.
    
    Toggling the check-state of multiple items wasn't working correctly when the
    user clicked on the "checkbox" itself, rather than the name of the item. This
    fix address that issue. We make each of the items non-checkable. Thus Qt no
    longer deals with the check-box toggling. This results in the clicks on the
    "check-box" to be treated similar to clicks on the item's name. We have code
    that handles that already and hence everything works as expected. Now the
    perceived behaviour is identical whether the user click on the checkbox or its
    name in the variable selection widget.
    
    Change-Id: I30fb162788a8cf47214f72b92a91cbb1db6c9ff8
(0030110)
Utkarsh Ayachit (administrator)
2013-01-11 14:43

 merged into master, where applicable.
(0030127)
Alan Scott (manager)
2013-01-11 18:17

 That fixed it. Nice.

Tested remote server, master, Linux.

 Issue History
Date Modified Username Field Change
2012-11-07 22:24 Alan Scott New Issue
2012-12-14 18:12 David Thompson Assigned To => David Thompson
2012-12-17 13:14 David Thompson Topic Name => 13629_easy_exodus_variable_seln
2012-12-17 13:14 David Thompson Note Added: 0029897
2012-12-17 13:14 David Thompson Status backlog => gatekeeper review
2012-12-17 13:14 David Thompson Fixed in Version => git-next
2012-12-17 13:14 David Thompson Resolution open => fixed
2012-12-21 11:20 Utkarsh Ayachit Fixed in Version git-next => git-master
2012-12-21 11:21 Utkarsh Ayachit Status gatekeeper review => customer review
2012-12-21 11:21 Utkarsh Ayachit Note Added: 0029931
2012-12-31 11:20 Utkarsh Ayachit Note Added: 0029960
2012-12-31 11:23 Utkarsh Ayachit Note Edited: 0029960
2012-12-31 11:30 Utkarsh Ayachit Note Deleted: 0029960
2012-12-31 11:45 Utkarsh Ayachit Note Added: 0029961
2012-12-31 11:51 Utkarsh Ayachit Note Deleted: 0029961
2012-12-31 12:05 Utkarsh Ayachit Relationship added related to 0013739
2013-01-03 16:55 Alan Scott Note Added: 0029973
2013-01-07 12:41 Alan Scott Note Added: 0029995
2013-01-07 12:41 Alan Scott Status customer review => todo
2013-01-07 12:42 Alan Scott Note Added: 0029997
2013-01-08 10:30 Utkarsh Ayachit Assigned To David Thompson => Utkarsh Ayachit
2013-01-08 10:30 Utkarsh Ayachit Status todo => active development
2013-01-08 11:29 Utkarsh Ayachit Topic Name 13629_easy_exodus_variable_seln => 13739_fix_variable_selection
2013-01-08 11:29 Utkarsh Ayachit Note Added: 0030006
2013-01-08 11:29 Utkarsh Ayachit Status active development => gatekeeper review
2013-01-11 14:43 Utkarsh Ayachit Status gatekeeper review => customer review
2013-01-11 14:43 Utkarsh Ayachit Note Added: 0030110
2013-01-11 18:17 Alan Scott Note Added: 0030127
2013-01-11 18:17 Alan Scott Status customer review => closed
2013-01-30 10:40 Utkarsh Ayachit Fixed in Version git-master => 3.98.1

Copyright © 2000 - 2018 MantisBT Team