View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0013726 | ParaView | (No Category) | public | 2012-12-11 19:43 | 2015-01-11 08:29 | ||||
Reporter | Alan Scott | ||||||||
Assigned To | Utkarsh Ayachit | ||||||||
Priority | high | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | 3.98.0 | ||||||||
Target Version | Fixed in Version | 3.98.1 | |||||||
Summary | 0013726: Extreme slowness turning on all variables | ||||||||
Description | A user has a dataset that is extremely slow selecting all variables. It takes numerous minutes, up to 10ish minutes. This Exodus dataset has hundreds of variables in it. I can give Utkarsh the file (Windows 7, output_wedge_presto_paraview_bug.e) Open file. Select all variables. Wait for numerous minutes. Issue seems to be in pqExodusIIVariableSelectionWidget::pqInternals(), called (indirectly) from pqExodusIIVariableSelectionWidget::propertyChanged(). Seems to be an event driven call, to a foreach loop, with an inner findItem loop, with an inner foreach loop. Note that 3.14.0 selects all variables within about 5 seconds. This bug has made ParaView 3.98.0 unusable for my user. | ||||||||
Tags | No tags attached. | ||||||||
Project | Sandia | ||||||||
Topic Name | 13726_fix_variable_selection_performance | ||||||||
Type | incorrect functionality | ||||||||
Attached Files | |||||||||
Relationships | |
Relationships |
Notes | |
(0029869) Alan Scott (manager) 2012-12-11 19:43 |
Needed for 4.0 |
(0029878) Kyle Lutz (viewer) 2012-12-12 17:04 |
Utkarsh is on vacation. Can you send the file to anyone else at Kitware? Otherwise we'll have to wait until Utkarsh gets back. |
(0029879) Alan Scott (manager) 2012-12-12 18:31 |
file can be seen by anyone at Kitware. However, since this doesn't need to be fixed immediately (this week), I can just push to Utkarsh next week. Sound good, or is there a specific person you want it sent to? |
(0029907) Utkarsh Ayachit (administrator) 2012-12-18 14:16 |
commit d8446c652c82c4eb88122c4f77a254afbcd4b10a Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Tue Dec 18 14:10:32 2012 -0500 BUG 0013726. Fix variable selection performance. Addresses extreme slowness when dealing with lists containing large number of variables on panels such as exodus. Using a timer to collapse all updates into a single update thus avoiding the O(N^2) updates. |
(0029934) Utkarsh Ayachit (administrator) 2012-12-21 11:21 |
merged into master, if applicable. |
(0030002) Alan Scott (manager) 2013-01-07 21:13 edited on: 2013-01-07 21:24 |
This needs more fineness or polishing. A common thing to do is as follows: * Turn on all variables. (click the Variables button) * No wait - I only want 15 variables on. (Click the Variables button) * (Or, accidentally click the button twice, then again). Try clicking on this button twice, and the second one freezes for over a minute. |
(0030004) Utkarsh Ayachit (administrator) 2013-01-08 11:07 |
commit d428305797a386d6e5422876bc64512d024a50eb Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Tue Jan 8 11:04:23 2013 -0500 BUG 0013726. Fixing performance issues with updating variables. This fixes the performance issue still observed after the supposed fix d8446c652c. The issue was that we were still ending up with a list that updated the item multiple times. Updating the internal datastructures to create the smallest possible list of items that need updating. This addresses the issue. Change-Id: I878c5171b9a174d51b0ac853adba6b05f77be66a |
(0030109) Utkarsh Ayachit (administrator) 2013-01-11 14:43 |
merged into master, where applicable. |
(0030126) Alan Scott (manager) 2013-01-11 18:16 |
This seems to have fixed it. Sweet! Tested remote server, Linux, master. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2012-12-11 19:43 | Alan Scott | New Issue | |
2012-12-11 19:43 | Alan Scott | Note Added: 0029869 | |
2012-12-11 19:43 | Alan Scott | Status | backlog => todo |
2012-12-12 16:49 | Sebastien Jourdain | Assigned To | => Kyle Lutz |
2012-12-12 17:04 | Kyle Lutz | Note Added: 0029878 | |
2012-12-12 18:31 | Alan Scott | Note Added: 0029879 | |
2012-12-18 14:16 | Utkarsh Ayachit | Topic Name | => 13726_fix_variable_selection_performance, 13629_easy_exodus_variable_seln |
2012-12-18 14:16 | Utkarsh Ayachit | Note Added: 0029907 | |
2012-12-18 14:16 | Utkarsh Ayachit | Status | todo => gatekeeper review |
2012-12-18 14:16 | Utkarsh Ayachit | Fixed in Version | => git-next |
2012-12-18 14:16 | Utkarsh Ayachit | Resolution | open => fixed |
2012-12-18 14:16 | Utkarsh Ayachit | Assigned To | Kyle Lutz => Utkarsh Ayachit |
2012-12-19 09:55 | Utkarsh Ayachit | Topic Name | 13726_fix_variable_selection_performance, 13629_easy_exodus_variable_seln => 13726_fix_variable_selection_performance, 13629_easy_exodus_variable_seln, remove_obsolete_files |
2012-12-21 11:20 | Utkarsh Ayachit | Fixed in Version | git-next => git-master |
2012-12-21 11:21 | Utkarsh Ayachit | Status | gatekeeper review => customer review |
2012-12-21 11:21 | Utkarsh Ayachit | Note Added: 0029934 | |
2013-01-07 21:13 | Alan Scott | Note Added: 0030002 | |
2013-01-07 21:13 | Alan Scott | Status | customer review => todo |
2013-01-07 21:24 | Alan Scott | Note Edited: 0030002 | |
2013-01-08 10:30 | Utkarsh Ayachit | Status | todo => active development |
2013-01-08 11:07 | Utkarsh Ayachit | Topic Name | 13726_fix_variable_selection_performance, 13629_easy_exodus_variable_seln, remove_obsolete_files => 13726_fix_variable_selection_performance |
2013-01-08 11:07 | Utkarsh Ayachit | Note Added: 0030004 | |
2013-01-08 11:07 | Utkarsh Ayachit | Status | active development => gatekeeper review |
2013-01-08 11:07 | Utkarsh Ayachit | Fixed in Version | git-master => git-next |
2013-01-11 14:42 | Utkarsh Ayachit | Fixed in Version | git-next => git-master |
2013-01-11 14:43 | Utkarsh Ayachit | Status | gatekeeper review => customer review |
2013-01-11 14:43 | Utkarsh Ayachit | Note Added: 0030109 | |
2013-01-11 18:16 | Alan Scott | Note Added: 0030126 | |
2013-01-11 18:16 | Alan Scott | Status | customer review => closed |
2013-01-30 10:40 | Utkarsh Ayachit | Fixed in Version | git-master => 3.98.1 |
2015-01-11 08:28 | Utkarsh Ayachit | Source_changeset_attached | => ParaView master c9717e25 |
2015-01-11 08:28 | Utkarsh Ayachit | Source_changeset_attached | => ParaView master d4283057 |
2015-01-11 08:29 | Utkarsh Ayachit | Source_changeset_attached | => ParaView master 66684404 |
2015-01-11 08:29 | Utkarsh Ayachit | Source_changeset_attached | => ParaView master dc331ccc |
2015-01-11 08:29 | Utkarsh Ayachit | Source_changeset_attached | => ParaView master d8446c65 |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |