View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013865VTK(No Category)public2013-02-07 17:312013-12-16 15:39
ReporterBastian Angermann 
Assigned ToDave DeMarle 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version5.10.1 
Target VersionFixed in Version6.0.0 
Summary0013865: Legend in vtkPlotStracked shows the same color for all entries
DescriptionI am drawing a vtkPlotStracked where the colors are set using a vtkColorSeries.
All colors displayed in the legend are the same. The color that is displayed matches the color I would expect for the last entry (see the attached screenshot).

The code for the PaintLegend method reads
bool vtkPlotStacked::PaintLegend(vtkContext2D *painter, const vtkRectf& rect, int)
{
   painter->ApplyPen(this->Pen);
   painter->ApplyBrush(this->Brush);
   painter->DrawRect(rect[0], rect[1], rect[2], rect[3]);
   return true;
}

shouldn't this be

bool vtkPlotStacked::PaintLegend(vtkContext2D *painter, const vtkRectf& rect, int legendIndex)
{
  if (this->ColorSeries)
  {
    this->Brush->SetColor(
          this->ColorSeries->GetColorRepeating(legendIndex).GetData());
  }
  painter->ApplyPen(this->Pen);
  painter->ApplyBrush(this->Brush);
  painter->DrawRect(rect[0], rect[1], rect[2], rect[3]);
  return true;
}
TagsNo tags attached.
ProjectTBD
Typeincorrect functionality
Attached Filespng file icon vtkPlotStacked.png [^] (21,270 bytes) 2013-02-07 17:31

 Relationships

  Notes
(0031052)
Dave DeMarle (administrator)
2013-06-25 12:45

Can you submit that patch in the form of a gerrit patch for automated testing and review?
For details on how to do so see http://www.vtk.org/Wiki/VTK/Git/Develop [^]
thanks
(0031118)
Bastian Angermann (reporter)
2013-07-03 13:35

This issue has been fixed in the following commit
https://github.com/Kitware/VTK/commit/ffd2444c2abe3814c16b78043e14382c25fe82bc [^]

The fix is an improvement over the suggestion in the bug description in that this->Brush is not changed, a temporary brush is created instead. Do you want me to create a patch nevertheless e.g. for back-porting the fix into the 5.10 line?
(0031953)
Dave DeMarle (administrator)
2013-12-16 15:37

Thank you Bastian.

I can't guarantee that a patch will go into the release-5.10 branch because right now we are only merging in critical fixes. But you are more than welcome to backport the fix and submit it though gerrit. Once there it has the best chance of getting in.

 Issue History
Date Modified Username Field Change
2013-02-07 17:31 Bastian Angermann New Issue
2013-02-07 17:31 Bastian Angermann File Added: vtkPlotStacked.png
2013-06-25 12:45 Dave DeMarle Note Added: 0031052
2013-07-03 13:35 Bastian Angermann Note Added: 0031118
2013-12-16 15:37 Dave DeMarle Note Added: 0031953
2013-12-16 15:37 Dave DeMarle Status backlog => closed
2013-12-16 15:37 Dave DeMarle Assigned To => Dave DeMarle
2013-12-16 15:37 Dave DeMarle Resolution open => fixed
2013-12-16 15:39 Dave DeMarle Fixed in Version => 6.0.0


Copyright © 2000 - 2018 MantisBT Team