View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014204ParaView(No Category)public2013-08-01 14:362015-01-11 08:24
ReporterUtkarsh Ayachit 
Assigned ToUtkarsh Ayachit 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version4.1 
Summary0014204: Auto-updating domains
DescriptionDomains for properties in ParaView ServerManager currently need to be manually updated. It's annoying to use and one is never clear when the domain is to be updated and who updates it. We need to clean the logic up so Panels can respond more gracefully (and consistently) to domain changes.
TagsNo tags attached.
ProjectKitware
Topic Name14204_fix_domains
Typeincorrect functionality
Attached Files

 Relationships

  Notes
(0031440)
Utkarsh Ayachit (administrator)
2013-08-13 14:19

 commit 4b3af8bd97db73a61c69743e506eacdb2abf2562
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Fri Aug 2 16:25:53 2013 -0400

    BUG 0014204. Refactor domains and domain-update logic.
    
    This commit refactors the domains in ServerManager. Domain are no longer
    expected to be updated by the application manually
    (vtkSMProperty::UpdateDependentDomains() has been deprecated). Instead, whenever
    a property is modified (rather its unchecked values are modified), the depedent
    domains are automatically updated.
    
    vtkSMDomain subclasses have been updated to fire DomainModifiedEvent only when
    the domain actually changes. Next, we can update the Qt layer to simplify
    handling domains.
    
    This commit also includes some restructuring of the vtkSMDomain hierarchy.
    
    vtkSMDoubleRangeDomain and vtkSMIntRangeDomain are now just template
    specializations of vtkSMRangeDomainTemplate (instead of duplicated logic).
    
    vtkSMArraySelectionDomain is now simply an empty subclass of
    vtkStringListDomain. It didn't need any custom logic.
    
    Also removed unused domains: vtkSMNumberOfGroupsDomaini,a nd
    vtkSMStringListRangeDomain.
    
    Deleting vtkSMPropertyAdaptor. One can use vtkSMPropertyHelper instead.
    
    Change-Id: Ib227082b3eeea6af89db5ccd0a7f0d539e1abce2
(0031475)
Utkarsh Ayachit (administrator)
2013-08-16 13:48

 Topics merged into master:
        0014218_fix_color_preset_issues
        13029_fix_auto_apply
        14158_fix_double_range_slider
        14185_fix_component_name
        14204_fix_domains
        14233_fix_disconnect_button
        14234_fix_trace_views
        better_disconnect_error_v2
        serverside_only_reader
(VTK) update_to_master
(0031528)
Alan Scott (manager)
2013-09-03 21:05

 Developer tag in git. Closing.

 Issue History
Date Modified Username Field Change
2013-08-01 14:36 Utkarsh Ayachit New Issue
2013-08-13 14:19 Utkarsh Ayachit Topic Name => 14204_fix_domains
2013-08-13 14:19 Utkarsh Ayachit Note Added: 0031440
2013-08-13 14:19 Utkarsh Ayachit Status backlog => gatekeeper review
2013-08-13 14:19 Utkarsh Ayachit Fixed in Version => git-next
2013-08-13 14:19 Utkarsh Ayachit Resolution open => fixed
2013-08-13 14:19 Utkarsh Ayachit Assigned To => Utkarsh Ayachit
2013-08-16 13:48 Utkarsh Ayachit Fixed in Version git-next => git-master
2013-08-16 13:48 Utkarsh Ayachit Status gatekeeper review => customer review
2013-08-16 13:48 Utkarsh Ayachit Note Added: 0031475
2013-09-03 21:05 Alan Scott Note Added: 0031528
2013-09-03 21:05 Alan Scott Status customer review => closed
2013-11-01 13:18 Utkarsh Ayachit Fixed in Version git-master => 4.1
2015-01-11 08:23 Utkarsh Ayachit Source_changeset_attached => ParaView master 6334af13
2015-01-11 08:24 Utkarsh Ayachit Source_changeset_attached => ParaView master 4b3af8bd

Copyright © 2000 - 2018 MantisBT Team