| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0014379 | VTK | (No Category) | public | 2013-10-31 19:35 | 2016-03-07 17:53 | ||||
| Reporter | dennisHu | ||||||||
| Assigned To | David Gobbi | ||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | 5.10.1 | ||||||||
| Target Version | Fixed in Version | 7.0.0 | |||||||
| Summary | 0014379: RemoveExtent in vtkImageStencilData is incorrect | ||||||||
| Description | If there are two entries( clist[k], clist[k+1]) need to be removed, only one can be deleted. I think k should not be increased after remove one entry. Please review those codes: 682 int length = clistlen; 683 for (int k = 0; k < length; k += 2) 684 { 685 if (r1 <= clist[k] && r2 >= (clist[k+1]-1)) 686 { ... also if r1>clist[k] and r2>=clist[k+1], i think we should update entry as clist[k+1] = r1. | ||||||||
| Tags | No tags attached. | ||||||||
| Project | TBD | ||||||||
| Type | incorrect functionality | ||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0031841) Joseph Ott (reporter) 2013-11-06 11:06 |
As a quick test I opened the test image in paint and saved it. The header size was correctly reported on the new test image. I looked at the file size and noticed that the file saved from Photoshop was 2 bytes bigger than that saved by Paint. I inspected the code vtkImageReader2::GetHeaderSize() and realized that the header size is computed from the file size and not based on the data offset read from the BMP file. With Photoshop adding 2 bytes to the BMP file this is causing the wrong header size to be reported. Would a potential solution be to have the vtkBMPReader class call SetHeaderSize with the data offset value read in from the file? This does not change the base class, but allows the BMP file to use the header size found within the file. |
|
(0035833) David Gobbi (developer) 2016-03-07 17:53 |
Fixed in VTK 7.0.0: https://gitlab.kitware.com/vtk/vtk/merge_requests/824 [^] Still unknown whether this will be backported to VTK 6.3.x. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2013-10-31 19:35 | dennisHu | New Issue | |
| 2013-11-06 11:06 | Joseph Ott | Note Added: 0031841 | |
| 2014-10-23 06:58 | David Gobbi | Assigned To | => David Gobbi |
| 2016-03-07 17:53 | David Gobbi | Note Added: 0035833 | |
| 2016-03-07 17:53 | David Gobbi | Status | backlog => closed |
| 2016-03-07 17:53 | David Gobbi | Resolution | open => fixed |
| 2016-03-07 17:53 | David Gobbi | Fixed in Version | => 7.0.0 |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |