View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014445VTK(No Category)public2013-12-05 20:122014-10-03 11:35
ReporterdennisHu 
Assigned ToDavid Gobbi 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version6.2.0 
Summary0014445: IsInside in vtkImageStencilData is wrong
Descriptioncompare to GetNextExtent, it will give wrong result.
for example if we get stencil [r1,r2] from GetNextExtent. IsInside(r2+1, yIdx, zIdx) will return 1. that is wrong.

from code review.
  i think we should change "if(xIdx <= clist[iter++])" to "if(xIdx < clist[iter++])"
Tagshackaton
ProjectTBD
Typeincorrect functionality
Attached Files

 Relationships

  Notes
(0031964)
Dave DeMarle (administrator)
2013-12-16 17:01

Thanks. Please submit proposed change via gerrit to simplify regression testing and code review.
(0033527)
David Gobbi (developer)
2014-10-02 15:31

I've reproduced this bug on my machine.
(0033542)
David Gobbi (developer)
2014-10-02 16:36

http://review.source.kitware.com/17363 [^]
(0033571)
Cory Quammen (developer)
2014-10-03 11:35

Merged in commit:

Author: David Gobbi <david.gobbi@gmail.com> 2014-10-02 16:25:17
Committer: David Gobbi <david.gobbi@gmail.com> 2014-10-02 16:32:52

14445: Fix vtkImageStencilData IsInside upper bound.

The upper bound check on the IsInside method was off by one.

Change-Id: If19f632d5490018cbeda0d8399153512b37b1891

 Issue History
Date Modified Username Field Change
2013-12-05 20:12 dennisHu New Issue
2013-12-16 17:01 Dave DeMarle Note Added: 0031964
2014-10-01 21:47 Sean McBride Tag Attached: hackaton
2014-10-02 09:23 David Gobbi Assigned To => David Gobbi
2014-10-02 15:31 David Gobbi Note Added: 0033527
2014-10-02 15:31 David Gobbi Status backlog => active development
2014-10-02 16:36 David Gobbi Note Added: 0033542
2014-10-02 16:36 David Gobbi Status active development => gerrit review
2014-10-03 11:35 Cory Quammen Note Added: 0033571
2014-10-03 11:35 Cory Quammen Status gerrit review => closed
2014-10-03 11:35 Cory Quammen Resolution open => fixed
2014-10-03 11:35 Cory Quammen Fixed in Version => 6.2.0


Copyright © 2000 - 2018 MantisBT Team