View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014734ParaView(No Category)public2014-05-16 08:392014-08-29 11:00
ReporterUtkarsh Ayachit 
Assigned Tojohan andruejol 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version4.2Fixed in Version4.2 
Summary0014734: Automatically pick a good default size of pqProxyWidgetDialog
DescriptionpqProxyWidgetDialog is used to automatically create dialogs for pqProxyWidget -- which is a autogenerated widget for a vtkSMProxy. We use pqProxyWidgetDialog in several locations e.g

1. "Edit Color Legend Properties" dialog
    + Start ParaView
    + Create "Wavelet" from "Sources" menu, hit "Apply"
    + Click "Edit Color Map" from the toolbar and then click the "Edit color legend properties" button (http://www.kitware.com/blog/home/post/578 [^])
    + This dialog will popup

2. "Configure Writer" dialog
    + Start ParaView
    + Create "Wavelet" from "Sources" menu, hit "Apply"
    + File | Save Data --- save as foo.vtk
    + Configure Writer dialog will popup.

Dialog (1) is too short. We could easily make it longer, to avoid scroll bars, which would make it easier to use. However, doing that makes dialog (2) unnecessarily longer. The goal of this task is to fix pqProxyWidgetDialog to try to show the dialog with "optimal" length between a fixed minimum and maximum size based on the contents of the dialog. "Optimal" length is the minimum length needed to now show the vertical scroll bar. Of course, if optimal length is too small or too big, we will clamp it to a predermined min/max value.
TagsNo tags attached.
ProjectSandia
Topic Name14734-GoodDefaultSizeForpqProxyWidgetDialog
Typeincorrect functionality
Attached Files

 Relationships

  Notes
(0032660)
Cory Quammen (developer)
2014-05-23 16:16

 Looks good. Now merge into the next branch with

git stage-push
git stage-merge
(0032672)
Utkarsh Ayachit (administrator)
2014-05-28 09:43

 Johan, mind updating the "Topic Name" to refer to the branch name used when pushing to stage?

I typically also point to the gerrit topic or the commit log in the "note" field to make it easier to track the commit from the bug.
(0032673)
johan andruejol (developer)
2014-05-28 09:47

 Gerrit topic for reference:
http://review.source.kitware.com/#/c/15499/ [^]
(0032678)
johan andruejol (developer)
2014-05-29 11:21

 See commit: c0aa71f454c49751b11171aa339af7da20cb8cf7
(0032694)
Utkarsh Ayachit (administrator)
2014-05-30 08:14

 SUMMARY
---------------------------------------------
Topics merged into master:
        14679_color_legend_bugs
        14734-GoodDefaultSizeForpqProxyWidgetDialog
        cleanup-cmake
        fix_assembly_render_view
        fix_fragment_large_scale
        fix_plugin_loading_order
        fix_qt_modules
        remove-unused-directory


---------------------------------------------
Topics reverted from next:
  14673_fix_follow_data
(0032722)
Alan Scott (manager)
2014-06-03 20:24

 Tested master, Linux, remote server.

 Issue History
Date Modified Username Field Change
2014-05-16 08:39 Utkarsh Ayachit New Issue
2014-05-16 10:10 Utkarsh Ayachit Assigned To => johan andruejol
2014-05-20 10:33 johan andruejol Status backlog => active development
2014-05-23 16:16 Cory Quammen Note Added: 0032660
2014-05-28 09:41 johan andruejol Status active development => gatekeeper review
2014-05-28 09:41 johan andruejol Resolution open => fixed
2014-05-28 09:43 Utkarsh Ayachit Note Added: 0032672
2014-05-28 09:44 johan andruejol Status gatekeeper review => active development
2014-05-28 09:47 johan andruejol Topic Name => 14734-GoodDefaultSizeForpqProxyWidgetDialog
2014-05-28 09:47 johan andruejol Note Added: 0032673
2014-05-28 09:47 johan andruejol Status active development => gatekeeper review
2014-05-28 09:47 johan andruejol Fixed in Version => git-next
2014-05-29 11:20 johan andruejol Status gatekeeper review => active development
2014-05-29 11:21 johan andruejol Note Added: 0032678
2014-05-29 11:21 johan andruejol Status active development => gatekeeper review
2014-05-30 08:13 Utkarsh Ayachit Fixed in Version git-next => git-master
2014-05-30 08:14 Utkarsh Ayachit Note Added: 0032694
2014-05-30 08:14 Utkarsh Ayachit Status gatekeeper review => customer review
2014-06-03 20:24 Alan Scott Note Added: 0032722
2014-06-03 20:24 Alan Scott Status customer review => closed
2014-06-17 09:22 Utkarsh Ayachit Target Version => 4.2
2014-08-29 11:00 Utkarsh Ayachit Fixed in Version git-master => 4.2

Copyright © 2000 - 2018 MantisBT Team