View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0014744 | ParaView | (No Category) | public | 2014-05-20 08:40 | 2014-08-29 11:00 | ||||
Reporter | Utkarsh Ayachit | ||||||||
Assigned To | Utkarsh Ayachit | ||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | 4.2 | Fixed in Version | 4.2 | ||||||
Summary | 0014744: Developer tag: Cleanup view plugin infrastructure | ||||||||
Description | The mechanism to add new views in unnecessary complicated. There should not be any need to add pqView classes anymore. We need to simplify the infrastructure. | ||||||||
Tags | No tags attached. | ||||||||
Project | Kitware | ||||||||
Topic Name | 14744_cleanup_views | ||||||||
Type | incorrect functionality | ||||||||
Attached Files | |||||||||
Relationships | |
Relationships |
Notes | |
(0032654) Utkarsh Ayachit (administrator) 2014-05-20 08:41 |
commit 7091737a5c9ae0dbb9f298bba2d761147b75ba95 Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Sat May 17 16:14:03 2014 -0400 Refactoring how view types are created and registered with ParaView. This commits simplifies how views are added to ParaView. In past, we need to create a pqView subclass and then add that using pqViewModuleInterface implementation. After this change, one can add new view types by simply defining new proxy types under the "views" group. If you need to add a pqView subclass, or specify a pqView subclass to use with your new view type, simply use add_pqproxy() macro, instead of add_paraview_view_module() macro. Label used for the view is now garnered from the proxy itself (vtkSMProxy::GetXMLLabel()). Updating plugins, examples to use this new code. Removed pqStandardViewModules since it's no longer relevant. If you're using that class, simply remove it from your code and ParaView will continue to work as expected. Moved view XML definitions that were "internal" to "internal_views" group. This keeps the list of "available" views clean. Plugins may have to be updated if they are using "ViewBase" proxy definition. Change-Id: I15b329ea13ce526ca3c1fe016da0201ac5826355 |
(0032665) Utkarsh Ayachit (administrator) 2014-05-28 07:00 |
SUMMARY --------------------------------------------- Topics merged into master: 14723_export_coprocessing_scripts 14742_vtkImageDataToUniformGrid 14744_cleanup_views 14748_compile_cth_markers_in_by_default 14753_PluginSettings cleanup_viewframe_interface dashboard_maintenance fix-install-test fix_intel_compiler_mpich_issues fix_settings_server_processes pvweb-ubuntu-14LTS-doc-update settings_custom_apps use-external-data |
(0032709) Alan Scott (manager) 2014-05-30 22:32 |
Developer tag in git. Closing. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2014-05-20 08:40 | Utkarsh Ayachit | New Issue | |
2014-05-20 08:41 | Utkarsh Ayachit | Topic Name | => 14744_cleanup_views |
2014-05-20 08:41 | Utkarsh Ayachit | Note Added: 0032654 | |
2014-05-20 08:41 | Utkarsh Ayachit | Status | backlog => gatekeeper review |
2014-05-20 08:41 | Utkarsh Ayachit | Fixed in Version | => git-next |
2014-05-20 08:41 | Utkarsh Ayachit | Resolution | open => fixed |
2014-05-20 08:41 | Utkarsh Ayachit | Assigned To | => Utkarsh Ayachit |
2014-05-28 06:59 | Utkarsh Ayachit | Fixed in Version | git-next => git-master |
2014-05-28 07:00 | Utkarsh Ayachit | Status | gatekeeper review => customer review |
2014-05-28 07:00 | Utkarsh Ayachit | Note Added: 0032665 | |
2014-05-30 22:32 | Alan Scott | Note Added: 0032709 | |
2014-05-30 22:32 | Alan Scott | Status | customer review => closed |
2014-06-17 09:22 | Utkarsh Ayachit | Target Version | => 4.2 |
2014-08-29 11:00 | Utkarsh Ayachit | Fixed in Version | git-master => 4.2 |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |