View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014788ParaView(No Category)public2014-06-08 10:362014-08-29 10:59
ReporterUtkarsh Ayachit 
Assigned Tojohan andruejol 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version4.2Fixed in Version4.2 
Summary0014788: Multi-line text edits broken in Properties panel.
DescriptionSteps to illustrate the bug:
+ Create "Text" from "Sources" menu.
+ Apply -- "Text" renders on the screen as expected.

+ Now, change the text in the Properties panel to something else e.g. "Hello world"

** BUG ** : You cannot hit apply, since Apply button doesn't go green. The only way to make the Apply button go green is to hit "Tab".
Hitting "Tab" doesn't work as expected either in a text-editor box either -- i.e. it doesn't indent, nor does it switch the focus to another widget.
TagsNo tags attached.
ProjectSandia
Topic Name14788-pqTextEdit
Typeincorrect functionality
Attached Files

 Relationships
related to 0014745closedUtkarsh Ayachit Programmable filter panel not working properly 

  Notes
(0032776)
Utkarsh Ayachit (administrator)
2014-06-08 11:02

 Developer notes:

This bug was introduced by commit ce96d52a. This was an incorrect attempt to fix an issue with QTextEdit which, unlike QLineEdit, doesn't fire separate signals for textChanged() and editingFinished(). We have subclassed QLineEdit as pqLineEdit to add a new signal textChangedAndEditingFinished() to further restrict firing of editingFinished() to only when the text is actually changed by the user.

Properties panel works by connecting the textChanged() to slots/signals indicating some change is available and the connecting the textChangedAndEditingFinished() to the pqPropertyWidget::changeFinished() signal. The former results in the "Apply" button being enabled and then latter results in accepting the changes when Auto-Apply is ON.

For this to continue to work with QTextEdit, we need to do the following:

+ remove the class pqTextEditSignalEndOfEdit entirely. Replace it with a new class pqTextEdit instead, which subclasses from QTextEdit and put it under Qt/Widgets.
+ Add 2 new signals: editingFinished(), textChangedAndEditingFinished(). Look at pqLineEdit to capture correctly when the text indeed is changed to property fire textChangedAndEditingFinished() signal.
+ Add event listeners to pqTextEdit to treat loss of focus and user hitting Ctrl+Enter or Alt+Enter keys as end of editing and fire editingFinished() signal (which should in turn trigger textChangedAndEditingFinished() if applicable).
+ Now replace all usages of pqTextEditSignalEndOfEdit with pqTextEdit, using textChanged() signal to hookup with the pqPropertyLinks (or if firing pqPropertyWidget::changeAvailable() signal) and using textChangedAndEditingFinished() to fire the pqPropertyWidget::changeFinished() signal.
(0032952)
johan andruejol (developer)
2014-06-27 17:19

 commit 10c8f1206421bca2b3f93c16ddd600a202f53d1a
Author: Johan Andruejol <johan.andruejol@kitware.com>
Date: Fri Jun 27 09:55:37 2014 -0400

    Fix pqTextEditTest compilation with Qt5
    
    Change-Id: I2244365d4ba0556abb5cceb7b5da0676cf3dcfde

commit 40593e0d4f5b4d48dd5afae10067665e401e7e42
Author: Johan Andruejol <johan.andruejol@kitware.com>
Date: Fri Jun 20 12:14:40 2014 -0400

    Refactor pqTextEditTest
    
    The pqTextEditTest was a little bit flaky on Unix. Also make the test more
    qt like to leverage QTest powerful methods.
    
    Change-Id: I887af09c0e9d6fd0f60da4ece914527fe9797019

commit b6a314db488a60a3d16e382eff3651cc7fb76953
Author: Johan Andruejol <johan.andruejol@kitware.com>
Date: Tue Jun 17 15:55:06 2014 -0400

    Add test for pqTextEdit
    
    Modify the QTestApp to allow QString to be sent as keyboard events.
    Add a unit test for pqTextEdit.
    
    Change-Id: I31c8c4994a8c7e979ae25b84ebb3f4d5e5143e75

commit e65fcb094b266072900ca48d1c19ba4450380ef3
Author: Johan Andruejol <johan.andruejol@kitware.com>
Date: Tue Jun 17 15:08:46 2014 -0400

    Add pqTextEdit
    
    pqTextEdit is a text edit that follows what is done for pqLineEdit.
    It implements the signals editingFinished() and
    textChangedAndEditingFinished().
    This new widget is used to remove the pqTextEditSignalEndOfEdit widget.
    
    Change-Id: Ifc247869113e00fd2dd0d868f2fe70d9ac1ab2b4
(0032957)
Utkarsh Ayachit (administrator)
2014-06-30 08:24

 SUMMARY
---------------------------------------------
Topics merged into master:
        14557-color-legend-update
(VTK) 14713_fix_lsdyna_reader
        14788-pqTextEdit
        14814_fix_cell_point_label_format
        14827_fix_paraview_module_requirements
        misc_quad_view_fixes
(0032981)
Alan Scott (manager)
2014-07-07 21:58

 Tested master, Linux, local server.

 Issue History
Date Modified Username Field Change
2014-06-08 10:36 Utkarsh Ayachit New Issue
2014-06-08 11:02 Utkarsh Ayachit Note Added: 0032776
2014-06-08 11:03 Utkarsh Ayachit Assigned To => johan andruejol
2014-06-08 18:53 Utkarsh Ayachit Target Version => 4.2
2014-06-09 07:17 Utkarsh Ayachit Relationship added related to 0014745
2014-06-13 10:41 johan andruejol Status backlog => active development
2014-06-27 17:19 johan andruejol Topic Name => 14788-pqTextEdit
2014-06-27 17:19 johan andruejol Note Added: 0032952
2014-06-27 17:19 johan andruejol Status active development => gatekeeper review
2014-06-27 17:19 johan andruejol Resolution open => fixed
2014-06-30 08:24 Utkarsh Ayachit Fixed in Version => git-master
2014-06-30 08:24 Utkarsh Ayachit Status gatekeeper review => customer review
2014-06-30 08:24 Utkarsh Ayachit Note Added: 0032957
2014-07-07 21:58 Alan Scott Note Added: 0032981
2014-07-07 21:58 Alan Scott Status customer review => closed
2014-08-29 10:59 Utkarsh Ayachit Fixed in Version git-master => 4.2

Copyright © 2000 - 2018 MantisBT Team