View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014961ParaView(No Category)public2014-08-21 10:582015-02-18 19:05
ReporterCory Quammen 
Assigned ToUtkarsh Ayachit 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Versiongit-master 
Target Version4.3Fixed in Version4.3 
Summary0014961: Color map range reset inappropriately
DescriptionSteps to reproduce:

* Create a Plane source.
* Change to color by TextureCoordinates, X component
* Open Color Map Editor, change range manually to [0.4, 0.6]
* Create Sphere source.
* Click back on Plane source. The color map range will be reset to [0.0, 1.0]
TagsNo tags attached.
ProjectTBD
Topic Name14961_fix_color_widget
Typeincorrect functionality
Attached Files

 Relationships

  Notes
(0033290)
Cory Quammen (developer)
2014-08-27 11:30

 I haven't confirmted this, but the culprit might be in pqDisplayColorWidget::componentNumberChanged() (see the last line):

//-----------------------------------------------------------------------------
void pqDisplayColorWidget::componentNumberChanged()
{
  if (this->ColorTransferFunction)
    {
    BEGIN_UNDO_SET("Change color component");
    SM_SCOPED_TRACE(PropertiesModified)
      .arg("proxy", this->ColorTransferFunction->getProxy())
      .arg("comment", "change array component used for coloring");

    int number = this->componentNumber();
    this->ColorTransferFunction->setVectorMode(
      number<0? pqScalarsToColors::MAGNITUDE : pqScalarsToColors::COMPONENT,
      number<0? 0 : number);

    // we could now respect some application setting to determine if the LUT is
    // to be reset.
    vtkSMProxy* reprProxy = this->Representation?
      this->Representation->getProxy() : NULL;
    vtkSMPVRepresentationProxy::RescaleTransferFunctionToDataRange(reprProxy);
(0033919)
Utkarsh Ayachit (administrator)
2014-12-10 09:35

 commit ff83b782e40d3e1bf4e0a6b81e4398e50871b4a6
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Wed Dec 10 09:32:43 2014 -0500

    BUG 0014961: Fix pqDisplayColorWidget bug.
    
    Fixed pqDisplayColorWidget to not accidentally override the
    ServerManager state when the UI is being setup. The bug was arising
    because the current component number was being shown in the UI, it acted
    same as if the user changed the component number.
    
    Change-Id: I4d0c54995b7e4f9c8350d343a2c9e7fd40d5a400
(0033939)
Utkarsh Ayachit (administrator)
2014-12-11 08:21

 ---------------------------------------------
Topics merged into master (v4.2.0-238-g2c03596):
        14961_fix_color_widget
        python-view-15122
(0034255)
Alan Scott (manager)
2015-02-18 19:05

 Tested local server, Linux, master.

 Issue History
Date Modified Username Field Change
2014-08-21 10:58 Cory Quammen New Issue
2014-08-21 13:26 Utkarsh Ayachit Assigned To => Utkarsh Ayachit
2014-08-21 13:26 Utkarsh Ayachit Target Version => 4.2
2014-08-27 11:30 Cory Quammen Note Added: 0033290
2014-11-12 15:17 Utkarsh Ayachit Target Version 4.2 => bug_fix
2014-11-14 22:56 Utkarsh Ayachit Target Version bug_fix => 4.3
2014-12-09 10:38 Dan Lipsa Status backlog => active development
2014-12-09 10:40 Dan Lipsa Assigned To Utkarsh Ayachit => Dan Lipsa
2014-12-09 10:46 Dan Lipsa Assigned To Dan Lipsa => Utkarsh Ayachit
2014-12-09 10:46 Dan Lipsa Status active development => todo
2014-12-09 10:46 Dan Lipsa Status todo => backlog
2014-12-09 14:00 Dan Lipsa Assigned To Utkarsh Ayachit => Dan Lipsa
2014-12-09 14:00 Dan Lipsa Status backlog => active development
2014-12-10 09:13 Utkarsh Ayachit Assigned To Dan Lipsa => Utkarsh Ayachit
2014-12-10 09:35 Utkarsh Ayachit Topic Name => 14961_fix_color_widget
2014-12-10 09:35 Utkarsh Ayachit Note Added: 0033919
2014-12-10 09:35 Utkarsh Ayachit Status active development => gatekeeper review
2014-12-10 09:35 Utkarsh Ayachit Fixed in Version => git-next
2014-12-10 09:35 Utkarsh Ayachit Resolution open => fixed
2014-12-11 08:21 Utkarsh Ayachit Note Added: 0033939
2014-12-11 08:21 Utkarsh Ayachit Fixed in Version git-next => git-master
2014-12-11 08:22 Utkarsh Ayachit Status gatekeeper review => customer review
2015-01-02 10:43 Utkarsh Ayachit Fixed in Version git-master => 4.3
2015-01-11 08:14 Utkarsh Ayachit Source_changeset_attached => ParaView master ac2caa35
2015-01-11 08:14 Utkarsh Ayachit Source_changeset_attached => ParaView master 6f39c159
2015-02-18 19:05 Alan Scott Note Added: 0034255
2015-02-18 19:05 Alan Scott Status customer review => closed

Copyright © 2000 - 2018 MantisBT Team