View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0015567 | ParaView | (No Category) | public | 2015-07-06 21:50 | 2015-09-06 12:17 | ||||
Reporter | Alan Scott | ||||||||
Assigned To | Utkarsh Ayachit | ||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | git-master | ||||||||
Target Version | 4.4 | Fixed in Version | 4.4 | ||||||
Summary | 0015567: vtkRTAnalyticSource.cxx Wavelet performance work | ||||||||
Description | Performance work in the file vtkRTTAnalyticSource.cxx. Test with sources/wavelet. Basically, don't calculate stuff in the bottom of for loops that is constant at that point. | ||||||||
Tags | No tags attached. | ||||||||
Project | Sandia | ||||||||
Topic Name | |||||||||
Type | performance | ||||||||
Attached Files | vtkRTAnalyticSource.cxx.diff [^] (5,393 bytes) 2015-07-06 21:53 [Show Content]
Unoptimized.png [^] (922,617 bytes) 2015-07-06 22:07 Optimized.png [^] (890,420 bytes) 2015-07-06 22:07 0001-Performance-improvements-to-vtkRTAnalyticSource.patch [^] (3,070 bytes) 2015-07-22 13:35 [Show Content] | ||||||||
Relationships | ||||||
|
Relationships |
Notes | |
(0034668) Alan Scott (manager) 2015-07-06 22:04 |
Time for a [-10, 1000] [-10,1000] [-10,1000] wavelet went from 140 to 84 seconds. |
(0034669) Alan Scott (manager) 2015-07-06 22:06 |
Note to myself - the only way to cut time again would be a faster sin() and exp() functions. Taylor series. |
(0034813) Utkarsh Ayachit (administrator) 2015-07-22 13:35 |
Alan, I've updated your patch to essentially have the same tweaks but without having to duplicate some of the loops. Let me know if that's okay and I'll have it merged. I've attached the patch: 0001-Performance-improvements-to-vtkRTAnalyticSource.patch |
(0034814) Utkarsh Ayachit (administrator) 2015-07-22 13:37 |
Merge request: https://gitlab.kitware.com/vtk/vtk/merge_requests/445 [^] |
(0034815) Alan Scott (manager) 2015-07-22 16:18 |
Excellent. I tested the performance, which is better than mine, and that it is correct, which it is. Tested Linux, master (with Utkarsh's patch), local server. Tested with VTune, 67 seconds. |
(0034817) Utkarsh Ayachit (administrator) 2015-07-23 11:52 |
Paraview merge request: https://gitlab.kitware.com/paraview/paraview/merge_requests/248 [^] |
(0034820) Utkarsh Ayachit (administrator) 2015-07-24 09:40 |
Merged. |
(0034831) Alan Scott (manager) 2015-07-27 18:24 |
Nice. Tested for correctness (not performance) local server, master, Linux. |
(0034832) Alan Scott (manager) 2015-07-27 18:25 |
Also tested remote server. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2015-07-06 21:50 | Alan Scott | New Issue | |
2015-07-06 21:53 | Alan Scott | File Added: vtkRTAnalyticSource.cxx.diff | |
2015-07-06 22:04 | Alan Scott | Note Added: 0034668 | |
2015-07-06 22:06 | Alan Scott | Note Added: 0034669 | |
2015-07-06 22:07 | Alan Scott | File Added: Unoptimized.png | |
2015-07-06 22:07 | Alan Scott | File Added: Optimized.png | |
2015-07-06 22:08 | Alan Scott | Target Version | => 4.4 |
2015-07-06 22:14 | Alan Scott | Relationship added | related to 0015568 |
2015-07-08 16:36 | Utkarsh Ayachit | Status | backlog => todo |
2015-07-22 13:35 | Utkarsh Ayachit | File Added: 0001-Performance-improvements-to-vtkRTAnalyticSource.patch | |
2015-07-22 13:35 | Utkarsh Ayachit | Note Added: 0034813 | |
2015-07-22 13:37 | Utkarsh Ayachit | Note Added: 0034814 | |
2015-07-22 13:38 | Utkarsh Ayachit | Status | todo => gatekeeper review |
2015-07-22 13:38 | Utkarsh Ayachit | Resolution | open => fixed |
2015-07-22 13:38 | Utkarsh Ayachit | Assigned To | => Utkarsh Ayachit |
2015-07-22 16:18 | Alan Scott | Note Added: 0034815 | |
2015-07-23 11:52 | Utkarsh Ayachit | Note Added: 0034817 | |
2015-07-24 09:40 | Utkarsh Ayachit | Note Added: 0034820 | |
2015-07-24 09:40 | Utkarsh Ayachit | Status | gatekeeper review => customer review |
2015-07-24 09:40 | Utkarsh Ayachit | Fixed in Version | => git-master |
2015-07-27 18:24 | Alan Scott | Note Added: 0034831 | |
2015-07-27 18:24 | Alan Scott | Status | customer review => closed |
2015-07-27 18:25 | Alan Scott | Note Added: 0034832 | |
2015-09-06 12:17 | Utkarsh Ayachit | Fixed in Version | git-master => 4.4 |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |