View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0002886 | ParaView | Bug | public | 2006-02-15 09:07 | 2015-01-09 14:06 | ||||
Reporter | Christian Becker | ||||||||
Assigned To | Berk Geveci | ||||||||
Priority | low | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | Fixed in Version | 3.14 | |||||||
Summary | 0002886: AVS UCD reader doesn't recognize comment lines | ||||||||
Description | If AVS ucd files with comment lines (symbol #) are used, the reader doesn't recognize the file information without any error message. | ||||||||
Tags | No tags attached. | ||||||||
Project | |||||||||
Topic Name | |||||||||
Type | |||||||||
Attached Files | cellsnd.ascii.reader-chokes-on-empty-comment.inp [^] (1,171 bytes) 2011-06-29 15:44 cellsnd.ascii.reader-chokes-on-excessive-comment-length.inp [^] (1,271 bytes) 2011-06-29 15:44 0001-BUG-Fix-for-BUG-2886.-AVS-UCD-reader-could-choke-on-.patch [^] (1,356 bytes) 2011-06-29 15:45 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0026914) Sven Buijssen (reporter) 2011-06-29 15:42 |
I'm familiar with the issue the original reporter tried to explain and will try to be more specific: The reader silently chokes on 1) empty comment lines (i.e. comment character in column 1 and no trailing white space) 2) comment lines of excessive length (i.e. > 100 characters) 1) is due to this->FileStream->get(buf, 100, '\n'); in vtkAVSucdReader.cxx:226 setting the failbit flag as soon as an empty comment line is found. Subsequent parsing then fails due to !this->FileStream->good() In both cases subsequent attempts to read the number of nodes/cells/node fields etc. set all of these variables to zero such that the user ends up with no data being imported at all. I'll attach an example file for either case (both files are derived from VTK_Data/Data/cellsnd.ascii.inp) and a suggested patch. |
(0028325) Sven Buijssen (reporter) 2012-02-28 04:26 |
c1fd00a BUG: Fix for BUG 0002886. AVS UCD reader could choke on comments |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2009-12-09 14:51 | Berk Geveci | Project | @3@ => ParaView |
2009-12-09 17:22 | Berk Geveci | Priority | normal => low |
2009-12-09 17:22 | Berk Geveci | Category | => Bug |
2011-06-29 15:42 | Sven Buijssen | Note Added: 0026914 | |
2011-06-29 15:44 | Sven Buijssen | File Added: cellsnd.ascii.reader-chokes-on-empty-comment.inp | |
2011-06-29 15:44 | Sven Buijssen | File Added: cellsnd.ascii.reader-chokes-on-excessive-comment-length.inp | |
2011-06-29 15:45 | Sven Buijssen | File Added: 0001-BUG-Fix-for-BUG-2886.-AVS-UCD-reader-could-choke-on-.patch | |
2012-02-28 04:26 | Sven Buijssen | Note Added: 0028325 | |
2012-02-28 04:26 | Sven Buijssen | Status | expired => closed |
2012-02-28 04:26 | Sven Buijssen | Resolution | open => fixed |
2012-02-28 04:26 | Sven Buijssen | Fixed in Version | => 3.14 |
2015-01-09 14:04 | Robert Maynard | Source_changeset_attached | => VTK master 69dd488d |
2015-01-09 14:04 | Robert Maynard | Source_changeset_attached | => VTK master c1fd00a2 |
2015-01-09 14:06 | Utkarsh Ayachit | Source_changeset_attached | => VTK master 55be43b6 |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |