View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0005815 | VTK | (No Category) | public | 2007-10-02 04:58 | 2014-02-18 08:57 | ||||
Reporter | xabi riobe | ||||||||
Assigned To | Dave DeMarle | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | Fixed in Version | 6.2.0 | |||||||
Summary | 0005815: memory leak when failing to write with vtkPNGWriter | ||||||||
Description | There are some memory leaks if a vtkPNGWriter fails to write a file if we are out of disk space. Here comes a diff patch to avoid this: @@ -198,6 +198,8 @@ this->TempFP = 0; + png_byte **row_pointers; + if (this->WriteToMemory) { vtkUnsignedCharArray *uc = this->GetResult(); @@ -227,6 +229,9 @@ if (setjmp(png_ptr->jmpbuf)) { fclose(this->TempFP); + if(row_pointers) + delete [] row_pointers; + png_destroy_write_struct(&png_ptr, &info_ptr); this->SetErrorCode(vtkErrorCode::OutOfDiskSpaceError); return; } @@ -272,7 +277,7 @@ png_set_swap(png_ptr); #endif } - png_byte **row_pointers = new png_byte *[height]; + row_pointers = new png_byte *[height]; vtkIdType *outInc = data->GetIncrements(); vtkIdType rowInc = outInc[1]*bit_depth/8; for (ui = 0; ui < height; ui++) | ||||||||
Tags | No tags attached. | ||||||||
Project | TBD | ||||||||
Type | incorrect functionality | ||||||||
Attached Files | |||||||||
Relationships | |
Relationships |
Notes | |
(0031300) Dave DeMarle (administrator) 2013-07-22 20:33 |
Dave P no longer works on the project. If these old issues still exist in 6.0.0, reopen them and assign to Dave DeMarle |
(0031659) xabi riobe (reporter) 2013-09-30 08:41 |
The issue is still present in 6.0.0 |
(0031667) xabi riobe (reporter) 2013-09-30 09:36 |
http://review.source.kitware.com/#/t/3344 [^] |
(0031940) Dave DeMarle (administrator) 2013-12-16 11:36 |
problems in gerrit, reverting to backlog until after 6.1 |
(0032345) Dave DeMarle (administrator) 2014-02-18 08:57 |
http://review.source.kitware.com/#/t/3344/ [^] |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2007-10-02 04:58 | xabi riobe | New Issue | |
2008-08-29 17:23 | David Cole | Status | backlog => tabled |
2008-08-29 17:23 | David Cole | Assigned To | => David Cole |
2011-01-19 09:45 | David Cole | Assigned To | David Cole => David Partyka |
2011-06-16 13:11 | Zack Galbreath | Category | => (No Category) |
2013-07-22 20:33 | Dave DeMarle | Status | backlog => expired |
2013-07-22 20:33 | Dave DeMarle | Note Added: 0031300 | |
2013-09-30 08:41 | xabi riobe | Note Added: 0031659 | |
2013-09-30 08:41 | xabi riobe | Status | expired => backlog |
2013-09-30 08:41 | xabi riobe | Resolution | open => reopened |
2013-09-30 09:36 | xabi riobe | Note Added: 0031667 | |
2013-09-30 09:36 | xabi riobe | Status | backlog => gerrit review |
2013-12-16 11:36 | Dave DeMarle | Project | => TBD |
2013-12-16 11:36 | Dave DeMarle | Type | => incorrect functionality |
2013-12-16 11:36 | Dave DeMarle | Note Added: 0031940 | |
2013-12-16 11:36 | Dave DeMarle | Assigned To | David Partyka => Dave DeMarle |
2013-12-16 11:36 | Dave DeMarle | Status | gerrit review => backlog |
2014-01-14 05:52 | xabi riobe | Status | backlog => gerrit review |
2014-02-18 08:57 | Dave DeMarle | Note Added: 0032345 | |
2014-02-18 08:57 | Dave DeMarle | Status | gerrit review => closed |
2014-02-18 08:57 | Dave DeMarle | Resolution | reopened => fixed |
2014-02-18 08:57 | Dave DeMarle | Fixed in Version | => 6.2.0 |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |