From david.gobbi at gmail.com Fri May 1 00:22:47 2015 From: david.gobbi at gmail.com (David Gobbi) Date: Thu, 30 Apr 2015 22:22:47 -0600 Subject: [vtk-developers] vtkImageReslice with the problem of slice original In-Reply-To: <1430417953698-5731718.post@n5.nabble.com> References: <1430357911572-5731694.post@n5.nabble.com> <1430392832059-5731695.post@n5.nabble.com> <1430417953698-5731718.post@n5.nabble.com> Message-ID: Hi Jason, This approach does not work well because AutoCropOutputOn() changes the extent of the output depending on the direction cosines. In general, it is not possible to do what you are trying to do with a simple VTK pipeline. Callbacks or some similar mechanism must be used to properly update the the slice position every time the direction changes. Position changes can be accomplished in two ways: 1) by changing the fourth column of the ResliceAxes matrix (this modifies the position in the "x" coordinate system, i.e. your 3D coordinate system) 2) by changing the OutputOrigin (this modifies the position in x' coords) As an example, see the UpdatePlane() method of vtkImagePlaneWidget: http://www.vtk.org/gitweb?p=VTK.git;a=blob;f=Interaction/Widgets/vtkImagePlaneWidget.cxx#l1550 For VTK 5.10 and VTK 6, you can try using the vtkImageResliceMapper. - David On Thu, Apr 30, 2015 at 12:19 PM, Jason <2130220212 at email.szu.edu.cn> wrote: > Hi, David > > I cannot set the parameters like SetOutputOrigin, SetOutputSpacing,and > SetOutputExtent for vtkImageReslice, as I get a slice image by the cosin > value and one point's position.It will get a wrong slice if I set these > paremeters for vtkImageReslice > static double axialElements[16] = { > 1, 0, 0, 0, > 0, 0.866025, -0.5, 0, > 0, 0.5, 0.866025, 0, > 0, 0, 0, 1 }; > > vtkSmartPointer resliceAxes = > vtkSmartPointer::New(); > resliceAxes->DeepCopy(axialElements); > resliceAxes->SetElement(0, 3, 10); > resliceAxes->SetElement(1, 3, 10); > resliceAxes->SetElement(2, 3, 10); > > vtkSmartPointer reslice = > vtkSmartPointer::New(); > reslice->SetInput(connector->GetOutput()); > reslice->SetOutputDimensionality(2); > reslice->SetResliceAxes(resliceAxes); > reslice->SetInterpolationModeToLinear(); > reslice->AutoCropOutputOn(); > > vtkSmartPointer colorTable = > vtkSmartPointer::New(); > colorTable->SetRange(0, 1000); > colorTable->SetValueRange(0.0, 1.0); > colorTable->SetSaturationRange(0.0, 0.0); > colorTable->SetRampToLinear(); > colorTable->Build(); > > My purpose is to calculate the origin of image(2D) in 3D volume > position,and > I can only get the bounds of the slice image through vtkImageActor : > vtkSmartPointer colorMap = > vtkSmartPointer::New(); > colorMap->SetLookupTable(colorTable); > colorMap->SetInputConnection(reslice->GetOutputPort()); > > vtkSmartPointer imgActor = > vtkSmartPointer::New(); > imgActor->SetInput(colorMap->GetOutput()); > double extent[6]={0}; > imgActor->GetBounds(extent); > > Can I take point'(extent[0],extet[2]) as the original position of the slice > image ? > And calculate its corresponding position in 3D volume by point = M*point' > ? > > I'm not so sure if this is right or not. Maybe there is a way to get the > original position(2D) by vtkImageReslice itself. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Fri May 1 01:20:31 2015 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Fri, 1 May 2015 15:20:31 +1000 Subject: [vtk-developers] Need help with a crash on Kamino OSX Release mode. In-Reply-To: References: <20150429025840.868205794@mail.rogue-research.com> Message-ID: I am wondering whether tbb may be picking up something. Kamino is the only machine with tbb and it is the only one generating this error, unfortunately it runs in release mode: Process id 46048 Caught SIGSEGV at 0x0 address not mapped to object Program Stack: WARNING: The stack trace will not use advanced capabilities because this is a release build. 0x7fff87b7acfa : _sigtramp [(libsystem_c.dylib) ???:-1] 0x2 : ??? [(???) ???:-1] 0x10f5e8f68 : _ZL27PyvtkView_SetRepresentationP7_objectS0_ [(libvtkViewsCorePython27D-6.3.1.dylib) ???:-1] Has someone got a debug build similar to Kamino using tbb? If so I would really appreciate it if they could run this code on it. To reiterate it is the following merge request: https://gitlab.kitware.com/vtk/vtk/merge_requests/151 Thanks Andrew On Thu, Apr 30, 2015 at 10:09 AM, Andrew Maclean wrote: > Hi David, > Thanks for this. > I have just added vtkScatterPlotMatrix along with vtkChartMatrix back, > oddly enough my windows machine never picked it up but one of the linux > buildbots did once. Then I took it out and everything seemed ok, it's back > in now. > > I totally agree with you over the usefulness of Debug Visual Studio! It is > my main bug catcher. I use a little utility called Path Editor to reorder > the release and debug lib and bin paths in the environment variables > (PYTHONPATH and PATH). > > Regards > Andrew > > On Wed, Apr 29, 2015 at 10:57 PM, David Cole wrote: > >> The call stack for the out of range subscript assertion is: >> >> msvcp120d.dll!00007fff4d2765d6() Unknown >> >> vtkChartsCore-6.3.dll!std::vector,std::allocator >> > >::operator[](unsigned __int64 _Pos) Line 1202 C++ >> vtkChartsCore-6.3.dll!vtkChartMatrix::GetChart(const vtkVector2i & >> position) Line 223 C++ >> vtkChartsCore-6.3.dll!vtkScatterPlotMatrix::SetActivePlot(const >> vtkVector2i & pos) Line 402 C++ >> > >> vtkChartsCorePython27D-6.3.dll!PyvtkScatterPlotMatrix_SetActivePlot(_object >> * self, _object * args) Line 213 C++ >> python27.dll!000000001e0c2199() Unknown >> >> Looks like vtkScatterPlotMatrix_SetActivePlot can't be called from >> this test because other stuff that it depends on for proper operation >> is not usable as-initialized. This indicates to me that it may only be >> luck when it succeeds on non-VS-Debug builds, since the uninitialized >> variables, assuming that's what the cause is, will contain random >> contents when the test runs. >> >> When I add "vtkScatterPlotMatrix" as a Windows exception, the test >> passes on this build. >> >> I always love running Debug Visual Studio builds for catching easy >> errors like uninitialized variables and out of subscript references... >> >> >> HTH, >> D >> >> >> On Wed, Apr 29, 2015 at 8:38 AM, David Cole wrote: >> > I ran a build on my machine, named trivet, a Debug 64-bit build from >> > VS 2013, and the test fails with a single assertion failure and 10-20 >> > mem leaks: >> > >> > https://open.cdash.org/testDetails.php?test=331705794&build=3791568 >> > >> > Perhaps the "C:\Program Files (x86)\Microsoft Visual Studio >> > 12.0\VC\INCLUDE\vector(1201) : Assertion failed: vector subscript out >> > of range" report indicates the *real* cause of the problem on the Mac >> > Release build. I'm not sure which class/method that comes from, but >> > I'm about to run it and try to find out. >> > >> > >> > David C. >> > >> > >> > >> > On Wed, Apr 29, 2015 at 2:23 AM, Andrew Maclean >> > wrote: >> >> He Sean, >> >> >> >> I should clarify this a bit more. >> >> vtkDataEncoder invokes a thread pool which doesn't clean up after use, >> hence >> >> the crashes after program execution, adding vtkDataEncoder to the list >> of >> >> excluded classes "almost" fixed this. >> >> However Windows was still crashing when the program was run again, so, >> >> adding vtkWebApplication (which is the only class that calls >> >> vtkDataEncoder), to the list of excluded classes, fixed this issue. >> >> >> >> Notwithstanding this, it is puzzling, as I said in the previous e-mail >> as to >> >> why on Kamino we get a SIGSEGV at 0x0 address not mapped to object >> since >> >> vtkView is specifically excluded. >> >> >> >> Regards >> >> Andrew >> >> >> >> >> >> >> >> On Wed, Apr 29, 2015 at 1:32 PM, Andrew Maclean < >> andrew.amaclean at gmail.com> >> >> wrote: >> >>> >> >>> Hi Sean, >> >>> >> >>> Yes, vtkDataEncoder and vtkWebApplication (which uses it) are excluded >> >>> form TestSetGet.py and TestEmptyInput.py. This fixed the crashes and >> also >> >>> the crash in windows when the program was run again. I think Windows >> was a >> >>> bit slow recovering memory. after program execution. >> >>> >> >>> What is puzzling is that TestGetSet excludes vtkView so >> >>> vtkView.SetRepresentation() is never tested, this only fails on Kamino >> >>> (release). It passes on trey (osX release) and also on megas. >> >>> >> >>> Regards >> >>> Andrew >> >>> >> >>> >> >>> On Wed, Apr 29, 2015 at 12:58 PM, Sean McBride < >> sean at rogue-research.com> >> >>> wrote: >> >>>> >> >>>> Did you fix the use-after-free we discussed on this list a few weeks >> ago? >> >>>> >> >>>> Sean >> >>>> >> >>>> >> >>>> >> >>>> On Wed, 29 Apr 2015 12:07:35 +1000, Andrew Maclean said: >> >>>> >> >>>> >David, >> >>>> > Thanks for your insights. >> >>>> >Just finished testing this code on my Macbook Pro OS X Yosemite, >> Python >> >>>> >2.7.6 after building VTK in both Debug and Release mode. Everything >> runs >> >>>> > Ok >> >>>> >so I don't think it is a typedef or macro related to a release >> build on >> >>>> > OS >> >>>> >X. >> >>>> > >> >>>> >Has anyone else got any suggestions? >> >>>> > >> >>>> > >> >>>> >Regards >> >>>> > Andrew >> >>>> > >> >>>> >On Wed, Apr 29, 2015 at 2:23 AM, David Gobbi > > >> >>>> > wrote: >> >>>> > >> >>>> >> Hi Andrew, >> >>>> >> >> >>>> >> The stack trace provides strong evidence that TestSetGet.py is not >> >>>> >> excluding vtkView on those dashboards, as ludicrous as that >> sounds. >> >>>> >> >> >>>> >> c++filt -n _ZL27PyvtkView_SetRepresentationP7_objectS0_ >> >>>> >> PyvtkView_SetRepresentation(_object*, _object*) >> >>>> >> >> >>>> >> This method is only defined in vtkViewPython.cxx, and only >> >>>> >> dir(vtk.vtkView) will return this method. Calling dir() on the >> >>>> >> vtkView >> >>>> >> subclasses will not return this method. Hence, the only reason >> that >> >>>> >> TestSetGet.py would be calling this method is if it was testing >> >>>> >> vtkView. >> >>>> >> >> >>>> >> Perhaps someone added either a typedef or a macro that causes an >> >>>> >> additional reference to vtkView to appear in the vtk module under >> a >> >>>> >> different name. >> >>>> >> >> >>>> >> - David >> >>>> >> >> >>>> >> On Tue, Apr 28, 2015 at 1:42 AM, Andrew Maclean >> >>>> >> > >>>> >> > wrote: >> >>>> >> >> >>>> >>> Hi All, >> >>>> >>> I need some help here. >> >>>> >>> >> >>>> >>> I have converted TestSetGet.tcl to Python but I get a crash on >> the >> >>>> >>> dashboard for kamino building osx in release mode, here: >> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789971 >> >>>> >>> and here: >> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789950 >> >>>> >>> >> >>>> >>> In an earlier attempt, linux release on megas was also crashing >> in >> >>>> >>> release mode: >> >>>> >>> >> https://open.cdash.org/testDetails.php?test=331289192&build=3789418 >> >>>> >>> Based on this I excluded vtkScatterPlotMatrix which fixed it on >> megas >> >>>> >>> but >> >>>> >>> not on Kamino. >> >>>> >>> So I excluded vtkChartMatrix and I still have the same errors on >> >>>> >>> Kamino. >> >>>> >>> But there are no clues as to where the crash is happening. >> However in >> >>>> >>> looking at: >> >>>> >>> >> https://open.cdash.org/testDetails.php?test=331378847&build=3789950 >> >>>> >>> I think it is in vtkView - which is already excluded. >> >>>> >>> This could be the problem: >> >>>> >>> void SetRepresentation (vtkDataRepresentation *rep) >> >>>> >>> vtkDataRepresentation * GetRepresentation (int index=0) >> >>>> >>> >> >>>> >>> Can anyone help? >> >>>> >>> >> >>>> >>> I guess I can try excluding all the *View classes as documented >> in: >> >>>> >>> http://www.vtk.org/doc/nightly/html/classvtkView.html >> >>>> >>> Is there a less brute-force approach? >> >>>> >>> >> >>>> >>> >> >>>> >>> The code is here: >> >>>> >>> https://gitlab.kitware.com/vtk/vtk/merge_requests/151 >> >>>> >>> >> >>>> >>> Thanks in advance for any help/guidance. >> >>>> >> >>>> >> >>> >> >>> >> >>> >> >>> -- >> >>> ___________________________________________ >> >>> Andrew J. P. Maclean >> >>> >> >>> ___________________________________________ >> >> >> >> >> >> >> >> >> >> -- >> >> ___________________________________________ >> >> Andrew J. P. Maclean >> >> >> >> ___________________________________________ >> >> >> >> _______________________________________________ >> >> Powered by www.kitware.com >> >> >> >> Visit other Kitware open-source projects at >> >> http://www.kitware.com/opensource/opensource.html >> >> >> >> Search the list archives at: >> http://markmail.org/search/?q=vtk-developers >> >> >> >> Follow this link to subscribe/unsubscribe: >> >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> >> >> > > > > -- > ___________________________________________ > Andrew J. P. Maclean > > ___________________________________________ > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From 2130220212 at email.szu.edu.cn Fri May 1 04:18:46 2015 From: 2130220212 at email.szu.edu.cn (Jason) Date: Fri, 1 May 2015 01:18:46 -0700 (MST) Subject: [vtk-developers] vtkImageReslice with the problem of slice original In-Reply-To: References: <1430357911572-5731694.post@n5.nabble.com> <1430392832059-5731695.post@n5.nabble.com> <1430417953698-5731718.post@n5.nabble.com> Message-ID: <1430468326185-5731725.post@n5.nabble.com> Is that means I can get the origin position in 2D coordinate if I take off the AutoCropOutputOn()? I will update the cosines and fourth column of the ResliceAxes matrix to get the corresponding slice. And the slice will be wrong if I use SetOutputOrigin(). -- View this message in context: http://vtk.1045678.n5.nabble.com/vtkImageReslice-with-the-problem-of-slice-original-tp5731694p5731725.html Sent from the VTK - Dev mailing list archive at Nabble.com. From utkarsh.ayachit at kitware.com Fri May 1 09:17:50 2015 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Fri, 1 May 2015 09:17:50 -0400 Subject: [vtk-developers] Need help with a crash on Kamino OSX Release mode. In-Reply-To: References: <20150429025840.868205794@mail.rogue-research.com> Message-ID: Andrew, I can look at it over the weekend. Would that work? Utkarsh On Fri, May 1, 2015 at 1:20 AM, Andrew Maclean wrote: > I am wondering whether tbb may be picking up something. Kamino is the only > machine with tbb and it is the only one generating this error, unfortunately > it runs in release mode: > > Process id 46048 Caught SIGSEGV at 0x0 address not mapped to object > Program Stack: > WARNING: The stack trace will not use advanced capabilities because this is > a release build. > 0x7fff87b7acfa : _sigtramp [(libsystem_c.dylib) ???:-1] > 0x2 : ??? [(???) ???:-1] > 0x10f5e8f68 : _ZL27PyvtkView_SetRepresentationP7_objectS0_ > [(libvtkViewsCorePython27D-6.3.1.dylib) ???:-1] > > Has someone got a debug build similar to Kamino using tbb? > If so I would really appreciate it if they could run this code on it. > > To reiterate it is the following merge request: > https://gitlab.kitware.com/vtk/vtk/merge_requests/151 > > Thanks > Andrew > > > On Thu, Apr 30, 2015 at 10:09 AM, Andrew Maclean > wrote: >> >> Hi David, >> Thanks for this. >> I have just added vtkScatterPlotMatrix along with vtkChartMatrix back, >> oddly enough my windows machine never picked it up but one of the linux >> buildbots did once. Then I took it out and everything seemed ok, it's back >> in now. >> >> I totally agree with you over the usefulness of Debug Visual Studio! It is >> my main bug catcher. I use a little utility called Path Editor to reorder >> the release and debug lib and bin paths in the environment variables >> (PYTHONPATH and PATH). >> >> Regards >> Andrew >> >> On Wed, Apr 29, 2015 at 10:57 PM, David Cole wrote: >>> >>> The call stack for the out of range subscript assertion is: >>> >>> msvcp120d.dll!00007fff4d2765d6() Unknown >>> >>> vtkChartsCore-6.3.dll!std::vector,std::allocator >>> > >::operator[](unsigned __int64 _Pos) Line 1202 C++ >>> vtkChartsCore-6.3.dll!vtkChartMatrix::GetChart(const vtkVector2i & >>> position) Line 223 C++ >>> vtkChartsCore-6.3.dll!vtkScatterPlotMatrix::SetActivePlot(const >>> vtkVector2i & pos) Line 402 C++ >>> > >>> > vtkChartsCorePython27D-6.3.dll!PyvtkScatterPlotMatrix_SetActivePlot(_object >>> > * self, _object * args) Line 213 C++ >>> python27.dll!000000001e0c2199() Unknown >>> >>> Looks like vtkScatterPlotMatrix_SetActivePlot can't be called from >>> this test because other stuff that it depends on for proper operation >>> is not usable as-initialized. This indicates to me that it may only be >>> luck when it succeeds on non-VS-Debug builds, since the uninitialized >>> variables, assuming that's what the cause is, will contain random >>> contents when the test runs. >>> >>> When I add "vtkScatterPlotMatrix" as a Windows exception, the test >>> passes on this build. >>> >>> I always love running Debug Visual Studio builds for catching easy >>> errors like uninitialized variables and out of subscript references... >>> >>> >>> HTH, >>> D >>> >>> >>> On Wed, Apr 29, 2015 at 8:38 AM, David Cole wrote: >>> > I ran a build on my machine, named trivet, a Debug 64-bit build from >>> > VS 2013, and the test fails with a single assertion failure and 10-20 >>> > mem leaks: >>> > >>> > https://open.cdash.org/testDetails.php?test=331705794&build=3791568 >>> > >>> > Perhaps the "C:\Program Files (x86)\Microsoft Visual Studio >>> > 12.0\VC\INCLUDE\vector(1201) : Assertion failed: vector subscript out >>> > of range" report indicates the *real* cause of the problem on the Mac >>> > Release build. I'm not sure which class/method that comes from, but >>> > I'm about to run it and try to find out. >>> > >>> > >>> > David C. >>> > >>> > >>> > >>> > On Wed, Apr 29, 2015 at 2:23 AM, Andrew Maclean >>> > wrote: >>> >> He Sean, >>> >> >>> >> I should clarify this a bit more. >>> >> vtkDataEncoder invokes a thread pool which doesn't clean up after use, >>> >> hence >>> >> the crashes after program execution, adding vtkDataEncoder to the list >>> >> of >>> >> excluded classes "almost" fixed this. >>> >> However Windows was still crashing when the program was run again, so, >>> >> adding vtkWebApplication (which is the only class that calls >>> >> vtkDataEncoder), to the list of excluded classes, fixed this issue. >>> >> >>> >> Notwithstanding this, it is puzzling, as I said in the previous e-mail >>> >> as to >>> >> why on Kamino we get a SIGSEGV at 0x0 address not mapped to object >>> >> since >>> >> vtkView is specifically excluded. >>> >> >>> >> Regards >>> >> Andrew >>> >> >>> >> >>> >> >>> >> On Wed, Apr 29, 2015 at 1:32 PM, Andrew Maclean >>> >> >>> >> wrote: >>> >>> >>> >>> Hi Sean, >>> >>> >>> >>> Yes, vtkDataEncoder and vtkWebApplication (which uses it) are >>> >>> excluded >>> >>> form TestSetGet.py and TestEmptyInput.py. This fixed the crashes and >>> >>> also >>> >>> the crash in windows when the program was run again. I think Windows >>> >>> was a >>> >>> bit slow recovering memory. after program execution. >>> >>> >>> >>> What is puzzling is that TestGetSet excludes vtkView so >>> >>> vtkView.SetRepresentation() is never tested, this only fails on >>> >>> Kamino >>> >>> (release). It passes on trey (osX release) and also on megas. >>> >>> >>> >>> Regards >>> >>> Andrew >>> >>> >>> >>> >>> >>> On Wed, Apr 29, 2015 at 12:58 PM, Sean McBride >>> >>> >>> >>> wrote: >>> >>>> >>> >>>> Did you fix the use-after-free we discussed on this list a few weeks >>> >>>> ago? >>> >>>> >>> >>>> Sean >>> >>>> >>> >>>> >>> >>>> >>> >>>> On Wed, 29 Apr 2015 12:07:35 +1000, Andrew Maclean said: >>> >>>> >>> >>>> >David, >>> >>>> > Thanks for your insights. >>> >>>> >Just finished testing this code on my Macbook Pro OS X Yosemite, >>> >>>> > Python >>> >>>> >2.7.6 after building VTK in both Debug and Release mode. Everything >>> >>>> > runs >>> >>>> > Ok >>> >>>> >so I don't think it is a typedef or macro related to a release >>> >>>> > build on >>> >>>> > OS >>> >>>> >X. >>> >>>> > >>> >>>> >Has anyone else got any suggestions? >>> >>>> > >>> >>>> > >>> >>>> >Regards >>> >>>> > Andrew >>> >>>> > >>> >>>> >On Wed, Apr 29, 2015 at 2:23 AM, David Gobbi >>> >>>> > >>> >>>> > wrote: >>> >>>> > >>> >>>> >> Hi Andrew, >>> >>>> >> >>> >>>> >> The stack trace provides strong evidence that TestSetGet.py is >>> >>>> >> not >>> >>>> >> excluding vtkView on those dashboards, as ludicrous as that >>> >>>> >> sounds. >>> >>>> >> >>> >>>> >> c++filt -n _ZL27PyvtkView_SetRepresentationP7_objectS0_ >>> >>>> >> PyvtkView_SetRepresentation(_object*, _object*) >>> >>>> >> >>> >>>> >> This method is only defined in vtkViewPython.cxx, and only >>> >>>> >> dir(vtk.vtkView) will return this method. Calling dir() on the >>> >>>> >> vtkView >>> >>>> >> subclasses will not return this method. Hence, the only reason >>> >>>> >> that >>> >>>> >> TestSetGet.py would be calling this method is if it was testing >>> >>>> >> vtkView. >>> >>>> >> >>> >>>> >> Perhaps someone added either a typedef or a macro that causes an >>> >>>> >> additional reference to vtkView to appear in the vtk module under >>> >>>> >> a >>> >>>> >> different name. >>> >>>> >> >>> >>>> >> - David >>> >>>> >> >>> >>>> >> On Tue, Apr 28, 2015 at 1:42 AM, Andrew Maclean >>> >>>> >> >> >>>> >> > wrote: >>> >>>> >> >>> >>>> >>> Hi All, >>> >>>> >>> I need some help here. >>> >>>> >>> >>> >>>> >>> I have converted TestSetGet.tcl to Python but I get a crash on >>> >>>> >>> the >>> >>>> >>> dashboard for kamino building osx in release mode, here: >>> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789971 >>> >>>> >>> and here: >>> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789950 >>> >>>> >>> >>> >>>> >>> In an earlier attempt, linux release on megas was also crashing >>> >>>> >>> in >>> >>>> >>> release mode: >>> >>>> >>> >>> >>>> >>> https://open.cdash.org/testDetails.php?test=331289192&build=3789418 >>> >>>> >>> Based on this I excluded vtkScatterPlotMatrix which fixed it on >>> >>>> >>> megas >>> >>>> >>> but >>> >>>> >>> not on Kamino. >>> >>>> >>> So I excluded vtkChartMatrix and I still have the same errors on >>> >>>> >>> Kamino. >>> >>>> >>> But there are no clues as to where the crash is happening. >>> >>>> >>> However in >>> >>>> >>> looking at: >>> >>>> >>> >>> >>>> >>> https://open.cdash.org/testDetails.php?test=331378847&build=3789950 >>> >>>> >>> I think it is in vtkView - which is already excluded. >>> >>>> >>> This could be the problem: >>> >>>> >>> void SetRepresentation (vtkDataRepresentation *rep) >>> >>>> >>> vtkDataRepresentation * GetRepresentation (int index=0) >>> >>>> >>> >>> >>>> >>> Can anyone help? >>> >>>> >>> >>> >>>> >>> I guess I can try excluding all the *View classes as documented >>> >>>> >>> in: >>> >>>> >>> http://www.vtk.org/doc/nightly/html/classvtkView.html >>> >>>> >>> Is there a less brute-force approach? >>> >>>> >>> >>> >>>> >>> >>> >>>> >>> The code is here: >>> >>>> >>> https://gitlab.kitware.com/vtk/vtk/merge_requests/151 >>> >>>> >>> >>> >>>> >>> Thanks in advance for any help/guidance. >>> >>>> >>> >>>> >>> >>> >>> >>> >>> >>> >>> >>> -- >>> >>> ___________________________________________ >>> >>> Andrew J. P. Maclean >>> >>> >>> >>> ___________________________________________ >>> >> >>> >> >>> >> >>> >> >>> >> -- >>> >> ___________________________________________ >>> >> Andrew J. P. Maclean >>> >> >>> >> ___________________________________________ >>> >> >>> >> _______________________________________________ >>> >> Powered by www.kitware.com >>> >> >>> >> Visit other Kitware open-source projects at >>> >> http://www.kitware.com/opensource/opensource.html >>> >> >>> >> Search the list archives at: >>> >> http://markmail.org/search/?q=vtk-developers >>> >> >>> >> Follow this link to subscribe/unsubscribe: >>> >> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >> >>> >> >> >> >> >> >> -- >> ___________________________________________ >> Andrew J. P. Maclean >> >> ___________________________________________ > > > > > -- > ___________________________________________ > Andrew J. P. Maclean > > ___________________________________________ > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > From gururagaven at yahoo.co.in Fri May 1 09:23:16 2015 From: gururagaven at yahoo.co.in (Gru) Date: Fri, 01 May 2015 18:53:16 +0530 Subject: [vtk-developers] Need help with a crash on Kamino OSX Release mode. In-Reply-To: References: <20150429025840.868205794@mail.rogue-research.com> Message-ID: I want to unsunscribe this vtk Any one can suggest me Sent from my Sony Xperia? smartphone ---- Utkarsh Ayachit wrote ---- >Andrew, > >I can look at it over the weekend. Would that work? > >Utkarsh > >On Fri, May 1, 2015 at 1:20 AM, Andrew Maclean > wrote: >> I am wondering whether tbb may be picking up something. Kamino is the only >> machine with tbb and it is the only one generating this error, unfortunately >> it runs in release mode: >> >> Process id 46048 Caught SIGSEGV at 0x0 address not mapped to object >> Program Stack: >> WARNING: The stack trace will not use advanced capabilities because this is >> a release build. >> 0x7fff87b7acfa : _sigtramp [(libsystem_c.dylib) ???:-1] >> 0x2 : ??? [(???) ???:-1] >> 0x10f5e8f68 : _ZL27PyvtkView_SetRepresentationP7_objectS0_ >> [(libvtkViewsCorePython27D-6.3.1.dylib) ???:-1] >> >> Has someone got a debug build similar to Kamino using tbb? >> If so I would really appreciate it if they could run this code on it. >> >> To reiterate it is the following merge request: >> https://gitlab.kitware.com/vtk/vtk/merge_requests/151 >> >> Thanks >> Andrew >> >> >> On Thu, Apr 30, 2015 at 10:09 AM, Andrew Maclean >> wrote: >>> >>> Hi David, >>> Thanks for this. >>> I have just added vtkScatterPlotMatrix along with vtkChartMatrix back, >>> oddly enough my windows machine never picked it up but one of the linux >>> buildbots did once. Then I took it out and everything seemed ok, it's back >>> in now. >>> >>> I totally agree with you over the usefulness of Debug Visual Studio! It is >>> my main bug catcher. I use a little utility called Path Editor to reorder >>> the release and debug lib and bin paths in the environment variables >>> (PYTHONPATH and PATH). >>> >>> Regards >>> Andrew >>> >>> On Wed, Apr 29, 2015 at 10:57 PM, David Cole wrote: >>>> >>>> The call stack for the out of range subscript assertion is: >>>> >>>> msvcp120d.dll!00007fff4d2765d6() Unknown >>>> >>>> vtkChartsCore-6.3.dll!std::vector,std::allocator >>>> > >::operator[](unsigned __int64 _Pos) Line 1202 C++ >>>> vtkChartsCore-6.3.dll!vtkChartMatrix::GetChart(const vtkVector2i & >>>> position) Line 223 C++ >>>> vtkChartsCore-6.3.dll!vtkScatterPlotMatrix::SetActivePlot(const >>>> vtkVector2i & pos) Line 402 C++ >>>> > >>>> > vtkChartsCorePython27D-6.3.dll!PyvtkScatterPlotMatrix_SetActivePlot(_object >>>> > * self, _object * args) Line 213 C++ >>>> python27.dll!000000001e0c2199() Unknown >>>> >>>> Looks like vtkScatterPlotMatrix_SetActivePlot can't be called from >>>> this test because other stuff that it depends on for proper operation >>>> is not usable as-initialized. This indicates to me that it may only be >>>> luck when it succeeds on non-VS-Debug builds, since the uninitialized >>>> variables, assuming that's what the cause is, will contain random >>>> contents when the test runs. >>>> >>>> When I add "vtkScatterPlotMatrix" as a Windows exception, the test >>>> passes on this build. >>>> >>>> I always love running Debug Visual Studio builds for catching easy >>>> errors like uninitialized variables and out of subscript references... >>>> >>>> >>>> HTH, >>>> D >>>> >>>> >>>> On Wed, Apr 29, 2015 at 8:38 AM, David Cole wrote: >>>> > I ran a build on my machine, named trivet, a Debug 64-bit build from >>>> > VS 2013, and the test fails with a single assertion failure and 10-20 >>>> > mem leaks: >>>> > >>>> > https://open.cdash.org/testDetails.php?test=331705794&build=3791568 >>>> > >>>> > Perhaps the "C:\Program Files (x86)\Microsoft Visual Studio >>>> > 12.0\VC\INCLUDE\vector(1201) : Assertion failed: vector subscript out >>>> > of range" report indicates the *real* cause of the problem on the Mac >>>> > Release build. I'm not sure which class/method that comes from, but >>>> > I'm about to run it and try to find out. >>>> > >>>> > >>>> > David C. >>>> > >>>> > >>>> > >>>> > On Wed, Apr 29, 2015 at 2:23 AM, Andrew Maclean >>>> > wrote: >>>> >> He Sean, >>>> >> >>>> >> I should clarify this a bit more. >>>> >> vtkDataEncoder invokes a thread pool which doesn't clean up after use, >>>> >> hence >>>> >> the crashes after program execution, adding vtkDataEncoder to the list >>>> >> of >>>> >> excluded classes "almost" fixed this. >>>> >> However Windows was still crashing when the program was run again, so, >>>> >> adding vtkWebApplication (which is the only class that calls >>>> >> vtkDataEncoder), to the list of excluded classes, fixed this issue. >>>> >> >>>> >> Notwithstanding this, it is puzzling, as I said in the previous e-mail >>>> >> as to >>>> >> why on Kamino we get a SIGSEGV at 0x0 address not mapped to object >>>> >> since >>>> >> vtkView is specifically excluded. >>>> >> >>>> >> Regards >>>> >> Andrew >>>> >> >>>> >> >>>> >> >>>> >> On Wed, Apr 29, 2015 at 1:32 PM, Andrew Maclean >>>> >> >>>> >> wrote: >>>> >>> >>>> >>> Hi Sean, >>>> >>> >>>> >>> Yes, vtkDataEncoder and vtkWebApplication (which uses it) are >>>> >>> excluded >>>> >>> form TestSetGet.py and TestEmptyInput.py. This fixed the crashes and >>>> >>> also >>>> >>> the crash in windows when the program was run again. I think Windows >>>> >>> was a >>>> >>> bit slow recovering memory. after program execution. >>>> >>> >>>> >>> What is puzzling is that TestGetSet excludes vtkView so >>>> >>> vtkView.SetRepresentation() is never tested, this only fails on >>>> >>> Kamino >>>> >>> (release). It passes on trey (osX release) and also on megas. >>>> >>> >>>> >>> Regards >>>> >>> Andrew >>>> >>> >>>> >>> >>>> >>> On Wed, Apr 29, 2015 at 12:58 PM, Sean McBride >>>> >>> >>>> >>> wrote: >>>> >>>> >>>> >>>> Did you fix the use-after-free we discussed on this list a few weeks >>>> >>>> ago? >>>> >>>> >>>> >>>> Sean >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> On Wed, 29 Apr 2015 12:07:35 +1000, Andrew Maclean said: >>>> >>>> >>>> >>>> >David, >>>> >>>> > Thanks for your insights. >>>> >>>> >Just finished testing this code on my Macbook Pro OS X Yosemite, >>>> >>>> > Python >>>> >>>> >2.7.6 after building VTK in both Debug and Release mode. Everything >>>> >>>> > runs >>>> >>>> > Ok >>>> >>>> >so I don't think it is a typedef or macro related to a release >>>> >>>> > build on >>>> >>>> > OS >>>> >>>> >X. >>>> >>>> > >>>> >>>> >Has anyone else got any suggestions? >>>> >>>> > >>>> >>>> > >>>> >>>> >Regards >>>> >>>> > Andrew >>>> >>>> > >>>> >>>> >On Wed, Apr 29, 2015 at 2:23 AM, David Gobbi >>>> >>>> > >>>> >>>> > wrote: >>>> >>>> > >>>> >>>> >> Hi Andrew, >>>> >>>> >> >>>> >>>> >> The stack trace provides strong evidence that TestSetGet.py is >>>> >>>> >> not >>>> >>>> >> excluding vtkView on those dashboards, as ludicrous as that >>>> >>>> >> sounds. >>>> >>>> >> >>>> >>>> >> c++filt -n _ZL27PyvtkView_SetRepresentationP7_objectS0_ >>>> >>>> >> PyvtkView_SetRepresentation(_object*, _object*) >>>> >>>> >> >>>> >>>> >> This method is only defined in vtkViewPython.cxx, and only >>>> >>>> >> dir(vtk.vtkView) will return this method. Calling dir() on the >>>> >>>> >> vtkView >>>> >>>> >> subclasses will not return this method. Hence, the only reason >>>> >>>> >> that >>>> >>>> >> TestSetGet.py would be calling this method is if it was testing >>>> >>>> >> vtkView. >>>> >>>> >> >>>> >>>> >> Perhaps someone added either a typedef or a macro that causes an >>>> >>>> >> additional reference to vtkView to appear in the vtk module under >>>> >>>> >> a >>>> >>>> >> different name. >>>> >>>> >> >>>> >>>> >> - David >>>> >>>> >> >>>> >>>> >> On Tue, Apr 28, 2015 at 1:42 AM, Andrew Maclean >>>> >>>> >> >>> >>>> >> > wrote: >>>> >>>> >> >>>> >>>> >>> Hi All, >>>> >>>> >>> I need some help here. >>>> >>>> >>> >>>> >>>> >>> I have converted TestSetGet.tcl to Python but I get a crash on >>>> >>>> >>> the >>>> >>>> >>> dashboard for kamino building osx in release mode, here: >>>> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789971 >>>> >>>> >>> and here: >>>> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789950 >>>> >>>> >>> >>>> >>>> >>> In an earlier attempt, linux release on megas was also crashing >>>> >>>> >>> in >>>> >>>> >>> release mode: >>>> >>>> >>> >>>> >>>> >>> https://open.cdash.org/testDetails.php?test=331289192&build=3789418 >>>> >>>> >>> Based on this I excluded vtkScatterPlotMatrix which fixed it on >>>> >>>> >>> megas >>>> >>>> >>> but >>>> >>>> >>> not on Kamino. >>>> >>>> >>> So I excluded vtkChartMatrix and I still have the same errors on >>>> >>>> >>> Kamino. >>>> >>>> >>> But there are no clues as to where the crash is happening. >>>> >>>> >>> However in >>>> >>>> >>> looking at: >>>> >>>> >>> >>>> >>>> >>> https://open.cdash.org/testDetails.php?test=331378847&build=3789950 >>>> >>>> >>> I think it is in vtkView - which is already excluded. >>>> >>>> >>> This could be the problem: >>>> >>>> >>> void SetRepresentation (vtkDataRepresentation *rep) >>>> >>>> >>> vtkDataRepresentation * GetRepresentation (int index=0) >>>> >>>> >>> >>>> >>>> >>> Can anyone help? >>>> >>>> >>> >>>> >>>> >>> I guess I can try excluding all the *View classes as documented >>>> >>>> >>> in: >>>> >>>> >>> http://www.vtk.org/doc/nightly/html/classvtkView.html >>>> >>>> >>> Is there a less brute-force approach? >>>> >>>> >>> >>>> >>>> >>> >>>> >>>> >>> The code is here: >>>> >>>> >>> https://gitlab.kitware.com/vtk/vtk/merge_requests/151 >>>> >>>> >>> >>>> >>>> >>> Thanks in advance for any help/guidance. >>>> >>>> >>>> >>>> >>>> >>> >>>> >>> >>>> >>> >>>> >>> -- >>>> >>> ___________________________________________ >>>> >>> Andrew J. P. Maclean >>>> >>> >>>> >>> ___________________________________________ >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> -- >>>> >> ___________________________________________ >>>> >> Andrew J. P. Maclean >>>> >> >>>> >> ___________________________________________ >>>> >> >>>> >> _______________________________________________ >>>> >> Powered by www.kitware.com >>>> >> >>>> >> Visit other Kitware open-source projects at >>>> >> http://www.kitware.com/opensource/opensource.html >>>> >> >>>> >> Search the list archives at: >>>> >> http://markmail.org/search/?q=vtk-developers >>>> >> >>>> >> Follow this link to subscribe/unsubscribe: >>>> >> http://public.kitware.com/mailman/listinfo/vtk-developers >>>> >> >>>> >> >>> >>> >>> >>> >>> -- >>> ___________________________________________ >>> Andrew J. P. Maclean >>> >>> ___________________________________________ >> >> >> >> >> -- >> ___________________________________________ >> Andrew J. P. Maclean >> >> ___________________________________________ >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >_______________________________________________ >Powered by www.kitware.com > >Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > >Search the list archives at: http://markmail.org/search/?q=vtk-developers > >Follow this link to subscribe/unsubscribe: >http://public.kitware.com/mailman/listinfo/vtk-developers > -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Fri May 1 14:52:20 2015 From: sean at rogue-research.com (Sean McBride) Date: Fri, 1 May 2015 14:52:20 -0400 Subject: [vtk-developers] Bug fix for boolean operations filter In-Reply-To: References: Message-ID: <20150501185220.885647698@mail.rogue-research.com> On Thu, 30 Apr 2015 22:09:01 -0400, Cory Quammen said: >Today I committed a bug fix to vtkImplicitPolyDataDistance that should fix >at least some of the known problems with vtkBooleanOperationPolyDataFilter. Great, thanks! I'll give it a try. We are still using the contributed GTS-based code because it gives better results for us (though does crash sometimes). Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From andrew.amaclean at gmail.com Fri May 1 16:02:25 2015 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Sat, 2 May 2015 06:02:25 +1000 Subject: [vtk-developers] Need help with a crash on Kamino OSX Release mode. In-Reply-To: References: <20150429025840.868205794@mail.rogue-research.com> Message-ID: That would be perfect, thanks. On 01/05/2015 11:17 PM, "Utkarsh Ayachit" wrote: > Andrew, > > I can look at it over the weekend. Would that work? > > Utkarsh > > On Fri, May 1, 2015 at 1:20 AM, Andrew Maclean > wrote: > > I am wondering whether tbb may be picking up something. Kamino is the > only > > machine with tbb and it is the only one generating this error, > unfortunately > > it runs in release mode: > > > > Process id 46048 Caught SIGSEGV at 0x0 address not mapped to object > > Program Stack: > > WARNING: The stack trace will not use advanced capabilities because this > is > > a release build. > > 0x7fff87b7acfa : _sigtramp [(libsystem_c.dylib) ???:-1] > > 0x2 : ??? [(???) ???:-1] > > 0x10f5e8f68 : _ZL27PyvtkView_SetRepresentationP7_objectS0_ > > [(libvtkViewsCorePython27D-6.3.1.dylib) ???:-1] > > > > Has someone got a debug build similar to Kamino using tbb? > > If so I would really appreciate it if they could run this code on it. > > > > To reiterate it is the following merge request: > > https://gitlab.kitware.com/vtk/vtk/merge_requests/151 > > > > Thanks > > Andrew > > > > > > On Thu, Apr 30, 2015 at 10:09 AM, Andrew Maclean < > andrew.amaclean at gmail.com> > > wrote: > >> > >> Hi David, > >> Thanks for this. > >> I have just added vtkScatterPlotMatrix along with vtkChartMatrix back, > >> oddly enough my windows machine never picked it up but one of the linux > >> buildbots did once. Then I took it out and everything seemed ok, it's > back > >> in now. > >> > >> I totally agree with you over the usefulness of Debug Visual Studio! It > is > >> my main bug catcher. I use a little utility called Path Editor to > reorder > >> the release and debug lib and bin paths in the environment variables > >> (PYTHONPATH and PATH). > >> > >> Regards > >> Andrew > >> > >> On Wed, Apr 29, 2015 at 10:57 PM, David Cole wrote: > >>> > >>> The call stack for the out of range subscript assertion is: > >>> > >>> msvcp120d.dll!00007fff4d2765d6() Unknown > >>> > >>> > vtkChartsCore-6.3.dll!std::vector,std::allocator > >>> > >::operator[](unsigned __int64 _Pos) Line 1202 C++ > >>> vtkChartsCore-6.3.dll!vtkChartMatrix::GetChart(const vtkVector2i & > >>> position) Line 223 C++ > >>> vtkChartsCore-6.3.dll!vtkScatterPlotMatrix::SetActivePlot(const > >>> vtkVector2i & pos) Line 402 C++ > >>> > > >>> > > vtkChartsCorePython27D-6.3.dll!PyvtkScatterPlotMatrix_SetActivePlot(_object > >>> > * self, _object * args) Line 213 C++ > >>> python27.dll!000000001e0c2199() Unknown > >>> > >>> Looks like vtkScatterPlotMatrix_SetActivePlot can't be called from > >>> this test because other stuff that it depends on for proper operation > >>> is not usable as-initialized. This indicates to me that it may only be > >>> luck when it succeeds on non-VS-Debug builds, since the uninitialized > >>> variables, assuming that's what the cause is, will contain random > >>> contents when the test runs. > >>> > >>> When I add "vtkScatterPlotMatrix" as a Windows exception, the test > >>> passes on this build. > >>> > >>> I always love running Debug Visual Studio builds for catching easy > >>> errors like uninitialized variables and out of subscript references... > >>> > >>> > >>> HTH, > >>> D > >>> > >>> > >>> On Wed, Apr 29, 2015 at 8:38 AM, David Cole wrote: > >>> > I ran a build on my machine, named trivet, a Debug 64-bit build from > >>> > VS 2013, and the test fails with a single assertion failure and 10-20 > >>> > mem leaks: > >>> > > >>> > https://open.cdash.org/testDetails.php?test=331705794&build=3791568 > >>> > > >>> > Perhaps the "C:\Program Files (x86)\Microsoft Visual Studio > >>> > 12.0\VC\INCLUDE\vector(1201) : Assertion failed: vector subscript out > >>> > of range" report indicates the *real* cause of the problem on the Mac > >>> > Release build. I'm not sure which class/method that comes from, but > >>> > I'm about to run it and try to find out. > >>> > > >>> > > >>> > David C. > >>> > > >>> > > >>> > > >>> > On Wed, Apr 29, 2015 at 2:23 AM, Andrew Maclean > >>> > wrote: > >>> >> He Sean, > >>> >> > >>> >> I should clarify this a bit more. > >>> >> vtkDataEncoder invokes a thread pool which doesn't clean up after > use, > >>> >> hence > >>> >> the crashes after program execution, adding vtkDataEncoder to the > list > >>> >> of > >>> >> excluded classes "almost" fixed this. > >>> >> However Windows was still crashing when the program was run again, > so, > >>> >> adding vtkWebApplication (which is the only class that calls > >>> >> vtkDataEncoder), to the list of excluded classes, fixed this issue. > >>> >> > >>> >> Notwithstanding this, it is puzzling, as I said in the previous > e-mail > >>> >> as to > >>> >> why on Kamino we get a SIGSEGV at 0x0 address not mapped to object > >>> >> since > >>> >> vtkView is specifically excluded. > >>> >> > >>> >> Regards > >>> >> Andrew > >>> >> > >>> >> > >>> >> > >>> >> On Wed, Apr 29, 2015 at 1:32 PM, Andrew Maclean > >>> >> > >>> >> wrote: > >>> >>> > >>> >>> Hi Sean, > >>> >>> > >>> >>> Yes, vtkDataEncoder and vtkWebApplication (which uses it) are > >>> >>> excluded > >>> >>> form TestSetGet.py and TestEmptyInput.py. This fixed the crashes > and > >>> >>> also > >>> >>> the crash in windows when the program was run again. I think > Windows > >>> >>> was a > >>> >>> bit slow recovering memory. after program execution. > >>> >>> > >>> >>> What is puzzling is that TestGetSet excludes vtkView so > >>> >>> vtkView.SetRepresentation() is never tested, this only fails on > >>> >>> Kamino > >>> >>> (release). It passes on trey (osX release) and also on megas. > >>> >>> > >>> >>> Regards > >>> >>> Andrew > >>> >>> > >>> >>> > >>> >>> On Wed, Apr 29, 2015 at 12:58 PM, Sean McBride > >>> >>> > >>> >>> wrote: > >>> >>>> > >>> >>>> Did you fix the use-after-free we discussed on this list a few > weeks > >>> >>>> ago? > >>> >>>> > >>> >>>> Sean > >>> >>>> > >>> >>>> > >>> >>>> > >>> >>>> On Wed, 29 Apr 2015 12:07:35 +1000, Andrew Maclean said: > >>> >>>> > >>> >>>> >David, > >>> >>>> > Thanks for your insights. > >>> >>>> >Just finished testing this code on my Macbook Pro OS X Yosemite, > >>> >>>> > Python > >>> >>>> >2.7.6 after building VTK in both Debug and Release mode. > Everything > >>> >>>> > runs > >>> >>>> > Ok > >>> >>>> >so I don't think it is a typedef or macro related to a release > >>> >>>> > build on > >>> >>>> > OS > >>> >>>> >X. > >>> >>>> > > >>> >>>> >Has anyone else got any suggestions? > >>> >>>> > > >>> >>>> > > >>> >>>> >Regards > >>> >>>> > Andrew > >>> >>>> > > >>> >>>> >On Wed, Apr 29, 2015 at 2:23 AM, David Gobbi > >>> >>>> > > >>> >>>> > wrote: > >>> >>>> > > >>> >>>> >> Hi Andrew, > >>> >>>> >> > >>> >>>> >> The stack trace provides strong evidence that TestSetGet.py is > >>> >>>> >> not > >>> >>>> >> excluding vtkView on those dashboards, as ludicrous as that > >>> >>>> >> sounds. > >>> >>>> >> > >>> >>>> >> c++filt -n _ZL27PyvtkView_SetRepresentationP7_objectS0_ > >>> >>>> >> PyvtkView_SetRepresentation(_object*, _object*) > >>> >>>> >> > >>> >>>> >> This method is only defined in vtkViewPython.cxx, and only > >>> >>>> >> dir(vtk.vtkView) will return this method. Calling dir() on the > >>> >>>> >> vtkView > >>> >>>> >> subclasses will not return this method. Hence, the only reason > >>> >>>> >> that > >>> >>>> >> TestSetGet.py would be calling this method is if it was testing > >>> >>>> >> vtkView. > >>> >>>> >> > >>> >>>> >> Perhaps someone added either a typedef or a macro that causes > an > >>> >>>> >> additional reference to vtkView to appear in the vtk module > under > >>> >>>> >> a > >>> >>>> >> different name. > >>> >>>> >> > >>> >>>> >> - David > >>> >>>> >> > >>> >>>> >> On Tue, Apr 28, 2015 at 1:42 AM, Andrew Maclean > >>> >>>> >> >>> >>>> >> > wrote: > >>> >>>> >> > >>> >>>> >>> Hi All, > >>> >>>> >>> I need some help here. > >>> >>>> >>> > >>> >>>> >>> I have converted TestSetGet.tcl to Python but I get a crash on > >>> >>>> >>> the > >>> >>>> >>> dashboard for kamino building osx in release mode, here: > >>> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789971 > >>> >>>> >>> and here: > >>> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789950 > >>> >>>> >>> > >>> >>>> >>> In an earlier attempt, linux release on megas was also > crashing > >>> >>>> >>> in > >>> >>>> >>> release mode: > >>> >>>> >>> > >>> >>>> >>> > https://open.cdash.org/testDetails.php?test=331289192&build=3789418 > >>> >>>> >>> Based on this I excluded vtkScatterPlotMatrix which fixed it > on > >>> >>>> >>> megas > >>> >>>> >>> but > >>> >>>> >>> not on Kamino. > >>> >>>> >>> So I excluded vtkChartMatrix and I still have the same errors > on > >>> >>>> >>> Kamino. > >>> >>>> >>> But there are no clues as to where the crash is happening. > >>> >>>> >>> However in > >>> >>>> >>> looking at: > >>> >>>> >>> > >>> >>>> >>> > https://open.cdash.org/testDetails.php?test=331378847&build=3789950 > >>> >>>> >>> I think it is in vtkView - which is already excluded. > >>> >>>> >>> This could be the problem: > >>> >>>> >>> void SetRepresentation (vtkDataRepresentation *rep) > >>> >>>> >>> vtkDataRepresentation * GetRepresentation (int index=0) > >>> >>>> >>> > >>> >>>> >>> Can anyone help? > >>> >>>> >>> > >>> >>>> >>> I guess I can try excluding all the *View classes as > documented > >>> >>>> >>> in: > >>> >>>> >>> http://www.vtk.org/doc/nightly/html/classvtkView.html > >>> >>>> >>> Is there a less brute-force approach? > >>> >>>> >>> > >>> >>>> >>> > >>> >>>> >>> The code is here: > >>> >>>> >>> https://gitlab.kitware.com/vtk/vtk/merge_requests/151 > >>> >>>> >>> > >>> >>>> >>> Thanks in advance for any help/guidance. > >>> >>>> > >>> >>>> > >>> >>> > >>> >>> > >>> >>> > >>> >>> -- > >>> >>> ___________________________________________ > >>> >>> Andrew J. P. Maclean > >>> >>> > >>> >>> ___________________________________________ > >>> >> > >>> >> > >>> >> > >>> >> > >>> >> -- > >>> >> ___________________________________________ > >>> >> Andrew J. P. Maclean > >>> >> > >>> >> ___________________________________________ > >>> >> > >>> >> _______________________________________________ > >>> >> Powered by www.kitware.com > >>> >> > >>> >> Visit other Kitware open-source projects at > >>> >> http://www.kitware.com/opensource/opensource.html > >>> >> > >>> >> Search the list archives at: > >>> >> http://markmail.org/search/?q=vtk-developers > >>> >> > >>> >> Follow this link to subscribe/unsubscribe: > >>> >> http://public.kitware.com/mailman/listinfo/vtk-developers > >>> >> > >>> >> > >> > >> > >> > >> > >> -- > >> ___________________________________________ > >> Andrew J. P. Maclean > >> > >> ___________________________________________ > > > > > > > > > > -- > > ___________________________________________ > > Andrew J. P. Maclean > > > > ___________________________________________ > > > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Search the list archives at: > http://markmail.org/search/?q=vtk-developers > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/vtk-developers > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Sat May 2 11:04:50 2015 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Sat, 2 May 2015 11:04:50 -0400 Subject: [vtk-developers] Need help with a crash on Kamino OSX Release mode. In-Reply-To: References: <20150429025840.868205794@mail.rogue-research.com> Message-ID: Andrew, Attached is a patch that fixes issues with 'vtk-kamino-osx-shared-release+mpi+python+tbb' builder. Utkarsh On Fri, May 1, 2015 at 4:02 PM, Andrew Maclean wrote: > That would be perfect, thanks. > > On 01/05/2015 11:17 PM, "Utkarsh Ayachit" > wrote: >> >> Andrew, >> >> I can look at it over the weekend. Would that work? >> >> Utkarsh >> >> On Fri, May 1, 2015 at 1:20 AM, Andrew Maclean >> wrote: >> > I am wondering whether tbb may be picking up something. Kamino is the >> > only >> > machine with tbb and it is the only one generating this error, >> > unfortunately >> > it runs in release mode: >> > >> > Process id 46048 Caught SIGSEGV at 0x0 address not mapped to object >> > Program Stack: >> > WARNING: The stack trace will not use advanced capabilities because this >> > is >> > a release build. >> > 0x7fff87b7acfa : _sigtramp [(libsystem_c.dylib) ???:-1] >> > 0x2 : ??? [(???) ???:-1] >> > 0x10f5e8f68 : _ZL27PyvtkView_SetRepresentationP7_objectS0_ >> > [(libvtkViewsCorePython27D-6.3.1.dylib) ???:-1] >> > >> > Has someone got a debug build similar to Kamino using tbb? >> > If so I would really appreciate it if they could run this code on it. >> > >> > To reiterate it is the following merge request: >> > https://gitlab.kitware.com/vtk/vtk/merge_requests/151 >> > >> > Thanks >> > Andrew >> > >> > >> > On Thu, Apr 30, 2015 at 10:09 AM, Andrew Maclean >> > >> > wrote: >> >> >> >> Hi David, >> >> Thanks for this. >> >> I have just added vtkScatterPlotMatrix along with vtkChartMatrix back, >> >> oddly enough my windows machine never picked it up but one of the linux >> >> buildbots did once. Then I took it out and everything seemed ok, it's >> >> back >> >> in now. >> >> >> >> I totally agree with you over the usefulness of Debug Visual Studio! It >> >> is >> >> my main bug catcher. I use a little utility called Path Editor to >> >> reorder >> >> the release and debug lib and bin paths in the environment variables >> >> (PYTHONPATH and PATH). >> >> >> >> Regards >> >> Andrew >> >> >> >> On Wed, Apr 29, 2015 at 10:57 PM, David Cole wrote: >> >>> >> >>> The call stack for the out of range subscript assertion is: >> >>> >> >>> msvcp120d.dll!00007fff4d2765d6() Unknown >> >>> >> >>> >> >>> vtkChartsCore-6.3.dll!std::vector,std::allocator >> >>> > >::operator[](unsigned __int64 _Pos) Line 1202 C++ >> >>> vtkChartsCore-6.3.dll!vtkChartMatrix::GetChart(const vtkVector2i & >> >>> position) Line 223 C++ >> >>> vtkChartsCore-6.3.dll!vtkScatterPlotMatrix::SetActivePlot(const >> >>> vtkVector2i & pos) Line 402 C++ >> >>> > >> >>> > >> >>> > vtkChartsCorePython27D-6.3.dll!PyvtkScatterPlotMatrix_SetActivePlot(_object >> >>> > * self, _object * args) Line 213 C++ >> >>> python27.dll!000000001e0c2199() Unknown >> >>> >> >>> Looks like vtkScatterPlotMatrix_SetActivePlot can't be called from >> >>> this test because other stuff that it depends on for proper operation >> >>> is not usable as-initialized. This indicates to me that it may only be >> >>> luck when it succeeds on non-VS-Debug builds, since the uninitialized >> >>> variables, assuming that's what the cause is, will contain random >> >>> contents when the test runs. >> >>> >> >>> When I add "vtkScatterPlotMatrix" as a Windows exception, the test >> >>> passes on this build. >> >>> >> >>> I always love running Debug Visual Studio builds for catching easy >> >>> errors like uninitialized variables and out of subscript references... >> >>> >> >>> >> >>> HTH, >> >>> D >> >>> >> >>> >> >>> On Wed, Apr 29, 2015 at 8:38 AM, David Cole wrote: >> >>> > I ran a build on my machine, named trivet, a Debug 64-bit build from >> >>> > VS 2013, and the test fails with a single assertion failure and >> >>> > 10-20 >> >>> > mem leaks: >> >>> > >> >>> > https://open.cdash.org/testDetails.php?test=331705794&build=3791568 >> >>> > >> >>> > Perhaps the "C:\Program Files (x86)\Microsoft Visual Studio >> >>> > 12.0\VC\INCLUDE\vector(1201) : Assertion failed: vector subscript >> >>> > out >> >>> > of range" report indicates the *real* cause of the problem on the >> >>> > Mac >> >>> > Release build. I'm not sure which class/method that comes from, but >> >>> > I'm about to run it and try to find out. >> >>> > >> >>> > >> >>> > David C. >> >>> > >> >>> > >> >>> > >> >>> > On Wed, Apr 29, 2015 at 2:23 AM, Andrew Maclean >> >>> > wrote: >> >>> >> He Sean, >> >>> >> >> >>> >> I should clarify this a bit more. >> >>> >> vtkDataEncoder invokes a thread pool which doesn't clean up after >> >>> >> use, >> >>> >> hence >> >>> >> the crashes after program execution, adding vtkDataEncoder to the >> >>> >> list >> >>> >> of >> >>> >> excluded classes "almost" fixed this. >> >>> >> However Windows was still crashing when the program was run again, >> >>> >> so, >> >>> >> adding vtkWebApplication (which is the only class that calls >> >>> >> vtkDataEncoder), to the list of excluded classes, fixed this issue. >> >>> >> >> >>> >> Notwithstanding this, it is puzzling, as I said in the previous >> >>> >> e-mail >> >>> >> as to >> >>> >> why on Kamino we get a SIGSEGV at 0x0 address not mapped to object >> >>> >> since >> >>> >> vtkView is specifically excluded. >> >>> >> >> >>> >> Regards >> >>> >> Andrew >> >>> >> >> >>> >> >> >>> >> >> >>> >> On Wed, Apr 29, 2015 at 1:32 PM, Andrew Maclean >> >>> >> >> >>> >> wrote: >> >>> >>> >> >>> >>> Hi Sean, >> >>> >>> >> >>> >>> Yes, vtkDataEncoder and vtkWebApplication (which uses it) are >> >>> >>> excluded >> >>> >>> form TestSetGet.py and TestEmptyInput.py. This fixed the crashes >> >>> >>> and >> >>> >>> also >> >>> >>> the crash in windows when the program was run again. I think >> >>> >>> Windows >> >>> >>> was a >> >>> >>> bit slow recovering memory. after program execution. >> >>> >>> >> >>> >>> What is puzzling is that TestGetSet excludes vtkView so >> >>> >>> vtkView.SetRepresentation() is never tested, this only fails on >> >>> >>> Kamino >> >>> >>> (release). It passes on trey (osX release) and also on megas. >> >>> >>> >> >>> >>> Regards >> >>> >>> Andrew >> >>> >>> >> >>> >>> >> >>> >>> On Wed, Apr 29, 2015 at 12:58 PM, Sean McBride >> >>> >>> >> >>> >>> wrote: >> >>> >>>> >> >>> >>>> Did you fix the use-after-free we discussed on this list a few >> >>> >>>> weeks >> >>> >>>> ago? >> >>> >>>> >> >>> >>>> Sean >> >>> >>>> >> >>> >>>> >> >>> >>>> >> >>> >>>> On Wed, 29 Apr 2015 12:07:35 +1000, Andrew Maclean said: >> >>> >>>> >> >>> >>>> >David, >> >>> >>>> > Thanks for your insights. >> >>> >>>> >Just finished testing this code on my Macbook Pro OS X Yosemite, >> >>> >>>> > Python >> >>> >>>> >2.7.6 after building VTK in both Debug and Release mode. >> >>> >>>> > Everything >> >>> >>>> > runs >> >>> >>>> > Ok >> >>> >>>> >so I don't think it is a typedef or macro related to a release >> >>> >>>> > build on >> >>> >>>> > OS >> >>> >>>> >X. >> >>> >>>> > >> >>> >>>> >Has anyone else got any suggestions? >> >>> >>>> > >> >>> >>>> > >> >>> >>>> >Regards >> >>> >>>> > Andrew >> >>> >>>> > >> >>> >>>> >On Wed, Apr 29, 2015 at 2:23 AM, David Gobbi >> >>> >>>> > >> >>> >>>> > wrote: >> >>> >>>> > >> >>> >>>> >> Hi Andrew, >> >>> >>>> >> >> >>> >>>> >> The stack trace provides strong evidence that TestSetGet.py is >> >>> >>>> >> not >> >>> >>>> >> excluding vtkView on those dashboards, as ludicrous as that >> >>> >>>> >> sounds. >> >>> >>>> >> >> >>> >>>> >> c++filt -n _ZL27PyvtkView_SetRepresentationP7_objectS0_ >> >>> >>>> >> PyvtkView_SetRepresentation(_object*, _object*) >> >>> >>>> >> >> >>> >>>> >> This method is only defined in vtkViewPython.cxx, and only >> >>> >>>> >> dir(vtk.vtkView) will return this method. Calling dir() on >> >>> >>>> >> the >> >>> >>>> >> vtkView >> >>> >>>> >> subclasses will not return this method. Hence, the only >> >>> >>>> >> reason >> >>> >>>> >> that >> >>> >>>> >> TestSetGet.py would be calling this method is if it was >> >>> >>>> >> testing >> >>> >>>> >> vtkView. >> >>> >>>> >> >> >>> >>>> >> Perhaps someone added either a typedef or a macro that causes >> >>> >>>> >> an >> >>> >>>> >> additional reference to vtkView to appear in the vtk module >> >>> >>>> >> under >> >>> >>>> >> a >> >>> >>>> >> different name. >> >>> >>>> >> >> >>> >>>> >> - David >> >>> >>>> >> >> >>> >>>> >> On Tue, Apr 28, 2015 at 1:42 AM, Andrew Maclean >> >>> >>>> >> > >>> >>>> >> > wrote: >> >>> >>>> >> >> >>> >>>> >>> Hi All, >> >>> >>>> >>> I need some help here. >> >>> >>>> >>> >> >>> >>>> >>> I have converted TestSetGet.tcl to Python but I get a crash >> >>> >>>> >>> on >> >>> >>>> >>> the >> >>> >>>> >>> dashboard for kamino building osx in release mode, here: >> >>> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789971 >> >>> >>>> >>> and here: >> >>> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789950 >> >>> >>>> >>> >> >>> >>>> >>> In an earlier attempt, linux release on megas was also >> >>> >>>> >>> crashing >> >>> >>>> >>> in >> >>> >>>> >>> release mode: >> >>> >>>> >>> >> >>> >>>> >>> >> >>> >>>> >>> https://open.cdash.org/testDetails.php?test=331289192&build=3789418 >> >>> >>>> >>> Based on this I excluded vtkScatterPlotMatrix which fixed it >> >>> >>>> >>> on >> >>> >>>> >>> megas >> >>> >>>> >>> but >> >>> >>>> >>> not on Kamino. >> >>> >>>> >>> So I excluded vtkChartMatrix and I still have the same errors >> >>> >>>> >>> on >> >>> >>>> >>> Kamino. >> >>> >>>> >>> But there are no clues as to where the crash is happening. >> >>> >>>> >>> However in >> >>> >>>> >>> looking at: >> >>> >>>> >>> >> >>> >>>> >>> >> >>> >>>> >>> https://open.cdash.org/testDetails.php?test=331378847&build=3789950 >> >>> >>>> >>> I think it is in vtkView - which is already excluded. >> >>> >>>> >>> This could be the problem: >> >>> >>>> >>> void SetRepresentation (vtkDataRepresentation *rep) >> >>> >>>> >>> vtkDataRepresentation * GetRepresentation (int index=0) >> >>> >>>> >>> >> >>> >>>> >>> Can anyone help? >> >>> >>>> >>> >> >>> >>>> >>> I guess I can try excluding all the *View classes as >> >>> >>>> >>> documented >> >>> >>>> >>> in: >> >>> >>>> >>> http://www.vtk.org/doc/nightly/html/classvtkView.html >> >>> >>>> >>> Is there a less brute-force approach? >> >>> >>>> >>> >> >>> >>>> >>> >> >>> >>>> >>> The code is here: >> >>> >>>> >>> https://gitlab.kitware.com/vtk/vtk/merge_requests/151 >> >>> >>>> >>> >> >>> >>>> >>> Thanks in advance for any help/guidance. >> >>> >>>> >> >>> >>>> >> >>> >>> >> >>> >>> >> >>> >>> >> >>> >>> -- >> >>> >>> ___________________________________________ >> >>> >>> Andrew J. P. Maclean >> >>> >>> >> >>> >>> ___________________________________________ >> >>> >> >> >>> >> >> >>> >> >> >>> >> >> >>> >> -- >> >>> >> ___________________________________________ >> >>> >> Andrew J. P. Maclean >> >>> >> >> >>> >> ___________________________________________ >> >>> >> >> >>> >> _______________________________________________ >> >>> >> Powered by www.kitware.com >> >>> >> >> >>> >> Visit other Kitware open-source projects at >> >>> >> http://www.kitware.com/opensource/opensource.html >> >>> >> >> >>> >> Search the list archives at: >> >>> >> http://markmail.org/search/?q=vtk-developers >> >>> >> >> >>> >> Follow this link to subscribe/unsubscribe: >> >>> >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >>> >> >> >>> >> >> >> >> >> >> >> >> >> >> >> -- >> >> ___________________________________________ >> >> Andrew J. P. Maclean >> >> >> >> ___________________________________________ >> > >> > >> > >> > >> > -- >> > ___________________________________________ >> > Andrew J. P. Maclean >> > >> > ___________________________________________ >> > >> > _______________________________________________ >> > Powered by www.kitware.com >> > >> > Visit other Kitware open-source projects at >> > http://www.kitware.com/opensource/opensource.html >> > >> > Search the list archives at: >> > http://markmail.org/search/?q=vtk-developers >> > >> > Follow this link to subscribe/unsubscribe: >> > http://public.kitware.com/mailman/listinfo/vtk-developers >> > >> > -------------- next part -------------- A non-text attachment was scrubbed... Name: setgetfixes.patch Type: application/octet-stream Size: 3065 bytes Desc: not available URL: From matthew.brett at gmail.com Sat May 2 17:40:07 2015 From: matthew.brett at gmail.com (Matthew Brett) Date: Sat, 2 May 2015 14:40:07 -0700 Subject: [vtk-developers] Fwd: OSX build links directly with Python binary - avoidable? In-Reply-To: References: Message-ID: Hi, I have spent a little time trying to build OSX wheels [1] for VTK. These would be very useful for an automated binary install of VTK for OSX Python. Short version : vtk python libraries link directly against the Python binary, making more general packaging impossible. Long version: My plan was to first do an install into the Python site-packages, copy and do a relative path relink of the library dependencies into a `.dylibs` directory [2] and then package the files into a wheel. My first shot was using the homebrew installation: brew install vtk --with-python --with-qt --with-matplotlib This installation can't be used with a Python other than the one it is compiled with, because it links directly to the Python binary. The output from this: cd /usr/local/Cellar/vtk/6.2.0/lib/python2.7/site-packages/vtk otool -L vtkCommonCorePython.so includes: /usr/local/opt/python/Frameworks/Python.framework/Versions/2.7/Python (compatibility version 2.7.0, current version 2.7.0) This is true for many (?all) other vtk compiled extension modules. Is there any reason that this library has to link directly the Python binary? It makes it impossible to make a package that will install for a Python other than the one it was built with, and at the same path. I believe standard practice is to use " -undefined dynamic_lookup " for Python symbols loaded from extension modules, but I am happy to be corrected. Cheers, Matthew [1] https://github.com/MacPython/wiki/wiki/Spinning-wheels [2] https://github.com/matthew-brett/delocate From andrew.amaclean at gmail.com Sun May 3 21:35:27 2015 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Mon, 4 May 2015 11:35:27 +1000 Subject: [vtk-developers] Need help with a crash on Kamino OSX Release mode. In-Reply-To: References: <20150429025840.868205794@mail.rogue-research.com> Message-ID: Hi Utkarsh, Your fixes have worked perfectly. Thankyou for taking the time to look at Kamino for me. I owe you a beer! Seriously I would have never found the problems as all the resting on my machines was consistently clean. This is the strength of Kitware in that the testing environment is broad based and people are prepared to give up some time to look into issues and suggest fixes. TestSetGet.py is now ready for review along with the changes to vtkOverlappingAMR, vtkStructuredAMRGridConnectivity, vtkPStructuredGridConnectivity, vtkView. Regards Andrew On Sun, May 3, 2015 at 1:04 AM, Utkarsh Ayachit wrote: > Andrew, > > Attached is a patch that fixes issues with > 'vtk-kamino-osx-shared-release+mpi+python+tbb' builder. > > Utkarsh > > > On Fri, May 1, 2015 at 4:02 PM, Andrew Maclean > wrote: > > That would be perfect, thanks. > > > > On 01/05/2015 11:17 PM, "Utkarsh Ayachit" > > wrote: > >> > >> Andrew, > >> > >> I can look at it over the weekend. Would that work? > >> > >> Utkarsh > >> > >> On Fri, May 1, 2015 at 1:20 AM, Andrew Maclean > >> wrote: > >> > I am wondering whether tbb may be picking up something. Kamino is the > >> > only > >> > machine with tbb and it is the only one generating this error, > >> > unfortunately > >> > it runs in release mode: > >> > > >> > Process id 46048 Caught SIGSEGV at 0x0 address not mapped to object > >> > Program Stack: > >> > WARNING: The stack trace will not use advanced capabilities because > this > >> > is > >> > a release build. > >> > 0x7fff87b7acfa : _sigtramp [(libsystem_c.dylib) ???:-1] > >> > 0x2 : ??? [(???) ???:-1] > >> > 0x10f5e8f68 : _ZL27PyvtkView_SetRepresentationP7_objectS0_ > >> > [(libvtkViewsCorePython27D-6.3.1.dylib) ???:-1] > >> > > >> > Has someone got a debug build similar to Kamino using tbb? > >> > If so I would really appreciate it if they could run this code on it. > >> > > >> > To reiterate it is the following merge request: > >> > https://gitlab.kitware.com/vtk/vtk/merge_requests/151 > >> > > >> > Thanks > >> > Andrew > >> > > >> > > >> > On Thu, Apr 30, 2015 at 10:09 AM, Andrew Maclean > >> > > >> > wrote: > >> >> > >> >> Hi David, > >> >> Thanks for this. > >> >> I have just added vtkScatterPlotMatrix along with vtkChartMatrix > back, > >> >> oddly enough my windows machine never picked it up but one of the > linux > >> >> buildbots did once. Then I took it out and everything seemed ok, it's > >> >> back > >> >> in now. > >> >> > >> >> I totally agree with you over the usefulness of Debug Visual Studio! > It > >> >> is > >> >> my main bug catcher. I use a little utility called Path Editor to > >> >> reorder > >> >> the release and debug lib and bin paths in the environment variables > >> >> (PYTHONPATH and PATH). > >> >> > >> >> Regards > >> >> Andrew > >> >> > >> >> On Wed, Apr 29, 2015 at 10:57 PM, David Cole > wrote: > >> >>> > >> >>> The call stack for the out of range subscript assertion is: > >> >>> > >> >>> msvcp120d.dll!00007fff4d2765d6() Unknown > >> >>> > >> >>> > >> >>> > vtkChartsCore-6.3.dll!std::vector,std::allocator > >> >>> > >::operator[](unsigned __int64 _Pos) Line 1202 C++ > >> >>> vtkChartsCore-6.3.dll!vtkChartMatrix::GetChart(const vtkVector2i & > >> >>> position) Line 223 C++ > >> >>> vtkChartsCore-6.3.dll!vtkScatterPlotMatrix::SetActivePlot(const > >> >>> vtkVector2i & pos) Line 402 C++ > >> >>> > > >> >>> > > >> >>> > > vtkChartsCorePython27D-6.3.dll!PyvtkScatterPlotMatrix_SetActivePlot(_object > >> >>> > * self, _object * args) Line 213 C++ > >> >>> python27.dll!000000001e0c2199() Unknown > >> >>> > >> >>> Looks like vtkScatterPlotMatrix_SetActivePlot can't be called from > >> >>> this test because other stuff that it depends on for proper > operation > >> >>> is not usable as-initialized. This indicates to me that it may only > be > >> >>> luck when it succeeds on non-VS-Debug builds, since the > uninitialized > >> >>> variables, assuming that's what the cause is, will contain random > >> >>> contents when the test runs. > >> >>> > >> >>> When I add "vtkScatterPlotMatrix" as a Windows exception, the test > >> >>> passes on this build. > >> >>> > >> >>> I always love running Debug Visual Studio builds for catching easy > >> >>> errors like uninitialized variables and out of subscript > references... > >> >>> > >> >>> > >> >>> HTH, > >> >>> D > >> >>> > >> >>> > >> >>> On Wed, Apr 29, 2015 at 8:38 AM, David Cole > wrote: > >> >>> > I ran a build on my machine, named trivet, a Debug 64-bit build > from > >> >>> > VS 2013, and the test fails with a single assertion failure and > >> >>> > 10-20 > >> >>> > mem leaks: > >> >>> > > >> >>> > > https://open.cdash.org/testDetails.php?test=331705794&build=3791568 > >> >>> > > >> >>> > Perhaps the "C:\Program Files (x86)\Microsoft Visual Studio > >> >>> > 12.0\VC\INCLUDE\vector(1201) : Assertion failed: vector subscript > >> >>> > out > >> >>> > of range" report indicates the *real* cause of the problem on the > >> >>> > Mac > >> >>> > Release build. I'm not sure which class/method that comes from, > but > >> >>> > I'm about to run it and try to find out. > >> >>> > > >> >>> > > >> >>> > David C. > >> >>> > > >> >>> > > >> >>> > > >> >>> > On Wed, Apr 29, 2015 at 2:23 AM, Andrew Maclean > >> >>> > wrote: > >> >>> >> He Sean, > >> >>> >> > >> >>> >> I should clarify this a bit more. > >> >>> >> vtkDataEncoder invokes a thread pool which doesn't clean up after > >> >>> >> use, > >> >>> >> hence > >> >>> >> the crashes after program execution, adding vtkDataEncoder to the > >> >>> >> list > >> >>> >> of > >> >>> >> excluded classes "almost" fixed this. > >> >>> >> However Windows was still crashing when the program was run > again, > >> >>> >> so, > >> >>> >> adding vtkWebApplication (which is the only class that calls > >> >>> >> vtkDataEncoder), to the list of excluded classes, fixed this > issue. > >> >>> >> > >> >>> >> Notwithstanding this, it is puzzling, as I said in the previous > >> >>> >> e-mail > >> >>> >> as to > >> >>> >> why on Kamino we get a SIGSEGV at 0x0 address not mapped to > object > >> >>> >> since > >> >>> >> vtkView is specifically excluded. > >> >>> >> > >> >>> >> Regards > >> >>> >> Andrew > >> >>> >> > >> >>> >> > >> >>> >> > >> >>> >> On Wed, Apr 29, 2015 at 1:32 PM, Andrew Maclean > >> >>> >> > >> >>> >> wrote: > >> >>> >>> > >> >>> >>> Hi Sean, > >> >>> >>> > >> >>> >>> Yes, vtkDataEncoder and vtkWebApplication (which uses it) are > >> >>> >>> excluded > >> >>> >>> form TestSetGet.py and TestEmptyInput.py. This fixed the crashes > >> >>> >>> and > >> >>> >>> also > >> >>> >>> the crash in windows when the program was run again. I think > >> >>> >>> Windows > >> >>> >>> was a > >> >>> >>> bit slow recovering memory. after program execution. > >> >>> >>> > >> >>> >>> What is puzzling is that TestGetSet excludes vtkView so > >> >>> >>> vtkView.SetRepresentation() is never tested, this only fails on > >> >>> >>> Kamino > >> >>> >>> (release). It passes on trey (osX release) and also on megas. > >> >>> >>> > >> >>> >>> Regards > >> >>> >>> Andrew > >> >>> >>> > >> >>> >>> > >> >>> >>> On Wed, Apr 29, 2015 at 12:58 PM, Sean McBride > >> >>> >>> > >> >>> >>> wrote: > >> >>> >>>> > >> >>> >>>> Did you fix the use-after-free we discussed on this list a few > >> >>> >>>> weeks > >> >>> >>>> ago? > >> >>> >>>> > >> >>> >>>> Sean > >> >>> >>>> > >> >>> >>>> > >> >>> >>>> > >> >>> >>>> On Wed, 29 Apr 2015 12:07:35 +1000, Andrew Maclean said: > >> >>> >>>> > >> >>> >>>> >David, > >> >>> >>>> > Thanks for your insights. > >> >>> >>>> >Just finished testing this code on my Macbook Pro OS X > Yosemite, > >> >>> >>>> > Python > >> >>> >>>> >2.7.6 after building VTK in both Debug and Release mode. > >> >>> >>>> > Everything > >> >>> >>>> > runs > >> >>> >>>> > Ok > >> >>> >>>> >so I don't think it is a typedef or macro related to a release > >> >>> >>>> > build on > >> >>> >>>> > OS > >> >>> >>>> >X. > >> >>> >>>> > > >> >>> >>>> >Has anyone else got any suggestions? > >> >>> >>>> > > >> >>> >>>> > > >> >>> >>>> >Regards > >> >>> >>>> > Andrew > >> >>> >>>> > > >> >>> >>>> >On Wed, Apr 29, 2015 at 2:23 AM, David Gobbi > >> >>> >>>> > > >> >>> >>>> > wrote: > >> >>> >>>> > > >> >>> >>>> >> Hi Andrew, > >> >>> >>>> >> > >> >>> >>>> >> The stack trace provides strong evidence that TestSetGet.py > is > >> >>> >>>> >> not > >> >>> >>>> >> excluding vtkView on those dashboards, as ludicrous as that > >> >>> >>>> >> sounds. > >> >>> >>>> >> > >> >>> >>>> >> c++filt -n _ZL27PyvtkView_SetRepresentationP7_objectS0_ > >> >>> >>>> >> PyvtkView_SetRepresentation(_object*, _object*) > >> >>> >>>> >> > >> >>> >>>> >> This method is only defined in vtkViewPython.cxx, and only > >> >>> >>>> >> dir(vtk.vtkView) will return this method. Calling dir() on > >> >>> >>>> >> the > >> >>> >>>> >> vtkView > >> >>> >>>> >> subclasses will not return this method. Hence, the only > >> >>> >>>> >> reason > >> >>> >>>> >> that > >> >>> >>>> >> TestSetGet.py would be calling this method is if it was > >> >>> >>>> >> testing > >> >>> >>>> >> vtkView. > >> >>> >>>> >> > >> >>> >>>> >> Perhaps someone added either a typedef or a macro that > causes > >> >>> >>>> >> an > >> >>> >>>> >> additional reference to vtkView to appear in the vtk module > >> >>> >>>> >> under > >> >>> >>>> >> a > >> >>> >>>> >> different name. > >> >>> >>>> >> > >> >>> >>>> >> - David > >> >>> >>>> >> > >> >>> >>>> >> On Tue, Apr 28, 2015 at 1:42 AM, Andrew Maclean > >> >>> >>>> >> >> >>> >>>> >> > wrote: > >> >>> >>>> >> > >> >>> >>>> >>> Hi All, > >> >>> >>>> >>> I need some help here. > >> >>> >>>> >>> > >> >>> >>>> >>> I have converted TestSetGet.tcl to Python but I get a crash > >> >>> >>>> >>> on > >> >>> >>>> >>> the > >> >>> >>>> >>> dashboard for kamino building osx in release mode, here: > >> >>> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789971 > >> >>> >>>> >>> and here: > >> >>> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789950 > >> >>> >>>> >>> > >> >>> >>>> >>> In an earlier attempt, linux release on megas was also > >> >>> >>>> >>> crashing > >> >>> >>>> >>> in > >> >>> >>>> >>> release mode: > >> >>> >>>> >>> > >> >>> >>>> >>> > >> >>> >>>> >>> > https://open.cdash.org/testDetails.php?test=331289192&build=3789418 > >> >>> >>>> >>> Based on this I excluded vtkScatterPlotMatrix which fixed > it > >> >>> >>>> >>> on > >> >>> >>>> >>> megas > >> >>> >>>> >>> but > >> >>> >>>> >>> not on Kamino. > >> >>> >>>> >>> So I excluded vtkChartMatrix and I still have the same > errors > >> >>> >>>> >>> on > >> >>> >>>> >>> Kamino. > >> >>> >>>> >>> But there are no clues as to where the crash is happening. > >> >>> >>>> >>> However in > >> >>> >>>> >>> looking at: > >> >>> >>>> >>> > >> >>> >>>> >>> > >> >>> >>>> >>> > https://open.cdash.org/testDetails.php?test=331378847&build=3789950 > >> >>> >>>> >>> I think it is in vtkView - which is already excluded. > >> >>> >>>> >>> This could be the problem: > >> >>> >>>> >>> void SetRepresentation (vtkDataRepresentation *rep) > >> >>> >>>> >>> vtkDataRepresentation * GetRepresentation (int index=0) > >> >>> >>>> >>> > >> >>> >>>> >>> Can anyone help? > >> >>> >>>> >>> > >> >>> >>>> >>> I guess I can try excluding all the *View classes as > >> >>> >>>> >>> documented > >> >>> >>>> >>> in: > >> >>> >>>> >>> http://www.vtk.org/doc/nightly/html/classvtkView.html > >> >>> >>>> >>> Is there a less brute-force approach? > >> >>> >>>> >>> > >> >>> >>>> >>> > >> >>> >>>> >>> The code is here: > >> >>> >>>> >>> https://gitlab.kitware.com/vtk/vtk/merge_requests/151 > >> >>> >>>> >>> > >> >>> >>>> >>> Thanks in advance for any help/guidance. > >> >>> >>>> > >> >>> >>>> > >> >>> >>> > >> >>> >>> > >> >>> >>> > >> >>> >>> -- > >> >>> >>> ___________________________________________ > >> >>> >>> Andrew J. P. Maclean > >> >>> >>> > >> >>> >>> ___________________________________________ > >> >>> >> > >> >>> >> > >> >>> >> > >> >>> >> > >> >>> >> -- > >> >>> >> ___________________________________________ > >> >>> >> Andrew J. P. Maclean > >> >>> >> > >> >>> >> ___________________________________________ > >> >>> >> > >> >>> >> _______________________________________________ > >> >>> >> Powered by www.kitware.com > >> >>> >> > >> >>> >> Visit other Kitware open-source projects at > >> >>> >> http://www.kitware.com/opensource/opensource.html > >> >>> >> > >> >>> >> Search the list archives at: > >> >>> >> http://markmail.org/search/?q=vtk-developers > >> >>> >> > >> >>> >> Follow this link to subscribe/unsubscribe: > >> >>> >> http://public.kitware.com/mailman/listinfo/vtk-developers > >> >>> >> > >> >>> >> > >> >> > >> >> > >> >> > >> >> > >> >> -- > >> >> ___________________________________________ > >> >> Andrew J. P. Maclean > >> >> > >> >> ___________________________________________ > >> > > >> > > >> > > >> > > >> > -- > >> > ___________________________________________ > >> > Andrew J. P. Maclean > >> > > >> > ___________________________________________ > >> > > >> > _______________________________________________ > >> > Powered by www.kitware.com > >> > > >> > Visit other Kitware open-source projects at > >> > http://www.kitware.com/opensource/opensource.html > >> > > >> > Search the list archives at: > >> > http://markmail.org/search/?q=vtk-developers > >> > > >> > Follow this link to subscribe/unsubscribe: > >> > http://public.kitware.com/mailman/listinfo/vtk-developers > >> > > >> > > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From DLRdave at aol.com Mon May 4 07:52:16 2015 From: DLRdave at aol.com (David Cole) Date: Mon, 4 May 2015 07:52:16 -0400 Subject: [vtk-developers] Windows XP support.... Message-ID: Was there any conclusion reached after the recent discussion about whether folks are still actively using Windows XP? The last few days have seen massive testing failures on mirkwood and dash3 Windows dashboards... Is that merely a transition through figuring out the atomic int support on this platform, or is it intended to work there? Or is this possibly some other Windows only problem that we introduced late last week...? Thanks for any info, David C. From utkarsh.ayachit at kitware.com Mon May 4 08:18:35 2015 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Mon, 4 May 2015 08:18:35 -0400 Subject: [vtk-developers] Need help with a crash on Kamino OSX Release mode. In-Reply-To: References: <20150429025840.868205794@mail.rogue-research.com> Message-ID: Awesome! Glad that addressed the remaining issues. Utkarsh On Sun, May 3, 2015 at 9:35 PM, Andrew Maclean wrote: > Hi Utkarsh, > Your fixes have worked perfectly. Thankyou for taking the time to look at > Kamino for me. I owe you a beer! > > Seriously I would have never found the problems as all the resting on my > machines was consistently clean. This is the strength of Kitware in that the > testing environment is broad based and people are prepared to give up some > time to look into issues and suggest fixes. > > TestSetGet.py is now ready for review along with the changes to > vtkOverlappingAMR, vtkStructuredAMRGridConnectivity, > vtkPStructuredGridConnectivity, vtkView. > > Regards > Andrew > > > > On Sun, May 3, 2015 at 1:04 AM, Utkarsh Ayachit > wrote: >> >> Andrew, >> >> Attached is a patch that fixes issues with >> 'vtk-kamino-osx-shared-release+mpi+python+tbb' builder. >> >> Utkarsh >> >> >> On Fri, May 1, 2015 at 4:02 PM, Andrew Maclean >> wrote: >> > That would be perfect, thanks. >> > >> > On 01/05/2015 11:17 PM, "Utkarsh Ayachit" >> > wrote: >> >> >> >> Andrew, >> >> >> >> I can look at it over the weekend. Would that work? >> >> >> >> Utkarsh >> >> >> >> On Fri, May 1, 2015 at 1:20 AM, Andrew Maclean >> >> wrote: >> >> > I am wondering whether tbb may be picking up something. Kamino is the >> >> > only >> >> > machine with tbb and it is the only one generating this error, >> >> > unfortunately >> >> > it runs in release mode: >> >> > >> >> > Process id 46048 Caught SIGSEGV at 0x0 address not mapped to object >> >> > Program Stack: >> >> > WARNING: The stack trace will not use advanced capabilities because >> >> > this >> >> > is >> >> > a release build. >> >> > 0x7fff87b7acfa : _sigtramp [(libsystem_c.dylib) ???:-1] >> >> > 0x2 : ??? [(???) ???:-1] >> >> > 0x10f5e8f68 : _ZL27PyvtkView_SetRepresentationP7_objectS0_ >> >> > [(libvtkViewsCorePython27D-6.3.1.dylib) ???:-1] >> >> > >> >> > Has someone got a debug build similar to Kamino using tbb? >> >> > If so I would really appreciate it if they could run this code on it. >> >> > >> >> > To reiterate it is the following merge request: >> >> > https://gitlab.kitware.com/vtk/vtk/merge_requests/151 >> >> > >> >> > Thanks >> >> > Andrew >> >> > >> >> > >> >> > On Thu, Apr 30, 2015 at 10:09 AM, Andrew Maclean >> >> > >> >> > wrote: >> >> >> >> >> >> Hi David, >> >> >> Thanks for this. >> >> >> I have just added vtkScatterPlotMatrix along with vtkChartMatrix >> >> >> back, >> >> >> oddly enough my windows machine never picked it up but one of the >> >> >> linux >> >> >> buildbots did once. Then I took it out and everything seemed ok, >> >> >> it's >> >> >> back >> >> >> in now. >> >> >> >> >> >> I totally agree with you over the usefulness of Debug Visual Studio! >> >> >> It >> >> >> is >> >> >> my main bug catcher. I use a little utility called Path Editor to >> >> >> reorder >> >> >> the release and debug lib and bin paths in the environment variables >> >> >> (PYTHONPATH and PATH). >> >> >> >> >> >> Regards >> >> >> Andrew >> >> >> >> >> >> On Wed, Apr 29, 2015 at 10:57 PM, David Cole >> >> >> wrote: >> >> >>> >> >> >>> The call stack for the out of range subscript assertion is: >> >> >>> >> >> >>> msvcp120d.dll!00007fff4d2765d6() Unknown >> >> >>> >> >> >>> >> >> >>> >> >> >>> vtkChartsCore-6.3.dll!std::vector,std::allocator >> >> >>> > >::operator[](unsigned __int64 _Pos) Line 1202 C++ >> >> >>> vtkChartsCore-6.3.dll!vtkChartMatrix::GetChart(const vtkVector2i >> >> >>> & >> >> >>> position) Line 223 C++ >> >> >>> vtkChartsCore-6.3.dll!vtkScatterPlotMatrix::SetActivePlot(const >> >> >>> vtkVector2i & pos) Line 402 C++ >> >> >>> > >> >> >>> > >> >> >>> > >> >> >>> > vtkChartsCorePython27D-6.3.dll!PyvtkScatterPlotMatrix_SetActivePlot(_object >> >> >>> > * self, _object * args) Line 213 C++ >> >> >>> python27.dll!000000001e0c2199() Unknown >> >> >>> >> >> >>> Looks like vtkScatterPlotMatrix_SetActivePlot can't be called from >> >> >>> this test because other stuff that it depends on for proper >> >> >>> operation >> >> >>> is not usable as-initialized. This indicates to me that it may only >> >> >>> be >> >> >>> luck when it succeeds on non-VS-Debug builds, since the >> >> >>> uninitialized >> >> >>> variables, assuming that's what the cause is, will contain random >> >> >>> contents when the test runs. >> >> >>> >> >> >>> When I add "vtkScatterPlotMatrix" as a Windows exception, the test >> >> >>> passes on this build. >> >> >>> >> >> >>> I always love running Debug Visual Studio builds for catching easy >> >> >>> errors like uninitialized variables and out of subscript >> >> >>> references... >> >> >>> >> >> >>> >> >> >>> HTH, >> >> >>> D >> >> >>> >> >> >>> >> >> >>> On Wed, Apr 29, 2015 at 8:38 AM, David Cole >> >> >>> wrote: >> >> >>> > I ran a build on my machine, named trivet, a Debug 64-bit build >> >> >>> > from >> >> >>> > VS 2013, and the test fails with a single assertion failure and >> >> >>> > 10-20 >> >> >>> > mem leaks: >> >> >>> > >> >> >>> > >> >> >>> > https://open.cdash.org/testDetails.php?test=331705794&build=3791568 >> >> >>> > >> >> >>> > Perhaps the "C:\Program Files (x86)\Microsoft Visual Studio >> >> >>> > 12.0\VC\INCLUDE\vector(1201) : Assertion failed: vector subscript >> >> >>> > out >> >> >>> > of range" report indicates the *real* cause of the problem on the >> >> >>> > Mac >> >> >>> > Release build. I'm not sure which class/method that comes from, >> >> >>> > but >> >> >>> > I'm about to run it and try to find out. >> >> >>> > >> >> >>> > >> >> >>> > David C. >> >> >>> > >> >> >>> > >> >> >>> > >> >> >>> > On Wed, Apr 29, 2015 at 2:23 AM, Andrew Maclean >> >> >>> > wrote: >> >> >>> >> He Sean, >> >> >>> >> >> >> >>> >> I should clarify this a bit more. >> >> >>> >> vtkDataEncoder invokes a thread pool which doesn't clean up >> >> >>> >> after >> >> >>> >> use, >> >> >>> >> hence >> >> >>> >> the crashes after program execution, adding vtkDataEncoder to >> >> >>> >> the >> >> >>> >> list >> >> >>> >> of >> >> >>> >> excluded classes "almost" fixed this. >> >> >>> >> However Windows was still crashing when the program was run >> >> >>> >> again, >> >> >>> >> so, >> >> >>> >> adding vtkWebApplication (which is the only class that calls >> >> >>> >> vtkDataEncoder), to the list of excluded classes, fixed this >> >> >>> >> issue. >> >> >>> >> >> >> >>> >> Notwithstanding this, it is puzzling, as I said in the previous >> >> >>> >> e-mail >> >> >>> >> as to >> >> >>> >> why on Kamino we get a SIGSEGV at 0x0 address not mapped to >> >> >>> >> object >> >> >>> >> since >> >> >>> >> vtkView is specifically excluded. >> >> >>> >> >> >> >>> >> Regards >> >> >>> >> Andrew >> >> >>> >> >> >> >>> >> >> >> >>> >> >> >> >>> >> On Wed, Apr 29, 2015 at 1:32 PM, Andrew Maclean >> >> >>> >> >> >> >>> >> wrote: >> >> >>> >>> >> >> >>> >>> Hi Sean, >> >> >>> >>> >> >> >>> >>> Yes, vtkDataEncoder and vtkWebApplication (which uses it) are >> >> >>> >>> excluded >> >> >>> >>> form TestSetGet.py and TestEmptyInput.py. This fixed the >> >> >>> >>> crashes >> >> >>> >>> and >> >> >>> >>> also >> >> >>> >>> the crash in windows when the program was run again. I think >> >> >>> >>> Windows >> >> >>> >>> was a >> >> >>> >>> bit slow recovering memory. after program execution. >> >> >>> >>> >> >> >>> >>> What is puzzling is that TestGetSet excludes vtkView so >> >> >>> >>> vtkView.SetRepresentation() is never tested, this only fails on >> >> >>> >>> Kamino >> >> >>> >>> (release). It passes on trey (osX release) and also on megas. >> >> >>> >>> >> >> >>> >>> Regards >> >> >>> >>> Andrew >> >> >>> >>> >> >> >>> >>> >> >> >>> >>> On Wed, Apr 29, 2015 at 12:58 PM, Sean McBride >> >> >>> >>> >> >> >>> >>> wrote: >> >> >>> >>>> >> >> >>> >>>> Did you fix the use-after-free we discussed on this list a few >> >> >>> >>>> weeks >> >> >>> >>>> ago? >> >> >>> >>>> >> >> >>> >>>> Sean >> >> >>> >>>> >> >> >>> >>>> >> >> >>> >>>> >> >> >>> >>>> On Wed, 29 Apr 2015 12:07:35 +1000, Andrew Maclean said: >> >> >>> >>>> >> >> >>> >>>> >David, >> >> >>> >>>> > Thanks for your insights. >> >> >>> >>>> >Just finished testing this code on my Macbook Pro OS X >> >> >>> >>>> > Yosemite, >> >> >>> >>>> > Python >> >> >>> >>>> >2.7.6 after building VTK in both Debug and Release mode. >> >> >>> >>>> > Everything >> >> >>> >>>> > runs >> >> >>> >>>> > Ok >> >> >>> >>>> >so I don't think it is a typedef or macro related to a >> >> >>> >>>> > release >> >> >>> >>>> > build on >> >> >>> >>>> > OS >> >> >>> >>>> >X. >> >> >>> >>>> > >> >> >>> >>>> >Has anyone else got any suggestions? >> >> >>> >>>> > >> >> >>> >>>> > >> >> >>> >>>> >Regards >> >> >>> >>>> > Andrew >> >> >>> >>>> > >> >> >>> >>>> >On Wed, Apr 29, 2015 at 2:23 AM, David Gobbi >> >> >>> >>>> > >> >> >>> >>>> > wrote: >> >> >>> >>>> > >> >> >>> >>>> >> Hi Andrew, >> >> >>> >>>> >> >> >> >>> >>>> >> The stack trace provides strong evidence that TestSetGet.py >> >> >>> >>>> >> is >> >> >>> >>>> >> not >> >> >>> >>>> >> excluding vtkView on those dashboards, as ludicrous as that >> >> >>> >>>> >> sounds. >> >> >>> >>>> >> >> >> >>> >>>> >> c++filt -n _ZL27PyvtkView_SetRepresentationP7_objectS0_ >> >> >>> >>>> >> PyvtkView_SetRepresentation(_object*, _object*) >> >> >>> >>>> >> >> >> >>> >>>> >> This method is only defined in vtkViewPython.cxx, and only >> >> >>> >>>> >> dir(vtk.vtkView) will return this method. Calling dir() on >> >> >>> >>>> >> the >> >> >>> >>>> >> vtkView >> >> >>> >>>> >> subclasses will not return this method. Hence, the only >> >> >>> >>>> >> reason >> >> >>> >>>> >> that >> >> >>> >>>> >> TestSetGet.py would be calling this method is if it was >> >> >>> >>>> >> testing >> >> >>> >>>> >> vtkView. >> >> >>> >>>> >> >> >> >>> >>>> >> Perhaps someone added either a typedef or a macro that >> >> >>> >>>> >> causes >> >> >>> >>>> >> an >> >> >>> >>>> >> additional reference to vtkView to appear in the vtk module >> >> >>> >>>> >> under >> >> >>> >>>> >> a >> >> >>> >>>> >> different name. >> >> >>> >>>> >> >> >> >>> >>>> >> - David >> >> >>> >>>> >> >> >> >>> >>>> >> On Tue, Apr 28, 2015 at 1:42 AM, Andrew Maclean >> >> >>> >>>> >> > >> >>> >>>> >> > wrote: >> >> >>> >>>> >> >> >> >>> >>>> >>> Hi All, >> >> >>> >>>> >>> I need some help here. >> >> >>> >>>> >>> >> >> >>> >>>> >>> I have converted TestSetGet.tcl to Python but I get a >> >> >>> >>>> >>> crash >> >> >>> >>>> >>> on >> >> >>> >>>> >>> the >> >> >>> >>>> >>> dashboard for kamino building osx in release mode, here: >> >> >>> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789971 >> >> >>> >>>> >>> and here: >> >> >>> >>>> >>> https://open.cdash.org/buildSummary.php?buildid=3789950 >> >> >>> >>>> >>> >> >> >>> >>>> >>> In an earlier attempt, linux release on megas was also >> >> >>> >>>> >>> crashing >> >> >>> >>>> >>> in >> >> >>> >>>> >>> release mode: >> >> >>> >>>> >>> >> >> >>> >>>> >>> >> >> >>> >>>> >>> >> >> >>> >>>> >>> https://open.cdash.org/testDetails.php?test=331289192&build=3789418 >> >> >>> >>>> >>> Based on this I excluded vtkScatterPlotMatrix which fixed >> >> >>> >>>> >>> it >> >> >>> >>>> >>> on >> >> >>> >>>> >>> megas >> >> >>> >>>> >>> but >> >> >>> >>>> >>> not on Kamino. >> >> >>> >>>> >>> So I excluded vtkChartMatrix and I still have the same >> >> >>> >>>> >>> errors >> >> >>> >>>> >>> on >> >> >>> >>>> >>> Kamino. >> >> >>> >>>> >>> But there are no clues as to where the crash is happening. >> >> >>> >>>> >>> However in >> >> >>> >>>> >>> looking at: >> >> >>> >>>> >>> >> >> >>> >>>> >>> >> >> >>> >>>> >>> >> >> >>> >>>> >>> https://open.cdash.org/testDetails.php?test=331378847&build=3789950 >> >> >>> >>>> >>> I think it is in vtkView - which is already excluded. >> >> >>> >>>> >>> This could be the problem: >> >> >>> >>>> >>> void SetRepresentation (vtkDataRepresentation *rep) >> >> >>> >>>> >>> vtkDataRepresentation * GetRepresentation (int index=0) >> >> >>> >>>> >>> >> >> >>> >>>> >>> Can anyone help? >> >> >>> >>>> >>> >> >> >>> >>>> >>> I guess I can try excluding all the *View classes as >> >> >>> >>>> >>> documented >> >> >>> >>>> >>> in: >> >> >>> >>>> >>> http://www.vtk.org/doc/nightly/html/classvtkView.html >> >> >>> >>>> >>> Is there a less brute-force approach? >> >> >>> >>>> >>> >> >> >>> >>>> >>> >> >> >>> >>>> >>> The code is here: >> >> >>> >>>> >>> https://gitlab.kitware.com/vtk/vtk/merge_requests/151 >> >> >>> >>>> >>> >> >> >>> >>>> >>> Thanks in advance for any help/guidance. >> >> >>> >>>> >> >> >>> >>>> >> >> >>> >>> >> >> >>> >>> >> >> >>> >>> >> >> >>> >>> -- >> >> >>> >>> ___________________________________________ >> >> >>> >>> Andrew J. P. Maclean >> >> >>> >>> >> >> >>> >>> ___________________________________________ >> >> >>> >> >> >> >>> >> >> >> >>> >> >> >> >>> >> >> >> >>> >> -- >> >> >>> >> ___________________________________________ >> >> >>> >> Andrew J. P. Maclean >> >> >>> >> >> >> >>> >> ___________________________________________ >> >> >>> >> >> >> >>> >> _______________________________________________ >> >> >>> >> Powered by www.kitware.com >> >> >>> >> >> >> >>> >> Visit other Kitware open-source projects at >> >> >>> >> http://www.kitware.com/opensource/opensource.html >> >> >>> >> >> >> >>> >> Search the list archives at: >> >> >>> >> http://markmail.org/search/?q=vtk-developers >> >> >>> >> >> >> >>> >> Follow this link to subscribe/unsubscribe: >> >> >>> >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >>> >> >> >> >>> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> >> ___________________________________________ >> >> >> Andrew J. P. Maclean >> >> >> >> >> >> ___________________________________________ >> >> > >> >> > >> >> > >> >> > >> >> > -- >> >> > ___________________________________________ >> >> > Andrew J. P. Maclean >> >> > >> >> > ___________________________________________ >> >> > >> >> > _______________________________________________ >> >> > Powered by www.kitware.com >> >> > >> >> > Visit other Kitware open-source projects at >> >> > http://www.kitware.com/opensource/opensource.html >> >> > >> >> > Search the list archives at: >> >> > http://markmail.org/search/?q=vtk-developers >> >> > >> >> > Follow this link to subscribe/unsubscribe: >> >> > http://public.kitware.com/mailman/listinfo/vtk-developers >> >> > >> >> > > > > > > -- > ___________________________________________ > Andrew J. P. Maclean > > ___________________________________________ From david.gobbi at gmail.com Mon May 4 08:58:03 2015 From: david.gobbi at gmail.com (David Gobbi) Date: Mon, 4 May 2015 06:58:03 -0600 Subject: [vtk-developers] Fwd: OSX build links directly with Python binary - avoidable? In-Reply-To: References: Message-ID: Hi Matthew, Frameworks/Python.framework/Versions/2.7/Python is a framework library (a dylib without a suffix). In my build (probably yours too), cmake links all VTK python libs to libpython2.7.dylib, which is a symbolic link to Frameworks/Python.framework/Versions/2.7/Python. So this "binary" is none other than the libpython dynamic library, and it isn't too surprising to have it show up with "otool -L". I tried manually linking libCommonCorePython.so without using libpython in the link line, and it worked fine. And linking the other libs like libvtkWrappingPython27Core without libpython works if I add "-undefined dynamic_lookup". So this seems like a reasonable thing to do. - David On Sat, May 2, 2015 at 3:40 PM, Matthew Brett wrote: > Hi, > > I have spent a little time trying to build OSX wheels [1] for VTK. > These would be very useful for an automated binary install of VTK for > OSX Python. > > Short version : vtk python libraries link directly against the Python > binary, making more general packaging impossible. > > Long version: > > My plan was to first do an install into the Python site-packages, copy > and do a relative path relink of the library dependencies into a > `.dylibs` directory [2] and then package the files into a wheel. > > My first shot was using the homebrew installation: > > brew install vtk --with-python --with-qt --with-matplotlib > > This installation can't be used with a Python other than the one it is > compiled with, because it links directly to the Python binary. The > output from this: > > cd /usr/local/Cellar/vtk/6.2.0/lib/python2.7/site-packages/vtk > otool -L vtkCommonCorePython.so > > includes: > > /usr/local/opt/python/Frameworks/Python.framework/Versions/2.7/Python > (compatibility version 2.7.0, current version 2.7.0) > > This is true for many (?all) other vtk compiled extension modules. > > Is there any reason that this library has to link directly the Python > binary? It makes it impossible to make a package that will install > for a Python other than the one it was built with, and at the same > path. > > I believe standard practice is to use " -undefined dynamic_lookup " > for Python symbols loaded from extension modules, but I am happy to be > corrected. > > Cheers, > > Matthew > > [1] https://github.com/MacPython/wiki/wiki/Spinning-wheels > [2] https://github.com/matthew-brett/delocate > -------------- next part -------------- An HTML attachment was scrubbed... URL: From DLRdave at aol.com Mon May 4 10:08:59 2015 From: DLRdave at aol.com (David Cole) Date: Mon, 4 May 2015 10:08:59 -0400 Subject: [vtk-developers] Windows XP support.... In-Reply-To: References: Message-ID: By the way, one of these two days (last Tuesday and Wednesday) worth of commits pushed into nightly-master is the likely culprit for triggering the test failures on these machines: https://open.cdash.org/viewUpdate.php?buildid=3790874 https://open.cdash.org/viewUpdate.php?buildid=3792368 Hopefully, it's fixed soon... If Windows XP support will be discontinued, just let me know, and I'll stop submitting from mirkwood. Thanks, David C. On Mon, May 4, 2015 at 7:52 AM, David Cole wrote: > Was there any conclusion reached after the recent discussion about > whether folks are still actively using Windows XP? > > The last few days have seen massive testing failures on mirkwood and > dash3 Windows dashboards... Is that merely a transition through > figuring out the atomic int support on this platform, or is it > intended to work there? Or is this possibly some other Windows only > problem that we introduced late last week...? > > Thanks for any info, > David C. From david.lonie at kitware.com Mon May 4 10:28:53 2015 From: david.lonie at kitware.com (David Lonie) Date: Mon, 4 May 2015 10:28:53 -0400 Subject: [vtk-developers] Windows XP support.... In-Reply-To: References: Message-ID: On Mon, May 4, 2015 at 10:08 AM, David Cole via vtk-developers < vtk-developers at vtk.org> wrote: > By the way, one of these two days (last Tuesday and Wednesday) worth > of commits pushed into nightly-master is the likely culprit for > triggering the test failures on these machines: > > https://open.cdash.org/viewUpdate.php?buildid=3790874 > https://open.cdash.org/viewUpdate.php?buildid=3792368 > > Hopefully, it's fixed soon... If Windows XP support will be > discontinued, just let me know, and I'll stop submitting from > mirkwood. > Can you see why the tests are failing? There is nothing on the CDash pages that really says what's happening. The failures are fairly widespread and don't even seem to be generating images in the ones I checked, so the atomic int stuff seems like the likely cause. Perhaps a stack trace or similar for a couple of these failures would help narrow down the culprit? Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From robert.maynard at kitware.com Mon May 4 10:52:51 2015 From: robert.maynard at kitware.com (Robert Maynard) Date: Mon, 4 May 2015 10:52:51 -0400 Subject: [vtk-developers] Windows XP support.... In-Reply-To: References: Message-ID: Yes the issue is with updated atomic code. Sujin and I tracked down the issue, and now Sujin is determining a fix to allow WindowsXP to work. On Mon, May 4, 2015 at 10:28 AM, David Lonie wrote: > On Mon, May 4, 2015 at 10:08 AM, David Cole via vtk-developers > wrote: >> >> By the way, one of these two days (last Tuesday and Wednesday) worth >> of commits pushed into nightly-master is the likely culprit for >> triggering the test failures on these machines: >> >> https://open.cdash.org/viewUpdate.php?buildid=3790874 >> https://open.cdash.org/viewUpdate.php?buildid=3792368 >> >> Hopefully, it's fixed soon... If Windows XP support will be >> discontinued, just let me know, and I'll stop submitting from >> mirkwood. > > > Can you see why the tests are failing? There is nothing on the CDash pages > that really says what's happening. The failures are fairly widespread and > don't even seem to be generating images in the ones I checked, so the atomic > int stuff seems like the likely cause. Perhaps a stack trace or similar for > a couple of these failures would help narrow down the culprit? > > Dave > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > From DLRdave at aol.com Mon May 4 10:50:40 2015 From: DLRdave at aol.com (David Cole) Date: Mon, 4 May 2015 10:50:40 -0400 Subject: [vtk-developers] Windows XP support.... In-Reply-To: References: Message-ID: I can't do it today, but I assume it's the same as what's happening on dash3 at Kitware: https://open.cdash.org/viewTest.php?onlyfailed&buildid=3797861 So somebody there should be able to take a look if they have time before I do... D On Mon, May 4, 2015 at 10:28 AM, David Lonie wrote: > On Mon, May 4, 2015 at 10:08 AM, David Cole via vtk-developers > wrote: >> >> By the way, one of these two days (last Tuesday and Wednesday) worth >> of commits pushed into nightly-master is the likely culprit for >> triggering the test failures on these machines: >> >> https://open.cdash.org/viewUpdate.php?buildid=3790874 >> https://open.cdash.org/viewUpdate.php?buildid=3792368 >> >> Hopefully, it's fixed soon... If Windows XP support will be >> discontinued, just let me know, and I'll stop submitting from >> mirkwood. > > > Can you see why the tests are failing? There is nothing on the CDash pages > that really says what's happening. The failures are fairly widespread and > don't even seem to be generating images in the ones I checked, so the atomic > int stuff seems like the likely cause. Perhaps a stack trace or similar for > a couple of these failures would help narrow down the culprit? > > Dave From sean at rogue-research.com Mon May 4 12:04:37 2015 From: sean at rogue-research.com (Sean McBride) Date: Mon, 4 May 2015 12:04:37 -0400 Subject: [vtk-developers] Windows XP support.... In-Reply-To: References: Message-ID: <20150504160437.852861569@mail.rogue-research.com> On Mon, 4 May 2015 07:52:16 -0400, David Cole via vtk-developers said: >Was there any conclusion reached after the recent discussion about >whether folks are still actively using Windows XP? > >The last few days have seen massive testing failures on mirkwood and >dash3 Windows dashboards... Is that merely a transition through >figuring out the atomic int support on this platform, or is it >intended to work there? Or is this possibly some other Windows only >problem that we introduced late last week...? I have the same question wrt my PPC32 dashboard, which seems red for the same reasons: Seems to me some steps were skipped here. Sunjin's post about dropping support was April 23, and no one really complained. But before actually dropping support, it should have been announced that the decision was made. Then docs and dashboards could be updated before the switch was flipped. Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From matthew.brett at gmail.com Mon May 4 12:05:22 2015 From: matthew.brett at gmail.com (Matthew Brett) Date: Mon, 4 May 2015 09:05:22 -0700 Subject: [vtk-developers] Fwd: OSX build links directly with Python binary - avoidable? In-Reply-To: References: Message-ID: Hi, On Mon, May 4, 2015 at 5:58 AM, David Gobbi wrote: > Hi Matthew, > > Frameworks/Python.framework/Versions/2.7/Python is a framework > library (a dylib without a suffix). In my build (probably yours too), > cmake links all VTK python libs to libpython2.7.dylib, which is a > symbolic link to Frameworks/Python.framework/Versions/2.7/Python. > > So this "binary" is none other than the libpython dynamic library, > and it isn't too surprising to have it show up with "otool -L". > > I tried manually linking libCommonCorePython.so without using > libpython in the link line, and it worked fine. And linking the other > libs like libvtkWrappingPython27Core without libpython works if > I add "-undefined dynamic_lookup". So this seems like a > reasonable thing to do. I believe this is the standard Python extension behavior, and would help a great deal, because it would mean it should be possible to package vtk into a '.whl' file that can be installed (via 'pip install vtk') into any of the standard Python installations on OSX (including system Python, Python.org Python, homebrew, macports) without recompiling. Cheers, Matthew From sujin.philip at kitware.com Mon May 4 12:09:12 2015 From: sujin.philip at kitware.com (Sujin Philip) Date: Mon, 4 May 2015 12:09:12 -0400 Subject: [vtk-developers] Windows XP support.... In-Reply-To: <20150504160437.852861569@mail.rogue-research.com> References: <20150504160437.852861569@mail.rogue-research.com> Message-ID: The code is intended to work on 32 bit PPCs and Windows XP, though using the slower mutexes instead of atomic variables. There is an error in testing for atomic operations support (false positives) which is causing the current failures. I am working on a fix. Thanks Sujin On Mon, May 4, 2015 at 12:04 PM, Sean McBride wrote: > On Mon, 4 May 2015 07:52:16 -0400, David Cole via vtk-developers said: > > >Was there any conclusion reached after the recent discussion about > >whether folks are still actively using Windows XP? > > > >The last few days have seen massive testing failures on mirkwood and > >dash3 Windows dashboards... Is that merely a transition through > >figuring out the atomic int support on this platform, or is it > >intended to work there? Or is this possibly some other Windows only > >problem that we introduced late last week...? > > I have the same question wrt my PPC32 dashboard, which seems red for the > same reasons: > > > > Seems to me some steps were skipped here. Sunjin's post about dropping > support was April 23, and no one really complained. But before actually > dropping support, it should have been announced that the decision was > made. Then docs and dashboards could be updated before the switch was > flipped. > > Cheers, > > -- > ____________________________________________________________ > Sean McBride, B. Eng sean at rogue-research.com > Rogue Research www.rogue-research.com > Mac Software Developer Montr?al, Qu?bec, Canada > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Mon May 4 15:11:10 2015 From: sean at rogue-research.com (Sean McBride) Date: Mon, 4 May 2015 15:11:10 -0400 Subject: [vtk-developers] Windows XP support.... In-Reply-To: References: <20150504160437.852861569@mail.rogue-research.com> Message-ID: <20150504191110.1401948886@mail.rogue-research.com> On Mon, 4 May 2015 12:09:12 -0400, Sujin Philip said: >The code is intended to work on 32 bit PPCs and Windows XP Shame. I was rather looking forward to us removing support for them. :) Sean From t.kilgus at Dkfz-Heidelberg.de Tue May 5 05:52:21 2015 From: t.kilgus at Dkfz-Heidelberg.de (Kilgus, Thomas) Date: Tue, 5 May 2015 11:52:21 +0200 Subject: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? In-Reply-To: References: <57EE86D11538B44096C712532DBB6C5A012EF2AC55A3@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC55BA@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC561F@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5653@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5657@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: <57EE86D11538B44096C712532DBB6C5A012EF2D92A34@DKFZEX01.ad.dkfz-heidelberg.de> Since this is a major issue for us, I am curious: Should I keep pressuring you here for a fix or in mantis? Or are you already looking into it? Regards, Thomas Von: David Lonie [mailto:david.lonie at kitware.com] Gesendet: Donnerstag, 23. April 2015 15:12 An: Kilgus, Thomas Cc: David Cole; vtk-developers at vtk.org Betreff: Re: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? I can reproduce this on current master using the test script in the bug report. Something is definitely broken... Dave On Thu, Apr 23, 2015 at 8:53 AM, Kilgus, Thomas > wrote: Oh great, at least it is now visible. Do you have any build to reproduce this? -----Urspr?ngliche Nachricht----- Von: David Cole [mailto:DLRdave at aol.com] Gesendet: Donnerstag, 23. April 2015 14:49 An: Kilgus, Thomas Cc: David Lonie; vtk-developers at vtk.org Betreff: Re: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? OK -- I do see it in the AntiAliasingOff png file. On Thu, Apr 23, 2015 at 8:38 AM, Kilgus, Thomas > wrote: > Ah it's very tricky to make a nice screen shot of anti-aliasing... I attached another version in mantis named AntiAliasingOff.png. I hope it becomes clear now. It is obvious if you build the example. > > > -----Urspr?ngliche Nachricht----- > Von: David Cole [mailto:DLRdave at aol.com] > Gesendet: Donnerstag, 23. April 2015 12:41 > An: Kilgus, Thomas > Cc: David Lonie; vtk-developers at vtk.org > Betreff: Re: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? > > That looks like it could just be a lighting or color difference... > Both images appear anti-aliased to my eye, but the exact coloring of the lines is definitely different. > > > On Thu, Apr 23, 2015 at 5:22 AM, Kilgus, Thomas > wrote: >> Hi David, >> >> >> >> I filed a bug report: http://www.vtk.org/Bug/view.php?id=15433 >> >> >> >> We have this issue on various operating systems. I explained >> everything in mantis and added a file to reproduce it. In general, >> you could checkout the tag v6.2.0 and open any renderwindow which >> contains lots lines, such as a surface rendered as wireframe. I would >> be really surprised if this is not reproducible on that commit for you. >> >> >> >> Regards, >> >> Thomas >> >> >> >> Von: David Lonie [mailto:david.lonie at kitware.com] >> Gesendet: Mittwoch, 22. April 2015 16:55 >> An: Kilgus, Thomas >> Cc: vtk-developers at vtk.org >> Betreff: Re: [vtk-developers] Anti-aliasing / multi sampling turned >> off in VTK 6.2? >> >> >> >> On Wed, Apr 22, 2015 at 10:43 AM, Kilgus, Thomas >> > wrote: >> >> No, just the regular VTK example. Is this feature working for you? >> >> >> >> I've been using on-screen multisampling on the current dev branch >> without issues. Not sure what else would be causing this. >> >> >> >> Can you open a bug report for this? Best if you can include a short >> script that reproduces the issue and details about your operating system. >> >> >> >> Dave >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: >> http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: From gururagaven at yahoo.co.in Tue May 5 06:02:19 2015 From: gururagaven at yahoo.co.in (Gru) Date: Tue, 05 May 2015 15:32:19 +0530 Subject: [vtk-developers] Gerrit test error on amber8 In-Reply-To: References: <8874AF9D-94B6-4AAA-8860-45EF402CA721@kitware.com> Message-ID: Please. Unsunscribe me from vtk or its Sent from my Sony Xperia? smartphone ---- Yumin Yuan wrote ---- >_______________________________________________ >Powered by www.kitware.com > >Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > >Follow this link to subscribe/unsubscribe: >http://www.vtk.org/mailman/listinfo/vtk-developers > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lonie at kitware.com Tue May 5 09:51:56 2015 From: david.lonie at kitware.com (David Lonie) Date: Tue, 5 May 2015 09:51:56 -0400 Subject: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? In-Reply-To: <57EE86D11538B44096C712532DBB6C5A012EF2D92A34@DKFZEX01.ad.dkfz-heidelberg.de> References: <57EE86D11538B44096C712532DBB6C5A012EF2AC55A3@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC55BA@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC561F@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5653@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5657@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92A34@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: On Tue, May 5, 2015 at 5:52 AM, Kilgus, Thomas wrote: > Since this is a major issue for us, I am curious: Should I keep pressuring > you here for a fix or in mantis? Or are you already looking into it? > Well, pressuring developers for fixes to an open-source project isn't necessarily a strategy I'd advise ;) But I will be looking into this soon, and plan to have a patch in the next week or two. I'll update the bug report/this thread as things progress. Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Tue May 5 10:21:02 2015 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Tue, 5 May 2015 10:21:02 -0400 Subject: [vtk-developers] ANN: Buildbot status page now accessible to everyone! Message-ID: Folks, As many of you know, we have been using Buildbot [1] to drive the merge request testing for VTK and ParaView. Buildbot provides a status page where one can monitor the testing progress as well as the results. Until now, this status page was only accessible within Kitware's network, not anymore! It's now publicly accessible at [2]. We've also written a quick blog post summarizing how to interpret the Buildbot status page here [2]. Any suggestions to improve it further are welcome. Utkarsh [1] http://buildbot.net/ [2] https://builtbot.kitware.com [3] http://www.kitware.com/blog/home/post/875 From david.thompson at kitware.com Tue May 5 10:58:25 2015 From: david.thompson at kitware.com (David Thompson) Date: Tue, 5 May 2015 10:58:25 -0400 Subject: [vtk-developers] [Paraview-developers] ANN: Buildbot status page now accessible to everyone! In-Reply-To: References: Message-ID: Hi Utkarsh, I think link [2] should be https://buildbot.kitware.com/ . David > As many of you know, we have been using Buildbot [1] to drive the > merge request testing for VTK and ParaView. Buildbot provides a status > page where one can monitor the testing progress as well as the > results. Until now, this status page was only accessible within > Kitware's network, not anymore! It's now publicly accessible at [2]. > > We've also written a quick blog post summarizing how to interpret the > Buildbot status page here [2]. > > Any suggestions to improve it further are welcome. > > Utkarsh > > [1] http://buildbot.net/ > [2] https://builtbot.kitware.com > [3] http://www.kitware.com/blog/home/post/875 > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=Paraview-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/paraview-developers From utkarsh.ayachit at kitware.com Tue May 5 11:03:03 2015 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Tue, 5 May 2015 11:03:03 -0400 Subject: [vtk-developers] [Paraview-developers] ANN: Buildbot status page now accessible to everyone! In-Reply-To: References: Message-ID: > I think link [2] should be https://buildbot.kitware.com/ . Oops :). So it should. From dave.demarle at kitware.com Tue May 5 11:07:13 2015 From: dave.demarle at kitware.com (David E DeMarle) Date: Tue, 5 May 2015 11:07:13 -0400 Subject: [vtk-developers] Wiki scrapping regression after web page update In-Reply-To: References: Message-ID: So Bill trying to close the loop on this. We should now use. site = mwclient.Site('www.(project).org', '/Wiki/') page = site.Pages['PROJECT/Examples] That will work now and if/when www.itk.org gets it's own facelift. hth David E DeMarle Kitware, Inc. R&D Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4909 On Thu, Apr 16, 2015 at 6:31 PM, Jean-Christophe Fillion-Robin < jchris.fillionr at kitware.com> wrote: > Hi Bill, > > I wrote too fast. Ignore my previous email. > > Jc > > On Thu, Apr 16, 2015 at 6:30 PM, Jean-Christophe Fillion-Robin < > jchris.fillionr at kitware.com> wrote: > >> Hi Bill, >> >> Seems the wiki is available here: http://www.vtk.org/Wiki/VTK >> >> Instead of >> >> site = mwclient.Site('vtk.org', '/Wiki/') >> >> try this >> >> site = mwclient.Site('vtk.org', '/Wiki/VTK/') >> >> Hth >> Jc >> >> On Mon, Apr 13, 2015 at 11:45 AM, David E DeMarle < >> dave.demarle at kitware.com> wrote: >> >>> I'll take a look. >>> thanks >>> >>> David E DeMarle >>> Kitware, Inc. >>> R&D Engineer >>> 21 Corporate Drive >>> Clifton Park, NY 12065-8662 >>> Phone: 518-881-4909 >>> >>> On Tue, Mar 31, 2015 at 3:30 PM, Bill Lorensen >>> wrote: >>> >>>> Folks, >>>> >>>> I scrape the vtk.org wiki site each evening to maintain the vtk wiki >>>> examples. I have a python program that uses mwclient >>>> (https://github.com/mwclient/mwclient) that uses the MediaWiki API. >>>> >>>> Ever since the vtk.org page was updated, my nightly scripts have been >>>> failing. >>>> The error are occur on this line: >>>> >>>> site = mwclient.Site('vtk.org', '/Wiki/') >>>> >>>> If I change vtk.org to itk.org, my scripts work. >>>> >>>> I suspect some sort of web magic going on. I can workaround the >>>> problem but specifying itk.org, but I'd like to understand what >>>> happened just in case the itk.org site changes in the future. >>>> >>>> Thanks, >>>> >>>> Bill >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: >>>> http://markmail.org/search/?q=vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://public.kitware.com/mailman/listinfo/vtk-developers >>>> >>>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >>> >> >> >> -- >> +1 919 869 8849 >> > > > > -- > +1 919 869 8849 > -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Wed May 6 03:34:53 2015 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Wed, 6 May 2015 17:34:53 +1000 Subject: [vtk-developers] Solutions to TestSetGet/TestEmptyInput failures on RogueResearch3 Message-ID: Hi All, RogueResearch is running Python 2.5. Both TestSetGet.py and TestEmptyInput.py fail at this line: vtkClasses = inspect.getmembers( vtk, inspect.isclass and not inspect.isabstract) with this error: vtk, inspect.isclass and not inspect.isabstract) AttributeError: 'module' object has no attribute 'isabstract' Apparently the isabstract attribute was introduced in Python 2.6. >From what I can see there are these options: 1) Skip these two tests by checking the version of Python used when VTK is built. 2) Extend option 1 by by creating a global variables in ./Cmake/VTKConfig.cmake. 3) Do nothing, and hope Python 2.5 is eventually deprecated. My preferred option is 2) as this could be useful when VTK supports Python 3 e.g it may be useful to know which version of Python VTK is wrapped with, in the same way as we use VTK_QT_VERSION. If this is Ok I propose calling it VTK_WRAPPING_PYTHON_VERSION to distinguish it from VTK_PYTHON_VERSION in ./CmakeLists.txt (which can have the values 2, 2.x, 3, 3.x etc). VTK_WRAPPING_PYTHON_VERSION would be built from PYTHON_MAJOR_VERSION and PYTHON_MINOR_VERSION which are defined in ./CMake/FindPythonLibs.cmake. This would require just adding one line to ./CMake/VTKConfig.cmake.in, something like this: 2.1) SET(VTK_WRAPPING_PYTHON_VERSION "@PYTHON_MAJOR_VERSION@ . at PYTHON_MINOR_VERSION@") or ... would it be better to simply just do this in this file, since these are defined in ./Utilities/Python/vtkPythonConfigure.h.in? 2.2) SET(VTK_PYTHON_MAJOR_VERSION "@VTK_PYTHON_MAJOR_VERSION @") SET(VTK_PYTHON_MINOR_VERSION"@VTK_PYTHON_MINOR_VERSION@") I prefer option 2) and, on reflection, I would go with with 2.2) Please let me know what you think would be the best option. Regards Andrew -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From DLRdave at aol.com Wed May 6 07:37:06 2015 From: DLRdave at aol.com (David Cole) Date: Wed, 6 May 2015 07:37:06 -0400 Subject: [vtk-developers] Gerrit test error on amber8 In-Reply-To: References: <8874AF9D-94B6-4AAA-8860-45EF402CA721@kitware.com> Message-ID: You may unsubscribe from the VTK Users list on this page: http://www.vtk.org/mailman/listinfo/vtkusers On Tue, May 5, 2015 at 6:02 AM, Gru wrote: > Please. Unsunscribe me from vtk or its > > Sent from my Sony Xperia? smartphone > > > > ---- Yumin Yuan wrote ---- > > Just want to update on this. I have spent some decent time trying to track > it down without much success. The fact that the test passes if I run > manually on amber8, either individually or in a list of tests, makes it very > difficult to reproduce. I have trimmed down the test to minimum and played > around with different openGL calls, but it still intermittently fails when > running ctest. > > Given the fact that this test passes on all other dashboard machines, we > decided to exclude it from amber8 gerrit-dashboard. We still think this is > Mesa/openGL related, and I will set up one of my own machines with the same > environment as amber-8 and investigate further. > > Sorry for the inconvenience. > Yumin > > > On Mon, Apr 29, 2013 at 3:51 PM, Yumin Yuan wrote: >> >> Hi Bill, >> Yes, I agree. I will find some time to get on that machine next couple >> days. If it is really related to Mesa, I will suppress this test on that >> machine. >> >> Yumin >> >> >> On Mon, Apr 29, 2013 at 1:45 PM, Bill Lorensen >> wrote: >>> >>> Having intermittent gerrit test failures is not good. It would be great >>> to raise the priority of this. We spent a lot of time recently to get the >>> gerrit builds to 0 test failures. >>> >>> >>> >>> On Mon, Apr 29, 2013 at 1:05 PM, Yumin Yuan >>> wrote: >>>> >>>> Hi Dave, >>>> >>>> That test is for the new polygon-selection feature in VTK I added last >>>> week, I also noticed the odd (somewhat random) failure of this test on >>>> amber8 when I pushed to Gerrit, and I talked with Marcus a little bit, and >>>> he thought it may be related to the mesa library that amber8 is running. I >>>> have not spent time to track down the issue, but since this test is passing >>>> on all nightly dashboard machines, I think you can ignore it for the stuff >>>> you are working on. I will try to track it down when I get some free time. >>>> >>>> Yumin >>>> >>>> >>>> On Mon, Apr 29, 2013 at 12:37 PM, David Thompson >>>> wrote: >>>>> >>>>> Hi all, >>>>> >>>>> I'm seeing an odd test error on amber8: TestPolygonSelection is failing >>>>> which is unrelated to the code I checked in. It also appears to be failing >>>>> for other unrelated gerrit topics: >>>>> >>>>> http://open.cdash.org/testDetails.php?test=186977515&build=2890285 >>>>> http://open.cdash.org/testDetails.php?test=187458615&build=2890244 >>>>> >>>>> Are there any known issues with amber8's hardware or test environment? >>>>> >>>>> Thanks, >>>>> David >>>>> _______________________________________________ >>>>> Powered by www.kitware.com >>>>> >>>>> Visit other Kitware open-source projects at >>>>> http://www.kitware.com/opensource/opensource.html >>>>> >>>>> Follow this link to subscribe/unsubscribe: >>>>> http://www.vtk.org/mailman/listinfo/vtk-developers >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://www.vtk.org/mailman/listinfo/vtk-developers >>>> >>>> >>> >>> >>> >>> -- >>> Unpaid intern in BillsBasement at noware dot com >> >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > From DLRdave at aol.com Wed May 6 07:37:59 2015 From: DLRdave at aol.com (David Cole) Date: Wed, 6 May 2015 07:37:59 -0400 Subject: [vtk-developers] Gerrit test error on amber8 In-Reply-To: References: <8874AF9D-94B6-4AAA-8860-45EF402CA721@kitware.com> Message-ID: Or from the developer's list on this page: http://www.vtk.org/mailman/listinfo/vtk-developers On Wed, May 6, 2015 at 7:37 AM, David Cole wrote: > You may unsubscribe from the VTK Users list on this page: > http://www.vtk.org/mailman/listinfo/vtkusers > > > > On Tue, May 5, 2015 at 6:02 AM, Gru wrote: >> Please. Unsunscribe me from vtk or its >> >> Sent from my Sony Xperia? smartphone >> >> >> >> ---- Yumin Yuan wrote ---- >> >> Just want to update on this. I have spent some decent time trying to track >> it down without much success. The fact that the test passes if I run >> manually on amber8, either individually or in a list of tests, makes it very >> difficult to reproduce. I have trimmed down the test to minimum and played >> around with different openGL calls, but it still intermittently fails when >> running ctest. >> >> Given the fact that this test passes on all other dashboard machines, we >> decided to exclude it from amber8 gerrit-dashboard. We still think this is >> Mesa/openGL related, and I will set up one of my own machines with the same >> environment as amber-8 and investigate further. >> >> Sorry for the inconvenience. >> Yumin >> >> >> On Mon, Apr 29, 2013 at 3:51 PM, Yumin Yuan wrote: >>> >>> Hi Bill, >>> Yes, I agree. I will find some time to get on that machine next couple >>> days. If it is really related to Mesa, I will suppress this test on that >>> machine. >>> >>> Yumin >>> >>> >>> On Mon, Apr 29, 2013 at 1:45 PM, Bill Lorensen >>> wrote: >>>> >>>> Having intermittent gerrit test failures is not good. It would be great >>>> to raise the priority of this. We spent a lot of time recently to get the >>>> gerrit builds to 0 test failures. >>>> >>>> >>>> >>>> On Mon, Apr 29, 2013 at 1:05 PM, Yumin Yuan >>>> wrote: >>>>> >>>>> Hi Dave, >>>>> >>>>> That test is for the new polygon-selection feature in VTK I added last >>>>> week, I also noticed the odd (somewhat random) failure of this test on >>>>> amber8 when I pushed to Gerrit, and I talked with Marcus a little bit, and >>>>> he thought it may be related to the mesa library that amber8 is running. I >>>>> have not spent time to track down the issue, but since this test is passing >>>>> on all nightly dashboard machines, I think you can ignore it for the stuff >>>>> you are working on. I will try to track it down when I get some free time. >>>>> >>>>> Yumin >>>>> >>>>> >>>>> On Mon, Apr 29, 2013 at 12:37 PM, David Thompson >>>>> wrote: >>>>>> >>>>>> Hi all, >>>>>> >>>>>> I'm seeing an odd test error on amber8: TestPolygonSelection is failing >>>>>> which is unrelated to the code I checked in. It also appears to be failing >>>>>> for other unrelated gerrit topics: >>>>>> >>>>>> http://open.cdash.org/testDetails.php?test=186977515&build=2890285 >>>>>> http://open.cdash.org/testDetails.php?test=187458615&build=2890244 >>>>>> >>>>>> Are there any known issues with amber8's hardware or test environment? >>>>>> >>>>>> Thanks, >>>>>> David >>>>>> _______________________________________________ >>>>>> Powered by www.kitware.com >>>>>> >>>>>> Visit other Kitware open-source projects at >>>>>> http://www.kitware.com/opensource/opensource.html >>>>>> >>>>>> Follow this link to subscribe/unsubscribe: >>>>>> http://www.vtk.org/mailman/listinfo/vtk-developers >>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Powered by www.kitware.com >>>>> >>>>> Visit other Kitware open-source projects at >>>>> http://www.kitware.com/opensource/opensource.html >>>>> >>>>> Follow this link to subscribe/unsubscribe: >>>>> http://www.vtk.org/mailman/listinfo/vtk-developers >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Unpaid intern in BillsBasement at noware dot com >>> >>> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> From lasso at queensu.ca Wed May 6 07:26:24 2015 From: lasso at queensu.ca (Andras Lasso) Date: Wed, 6 May 2015 11:26:24 +0000 Subject: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? In-Reply-To: References: <57EE86D11538B44096C712532DBB6C5A012EF2AC55A3@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC55BA@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC561F@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5653@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5657@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92A34@DKFZEX01.ad.dkfz-heidelberg.de>, Message-ID: Developers of open-source projects often have some freedom in prioritization of their tasks, so actually I think it's a good idea to let developers know that a particular fix is critical for you. To expedite the process you may also consider: * creating a test that detects the problem * running the test on various computers, with different settings and share the results * asking advice from developers about potential approaches to fix the issue, trying to fix it yourself, then submitting a patch for review Andras ________________________________ From: David Lonie Sent: ?2015-?05-?05 09:52 To: Kilgus, Thomas Cc: vtk-developers at vtk.org Subject: Re: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? On Tue, May 5, 2015 at 5:52 AM, Kilgus, Thomas > wrote: Since this is a major issue for us, I am curious: Should I keep pressuring you here for a fix or in mantis? Or are you already looking into it? Well, pressuring developers for fixes to an open-source project isn't necessarily a strategy I'd advise ;) But I will be looking into this soon, and plan to have a patch in the next week or two. I'll update the bug report/this thread as things progress. Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Wed May 6 09:04:52 2015 From: berk.geveci at kitware.com (Berk Geveci) Date: Wed, 6 May 2015 09:04:52 -0400 Subject: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? In-Reply-To: References: <57EE86D11538B44096C712532DBB6C5A012EF2AC55A3@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC55BA@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC561F@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5653@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5657@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92A34@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: Very good advice Andras. Thank you. -berk On Wed, May 6, 2015 at 7:26 AM, Andras Lasso wrote: > Developers of open-source projects often have some freedom in > prioritization of their tasks, so actually I think it's a good idea to let > developers know that a particular fix is critical for you. > > To expedite the process you may also consider: > * creating a test that detects the problem > * running the test on various computers, with different settings and share > the results > * asking advice from developers about potential approaches to fix the > issue, trying to fix it yourself, then submitting a patch for review > > Andras > ------------------------------ > From: David Lonie > Sent: ?2015-?05-?05 09:52 > To: Kilgus, Thomas > Cc: vtk-developers at vtk.org > Subject: Re: [vtk-developers] Anti-aliasing / multi sampling turned off > in VTK 6.2? > > On Tue, May 5, 2015 at 5:52 AM, Kilgus, Thomas < > t.kilgus at dkfz-heidelberg.de> wrote: > >> Since this is a major issue for us, I am curious: Should I keep >> pressuring you here for a fix or in mantis? Or are you already looking into >> it? >> > > Well, pressuring developers for fixes to an open-source project isn't > necessarily a strategy I'd advise ;) But I will be looking into this soon, > and plan to have a patch in the next week or two. I'll update the bug > report/this thread as things progress. > > Dave > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From DLRdave at aol.com Wed May 6 09:28:27 2015 From: DLRdave at aol.com (David Cole) Date: Wed, 6 May 2015 09:28:27 -0400 Subject: [vtk-developers] Solutions to TestSetGet/TestEmptyInput failures on RogueResearch3 In-Reply-To: References: Message-ID: 4) Exclude these tests on machines submitting dashboards with python < 2.6, make a note somewhere that says these tests require 2.6 or later, and wait for 2.5 to go away... Just another option to consider. Another way to deal with it might be to simply print output from the test itself saying "python < 2.6 does not have isabstract, test not really running, fake pass anyway" D On Wed, May 6, 2015 at 3:34 AM, Andrew Maclean wrote: > Hi All, > > RogueResearch is running Python 2.5. > > Both TestSetGet.py and TestEmptyInput.py fail at this line: > vtkClasses = inspect.getmembers( > vtk, inspect.isclass and not inspect.isabstract) > with this error: > vtk, inspect.isclass and not inspect.isabstract) > AttributeError: 'module' object has no attribute 'isabstract' > > Apparently the isabstract attribute was introduced in Python 2.6. > > From what I can see there are these options: > > 1) Skip these two tests by checking the version of Python used when VTK is > built. > 2) Extend option 1 by by creating a global variables in > ./Cmake/VTKConfig.cmake. > 3) Do nothing, and hope Python 2.5 is eventually deprecated. > > My preferred option is 2) as this could be useful when VTK supports Python 3 > e.g it may be useful to know which version of Python VTK is wrapped with, in > the same way as we use VTK_QT_VERSION. If this is Ok I propose calling it > VTK_WRAPPING_PYTHON_VERSION to distinguish it from VTK_PYTHON_VERSION in > ./CmakeLists.txt (which can have the values 2, 2.x, 3, 3.x etc). > VTK_WRAPPING_PYTHON_VERSION would be built from PYTHON_MAJOR_VERSION and > PYTHON_MINOR_VERSION which are defined in ./CMake/FindPythonLibs.cmake. > This would require just adding one line to ./CMake/VTKConfig.cmake.in, > something like this: > 2.1) > SET(VTK_WRAPPING_PYTHON_VERSION > "@PYTHON_MAJOR_VERSION at .@PYTHON_MINOR_VERSION@") > > or ... would it be better to simply just do this in this file, since these > are defined in ./Utilities/Python/vtkPythonConfigure.h.in? > 2.2) > SET(VTK_PYTHON_MAJOR_VERSION "@VTK_PYTHON_MAJOR_VERSION @") > SET(VTK_PYTHON_MINOR_VERSION"@VTK_PYTHON_MINOR_VERSION@") > > I prefer option 2) and, on reflection, I would go with with 2.2) > > Please let me know what you think would be the best option. > > Regards > Andrew > > > -- > ___________________________________________ > Andrew J. P. Maclean > > ___________________________________________ > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > From t.kilgus at Dkfz-Heidelberg.de Wed May 6 10:22:46 2015 From: t.kilgus at Dkfz-Heidelberg.de (Kilgus, Thomas) Date: Wed, 6 May 2015 16:22:46 +0200 Subject: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? In-Reply-To: References: <57EE86D11538B44096C712532DBB6C5A012EF2AC55A3@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC55BA@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC561F@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5653@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5657@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92A34@DKFZEX01.ad.dkfz-heidelberg.de>, Message-ID: <57EE86D11538B44096C712532DBB6C5A012EF2D92BF4@DKFZEX01.ad.dkfz-heidelberg.de> That?s all very true, however, my most important question is: Is anyone working on that issue already or not? Regarding your suggestions: ? I don?t think that creating a test for anti-aliasing is feasible. As far as I am concerned, it is disabled in rendering tests on purpose due to the differences of hardware. If there is any reliable way to test it automatically, we already provided a script reproducing the error. The renderwindow can be used against a reference for a rendering test. ? As far as I know, it?s broken everywhere. As mentioned in previous mails we tested this on Mac, Linux (Ubuntu and Archlinux) and Windows 7. ? We also found a fix with some ?hack? which probably destroys other features. See Mantis for more information. Bottom line, I think we need feedback from VTK developers to continue. Regards, Thomas Von: Andras Lasso [mailto:lasso at queensu.ca] Gesendet: Mittwoch, 6. Mai 2015 13:26 An: David Lonie; Kilgus, Thomas Cc: vtk-developers at vtk.org Betreff: RE: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? Developers of open-source projects often have some freedom in prioritization of their tasks, so actually I think it's a good idea to let developers know that a particular fix is critical for you. To expedite the process you may also consider: * creating a test that detects the problem * running the test on various computers, with different settings and share the results * asking advice from developers about potential approaches to fix the issue, trying to fix it yourself, then submitting a patch for review Andras ________________________________ From: David Lonie Sent: ?2015-?05-?05 09:52 To: Kilgus, Thomas Cc: vtk-developers at vtk.org Subject: Re: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? On Tue, May 5, 2015 at 5:52 AM, Kilgus, Thomas > wrote: Since this is a major issue for us, I am curious: Should I keep pressuring you here for a fix or in mantis? Or are you already looking into it? Well, pressuring developers for fixes to an open-source project isn't necessarily a strategy I'd advise ;) But I will be looking into this soon, and plan to have a patch in the next week or two. I'll update the bug report/this thread as things progress. Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From t.kilgus at Dkfz-Heidelberg.de Wed May 6 10:25:03 2015 From: t.kilgus at Dkfz-Heidelberg.de (Kilgus, Thomas) Date: Wed, 6 May 2015 16:25:03 +0200 Subject: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? In-Reply-To: <57EE86D11538B44096C712532DBB6C5A012EF2D92BF4@DKFZEX01.ad.dkfz-heidelberg.de> References: <57EE86D11538B44096C712532DBB6C5A012EF2AC55A3@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC55BA@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC561F@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5653@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5657@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92A34@DKFZEX01.ad.dkfz-heidelberg.de>, <57EE86D11538B44096C712532DBB6C5A012EF2D92BF4@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: <57EE86D11538B44096C712532DBB6C5A012EF2D92BF8@DKFZEX01.ad.dkfz-heidelberg.de> Sorry, I forgot to add the mantis link: http://www.vtk.org/Bug/view.php?id=15433 Von: vtk-developers [mailto:vtk-developers-bounces at vtk.org] Im Auftrag von Kilgus, Thomas Gesendet: Mittwoch, 6. Mai 2015 16:23 An: Andras Lasso; David Lonie Cc: vtk-developers at vtk.org Betreff: Re: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? That?s all very true, however, my most important question is: Is anyone working on that issue already or not? Regarding your suggestions: ? I don?t think that creating a test for anti-aliasing is feasible. As far as I am concerned, it is disabled in rendering tests on purpose due to the differences of hardware. If there is any reliable way to test it automatically, we already provided a script reproducing the error. The renderwindow can be used against a reference for a rendering test. ? As far as I know, it?s broken everywhere. As mentioned in previous mails we tested this on Mac, Linux (Ubuntu and Archlinux) and Windows 7. ? We also found a fix with some ?hack? which probably destroys other features. See Mantis for more information. Bottom line, I think we need feedback from VTK developers to continue. Regards, Thomas Von: Andras Lasso [mailto:lasso at queensu.ca] Gesendet: Mittwoch, 6. Mai 2015 13:26 An: David Lonie; Kilgus, Thomas Cc: vtk-developers at vtk.org Betreff: RE: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? Developers of open-source projects often have some freedom in prioritization of their tasks, so actually I think it's a good idea to let developers know that a particular fix is critical for you. To expedite the process you may also consider: * creating a test that detects the problem * running the test on various computers, with different settings and share the results * asking advice from developers about potential approaches to fix the issue, trying to fix it yourself, then submitting a patch for review Andras ________________________________ From: David Lonie Sent: ?2015-?05-?05 09:52 To: Kilgus, Thomas Cc: vtk-developers at vtk.org Subject: Re: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? On Tue, May 5, 2015 at 5:52 AM, Kilgus, Thomas > wrote: Since this is a major issue for us, I am curious: Should I keep pressuring you here for a fix or in mantis? Or are you already looking into it? Well, pressuring developers for fixes to an open-source project isn't necessarily a strategy I'd advise ;) But I will be looking into this soon, and plan to have a patch in the next week or two. I'll update the bug report/this thread as things progress. Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lonie at kitware.com Wed May 6 10:36:44 2015 From: david.lonie at kitware.com (David Lonie) Date: Wed, 6 May 2015 10:36:44 -0400 Subject: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? In-Reply-To: <57EE86D11538B44096C712532DBB6C5A012EF2D92BF4@DKFZEX01.ad.dkfz-heidelberg.de> References: <57EE86D11538B44096C712532DBB6C5A012EF2AC55A3@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC55BA@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC561F@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5653@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5657@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92A34@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92BF4@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: On Wed, May 6, 2015 at 10:22 AM, Kilgus, Thomas wrote: > That?s all very true, however, my most important question is: Is anyone > working on that issue already or not? > Yes. Regarding the rest, letting us know that a feature is important to you is good. Asking for more information to help track-down/fix it on your own is good. "Pressuring" us for a fix is not. We have to find funding to pay for work on VTK, and sometimes a request is low-priority or too esoteric for existing funding sources to cover. So there are cases where pressuring developers will not work out well. In this case, the issue is not low-priority and is a regression of a major feature, so we can cover fixing it without much trouble. FWIW, I'm sure Thomas wasn't really implying that he was going to pester/pressure/harass us until this gets fixed. I was only trying to (lightheartedly) point out that "pressuring" open-source developers for a fix is not likely to produce the desired results. Best, Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From t.kilgus at Dkfz-Heidelberg.de Wed May 6 10:44:50 2015 From: t.kilgus at Dkfz-Heidelberg.de (Kilgus, Thomas) Date: Wed, 6 May 2015 16:44:50 +0200 Subject: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? In-Reply-To: References: <57EE86D11538B44096C712532DBB6C5A012EF2AC55A3@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC55BA@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC561F@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5653@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5657@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92A34@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92BF4@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: <57EE86D11538B44096C712532DBB6C5A012EF2D92C01@DKFZEX01.ad.dkfz-heidelberg.de> Ok thank you. Please let us know if we can do anything particular to help tracking it down. Von: David Lonie [mailto:david.lonie at kitware.com] Gesendet: Mittwoch, 6. Mai 2015 16:37 An: Kilgus, Thomas Cc: Andras Lasso; vtk-developers at vtk.org Betreff: Re: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? On Wed, May 6, 2015 at 10:22 AM, Kilgus, Thomas > wrote: That?s all very true, however, my most important question is: Is anyone working on that issue already or not? Yes. Regarding the rest, letting us know that a feature is important to you is good. Asking for more information to help track-down/fix it on your own is good. "Pressuring" us for a fix is not. We have to find funding to pay for work on VTK, and sometimes a request is low-priority or too esoteric for existing funding sources to cover. So there are cases where pressuring developers will not work out well. In this case, the issue is not low-priority and is a regression of a major feature, so we can cover fixing it without much trouble. FWIW, I'm sure Thomas wasn't really implying that he was going to pester/pressure/harass us until this gets fixed. I was only trying to (lightheartedly) point out that "pressuring" open-source developers for a fix is not likely to produce the desired results. Best, Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lonie at kitware.com Wed May 6 10:48:02 2015 From: david.lonie at kitware.com (David Lonie) Date: Wed, 6 May 2015 10:48:02 -0400 Subject: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? In-Reply-To: <57EE86D11538B44096C712532DBB6C5A012EF2D92C01@DKFZEX01.ad.dkfz-heidelberg.de> References: <57EE86D11538B44096C712532DBB6C5A012EF2AC55A3@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC55BA@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC561F@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5653@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5657@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92A34@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92BF4@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92C01@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: On Wed, May 6, 2015 at 10:44 AM, Kilgus, Thomas wrote: > Ok thank you. Please let us know if we can do anything particular to help > tracking it down. > Will do :-) You've provided a test script and tracked down that the bug was introduced in between 6.1.0 and 6.2.0. That's already a pretty significant help! Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From mbrown2 at ualberta.ca Wed May 6 11:25:56 2015 From: mbrown2 at ualberta.ca (mbrown) Date: Wed, 6 May 2015 08:25:56 -0700 (MST) Subject: [vtk-developers] Bug in vtkNIFTIImageReader's handling of left-handed images? Message-ID: <1430925956349-5731787.post@n5.nabble.com> Is the following behaviour a bug in vtkNIFTImageReader ? If you load SPM8's EPI.nii MNI template file using vtkNIFTIImageReader, it produces different q-form and s-form matrices. Note that the EPI.nii file obeys radiological convention (i.e. left-right flipped, qfac=-1 and left-handed s-form matrix), and vtkNIFTIImageReader flips the slice order and changes the q-form and s-form matrices as described in vtkNIFTIImageReader.cxx. To reproduce, in Python 2.7.3, running on Ubuntu 12.04, using vtk 6.2.0, do this: import vtk file_path = '/templates/EPI.nii' r = vtk.vtkNIFTIImageReader() r.SetFileName(file_path) r.Update() print(r.GetNIFTIHeader()) # original header values print(r.GetQFormMatrix()) # q-form matrix, with modifications by vtkNIFTIImageReader print(r.GetSFormMatrix()) # s-form matrix, with modifications by vtkNIFTIImageReader The last three lines produce ... original NIFTI header values (unnecessary fields not shown): Dim: 3 91 109 91 1 1 1 1 PixDim: -1 2 2 2 0 0 0 0 QFormCode: 4 SFormCode: 4 QuaternB: 0 QuaternC: 1 QuaternD: 0 QoffsetX: 90 QoffsetY: -126 QoffsetZ: -72 SRowX: -2 0 0 90 SRowY: 0 2 0 -126 SRowZ: 0 0 2 -72 q-form matrix -1 0 0 90 0 -1 0 -126 0 0 -1 108 0 0 0 1 s-form matrix -1 0 0 90 0 -1 0 -126 0 0 -1 -252 0 0 0 1 I.e. the z-offset number in the fourth column is different between the q-form and s-form matrices. I tracked down the cause. In vtkNIFTIImageReader.cxx (accessed from https://github.com/Kitware/VTK/blob/master/IO/Image/vtkNIFTIImageReader.cxx on 2015-05-06): lines 974-976, where it adjusts the q-form matrix when qfac<0: mmat[3] -= rmat[0][2]*hdr2->pixdim[3]*(hdr2->dim[3] - 1); mmat[7] -= rmat[1][2]*hdr2->pixdim[3]*(hdr2->dim[3] - 1); mmat[11] -= rmat[2][2]*hdr2->pixdim[3]*(hdr2->dim[3] - 1); versus lines 1031-1033, where it adjusts the s-form matrix when qfac<0: mmat[3] -= hdr2->srow_x[2]*(hdr2->dim[3] - 1); mmat[7] -= hdr2->srow_y[2]*(hdr2->dim[3] - 1); mmat[11] -= hdr2->srow_z[2]*(hdr2->dim[3] - 1); Importantly, the rmat matrix (computed on line 926) used in lines 974-976 is positive definite whereas the matrix defined by srow_x,y,z and used in lines 1031-1033 has negative determinant, in the case of SPM8's EPI.nii file. This means that rmat[2,2]=-1 and line 976 adds 180 to mmat[11] taking it from -72 to 108 in the case of EPI.nii. In contrast, srow_z[2]=2, and line 1033 subtracts 180 from mmat[11] taking it from -72 to -252. Is this difference in behaviour intentional? If so, why? Other tests suggest that the q-form code is correct and the s-form code is incorrect. A possible fix would be to replace lines 1031-1033 with: mmat[3] += hdr2->srow_x[2]*(hdr2->dim[3] - 1); mmat[7] += hdr2->srow_y[2]*(hdr2->dim[3] - 1); mmat[11] += hdr2->srow_z[2]*(hdr2->dim[3] - 1); What do you think? Thanks. Matt ---------- Matthew Brown, PhD Department of Psychiatry, University of Alberta Edmonton, Canada -- View this message in context: http://vtk.1045678.n5.nabble.com/Bug-in-vtkNIFTIImageReader-s-handling-of-left-handed-images-tp5731787.html Sent from the VTK - Dev mailing list archive at Nabble.com. From sean at rogue-research.com Wed May 6 11:36:05 2015 From: sean at rogue-research.com (Sean McBride) Date: Wed, 6 May 2015 11:36:05 -0400 Subject: [vtk-developers] Solutions to TestSetGet/TestEmptyInput failures on RogueResearch3 In-Reply-To: References: Message-ID: <20150506153605.1575016356@mail.rogue-research.com> On Wed, 6 May 2015 17:34:53 +1000, Andrew Maclean said: >3) Do nothing, and hope Python 2.5 is eventually deprecated. Is Rogue3 the only dashboard with Python 2.5? If so, maybe it's time to increase our minimum requirement? Personally, I think VTK's minimum requirements are too generous. I would ditch OS X 10.5, PowerPC, gcc <= 4.2, Windows XP, Visual Studio 2005, Python 2.5, etc., etc., etc. Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From david.gobbi at gmail.com Wed May 6 16:10:23 2015 From: david.gobbi at gmail.com (David Gobbi) Date: Wed, 6 May 2015 14:10:23 -0600 Subject: [vtk-developers] Bug in vtkNIFTIImageReader's handling of left-handed images? In-Reply-To: <1430925956349-5731787.post@n5.nabble.com> References: <1430925956349-5731787.post@n5.nabble.com> Message-ID: Hi Matthew, I have confirmed that when qfac=-1, the z-offset in the qform and sform differ when they should be exactly the same. It is a very good thing that you found this problem. I'll get to work on verifying your fix. - David On Wed, May 6, 2015 at 9:25 AM, mbrown wrote: > Is the following behaviour a bug in vtkNIFTImageReader ? > > If you load SPM8's EPI.nii MNI template file using vtkNIFTIImageReader, it > produces different q-form and s-form matrices. Note that the EPI.nii file > obeys radiological convention (i.e. left-right flipped, qfac=-1 and > left-handed s-form matrix), and vtkNIFTIImageReader flips the slice order > and changes the q-form and s-form matrices as described in > vtkNIFTIImageReader.cxx. To reproduce, in Python 2.7.3, running on Ubuntu > 12.04, using vtk 6.2.0, do this: > > import vtk > file_path = '/templates/EPI.nii' > r = vtk.vtkNIFTIImageReader() > r.SetFileName(file_path) > r.Update() > print(r.GetNIFTIHeader()) # original header values > print(r.GetQFormMatrix()) # q-form matrix, with modifications by > vtkNIFTIImageReader > print(r.GetSFormMatrix()) # s-form matrix, with modifications by > vtkNIFTIImageReader > > The last three lines produce ... > > original NIFTI header values (unnecessary fields not shown): > Dim: 3 91 109 91 1 1 1 1 > PixDim: -1 2 2 2 0 0 0 0 > QFormCode: 4 > SFormCode: 4 > QuaternB: 0 > QuaternC: 1 > QuaternD: 0 > QoffsetX: 90 > QoffsetY: -126 > QoffsetZ: -72 > SRowX: -2 0 0 90 > SRowY: 0 2 0 -126 > SRowZ: 0 0 2 -72 > > q-form matrix > -1 0 0 90 > 0 -1 0 -126 > 0 0 -1 108 > 0 0 0 1 > > s-form matrix > -1 0 0 90 > 0 -1 0 -126 > 0 0 -1 -252 > 0 0 0 1 > > I.e. the z-offset number in the fourth column is different between the > q-form and s-form matrices. I tracked down the cause. In > vtkNIFTIImageReader.cxx (accessed from > https://github.com/Kitware/VTK/blob/master/IO/Image/vtkNIFTIImageReader.cxx > on 2015-05-06): > > lines 974-976, where it adjusts the q-form matrix when qfac<0: > mmat[3] -= rmat[0][2]*hdr2->pixdim[3]*(hdr2->dim[3] - 1); > mmat[7] -= rmat[1][2]*hdr2->pixdim[3]*(hdr2->dim[3] - 1); > mmat[11] -= rmat[2][2]*hdr2->pixdim[3]*(hdr2->dim[3] - 1); > > versus lines 1031-1033, where it adjusts the s-form matrix when qfac<0: > mmat[3] -= hdr2->srow_x[2]*(hdr2->dim[3] - 1); > mmat[7] -= hdr2->srow_y[2]*(hdr2->dim[3] - 1); > mmat[11] -= hdr2->srow_z[2]*(hdr2->dim[3] - 1); > > Importantly, the rmat matrix (computed on line 926) used in lines 974-976 > is > positive definite whereas the matrix defined by srow_x,y,z and used in > lines > 1031-1033 has negative determinant, in the case of SPM8's EPI.nii file. > This > means that rmat[2,2]=-1 and line 976 adds 180 to mmat[11] taking it from > -72 > to 108 in the case of EPI.nii. In contrast, srow_z[2]=2, and line 1033 > subtracts 180 from mmat[11] taking it from -72 to -252. > > Is this difference in behaviour intentional? If so, why? > > Other tests suggest that the q-form code is correct and the s-form code is > incorrect. A possible fix would be to replace lines 1031-1033 with: > mmat[3] += hdr2->srow_x[2]*(hdr2->dim[3] - 1); > mmat[7] += hdr2->srow_y[2]*(hdr2->dim[3] - 1); > mmat[11] += hdr2->srow_z[2]*(hdr2->dim[3] - 1); > > What do you think? Thanks. > Matt > > ---------- > Matthew Brown, PhD > Department of Psychiatry, University of Alberta > Edmonton, Canada > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.gobbi at gmail.com Wed May 6 18:50:16 2015 From: david.gobbi at gmail.com (David Gobbi) Date: Wed, 6 May 2015 16:50:16 -0600 Subject: [vtk-developers] Bug in vtkNIFTIImageReader's handling of left-handed images? In-Reply-To: References: <1430925956349-5731787.post@n5.nabble.com> Message-ID: Hi Matthew, I've written a patch that includes your fix: https://gitlab.kitware.com/vtk/vtk/merge_requests/181 Hopefully we'll get this merged soon. - David On Wed, May 6, 2015 at 2:10 PM, David Gobbi wrote: > Hi Matthew, > > I have confirmed that when qfac=-1, the z-offset in the qform and sform > differ when they should be exactly the same. It is a very good thing that > you found this problem. I'll get to work on verifying your fix. > > - David > > > On Wed, May 6, 2015 at 9:25 AM, mbrown wrote: > >> Is the following behaviour a bug in vtkNIFTImageReader ? >> >> If you load SPM8's EPI.nii MNI template file using vtkNIFTIImageReader, it >> produces different q-form and s-form matrices. Note that the EPI.nii file >> obeys radiological convention (i.e. left-right flipped, qfac=-1 and >> left-handed s-form matrix), and vtkNIFTIImageReader flips the slice order >> and changes the q-form and s-form matrices as described in >> vtkNIFTIImageReader.cxx. To reproduce, in Python 2.7.3, running on Ubuntu >> 12.04, using vtk 6.2.0, do this: >> >> import vtk >> file_path = '/templates/EPI.nii' >> r = vtk.vtkNIFTIImageReader() >> r.SetFileName(file_path) >> r.Update() >> print(r.GetNIFTIHeader()) # original header values >> print(r.GetQFormMatrix()) # q-form matrix, with modifications by >> vtkNIFTIImageReader >> print(r.GetSFormMatrix()) # s-form matrix, with modifications by >> vtkNIFTIImageReader >> >> The last three lines produce ... >> >> original NIFTI header values (unnecessary fields not shown): >> Dim: 3 91 109 91 1 1 1 1 >> PixDim: -1 2 2 2 0 0 0 0 >> QFormCode: 4 >> SFormCode: 4 >> QuaternB: 0 >> QuaternC: 1 >> QuaternD: 0 >> QoffsetX: 90 >> QoffsetY: -126 >> QoffsetZ: -72 >> SRowX: -2 0 0 90 >> SRowY: 0 2 0 -126 >> SRowZ: 0 0 2 -72 >> >> q-form matrix >> -1 0 0 90 >> 0 -1 0 -126 >> 0 0 -1 108 >> 0 0 0 1 >> >> s-form matrix >> -1 0 0 90 >> 0 -1 0 -126 >> 0 0 -1 -252 >> 0 0 0 1 >> >> I.e. the z-offset number in the fourth column is different between the >> q-form and s-form matrices. I tracked down the cause. In >> vtkNIFTIImageReader.cxx (accessed from >> >> https://github.com/Kitware/VTK/blob/master/IO/Image/vtkNIFTIImageReader.cxx >> on 2015-05-06): >> >> lines 974-976, where it adjusts the q-form matrix when qfac<0: >> mmat[3] -= rmat[0][2]*hdr2->pixdim[3]*(hdr2->dim[3] - 1); >> mmat[7] -= rmat[1][2]*hdr2->pixdim[3]*(hdr2->dim[3] - 1); >> mmat[11] -= rmat[2][2]*hdr2->pixdim[3]*(hdr2->dim[3] - 1); >> >> versus lines 1031-1033, where it adjusts the s-form matrix when qfac<0: >> mmat[3] -= hdr2->srow_x[2]*(hdr2->dim[3] - 1); >> mmat[7] -= hdr2->srow_y[2]*(hdr2->dim[3] - 1); >> mmat[11] -= hdr2->srow_z[2]*(hdr2->dim[3] - 1); >> >> Importantly, the rmat matrix (computed on line 926) used in lines 974-976 >> is >> positive definite whereas the matrix defined by srow_x,y,z and used in >> lines >> 1031-1033 has negative determinant, in the case of SPM8's EPI.nii file. >> This >> means that rmat[2,2]=-1 and line 976 adds 180 to mmat[11] taking it from >> -72 >> to 108 in the case of EPI.nii. In contrast, srow_z[2]=2, and line 1033 >> subtracts 180 from mmat[11] taking it from -72 to -252. >> >> Is this difference in behaviour intentional? If so, why? >> >> Other tests suggest that the q-form code is correct and the s-form code is >> incorrect. A possible fix would be to replace lines 1031-1033 with: >> mmat[3] += hdr2->srow_x[2]*(hdr2->dim[3] - 1); >> mmat[7] += hdr2->srow_y[2]*(hdr2->dim[3] - 1); >> mmat[11] += hdr2->srow_z[2]*(hdr2->dim[3] - 1); >> >> What do you think? Thanks. >> Matt >> >> ---------- >> Matthew Brown, PhD >> Department of Psychiatry, University of Alberta >> Edmonton, Canada >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Wed May 6 19:27:41 2015 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Thu, 7 May 2015 09:27:41 +1000 Subject: [vtk-developers] Solutions to TestSetGet/TestEmptyInput failures on RogueResearch3 In-Reply-To: <20150506153605.1575016356@mail.rogue-research.com> References: <20150506153605.1575016356@mail.rogue-research.com> Message-ID: Sean: >From what I see, none of these OS's/Compilers are supported any more by their makers. Personally I would be happy to see them go too. It does constrain innovation supporting such old systems/compilers. David: Thanks for the input, I'll go with option 4). It is the least intrusive. Regards Andrew On Thu, May 7, 2015 at 1:36 AM, Sean McBride wrote: > On Wed, 6 May 2015 17:34:53 +1000, Andrew Maclean said: > > >3) Do nothing, and hope Python 2.5 is eventually deprecated. > > Is Rogue3 the only dashboard with Python 2.5? If so, maybe it's time to > increase our minimum requirement? > > Personally, I think VTK's minimum requirements are too generous. I would > ditch OS X 10.5, PowerPC, gcc <= 4.2, Windows XP, Visual Studio 2005, > Python 2.5, etc., etc., etc. > > Cheers, > > -- > ____________________________________________________________ > Sean McBride, B. Eng sean at rogue-research.com > Rogue Research www.rogue-research.com > Mac Software Developer Montr?al, Qu?bec, Canada > > > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From mbrown2 at ualberta.ca Wed May 6 21:42:19 2015 From: mbrown2 at ualberta.ca (mbrown) Date: Wed, 6 May 2015 18:42:19 -0700 (MST) Subject: [vtk-developers] Bug in vtkNIFTIImageReader's handling of left-handed images? In-Reply-To: References: <1430925956349-5731787.post@n5.nabble.com> Message-ID: <1430962939546-5731798.post@n5.nabble.com> Great! Glad this was helpful. Matt -- View this message in context: http://vtk.1045678.n5.nabble.com/Bug-in-vtkNIFTIImageReader-s-handling-of-left-handed-images-tp5731787p5731798.html Sent from the VTK - Dev mailing list archive at Nabble.com. From david.lonie at kitware.com Thu May 7 07:20:38 2015 From: david.lonie at kitware.com (David Lonie) Date: Thu, 7 May 2015 07:20:38 -0400 Subject: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? In-Reply-To: References: <57EE86D11538B44096C712532DBB6C5A012EF2AC55A3@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC55BA@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC561F@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5653@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5657@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92A34@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92BF4@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92C01@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: There's a fix up here: https://gitlab.kitware.com/vtk/vtk/merge_requests/178 Let me know if you get a chance to test it. Dave On Wed, May 6, 2015 at 10:48 AM, David Lonie wrote: > On Wed, May 6, 2015 at 10:44 AM, Kilgus, Thomas < > t.kilgus at dkfz-heidelberg.de> wrote: > >> Ok thank you. Please let us know if we can do anything particular to help >> tracking it down. >> > > Will do :-) You've provided a test script and tracked down that the bug > was introduced in between 6.1.0 and 6.2.0. That's already a pretty > significant help! > > Dave > -------------- next part -------------- An HTML attachment was scrubbed... URL: From c.kolb at dkfz-heidelberg.de Thu May 7 08:31:53 2015 From: c.kolb at dkfz-heidelberg.de (Christoph Kolb) Date: Thu, 07 May 2015 14:31:53 +0200 Subject: [vtk-developers] Anti-aliasing / multi sampling turned off in VTK 6.2? In-Reply-To: References: <57EE86D11538B44096C712532DBB6C5A012EF2AC55A3@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5653@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2AC5657@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92A34@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92BF4@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF2D92C01@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: <554B5B39.5090602@dkfz-heidelberg.de> Hello Dave, your fix works for me in the RGrid example and also in SimpleView with Qt4. But not in Qt5. If you run the SimpleView example with Qt5, multisampling is off again which is inexplicable to me because in my understanding the QVTKWidget was simply painting the GL buffer rendered by a vtkRenderWindow which should already be antialiased... Is that wrong? Christoph On 05/07/2015 01:20 PM, David Lonie wrote: > There's a fix up here: > https://gitlab.kitware.com/vtk/vtk/merge_requests/178 > > Let me know if you get a chance to test it. > > Dave > > On Wed, May 6, 2015 at 10:48 AM, David Lonie > wrote: > > On Wed, May 6, 2015 at 10:44 AM, Kilgus, Thomas > > > wrote: > > Ok thank you. Please let us know if we can do anything > particular to help tracking it down. > > > Will do :-) You've provided a test script and tracked down that > the bug was introduced in between 6.1.0 and 6.2.0. That's already > a pretty significant help! > > Dave > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lonie at kitware.com Thu May 7 09:17:43 2015 From: david.lonie at kitware.com (David Lonie) Date: Thu, 7 May 2015 09:17:43 -0400 Subject: [vtk-developers] Antialiasing broken in Qt5 Message-ID: On Thu, May 7, 2015 at 8:31 AM, Christoph Kolb wrote: > your fix works for me in the RGrid example and also in SimpleView with > Qt4. > But not in Qt5. > If you run the SimpleView example with Qt5, multisampling is off again > which is inexplicable to me because in my understanding the QVTKWidget was > simply painting the GL buffer rendered by a vtkRenderWindow which should > already be antialiased... Is that wrong? > Hmm, I'm not super familiar with the Qt layer in VTK. Perhaps someone else on the list might know? Looking at the QVTKWidget implementation, I don't see why the Qt version would make a difference regarding MSAA. Let's see if someone on the list has any ideas, and I'll ask around to see what I can find out. Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Fri May 8 02:00:08 2015 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Fri, 8 May 2015 16:00:08 +1000 Subject: [vtk-developers] An interesting statistic about VTK Message-ID: Hi All, Look at this for VTK: ---------------------------------------- Total number of Cxx tests : 1053 Total number of Python tests : 537 Total number of TCL tests : 443 Total number of tests : 2033 ---------------------------------------- Tests in TCL but not in Python or Cxx. Common/Core/Testing/Tcl TestArrays TestString otherInterp otherPrint Filters/Core/Testing/Tcl probe Filters/Sources/Testing/Tcl squadViewer Rendering/Tk/Testing/Tcl TestTextActor3D cursor3D ---------------------------------------- Some time ago we spent a lot of time converting the Tcl tests to Python either automatically or by hand, so now these 8 tests are the only ones not in Python or TCL. Although Common/Core/Testing/Python/TestStrings.py vastly extends the TCL version so really there are just 7 tests not tested by either Python or Cxx. Is it time to disable the duplicate 436 TCL tests? The advantage here is that it may speed up the testing times and these 436 tests are redundant anyway. Note: I am NOT advocating removing the tests as there may be people still using TCL and these may be a useful reference for them. I wrote a python script to do this investigation. If people think it is useful, I will clean it up and put it into VTK. The code currently only looks at Testing/Cxx, Testing/Python, Testing/Tcl in the VTK tree, so folders below these are not looked at. Regards Andrew -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From sz.zwolan at gmail.com Fri May 8 02:22:00 2015 From: sz.zwolan at gmail.com (Szymek_10) Date: Thu, 7 May 2015 23:22:00 -0700 (MST) Subject: [vtk-developers] CMake 3.2.2 + VTK 6.2 + VS 2013 - missing USE_VTK_Rendering Message-ID: <1431066120109-5731824.post@n5.nabble.com> Dears, I would like to start using VTK library but unfortunately I have big problem at begining. I want to compaile this example with DICOM viewer: http://web.mit.edu/16.225/dv/VTK/Examples/ImageProcessing/Cxx/ But there is an error during compiling CMakeLists error with missing VTKRendering and VTKTestingRendering modules (photo attached http://postimg.org/image/p2u9lotid/) *CMakeLists.txt :* /PROJECT(ImageProcessing) IF(NOT VTK_BINARY_DIR) FIND_PACKAGE(VTK REQUIRED) *IF(NOT VTK_USE_RENDERING) MESSAGE(FATAL_ERROR "Example ${PROJECT_NAME} requires VTK_USE_RENDERING.")* ENDIF(NOT VTK_USE_RENDERING) INCLUDE(${VTK_USE_FILE}) ENDIF(NOT VTK_BINARY_DIR) ADD_EXECUTABLE(ImageSlicing ImageSlicing.cxx) TARGET_LINK_LIBRARIES(ImageSlicing vtkRendering vtkImaging vtkIO) ######## Regression Testing ######## SET(KIT ImageProcessingExamples) SET(MyTests TestImageSlicing.cxx) INCLUDE(vtkTestingObjectFactory) ADD_EXECUTABLE(${KIT}CxxTests ${KIT}CxxTests.cxx ${MyTests}) TARGET_LINK_LIBRARIES(${KIT}CxxTests vtkRendering vtkIO) ADD_TEST(${KIT}-ImageSlicing ${EXECUTABLE_OUTPUT_PATH}/${KIT}CxxTests TestImageSlicing ${VTK_DATA_ROOT}/Data/headsq/quarter)/ What i found out is that in VTK version greater than 6.0.0 there is no *USE_VTK_RENDERING* entry in CMake which i should select during compiling process. It was replaced with more 'rendering' modules (CMake photo attached http://postimg.org/image/4rn6tpxq3/) but which I should use? Which module is equivalent to USE_VTK_RENDERING option? I am using Visual Studio 2013 with CMake 3.2.2 version and newest VTK 6.2. I tried to install VS2010 and compaile it in CMake 2.8 with VTK 5.10.1 version but there is too many incompatibilitie errors. After few days of trying to make it right it seems to be ungrateful library which I used to use. I hope that it is a quite easy mistake from me becasue I am really stuck.. I will be grateful for any help! Thank you in advance! Sz -- View this message in context: http://vtk.1045678.n5.nabble.com/CMake-3-2-2-VTK-6-2-VS-2013-missing-USE-VTK-Rendering-tp5731824.html Sent from the VTK - Dev mailing list archive at Nabble.com. From will.schroeder at kitware.com Fri May 8 05:50:52 2015 From: will.schroeder at kitware.com (Will Schroeder) Date: Fri, 8 May 2015 05:50:52 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: Message-ID: Nice work Andrew! I'm all for eliminating duplicates, especially if it means people can test more and faster, although if we are going to retain Tcl for the long haul we do have to continue to test Tcl language bindings. Personally I have not used Tcl for several years now..... W On Fri, May 8, 2015 at 2:00 AM, Andrew Maclean wrote: > Hi All, > > Look at this for VTK: > ---------------------------------------- > Total number of Cxx tests : 1053 > Total number of Python tests : 537 > Total number of TCL tests : 443 > Total number of tests : 2033 > ---------------------------------------- > Tests in TCL but not in Python or Cxx. > Common/Core/Testing/Tcl > TestArrays > TestString > otherInterp > otherPrint > Filters/Core/Testing/Tcl > probe > Filters/Sources/Testing/Tcl > squadViewer > Rendering/Tk/Testing/Tcl > TestTextActor3D > cursor3D > ---------------------------------------- > > Some time ago we spent a lot of time converting the Tcl tests to Python > either automatically or by hand, so now these 8 tests are the only ones not > in Python or TCL. Although Common/Core/Testing/Python/TestStrings.py vastly > extends the TCL version so really there are just 7 tests not tested by > either Python or Cxx. > > Is it time to disable the duplicate 436 TCL tests? > The advantage here is that it may speed up the testing times and these 436 > tests are redundant anyway. > > Note: I am NOT advocating removing the tests as there may be people still > using TCL and these may be a useful reference for them. > > I wrote a python script to do this investigation. If people think it is > useful, I will clean it up and put it into VTK. The code currently only > looks at Testing/Cxx, Testing/Python, Testing/Tcl in the VTK tree, so > folders below these are not looked at. > > Regards > Andrew > > -- > ___________________________________________ > Andrew J. P. Maclean > > ___________________________________________ > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -- William J. Schroeder, PhD Kitware, Inc. 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Fri May 8 08:51:27 2015 From: berk.geveci at kitware.com (Berk Geveci) Date: Fri, 8 May 2015 08:51:27 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: Message-ID: Seconded. On Fri, May 8, 2015 at 5:50 AM, Will Schroeder wrote: > Nice work Andrew! > > I'm all for eliminating duplicates, especially if it means people can test > more and faster, although if we are going to retain Tcl for the long haul > we do have to continue to test Tcl language bindings. Personally I have not > used Tcl for several years now..... > > W > > On Fri, May 8, 2015 at 2:00 AM, Andrew Maclean > wrote: > >> Hi All, >> >> Look at this for VTK: >> ---------------------------------------- >> Total number of Cxx tests : 1053 >> Total number of Python tests : 537 >> Total number of TCL tests : 443 >> Total number of tests : 2033 >> ---------------------------------------- >> Tests in TCL but not in Python or Cxx. >> Common/Core/Testing/Tcl >> TestArrays >> TestString >> otherInterp >> otherPrint >> Filters/Core/Testing/Tcl >> probe >> Filters/Sources/Testing/Tcl >> squadViewer >> Rendering/Tk/Testing/Tcl >> TestTextActor3D >> cursor3D >> ---------------------------------------- >> >> Some time ago we spent a lot of time converting the Tcl tests to Python >> either automatically or by hand, so now these 8 tests are the only ones not >> in Python or TCL. Although Common/Core/Testing/Python/TestStrings.py vastly >> extends the TCL version so really there are just 7 tests not tested by >> either Python or Cxx. >> >> Is it time to disable the duplicate 436 TCL tests? >> The advantage here is that it may speed up the testing times and these >> 436 tests are redundant anyway. >> >> Note: I am NOT advocating removing the tests as there may be people still >> using TCL and these may be a useful reference for them. >> >> I wrote a python script to do this investigation. If people think it is >> useful, I will clean it up and put it into VTK. The code currently only >> looks at Testing/Cxx, Testing/Python, Testing/Tcl in the VTK tree, so >> folders below these are not looked at. >> >> Regards >> Andrew >> >> -- >> ___________________________________________ >> Andrew J. P. Maclean >> >> ___________________________________________ >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > > > -- > William J. Schroeder, PhD > Kitware, Inc. > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From DLRdave at aol.com Fri May 8 09:20:32 2015 From: DLRdave at aol.com (David Cole) Date: Fri, 8 May 2015 09:20:32 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: Message-ID: On the other hand, the tests are "not even there" if you simply turn off TCL wrapping... So why bother removing them? They're a useful reference for those who turn on TCL wrapping. If TCL wrapping is supported, there should be some tests/examples in TCL. I would say if you want to get rid of them, get rid of TCL wrapping entirely. But if you're not willing to go all the way like that, leave the tests for the poor souls stuck using TCL. Just an alternate opinion to consider. Please don't give it too much weight, as I have personally totally been in favor of getting rid of TCL entirely since 2005. David C. On Fri, May 8, 2015 at 8:51 AM, Berk Geveci wrote: > Seconded. > > On Fri, May 8, 2015 at 5:50 AM, Will Schroeder > wrote: >> >> Nice work Andrew! >> >> I'm all for eliminating duplicates, especially if it means people can test >> more and faster, although if we are going to retain Tcl for the long haul we >> do have to continue to test Tcl language bindings. Personally I have not >> used Tcl for several years now..... >> >> W >> >> On Fri, May 8, 2015 at 2:00 AM, Andrew Maclean >> wrote: >>> >>> Hi All, >>> >>> Look at this for VTK: >>> ---------------------------------------- >>> Total number of Cxx tests : 1053 >>> Total number of Python tests : 537 >>> Total number of TCL tests : 443 >>> Total number of tests : 2033 >>> ---------------------------------------- >>> Tests in TCL but not in Python or Cxx. >>> Common/Core/Testing/Tcl >>> TestArrays >>> TestString >>> otherInterp >>> otherPrint >>> Filters/Core/Testing/Tcl >>> probe >>> Filters/Sources/Testing/Tcl >>> squadViewer >>> Rendering/Tk/Testing/Tcl >>> TestTextActor3D >>> cursor3D >>> ---------------------------------------- >>> >>> Some time ago we spent a lot of time converting the Tcl tests to Python >>> either automatically or by hand, so now these 8 tests are the only ones not >>> in Python or TCL. Although Common/Core/Testing/Python/TestStrings.py vastly >>> extends the TCL version so really there are just 7 tests not tested by >>> either Python or Cxx. >>> >>> Is it time to disable the duplicate 436 TCL tests? >>> The advantage here is that it may speed up the testing times and these >>> 436 tests are redundant anyway. >>> >>> Note: I am NOT advocating removing the tests as there may be people still >>> using TCL and these may be a useful reference for them. >>> >>> I wrote a python script to do this investigation. If people think it is >>> useful, I will clean it up and put it into VTK. The code currently only >>> looks at Testing/Cxx, Testing/Python, Testing/Tcl in the VTK tree, so >>> folders below these are not looked at. >>> >>> Regards >>> Andrew >>> >>> -- >>> ___________________________________________ >>> Andrew J. P. Maclean >>> >>> ___________________________________________ >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >> >> >> >> -- >> William J. Schroeder, PhD >> Kitware, Inc. >> 28 Corporate Drive >> Clifton Park, NY 12065 >> will.schroeder at kitware.com >> http://www.kitware.com >> (518) 881-4902 >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > From robert.maynard at kitware.com Fri May 8 09:37:15 2015 From: robert.maynard at kitware.com (Robert Maynard) Date: Fri, 8 May 2015 09:37:15 -0400 Subject: [vtk-developers] CMake 3.2.2 + VTK 6.2 + VS 2013 - missing USE_VTK_Rendering In-Reply-To: <1431066120109-5731824.post@n5.nabble.com> References: <1431066120109-5731824.post@n5.nabble.com> Message-ID: You want to enable VTK_Group_Rendering. On Fri, May 8, 2015 at 2:22 AM, Szymek_10 wrote: > Dears, > > I would like to start using VTK library but unfortunately I have big > problem > at begining. > > I want to compaile this example with DICOM viewer: > > http://web.mit.edu/16.225/dv/VTK/Examples/ImageProcessing/Cxx/ > > But there is an error during compiling CMakeLists error with missing > VTKRendering and VTKTestingRendering modules (photo attached > http://postimg.org/image/p2u9lotid/) > > > *CMakeLists.txt :* > > /PROJECT(ImageProcessing) > > IF(NOT VTK_BINARY_DIR) > FIND_PACKAGE(VTK REQUIRED) > *IF(NOT VTK_USE_RENDERING) > MESSAGE(FATAL_ERROR "Example ${PROJECT_NAME} requires > VTK_USE_RENDERING.")* > ENDIF(NOT VTK_USE_RENDERING) > INCLUDE(${VTK_USE_FILE}) > ENDIF(NOT VTK_BINARY_DIR) > > ADD_EXECUTABLE(ImageSlicing ImageSlicing.cxx) > TARGET_LINK_LIBRARIES(ImageSlicing vtkRendering vtkImaging vtkIO) > > ######## Regression Testing ######## > SET(KIT ImageProcessingExamples) > SET(MyTests TestImageSlicing.cxx) > > INCLUDE(vtkTestingObjectFactory) > ADD_EXECUTABLE(${KIT}CxxTests ${KIT}CxxTests.cxx > ${MyTests}) > TARGET_LINK_LIBRARIES(${KIT}CxxTests vtkRendering vtkIO) > > ADD_TEST(${KIT}-ImageSlicing ${EXECUTABLE_OUTPUT_PATH}/${KIT}CxxTests > TestImageSlicing ${VTK_DATA_ROOT}/Data/headsq/quarter)/ > > What i found out is that in VTK version greater than 6.0.0 there is no > *USE_VTK_RENDERING* entry in CMake which i should select during compiling > process. It was replaced with more 'rendering' modules (CMake photo > attached > http://postimg.org/image/4rn6tpxq3/) but which I should use? Which module > is > equivalent to USE_VTK_RENDERING option? > > I am using Visual Studio 2013 with CMake 3.2.2 version and newest VTK 6.2. > I > tried to install VS2010 and compaile it in CMake 2.8 with VTK 5.10.1 > version > but there is too many incompatibilitie errors. > > After few days of trying to make it right it seems to be ungrateful library > which I used to use. I hope that it is a quite easy mistake from me becasue > I am really stuck.. > > I will be grateful for any help! > > Thank you in advance! > > Sz > > > > -- > View this message in context: > http://vtk.1045678.n5.nabble.com/CMake-3-2-2-VTK-6-2-VS-2013-missing-USE-VTK-Rendering-tp5731824.html > Sent from the VTK - Dev mailing list archive at Nabble.com. > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Fri May 8 09:43:13 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 8 May 2015 09:43:13 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: Message-ID: I agree with Dave C. Just turn TCL wrapping off on most platforms. Turn it on for a couple. On May 8, 2015 9:21 AM, "David Cole via vtk-developers" < vtk-developers at vtk.org> wrote: > On the other hand, the tests are "not even there" if you simply turn > off TCL wrapping... So why bother removing them? They're a useful > reference for those who turn on TCL wrapping. > > If TCL wrapping is supported, there should be some tests/examples in TCL. > > I would say if you want to get rid of them, get rid of TCL wrapping > entirely. But if you're not willing to go all the way like that, leave > the tests for the poor souls stuck using TCL. > > Just an alternate opinion to consider. Please don't give it too much > weight, as I have personally totally been in favor of getting rid of > TCL entirely since 2005. > > > David C. > > > > On Fri, May 8, 2015 at 8:51 AM, Berk Geveci > wrote: > > Seconded. > > > > On Fri, May 8, 2015 at 5:50 AM, Will Schroeder < > will.schroeder at kitware.com> > > wrote: > >> > >> Nice work Andrew! > >> > >> I'm all for eliminating duplicates, especially if it means people can > test > >> more and faster, although if we are going to retain Tcl for the long > haul we > >> do have to continue to test Tcl language bindings. Personally I have not > >> used Tcl for several years now..... > >> > >> W > >> > >> On Fri, May 8, 2015 at 2:00 AM, Andrew Maclean < > andrew.amaclean at gmail.com> > >> wrote: > >>> > >>> Hi All, > >>> > >>> Look at this for VTK: > >>> ---------------------------------------- > >>> Total number of Cxx tests : 1053 > >>> Total number of Python tests : 537 > >>> Total number of TCL tests : 443 > >>> Total number of tests : 2033 > >>> ---------------------------------------- > >>> Tests in TCL but not in Python or Cxx. > >>> Common/Core/Testing/Tcl > >>> TestArrays > >>> TestString > >>> otherInterp > >>> otherPrint > >>> Filters/Core/Testing/Tcl > >>> probe > >>> Filters/Sources/Testing/Tcl > >>> squadViewer > >>> Rendering/Tk/Testing/Tcl > >>> TestTextActor3D > >>> cursor3D > >>> ---------------------------------------- > >>> > >>> Some time ago we spent a lot of time converting the Tcl tests to Python > >>> either automatically or by hand, so now these 8 tests are the only > ones not > >>> in Python or TCL. Although Common/Core/Testing/Python/TestStrings.py > vastly > >>> extends the TCL version so really there are just 7 tests not tested by > >>> either Python or Cxx. > >>> > >>> Is it time to disable the duplicate 436 TCL tests? > >>> The advantage here is that it may speed up the testing times and these > >>> 436 tests are redundant anyway. > >>> > >>> Note: I am NOT advocating removing the tests as there may be people > still > >>> using TCL and these may be a useful reference for them. > >>> > >>> I wrote a python script to do this investigation. If people think it is > >>> useful, I will clean it up and put it into VTK. The code currently only > >>> looks at Testing/Cxx, Testing/Python, Testing/Tcl in the VTK tree, so > >>> folders below these are not looked at. > >>> > >>> Regards > >>> Andrew > >>> > >>> -- > >>> ___________________________________________ > >>> Andrew J. P. Maclean > >>> > >>> ___________________________________________ > >>> > >>> _______________________________________________ > >>> Powered by www.kitware.com > >>> > >>> Visit other Kitware open-source projects at > >>> http://www.kitware.com/opensource/opensource.html > >>> > >>> Search the list archives at: > http://markmail.org/search/?q=vtk-developers > >>> > >>> Follow this link to subscribe/unsubscribe: > >>> http://public.kitware.com/mailman/listinfo/vtk-developers > >>> > >>> > >> > >> > >> > >> -- > >> William J. Schroeder, PhD > >> Kitware, Inc. > >> 28 Corporate Drive > >> Clifton Park, NY 12065 > >> will.schroeder at kitware.com > >> http://www.kitware.com > >> (518) 881-4902 > >> > >> _______________________________________________ > >> Powered by www.kitware.com > >> > >> Visit other Kitware open-source projects at > >> http://www.kitware.com/opensource/opensource.html > >> > >> Search the list archives at: > http://markmail.org/search/?q=vtk-developers > >> > >> Follow this link to subscribe/unsubscribe: > >> http://public.kitware.com/mailman/listinfo/vtk-developers > >> > >> > > > > > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Search the list archives at: > http://markmail.org/search/?q=vtk-developers > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/vtk-developers > > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Fri May 8 09:46:42 2015 From: berk.geveci at kitware.com (Berk Geveci) Date: Fri, 8 May 2015 09:46:42 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: Message-ID: I believe that we all agree on this - turn off TCL testing for most dashboards but leave the tests around. Someone should port the few remaining tests before we do this though. -berk On Fri, May 8, 2015 at 9:43 AM, Bill Lorensen wrote: > I agree with Dave C. Just turn TCL wrapping off on most platforms. Turn it > on for a couple. > On May 8, 2015 9:21 AM, "David Cole via vtk-developers" < > vtk-developers at vtk.org> wrote: > >> On the other hand, the tests are "not even there" if you simply turn >> off TCL wrapping... So why bother removing them? They're a useful >> reference for those who turn on TCL wrapping. >> >> If TCL wrapping is supported, there should be some tests/examples in TCL. >> >> I would say if you want to get rid of them, get rid of TCL wrapping >> entirely. But if you're not willing to go all the way like that, leave >> the tests for the poor souls stuck using TCL. >> >> Just an alternate opinion to consider. Please don't give it too much >> weight, as I have personally totally been in favor of getting rid of >> TCL entirely since 2005. >> >> >> David C. >> >> >> >> On Fri, May 8, 2015 at 8:51 AM, Berk Geveci >> wrote: >> > Seconded. >> > >> > On Fri, May 8, 2015 at 5:50 AM, Will Schroeder < >> will.schroeder at kitware.com> >> > wrote: >> >> >> >> Nice work Andrew! >> >> >> >> I'm all for eliminating duplicates, especially if it means people can >> test >> >> more and faster, although if we are going to retain Tcl for the long >> haul we >> >> do have to continue to test Tcl language bindings. Personally I have >> not >> >> used Tcl for several years now..... >> >> >> >> W >> >> >> >> On Fri, May 8, 2015 at 2:00 AM, Andrew Maclean < >> andrew.amaclean at gmail.com> >> >> wrote: >> >>> >> >>> Hi All, >> >>> >> >>> Look at this for VTK: >> >>> ---------------------------------------- >> >>> Total number of Cxx tests : 1053 >> >>> Total number of Python tests : 537 >> >>> Total number of TCL tests : 443 >> >>> Total number of tests : 2033 >> >>> ---------------------------------------- >> >>> Tests in TCL but not in Python or Cxx. >> >>> Common/Core/Testing/Tcl >> >>> TestArrays >> >>> TestString >> >>> otherInterp >> >>> otherPrint >> >>> Filters/Core/Testing/Tcl >> >>> probe >> >>> Filters/Sources/Testing/Tcl >> >>> squadViewer >> >>> Rendering/Tk/Testing/Tcl >> >>> TestTextActor3D >> >>> cursor3D >> >>> ---------------------------------------- >> >>> >> >>> Some time ago we spent a lot of time converting the Tcl tests to >> Python >> >>> either automatically or by hand, so now these 8 tests are the only >> ones not >> >>> in Python or TCL. Although Common/Core/Testing/Python/TestStrings.py >> vastly >> >>> extends the TCL version so really there are just 7 tests not tested by >> >>> either Python or Cxx. >> >>> >> >>> Is it time to disable the duplicate 436 TCL tests? >> >>> The advantage here is that it may speed up the testing times and these >> >>> 436 tests are redundant anyway. >> >>> >> >>> Note: I am NOT advocating removing the tests as there may be people >> still >> >>> using TCL and these may be a useful reference for them. >> >>> >> >>> I wrote a python script to do this investigation. If people think it >> is >> >>> useful, I will clean it up and put it into VTK. The code currently >> only >> >>> looks at Testing/Cxx, Testing/Python, Testing/Tcl in the VTK tree, so >> >>> folders below these are not looked at. >> >>> >> >>> Regards >> >>> Andrew >> >>> >> >>> -- >> >>> ___________________________________________ >> >>> Andrew J. P. Maclean >> >>> >> >>> ___________________________________________ >> >>> >> >>> _______________________________________________ >> >>> Powered by www.kitware.com >> >>> >> >>> Visit other Kitware open-source projects at >> >>> http://www.kitware.com/opensource/opensource.html >> >>> >> >>> Search the list archives at: >> http://markmail.org/search/?q=vtk-developers >> >>> >> >>> Follow this link to subscribe/unsubscribe: >> >>> http://public.kitware.com/mailman/listinfo/vtk-developers >> >>> >> >>> >> >> >> >> >> >> >> >> -- >> >> William J. Schroeder, PhD >> >> Kitware, Inc. >> >> 28 Corporate Drive >> >> Clifton Park, NY 12065 >> >> will.schroeder at kitware.com >> >> http://www.kitware.com >> >> (518) 881-4902 >> >> >> >> _______________________________________________ >> >> Powered by www.kitware.com >> >> >> >> Visit other Kitware open-source projects at >> >> http://www.kitware.com/opensource/opensource.html >> >> >> >> Search the list archives at: >> http://markmail.org/search/?q=vtk-developers >> >> >> >> Follow this link to subscribe/unsubscribe: >> >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> >> >> > >> > >> > _______________________________________________ >> > Powered by www.kitware.com >> > >> > Visit other Kitware open-source projects at >> > http://www.kitware.com/opensource/opensource.html >> > >> > Search the list archives at: >> http://markmail.org/search/?q=vtk-developers >> > >> > Follow this link to subscribe/unsubscribe: >> > http://public.kitware.com/mailman/listinfo/vtk-developers >> > >> > >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Fri May 8 09:47:06 2015 From: will.schroeder at kitware.com (Will Schroeder) Date: Fri, 8 May 2015 09:47:06 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: Message-ID: That's okay as long as maintaining these Tcl scripts and associated infrastructure is not an undue burden. After cleaning out my attic this winter I am all for getting rid of junk :-) W On Fri, May 8, 2015 at 9:43 AM, Bill Lorensen wrote: > I agree with Dave C. Just turn TCL wrapping off on most platforms. Turn it > on for a couple. > On May 8, 2015 9:21 AM, "David Cole via vtk-developers" < > vtk-developers at vtk.org> wrote: > >> On the other hand, the tests are "not even there" if you simply turn >> off TCL wrapping... So why bother removing them? They're a useful >> reference for those who turn on TCL wrapping. >> >> If TCL wrapping is supported, there should be some tests/examples in TCL. >> >> I would say if you want to get rid of them, get rid of TCL wrapping >> entirely. But if you're not willing to go all the way like that, leave >> the tests for the poor souls stuck using TCL. >> >> Just an alternate opinion to consider. Please don't give it too much >> weight, as I have personally totally been in favor of getting rid of >> TCL entirely since 2005. >> >> >> David C. >> >> >> >> On Fri, May 8, 2015 at 8:51 AM, Berk Geveci >> wrote: >> > Seconded. >> > >> > On Fri, May 8, 2015 at 5:50 AM, Will Schroeder < >> will.schroeder at kitware.com> >> > wrote: >> >> >> >> Nice work Andrew! >> >> >> >> I'm all for eliminating duplicates, especially if it means people can >> test >> >> more and faster, although if we are going to retain Tcl for the long >> haul we >> >> do have to continue to test Tcl language bindings. Personally I have >> not >> >> used Tcl for several years now..... >> >> >> >> W >> >> >> >> On Fri, May 8, 2015 at 2:00 AM, Andrew Maclean < >> andrew.amaclean at gmail.com> >> >> wrote: >> >>> >> >>> Hi All, >> >>> >> >>> Look at this for VTK: >> >>> ---------------------------------------- >> >>> Total number of Cxx tests : 1053 >> >>> Total number of Python tests : 537 >> >>> Total number of TCL tests : 443 >> >>> Total number of tests : 2033 >> >>> ---------------------------------------- >> >>> Tests in TCL but not in Python or Cxx. >> >>> Common/Core/Testing/Tcl >> >>> TestArrays >> >>> TestString >> >>> otherInterp >> >>> otherPrint >> >>> Filters/Core/Testing/Tcl >> >>> probe >> >>> Filters/Sources/Testing/Tcl >> >>> squadViewer >> >>> Rendering/Tk/Testing/Tcl >> >>> TestTextActor3D >> >>> cursor3D >> >>> ---------------------------------------- >> >>> >> >>> Some time ago we spent a lot of time converting the Tcl tests to >> Python >> >>> either automatically or by hand, so now these 8 tests are the only >> ones not >> >>> in Python or TCL. Although Common/Core/Testing/Python/TestStrings.py >> vastly >> >>> extends the TCL version so really there are just 7 tests not tested by >> >>> either Python or Cxx. >> >>> >> >>> Is it time to disable the duplicate 436 TCL tests? >> >>> The advantage here is that it may speed up the testing times and these >> >>> 436 tests are redundant anyway. >> >>> >> >>> Note: I am NOT advocating removing the tests as there may be people >> still >> >>> using TCL and these may be a useful reference for them. >> >>> >> >>> I wrote a python script to do this investigation. If people think it >> is >> >>> useful, I will clean it up and put it into VTK. The code currently >> only >> >>> looks at Testing/Cxx, Testing/Python, Testing/Tcl in the VTK tree, so >> >>> folders below these are not looked at. >> >>> >> >>> Regards >> >>> Andrew >> >>> >> >>> -- >> >>> ___________________________________________ >> >>> Andrew J. P. Maclean >> >>> >> >>> ___________________________________________ >> >>> >> >>> _______________________________________________ >> >>> Powered by www.kitware.com >> >>> >> >>> Visit other Kitware open-source projects at >> >>> http://www.kitware.com/opensource/opensource.html >> >>> >> >>> Search the list archives at: >> http://markmail.org/search/?q=vtk-developers >> >>> >> >>> Follow this link to subscribe/unsubscribe: >> >>> http://public.kitware.com/mailman/listinfo/vtk-developers >> >>> >> >>> >> >> >> >> >> >> >> >> -- >> >> William J. Schroeder, PhD >> >> Kitware, Inc. >> >> 28 Corporate Drive >> >> Clifton Park, NY 12065 >> >> will.schroeder at kitware.com >> >> http://www.kitware.com >> >> (518) 881-4902 >> >> >> >> _______________________________________________ >> >> Powered by www.kitware.com >> >> >> >> Visit other Kitware open-source projects at >> >> http://www.kitware.com/opensource/opensource.html >> >> >> >> Search the list archives at: >> http://markmail.org/search/?q=vtk-developers >> >> >> >> Follow this link to subscribe/unsubscribe: >> >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> >> >> > >> > >> > _______________________________________________ >> > Powered by www.kitware.com >> > >> > Visit other Kitware open-source projects at >> > http://www.kitware.com/opensource/opensource.html >> > >> > Search the list archives at: >> http://markmail.org/search/?q=vtk-developers >> > >> > Follow this link to subscribe/unsubscribe: >> > http://public.kitware.com/mailman/listinfo/vtk-developers >> > >> > >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> -- William J. Schroeder, PhD Kitware, Inc. 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Fri May 8 09:53:32 2015 From: berk.geveci at kitware.com (Berk Geveci) Date: Fri, 8 May 2015 09:53:32 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: Message-ID: We decided to keep the Tcl wrapping going for a while longer in a separate thread a while ago. It is really not a burden on us to do it, as long as we are not asked to add more features. I expect that this will come up again in a few years and the community may be ready to let go then. -berk On Fri, May 8, 2015 at 9:47 AM, Will Schroeder wrote: > That's okay as long as maintaining these Tcl scripts and associated > infrastructure is not an undue burden. After cleaning out my attic this > winter I am all for getting rid of junk :-) > > W > > On Fri, May 8, 2015 at 9:43 AM, Bill Lorensen > wrote: > >> I agree with Dave C. Just turn TCL wrapping off on most platforms. Turn >> it on for a couple. >> On May 8, 2015 9:21 AM, "David Cole via vtk-developers" < >> vtk-developers at vtk.org> wrote: >> >>> On the other hand, the tests are "not even there" if you simply turn >>> off TCL wrapping... So why bother removing them? They're a useful >>> reference for those who turn on TCL wrapping. >>> >>> If TCL wrapping is supported, there should be some tests/examples in TCL. >>> >>> I would say if you want to get rid of them, get rid of TCL wrapping >>> entirely. But if you're not willing to go all the way like that, leave >>> the tests for the poor souls stuck using TCL. >>> >>> Just an alternate opinion to consider. Please don't give it too much >>> weight, as I have personally totally been in favor of getting rid of >>> TCL entirely since 2005. >>> >>> >>> David C. >>> >>> >>> >>> On Fri, May 8, 2015 at 8:51 AM, Berk Geveci >>> wrote: >>> > Seconded. >>> > >>> > On Fri, May 8, 2015 at 5:50 AM, Will Schroeder < >>> will.schroeder at kitware.com> >>> > wrote: >>> >> >>> >> Nice work Andrew! >>> >> >>> >> I'm all for eliminating duplicates, especially if it means people can >>> test >>> >> more and faster, although if we are going to retain Tcl for the long >>> haul we >>> >> do have to continue to test Tcl language bindings. Personally I have >>> not >>> >> used Tcl for several years now..... >>> >> >>> >> W >>> >> >>> >> On Fri, May 8, 2015 at 2:00 AM, Andrew Maclean < >>> andrew.amaclean at gmail.com> >>> >> wrote: >>> >>> >>> >>> Hi All, >>> >>> >>> >>> Look at this for VTK: >>> >>> ---------------------------------------- >>> >>> Total number of Cxx tests : 1053 >>> >>> Total number of Python tests : 537 >>> >>> Total number of TCL tests : 443 >>> >>> Total number of tests : 2033 >>> >>> ---------------------------------------- >>> >>> Tests in TCL but not in Python or Cxx. >>> >>> Common/Core/Testing/Tcl >>> >>> TestArrays >>> >>> TestString >>> >>> otherInterp >>> >>> otherPrint >>> >>> Filters/Core/Testing/Tcl >>> >>> probe >>> >>> Filters/Sources/Testing/Tcl >>> >>> squadViewer >>> >>> Rendering/Tk/Testing/Tcl >>> >>> TestTextActor3D >>> >>> cursor3D >>> >>> ---------------------------------------- >>> >>> >>> >>> Some time ago we spent a lot of time converting the Tcl tests to >>> Python >>> >>> either automatically or by hand, so now these 8 tests are the only >>> ones not >>> >>> in Python or TCL. Although Common/Core/Testing/Python/TestStrings.py >>> vastly >>> >>> extends the TCL version so really there are just 7 tests not tested >>> by >>> >>> either Python or Cxx. >>> >>> >>> >>> Is it time to disable the duplicate 436 TCL tests? >>> >>> The advantage here is that it may speed up the testing times and >>> these >>> >>> 436 tests are redundant anyway. >>> >>> >>> >>> Note: I am NOT advocating removing the tests as there may be people >>> still >>> >>> using TCL and these may be a useful reference for them. >>> >>> >>> >>> I wrote a python script to do this investigation. If people think it >>> is >>> >>> useful, I will clean it up and put it into VTK. The code currently >>> only >>> >>> looks at Testing/Cxx, Testing/Python, Testing/Tcl in the VTK tree, so >>> >>> folders below these are not looked at. >>> >>> >>> >>> Regards >>> >>> Andrew >>> >>> >>> >>> -- >>> >>> ___________________________________________ >>> >>> Andrew J. P. Maclean >>> >>> >>> >>> ___________________________________________ >>> >>> >>> >>> _______________________________________________ >>> >>> Powered by www.kitware.com >>> >>> >>> >>> Visit other Kitware open-source projects at >>> >>> http://www.kitware.com/opensource/opensource.html >>> >>> >>> >>> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >>> >>> >>> Follow this link to subscribe/unsubscribe: >>> >>> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >>> >>> >>> >> >>> >> >>> >> >>> >> -- >>> >> William J. Schroeder, PhD >>> >> Kitware, Inc. >>> >> 28 Corporate Drive >>> >> Clifton Park, NY 12065 >>> >> will.schroeder at kitware.com >>> >> http://www.kitware.com >>> >> (518) 881-4902 >>> >> >>> >> _______________________________________________ >>> >> Powered by www.kitware.com >>> >> >>> >> Visit other Kitware open-source projects at >>> >> http://www.kitware.com/opensource/opensource.html >>> >> >>> >> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >> >>> >> Follow this link to subscribe/unsubscribe: >>> >> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >> >>> >> >>> > >>> > >>> > _______________________________________________ >>> > Powered by www.kitware.com >>> > >>> > Visit other Kitware open-source projects at >>> > http://www.kitware.com/opensource/opensource.html >>> > >>> > Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> > >>> > Follow this link to subscribe/unsubscribe: >>> > http://public.kitware.com/mailman/listinfo/vtk-developers >>> > >>> > >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> > > > -- > William J. Schroeder, PhD > Kitware, Inc. > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Fri May 8 09:56:25 2015 From: ken.martin at kitware.com (Ken Martin) Date: Fri, 8 May 2015 09:56:25 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: Message-ID: <38b4c57b0b93f2a557d36954b3ac165a@mail.gmail.com> *** Cough *** Re: [vtk-developers] Tcl wrapping and output array arguments :-) Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 ken.martin at kitware.com 518 881-4901 (w) 518 371-4573 (f) This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. *From:* vtk-developers [mailto:vtk-developers-bounces at vtk.org] *On Behalf Of *Berk Geveci *Sent:* Friday, May 8, 2015 9:54 AM *To:* Will Schroeder *Cc:* Andrew Maclean; VTK Developers *Subject:* Re: [vtk-developers] An interesting statistic about VTK We decided to keep the Tcl wrapping going for a while longer in a separate thread a while ago. It is really not a burden on us to do it, as long as we are not asked to add more features. I expect that this will come up again in a few years and the community may be ready to let go then. -berk On Fri, May 8, 2015 at 9:47 AM, Will Schroeder wrote: That's okay as long as maintaining these Tcl scripts and associated infrastructure is not an undue burden. After cleaning out my attic this winter I am all for getting rid of junk :-) W On Fri, May 8, 2015 at 9:43 AM, Bill Lorensen wrote: I agree with Dave C. Just turn TCL wrapping off on most platforms. Turn it on for a couple. On May 8, 2015 9:21 AM, "David Cole via vtk-developers" < vtk-developers at vtk.org> wrote: On the other hand, the tests are "not even there" if you simply turn off TCL wrapping... So why bother removing them? They're a useful reference for those who turn on TCL wrapping. If TCL wrapping is supported, there should be some tests/examples in TCL. I would say if you want to get rid of them, get rid of TCL wrapping entirely. But if you're not willing to go all the way like that, leave the tests for the poor souls stuck using TCL. Just an alternate opinion to consider. Please don't give it too much weight, as I have personally totally been in favor of getting rid of TCL entirely since 2005. David C. On Fri, May 8, 2015 at 8:51 AM, Berk Geveci wrote: > Seconded. > > On Fri, May 8, 2015 at 5:50 AM, Will Schroeder > wrote: >> >> Nice work Andrew! >> >> I'm all for eliminating duplicates, especially if it means people can test >> more and faster, although if we are going to retain Tcl for the long haul we >> do have to continue to test Tcl language bindings. Personally I have not >> used Tcl for several years now..... >> >> W >> >> On Fri, May 8, 2015 at 2:00 AM, Andrew Maclean >> wrote: >>> >>> Hi All, >>> >>> Look at this for VTK: >>> ---------------------------------------- >>> Total number of Cxx tests : 1053 >>> Total number of Python tests : 537 >>> Total number of TCL tests : 443 >>> Total number of tests : 2033 >>> ---------------------------------------- >>> Tests in TCL but not in Python or Cxx. >>> Common/Core/Testing/Tcl >>> TestArrays >>> TestString >>> otherInterp >>> otherPrint >>> Filters/Core/Testing/Tcl >>> probe >>> Filters/Sources/Testing/Tcl >>> squadViewer >>> Rendering/Tk/Testing/Tcl >>> TestTextActor3D >>> cursor3D >>> ---------------------------------------- >>> >>> Some time ago we spent a lot of time converting the Tcl tests to Python >>> either automatically or by hand, so now these 8 tests are the only ones not >>> in Python or TCL. Although Common/Core/Testing/Python/TestStrings.py vastly >>> extends the TCL version so really there are just 7 tests not tested by >>> either Python or Cxx. >>> >>> Is it time to disable the duplicate 436 TCL tests? >>> The advantage here is that it may speed up the testing times and these >>> 436 tests are redundant anyway. >>> >>> Note: I am NOT advocating removing the tests as there may be people still >>> using TCL and these may be a useful reference for them. >>> >>> I wrote a python script to do this investigation. If people think it is >>> useful, I will clean it up and put it into VTK. The code currently only >>> looks at Testing/Cxx, Testing/Python, Testing/Tcl in the VTK tree, so >>> folders below these are not looked at. >>> >>> Regards >>> Andrew >>> >>> -- >>> ___________________________________________ >>> Andrew J. P. Maclean >>> >>> ___________________________________________ >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >> >> >> >> -- >> William J. Schroeder, PhD >> Kitware, Inc. >> 28 Corporate Drive >> Clifton Park, NY 12065 >> will.schroeder at kitware.com >> http://www.kitware.com >> (518) 881-4902 >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Search the list archives at: http://markmail.org/search/?q=vtk-developers Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/vtk-developers -- William J. Schroeder, PhD Kitware, Inc. 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From sz.zwolan at gmail.com Fri May 8 10:04:27 2015 From: sz.zwolan at gmail.com (Szymek_10) Date: Fri, 8 May 2015 07:04:27 -0700 (MST) Subject: [vtk-developers] CMake 3.2.2 + VTK 6.2 + VS 2013 - missing USE_VTK_Rendering In-Reply-To: References: <1431066120109-5731824.post@n5.nabble.com> Message-ID: <1431093867626-5731839.post@n5.nabble.com> VTK_GROUP_RENDERING was selected automaticly. Should I unselect this? -- View this message in context: http://vtk.1045678.n5.nabble.com/CMake-3-2-2-VTK-6-2-VS-2013-missing-USE-VTK-Rendering-tp5731824p5731839.html Sent from the VTK - Dev mailing list archive at Nabble.com. From robert.maynard at kitware.com Fri May 8 10:19:49 2015 From: robert.maynard at kitware.com (Robert Maynard) Date: Fri, 8 May 2015 10:19:49 -0400 Subject: [vtk-developers] CMake 3.2.2 + VTK 6.2 + VS 2013 - missing USE_VTK_Rendering In-Reply-To: <1431093867626-5731839.post@n5.nabble.com> References: <1431066120109-5731824.post@n5.nabble.com> <1431093867626-5731839.post@n5.nabble.com> Message-ID: You need to keep is selected. The real issue is that the library names between VTK 5 and 6 have changed. You should read the full build migration guide at: http://www.vtk.org/Wiki/VTK/Build_System_Migration But I believe the following should work for you: project(ImageProcessing) find_package(VTK REQUIRED NO_MODULE) include(${VTK_USE_FILE}) add_executable(ImageSlicing ImageSlicing.cxx) target_link_libraries(ImageSlicing ${VTK_LIBRARIES}) On Fri, May 8, 2015 at 10:04 AM, Szymek_10 wrote: > VTK_GROUP_RENDERING was selected automaticly. Should I unselect this? > > > > -- > View this message in context: > http://vtk.1045678.n5.nabble.com/CMake-3-2-2-VTK-6-2-VS-2013-missing-USE-VTK-Rendering-tp5731824p5731839.html > Sent from the VTK - Dev mailing list archive at Nabble.com. > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From marcus.hanwell at kitware.com Fri May 8 10:36:58 2015 From: marcus.hanwell at kitware.com (Marcus D. Hanwell) Date: Fri, 8 May 2015 10:36:58 -0400 Subject: [vtk-developers] New journal article about rendering improvements in VTK Message-ID: Hi, I would like to draw your attention to our open access (CC-BY) article about rendering improvements in the Visualization Toolkit in a new open access journal called SoftwareX. We are among the first publications, and we are pleased to see more journals working to highlight the importance of reusable, open source software in scientific research.? http://dx.doi.org/10.1016/j.softx.2015.04.001 The corrected proof is now available, it discusses some of the OpenGL2 rendering improvements present in VTK 6.2. As noted in the acknowledgements this work was supported by the NIH VTK maintenance grant. Thanks, Marcus -------------- next part -------------- An HTML attachment was scrubbed... URL: From ben.boeckel at kitware.com Fri May 8 10:49:12 2015 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Fri, 8 May 2015 10:49:12 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: Message-ID: <20150508144912.GA28235@megas.kitware.com> On Fri, May 08, 2015 at 09:46:42 -0400, Berk Geveci wrote: > I believe that we all agree on this - turn off TCL testing for most > dashboards but leave the tests around. Someone should port the few > remaining tests before we do this though. The only buildbot using Tcl is hythloth which is currently 'experimental' due to test timeouts. --Ben From sean at rogue-research.com Fri May 8 10:56:40 2015 From: sean at rogue-research.com (Sean McBride) Date: Fri, 8 May 2015 10:56:40 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: <20150508144912.GA28235@megas.kitware.com> References: <20150508144912.GA28235@megas.kitware.com> Message-ID: <20150508145641.1638151866@mail.rogue-research.com> On Fri, 8 May 2015 10:49:12 -0400, Ben Boeckel said: >On Fri, May 08, 2015 at 09:46:42 -0400, Berk Geveci wrote: >> I believe that we all agree on this - turn off TCL testing for most >> dashboards but leave the tests around. Someone should port the few >> remaining tests before we do this though. > >The only buildbot using Tcl is hythloth which is currently >'experimental' due to test timeouts. VTK_WRAP_TCL is 'on' for most of my dashboards. But I'm happy to turn it off. Might be able to squeeze in other build variations instead. Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From berk.geveci at kitware.com Fri May 8 12:03:28 2015 From: berk.geveci at kitware.com (Berk Geveci) Date: Fri, 8 May 2015 12:03:28 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: <20150508145641.1638151866@mail.rogue-research.com> References: <20150508144912.GA28235@megas.kitware.com> <20150508145641.1638151866@mail.rogue-research.com> Message-ID: Hi Sean, If you can leave it on on one of the dashboards, that should be good. -berk On Fri, May 8, 2015 at 10:56 AM, Sean McBride wrote: > On Fri, 8 May 2015 10:49:12 -0400, Ben Boeckel said: > > >On Fri, May 08, 2015 at 09:46:42 -0400, Berk Geveci wrote: > >> I believe that we all agree on this - turn off TCL testing for most > >> dashboards but leave the tests around. Someone should port the few > >> remaining tests before we do this though. > > > >The only buildbot using Tcl is hythloth which is currently > >'experimental' due to test timeouts. > > VTK_WRAP_TCL is 'on' for most of my dashboards. But I'm happy to turn it > off. Might be able to squeeze in other build variations instead. > > Cheers, > > -- > ____________________________________________________________ > Sean McBride, B. Eng sean at rogue-research.com > Rogue Research www.rogue-research.com > Mac Software Developer Montr?al, Qu?bec, Canada > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Fri May 8 12:23:14 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 8 May 2015 12:23:14 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: <20150508144912.GA28235@megas.kitware.com> <20150508145641.1638151866@mail.rogue-research.com> Message-ID: It would be great if python wrapping were turned on for the valgrind machine: karego-at.kitware Ubuntu-Valgrind Currently that machine does not have tcl not python turned on. On Fri, May 8, 2015 at 12:03 PM, Berk Geveci wrote: > Hi Sean, > > If you can leave it on on one of the dashboards, that should be good. > > -berk > > On Fri, May 8, 2015 at 10:56 AM, Sean McBride > wrote: >> >> On Fri, 8 May 2015 10:49:12 -0400, Ben Boeckel said: >> >> >On Fri, May 08, 2015 at 09:46:42 -0400, Berk Geveci wrote: >> >> I believe that we all agree on this - turn off TCL testing for most >> >> dashboards but leave the tests around. Someone should port the few >> >> remaining tests before we do this though. >> > >> >The only buildbot using Tcl is hythloth which is currently >> >'experimental' due to test timeouts. >> >> VTK_WRAP_TCL is 'on' for most of my dashboards. But I'm happy to turn it >> off. Might be able to squeeze in other build variations instead. >> >> Cheers, >> >> -- >> ____________________________________________________________ >> Sean McBride, B. Eng sean at rogue-research.com >> Rogue Research www.rogue-research.com >> Mac Software Developer Montr?al, Qu?bec, Canada >> >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- Unpaid intern in BillsBasement at noware dot com From dave.demarle at kitware.com Fri May 8 12:59:34 2015 From: dave.demarle at kitware.com (David E DeMarle) Date: Fri, 8 May 2015 12:59:34 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: <20150508144912.GA28235@megas.kitware.com> <20150508145641.1638151866@mail.rogue-research.com> Message-ID: Agreed, but we'll have to set up some newer machine to turn more valgrind tests on. karego-at is running on an old mac-mini which doesn't have the oomph to run much through valgrind and complete over night. When we do set it up, $VTKSRC/Utilities/Maintenance/parse_valgrind.py will be important. David E DeMarle Kitware, Inc. R&D Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4909 On Fri, May 8, 2015 at 12:23 PM, Bill Lorensen wrote: > It would be great if python wrapping were turned on for the valgrind > machine: > karego-at.kitware Ubuntu-Valgrind > > Currently that machine does not have tcl not python turned on. > > > On Fri, May 8, 2015 at 12:03 PM, Berk Geveci > wrote: > > Hi Sean, > > > > If you can leave it on on one of the dashboards, that should be good. > > > > -berk > > > > On Fri, May 8, 2015 at 10:56 AM, Sean McBride > > wrote: > >> > >> On Fri, 8 May 2015 10:49:12 -0400, Ben Boeckel said: > >> > >> >On Fri, May 08, 2015 at 09:46:42 -0400, Berk Geveci wrote: > >> >> I believe that we all agree on this - turn off TCL testing for most > >> >> dashboards but leave the tests around. Someone should port the few > >> >> remaining tests before we do this though. > >> > > >> >The only buildbot using Tcl is hythloth which is currently > >> >'experimental' due to test timeouts. > >> > >> VTK_WRAP_TCL is 'on' for most of my dashboards. But I'm happy to turn > it > >> off. Might be able to squeeze in other build variations instead. > >> > >> Cheers, > >> > >> -- > >> ____________________________________________________________ > >> Sean McBride, B. Eng sean at rogue-research.com > >> Rogue Research www.rogue-research.com > >> Mac Software Developer Montr?al, Qu?bec, Canada > >> > >> > > > > > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Search the list archives at: > http://markmail.org/search/?q=vtk-developers > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/vtk-developers > > > > > > > > -- > Unpaid intern in BillsBasement at noware dot com > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From sz.zwolan at gmail.com Sat May 9 06:34:02 2015 From: sz.zwolan at gmail.com (Szymek_10) Date: Sat, 9 May 2015 03:34:02 -0700 (MST) Subject: [vtk-developers] CMake 3.2.2 + VTK 6.2 + VS 2013 - missing USE_VTK_Rendering In-Reply-To: References: <1431066120109-5731824.post@n5.nabble.com> <1431093867626-5731839.post@n5.nabble.com> Message-ID: <1431167642360-5731857.post@n5.nabble.com> It works! Thank you! So assume: VTK greater or equal than 6.0 version should use this CMakeFile.txt : cmake_minimum_required(VERSION 2.8.5 FATAL_ERROR) project(ImageProcessing) find_package(VTK REQUIRED NO_MODULE) include(${VTK_USE_FILE}) add_executable(ImageSlicing ImageSlicing.cxx) target_link_libraries(ImageSlicing ${VTK_LIBRARIES}) -- View this message in context: http://vtk.1045678.n5.nabble.com/CMake-3-2-2-VTK-6-2-VS-2013-missing-USE-VTK-Rendering-tp5731824p5731857.html Sent from the VTK - Dev mailing list archive at Nabble.com. From andrew.amaclean at gmail.com Sun May 10 03:07:22 2015 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Sun, 10 May 2015 17:07:22 +1000 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: <20150508144912.GA28235@megas.kitware.com> <20150508145641.1638151866@mail.rogue-research.com> Message-ID: Ken, I hadn't forgotten that discussion but this is the first time we have had hard evidence regarding the test coverage by type(Cxx, Python, TCL). Following on ... since I volunteered to convert TestSetGet and TestEmptyInput, I'm happy to continue converting these. These will require conversion by hand: Common/Core/Testing/Tcl TestArrays TestString otherInterp otherPrint TestString.tcl is superseded by TestStrings.py, so no point converting. This one easily converted using tcl2py.py (I don't know why it was missed): Filters/Core/Testing/Tcl probe These require Tk: Filters/Sources/Testing/Tcl squadViewer Rendering/Tk/Testing/Tcl TestTextActor3D cursor3D Are there any plans to support Tk under OpenGL2? Currently it requires OpenGL, If there are no plans then it is not worth converting these. Andrew On Sat, May 9, 2015 at 2:59 AM, David E DeMarle wrote: > Agreed, but we'll have to set up some newer machine to turn more valgrind > tests on. > > karego-at is running on an old mac-mini which doesn't have the oomph to > run much through valgrind and complete over night. > > When we do set it up, $VTKSRC/Utilities/Maintenance/parse_valgrind.py will > be important. > > > David E DeMarle > Kitware, Inc. > R&D Engineer > 21 Corporate Drive > Clifton Park, NY 12065-8662 > Phone: 518-881-4909 > > On Fri, May 8, 2015 at 12:23 PM, Bill Lorensen > wrote: > >> It would be great if python wrapping were turned on for the valgrind >> machine: >> karego-at.kitware Ubuntu-Valgrind >> >> Currently that machine does not have tcl not python turned on. >> >> >> On Fri, May 8, 2015 at 12:03 PM, Berk Geveci >> wrote: >> > Hi Sean, >> > >> > If you can leave it on on one of the dashboards, that should be good. >> > >> > -berk >> > >> > On Fri, May 8, 2015 at 10:56 AM, Sean McBride >> > wrote: >> >> >> >> On Fri, 8 May 2015 10:49:12 -0400, Ben Boeckel said: >> >> >> >> >On Fri, May 08, 2015 at 09:46:42 -0400, Berk Geveci wrote: >> >> >> I believe that we all agree on this - turn off TCL testing for most >> >> >> dashboards but leave the tests around. Someone should port the few >> >> >> remaining tests before we do this though. >> >> > >> >> >The only buildbot using Tcl is hythloth which is currently >> >> >'experimental' due to test timeouts. >> >> >> >> VTK_WRAP_TCL is 'on' for most of my dashboards. But I'm happy to turn >> it >> >> off. Might be able to squeeze in other build variations instead. >> >> >> >> Cheers, >> >> >> >> -- >> >> ____________________________________________________________ >> >> Sean McBride, B. Eng sean at rogue-research.com >> >> Rogue Research www.rogue-research.com >> >> Mac Software Developer Montr?al, Qu?bec, Canada >> >> >> >> >> > >> > >> > _______________________________________________ >> > Powered by www.kitware.com >> > >> > Visit other Kitware open-source projects at >> > http://www.kitware.com/opensource/opensource.html >> > >> > Search the list archives at: >> http://markmail.org/search/?q=vtk-developers >> > >> > Follow this link to subscribe/unsubscribe: >> > http://public.kitware.com/mailman/listinfo/vtk-developers >> > >> > >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From applekey at gmail.com Sun May 10 10:52:02 2015 From: applekey at gmail.com (Vincent Chen) Date: Sun, 10 May 2015 10:52:02 -0400 Subject: [vtk-developers] GSoC project: Shared Memory Parallelism in VTK Message-ID: Hey Guys! My name is Vincent Chen and my Google Summer of Code project is on Shared Memory Parallelism in VTK. I am currently an employee at Oracle and will continue onto a masters and hopefully Phd at the University of Oregon. I would like to consider my major computer graphics. In the past, I researched 3D scanning techniques as well as designed 3D scanned and printed prosthetic sockets for Africa. During this Google Summer of Code Project, I would like to upgrade current VTK filters to operate more efficiently with many core processors. This will involve re working current threading implementations as well as re designing data structures. The end product will be filters that have much better scaling for consumer grade Cpu's up to Intel Xeon Phis. You can find a copy of my proposal here at https://docs.google.com/document/d/1rNKOk_SnyvprvS6lp98myBK6jHqmZ_h7oilA1Kto20M/edit?usp=sharing I look forward to working with you all this summer! If you have any further questions or suggestions please don't hesitate to email me. Best Regards, Vincent Chen -------------- next part -------------- An HTML attachment was scrubbed... URL: From max.sagebaum at scicomp.uni-kl.de Mon May 11 04:22:45 2015 From: max.sagebaum at scicomp.uni-kl.de (Max Sagebaum) Date: Mon, 11 May 2015 08:22:45 +0000 Subject: [vtk-developers] Changing floating point Types in VTK In-Reply-To: <1429513478.7444.5.camel@localhost> References: <1429513478.7444.5.camel@localhost> Message-ID: <1431332565.2896.5.camel@localhost> Dear developers, we had asked for your opinions about a typedef for the floating point types in vtk and if we make this change if it would be accepted. Until now we have received no answer. We would appreciate it, if we could get some insights about the acceptance of the changes we want to make. Best regards, Max Sagebaum On Mon, 2015-04-20 at 09:04 +0200, Max Sagebaum wrote: > Dear developers, > we are currently using parts of the VTK Version 5.10 for our CFD > Postprocessing Tool. We have successfully modified theses parts to > facilitate an AD-Tool (Algorithmic Differentiation) to differentiate > these code parts (intention is to not just get absolute values for our > CFD-results, but also evaluate sensitivities/gradients). Caused by > further developments in our tool we would like to go with newer > VTK-Versions, which means repeating the changes in the code parts > facilitating AD. We would like to implement these changes into the > VTK-trunk, to avoid reprogramming and to offer the possibility of using > AD to everyone. We would like to explain the changes in short and ask > you to judge if such changes are likely to be accepted or if there is an > interest in making VTK ?AD-able?. If not, we would avoid the presumably > laborious implementation and would not put it into the Git/Develop loop. > > There are two main changes we had to make. To get the gradients of a > program, the AD-Tool defines new AD floating point types which take care > of the derivative computation. In order to use these AD types in VTK we > needed to create two typedefs for float and double. Then every usage of > float and double in VTK was replaced by the new typedefs. With this > change, it is also possible to other types in VTK. E.g. complex values. > > The second change we made, was to rename every 'static_cast' call to a > new function 'perform_cast'. Basically 'perfom_cast' just calls > 'static_cast'. If you use other types than float or double 'static_cast' > will complain that the conversion from eg. 'MyFloatType' to 'int' does > not exist. 'perfom_cast' was specialized for the AD types and therefore > the casts could be done. During this process we checked most of the > occurrences of 'static_cast' and validated that the usage will not break > the differentiation. > There are two other solutions to our approach. We could implement > conversion operators for the AD types, which enables 'static_cast' to do > the conversion. But this is mostly discouraged by the tool developers. > If the conversion operators are implemented, the compiler starts to > implicit convert the AD types and very weird things can happen. > The second approach would define these operators as explicit which would > prevent the compiler from implicitly converting them. But then VTK would > need to be compiled with C++11 enabled or if the user changes these > types he also has to enable C++11 if necessary. > > Is the any interest on the developers or users side to use VTK with AD > or other floating point types? > Thanks for your opinions and judgment! > > Max Sagebaum > -- Max Sagebaum Chair for Scientific Computing, TU Kaiserslautern, Bldg/Geb 34, Paul-Ehrlich-Strasse, 67663 Kaiserslautern, Germany Phone: +49 (0)631 205 5638 Fax: +49 (0)631 205 3056 Email: max.sagebaum at scicomp.uni-kl.de URL: www.scicomp.uni-kl.de From ken.martin at kitware.com Mon May 11 10:40:26 2015 From: ken.martin at kitware.com (Ken Martin) Date: Mon, 11 May 2015 10:40:26 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: <20150508144912.GA28235@megas.kitware.com> <20150508145641.1638151866@mail.rogue-research.com> Message-ID: <1b05d3951b1ebf99b0a63f1864e1eb2b@mail.gmail.com> First off this is great Andrew that you are adding these tests to Python. I always felt like I **HAD** to test with Tcl because of these missing tests in Python and now I feel much better about not having to build Tcl. WRT Tk ... uh ... well ... I forgot there was a Tk directory. I mean seriously, it is only two letters. I just pushed a topic to provide better support for it. It seems to build and the TkTcl-cursor3D test runs. It looks like the squadViewer test is gimped because it looks for VTK_USE_RENDERING which maybe is no longer set? But I tested the script and it seems to work and is pretty mesmerizing -- three sliders o? fun. Thanks Ken Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 ken.martin at kitware.com 518 881-4901 (w) 518 371-4573 (f) This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. *From:* vtk-developers [mailto:vtk-developers-bounces at vtk.org] *On Behalf Of *Andrew Maclean *Sent:* Sunday, May 10, 2015 3:07 AM *To:* David E DeMarle *Cc:* VTK Developers; Berk Geveci; Will Schroeder *Subject:* Re: [vtk-developers] An interesting statistic about VTK Ken, I hadn't forgotten that discussion but this is the first time we have had hard evidence regarding the test coverage by type(Cxx, Python, TCL). Following on ... since I volunteered to convert TestSetGet and TestEmptyInput, I'm happy to continue converting these. These will require conversion by hand: Common/Core/Testing/Tcl TestArrays TestString otherInterp otherPrint TestString.tcl is superseded by TestStrings.py, so no point converting. This one easily converted using tcl2py.py (I don't know why it was missed): Filters/Core/Testing/Tcl probe These require Tk: Filters/Sources/Testing/Tcl squadViewer Rendering/Tk/Testing/Tcl TestTextActor3D cursor3D Are there any plans to support Tk under OpenGL2? Currently it requires OpenGL, If there are no plans then it is not worth converting these. Andrew On Sat, May 9, 2015 at 2:59 AM, David E DeMarle wrote: Agreed, but we'll have to set up some newer machine to turn more valgrind tests on. karego-at is running on an old mac-mini which doesn't have the oomph to run much through valgrind and complete over night. When we do set it up, $VTKSRC/Utilities/Maintenance/parse_valgrind.py will be important. David E DeMarle Kitware, Inc. R&D Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4909 On Fri, May 8, 2015 at 12:23 PM, Bill Lorensen wrote: It would be great if python wrapping were turned on for the valgrind machine: karego-at.kitware Ubuntu-Valgrind Currently that machine does not have tcl not python turned on. On Fri, May 8, 2015 at 12:03 PM, Berk Geveci wrote: > Hi Sean, > > If you can leave it on on one of the dashboards, that should be good. > > -berk > > On Fri, May 8, 2015 at 10:56 AM, Sean McBride > wrote: >> >> On Fri, 8 May 2015 10:49:12 -0400, Ben Boeckel said: >> >> >On Fri, May 08, 2015 at 09:46:42 -0400, Berk Geveci wrote: >> >> I believe that we all agree on this - turn off TCL testing for most >> >> dashboards but leave the tests around. Someone should port the few >> >> remaining tests before we do this though. >> > >> >The only buildbot using Tcl is hythloth which is currently >> >'experimental' due to test timeouts. >> >> VTK_WRAP_TCL is 'on' for most of my dashboards. But I'm happy to turn it >> off. Might be able to squeeze in other build variations instead. >> >> Cheers, >> >> -- >> ____________________________________________________________ >> Sean McBride, B. Eng sean at rogue-research.com >> Rogue Research www.rogue-research.com >> Mac Software Developer Montr?al, Qu?bec, Canada >> >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- Unpaid intern in BillsBasement at noware dot com _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Search the list archives at: http://markmail.org/search/?q=vtk-developers Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/vtk-developers -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From mhalle at bwh.harvard.edu Mon May 11 12:28:39 2015 From: mhalle at bwh.harvard.edu (Michael Halle) Date: Mon, 11 May 2015 12:28:39 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: Message-ID: <5550D8B7.10205@bwh.harvard.edu> Wow, if memory serves correctly I wrote squadViewer back in the day where "tests" were the best place for "examples"; it really wasn't designed at a non-interactive test. Was a simpler time, then. Three sliders of fun, indeed! --Mike The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail. From andrew.amaclean at gmail.com Mon May 11 19:30:47 2015 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Tue, 12 May 2015 09:30:47 +1000 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: <1b05d3951b1ebf99b0a63f1864e1eb2b@mail.gmail.com> References: <20150508144912.GA28235@megas.kitware.com> <20150508145641.1638151866@mail.rogue-research.com> <1b05d3951b1ebf99b0a63f1864e1eb2b@mail.gmail.com> Message-ID: Hi Ken, I am sure you can safely delete the "if (VTK_USE_RENDERING)" guard in Filters/Sources/Testing/Tcl the variable is no longer used in VTK 6.x as far as I know. If you add this change to https://gitlab.kitware.com/vtk/vtk/merge_requests/191 I'm happy to give it a +2. squadViewer.tcl is pretty neat! I converted: Common/Core/Testing/Tcl/TestArrays Filters/Core/Testing/Tcl/probe These two just test Tcl specific functions so there is no point converting: Common/Core/Testing/Tcl otherInterp otherPrint I'll have a go at converting the Tk ones to Python once you do a merge. Regards Andrew On Tue, May 12, 2015 at 12:40 AM, Ken Martin wrote: > First off this is great Andrew that you are adding these tests to Python. > I always felt like I **HAD** to test with Tcl because of these missing > tests in Python and now I feel much better about not having to build Tcl. > > > > WRT Tk ... uh ... well ... I forgot there was a Tk directory. I mean > seriously, it is only two letters. I just pushed a topic to provide better > support for it. It seems to build and the TkTcl-cursor3D test runs. It > looks like the squadViewer test is gimped because it looks for > VTK_USE_RENDERING which maybe is no longer set? But I tested the script and > it seems to work and is pretty mesmerizing -- three sliders o? fun. > > > > Thanks > > Ken > > > > Ken Martin PhD > > Chairman & CFO > > Kitware Inc. > > 28 Corporate Drive > > Clifton Park NY 12065 > > ken.martin at kitware.com > > 518 881-4901 (w) > > 518 371-4573 (f) > > > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > > > > *From:* vtk-developers [mailto:vtk-developers-bounces at vtk.org] *On Behalf > Of *Andrew Maclean > *Sent:* Sunday, May 10, 2015 3:07 AM > *To:* David E DeMarle > *Cc:* VTK Developers; Berk Geveci; Will Schroeder > *Subject:* Re: [vtk-developers] An interesting statistic about VTK > > > > Ken, I hadn't forgotten that discussion but this is the first time we have > had hard evidence regarding the test coverage by type(Cxx, Python, TCL). > > > > Following on ... since I volunteered to convert TestSetGet and > TestEmptyInput, I'm happy to continue converting these. > > > > These will require conversion by hand: > > Common/Core/Testing/Tcl > > TestArrays > > TestString > > otherInterp > > otherPrint > > > > TestString.tcl is superseded by TestStrings.py, so no point converting. > > > > This one easily converted using tcl2py.py (I don't know why it was missed): > > Filters/Core/Testing/Tcl > > probe > > > > These require Tk: > > Filters/Sources/Testing/Tcl > > squadViewer > > Rendering/Tk/Testing/Tcl > > TestTextActor3D > > cursor3D > > > > Are there any plans to support Tk under OpenGL2? > > Currently it requires OpenGL, If there are no plans then it is not worth > converting these. > > > > > > Andrew > > > > > > On Sat, May 9, 2015 at 2:59 AM, David E DeMarle > wrote: > > Agreed, but we'll have to set up some newer machine to turn more valgrind > tests on. > > > > karego-at is running on an old mac-mini which doesn't have the oomph to > run much through valgrind and complete over night. > > > > When we do set it up, $VTKSRC/Utilities/Maintenance/parse_valgrind.py will > be important. > > > > > David E DeMarle > Kitware, Inc. > R&D Engineer > 21 Corporate Drive > Clifton Park, NY 12065-8662 > Phone: 518-881-4909 > > > > On Fri, May 8, 2015 at 12:23 PM, Bill Lorensen > wrote: > > It would be great if python wrapping were turned on for the valgrind > machine: > karego-at.kitware Ubuntu-Valgrind > > Currently that machine does not have tcl not python turned on. > > > > On Fri, May 8, 2015 at 12:03 PM, Berk Geveci > wrote: > > Hi Sean, > > > > If you can leave it on on one of the dashboards, that should be good. > > > > -berk > > > > On Fri, May 8, 2015 at 10:56 AM, Sean McBride > > wrote: > >> > >> On Fri, 8 May 2015 10:49:12 -0400, Ben Boeckel said: > >> > >> >On Fri, May 08, 2015 at 09:46:42 -0400, Berk Geveci wrote: > >> >> I believe that we all agree on this - turn off TCL testing for most > >> >> dashboards but leave the tests around. Someone should port the few > >> >> remaining tests before we do this though. > >> > > >> >The only buildbot using Tcl is hythloth which is currently > >> >'experimental' due to test timeouts. > >> > >> VTK_WRAP_TCL is 'on' for most of my dashboards. But I'm happy to turn > it > >> off. Might be able to squeeze in other build variations instead. > >> > >> Cheers, > >> > >> -- > >> ____________________________________________________________ > >> Sean McBride, B. Eng sean at rogue-research.com > >> Rogue Research www.rogue-research.com > >> Mac Software Developer Montr?al, Qu?bec, Canada > >> > >> > > > > > > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Search the list archives at: > http://markmail.org/search/?q=vtk-developers > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/vtk-developers > > > > > > > > -- > Unpaid intern in BillsBasement at noware dot com > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > > > > > > -- > > ___________________________________________ > Andrew J. P. Maclean > > ___________________________________________ > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Mon May 11 21:02:10 2015 From: berk.geveci at kitware.com (Berk Geveci) Date: Mon, 11 May 2015 21:02:10 -0400 Subject: [vtk-developers] IEEE Scientific Visualization Contest Message-ID: Hi folks, We invite you to participate in the 2015 IEEE Scientific Visualization Contest. This year's contest targets data from cosmology research that studies the formation of structure in the Universe. Participants are challenged to create a comprehensive set of analysis and visualization capabilities that enable domain experts to gain deeper insight into the formation of various structures in the Universe and better understanding of observations from next generation telescopes. Besides a number of interesting incentives, the contest winners will be presenting their work at IEEE VIS 2015 and they will get a chance to publish their results as a full, peer-reviewed IEEE CG&A article. Find out more at http://sciviscontest.ieeevis.org/2015/ Best, -berk -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lonie at kitware.com Tue May 12 08:32:55 2015 From: david.lonie at kitware.com (David Lonie) Date: Tue, 12 May 2015 08:32:55 -0400 Subject: [vtk-developers] Antialiasing broken in Qt5 In-Reply-To: References: Message-ID: Bumping -- can someone with a Qt5 build around do a quick test to see if multisampling works in a QVTKWidget? Has anyone been working on Qt5 support that might have an idea what's happening? On Thu, May 7, 2015 at 9:17 AM, David Lonie wrote: > On Thu, May 7, 2015 at 8:31 AM, Christoph Kolb > wrote: > >> your fix works for me in the RGrid example and also in SimpleView with >> Qt4. >> But not in Qt5. >> If you run the SimpleView example with Qt5, multisampling is off again >> which is inexplicable to me because in my understanding the QVTKWidget was >> simply painting the GL buffer rendered by a vtkRenderWindow which should >> already be antialiased... Is that wrong? >> > > Hmm, I'm not super familiar with the Qt layer in VTK. Perhaps someone else > on the list might know? > > Looking at the QVTKWidget implementation, I don't see why the Qt version > would make a difference regarding MSAA. Let's see if someone on the list > has any ideas, and I'll ask around to see what I can find out. > > Dave > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.gobbi at gmail.com Tue May 12 09:28:33 2015 From: david.gobbi at gmail.com (David Gobbi) Date: Tue, 12 May 2015 07:28:33 -0600 Subject: [vtk-developers] Bug in vtkNIFTIImageReader's handling of left-handed images? In-Reply-To: <1430962939546-5731798.post@n5.nabble.com> References: <1430925956349-5731787.post@n5.nabble.com> <1430962939546-5731798.post@n5.nabble.com> Message-ID: The fix has been merged into the master branch and will be in the next release. - David -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.gobbi at gmail.com Tue May 12 11:56:52 2015 From: david.gobbi at gmail.com (David Gobbi) Date: Tue, 12 May 2015 09:56:52 -0600 Subject: [vtk-developers] Changing floating point Types in VTK In-Reply-To: <1431332565.2896.5.camel@localhost> References: <1429513478.7444.5.camel@localhost> <1431332565.2896.5.camel@localhost> Message-ID: Hi Max, >From your description, it sounds like this change would be very labour-intensive to maintain, since all future uses of floating-point numbers in VTK would have to follow new rules. But I can definitely understand the benefit of "plug-in" floating point types (I've even used some VTK algorithms with custom fixed-point types in the past). Can you host your changes somewhere so that interested parties can try them out and provide feedback? - David On Mon, May 11, 2015 at 2:22 AM, Max Sagebaum < max.sagebaum at scicomp.uni-kl.de> wrote: > Dear developers, > > we had asked for your opinions about a typedef for the floating point > types in vtk and if we make this change if it would be accepted. Until > now we have received no answer. We would appreciate it, if we could get > some insights about the acceptance of the changes we want to make. > > Best regards, > > Max Sagebaum > > On Mon, 2015-04-20 at 09:04 +0200, Max Sagebaum wrote: > > Dear developers, > > we are currently using parts of the VTK Version 5.10 for our CFD > > Postprocessing Tool. We have successfully modified theses parts to > > facilitate an AD-Tool (Algorithmic Differentiation) to differentiate > > these code parts (intention is to not just get absolute values for our > > CFD-results, but also evaluate sensitivities/gradients). Caused by > > further developments in our tool we would like to go with newer > > VTK-Versions, which means repeating the changes in the code parts > > facilitating AD. We would like to implement these changes into the > > VTK-trunk, to avoid reprogramming and to offer the possibility of using > > AD to everyone. We would like to explain the changes in short and ask > > you to judge if such changes are likely to be accepted or if there is an > > interest in making VTK "AD-able". If not, we would avoid the presumably > > laborious implementation and would not put it into the Git/Develop loop. > > > > There are two main changes we had to make. To get the gradients of a > > program, the AD-Tool defines new AD floating point types which take care > > of the derivative computation. In order to use these AD types in VTK we > > needed to create two typedefs for float and double. Then every usage of > > float and double in VTK was replaced by the new typedefs. With this > > change, it is also possible to other types in VTK. E.g. complex values. > > > > The second change we made, was to rename every 'static_cast' call to a > > new function 'perform_cast'. Basically 'perfom_cast' just calls > > 'static_cast'. If you use other types than float or double 'static_cast' > > will complain that the conversion from eg. 'MyFloatType' to 'int' does > > not exist. 'perfom_cast' was specialized for the AD types and therefore > > the casts could be done. During this process we checked most of the > > occurrences of 'static_cast' and validated that the usage will not break > > the differentiation. > > There are two other solutions to our approach. We could implement > > conversion operators for the AD types, which enables 'static_cast' to do > > the conversion. But this is mostly discouraged by the tool developers. > > If the conversion operators are implemented, the compiler starts to > > implicit convert the AD types and very weird things can happen. > > The second approach would define these operators as explicit which would > > prevent the compiler from implicitly converting them. But then VTK would > > need to be compiled with C++11 enabled or if the user changes these > > types he also has to enable C++11 if necessary. > > > > Is the any interest on the developers or users side to use VTK with AD > > or other floating point types? > > Thanks for your opinions and judgment! > > > > Max Sagebaum > > > > -- > Max Sagebaum > > Chair for Scientific Computing, > TU Kaiserslautern, > Bldg/Geb 34, Paul-Ehrlich-Strasse, > 67663 Kaiserslautern, Germany > > Phone: +49 (0)631 205 5638 > Fax: +49 (0)631 205 3056 > Email: max.sagebaum at scicomp.uni-kl.de > URL: www.scicomp.uni-kl.de > > > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From karasevpa at gmail.com Tue May 12 20:24:33 2015 From: karasevpa at gmail.com (Peter Karasev) Date: Tue, 12 May 2015 17:24:33 -0700 Subject: [vtk-developers] vtkKdTreePointLocator + updating polydata ? Message-ID: If vtkPolyData used as input to a vtkKdTreePointLocator is updated, does the result of querying for nearest points in the locator become stale until BuildLocator is re-executed explicitly? Of course if the point data totally gets shuffled, that makes sense... but is there a way to efficiently update the KdTree structure in-place if the transformation on the points is just scale + offset per {x,y,z} coordinate? -- _______________ Peter Karasev karasevpa at gmail.com From sean at rogue-research.com Wed May 13 17:29:04 2015 From: sean at rogue-research.com (Sean McBride) Date: Wed, 13 May 2015 17:29:04 -0400 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: References: <20150508144912.GA28235@megas.kitware.com> <20150508145641.1638151866@mail.rogue-research.com> Message-ID: <20150513212904.1433844122@mail.rogue-research.com> On Fri, 8 May 2015 12:03:28 -0400, Berk Geveci said: >If you can leave it on on one of the dashboards, that should be good. So today I disable VTK_WRAP_TCL everywhere but 2 builds on Rogue7. Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From andrew.amaclean at gmail.com Wed May 13 20:33:00 2015 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Thu, 14 May 2015 10:33:00 +1000 Subject: [vtk-developers] An interesting statistic about VTK In-Reply-To: <20150513212904.1433844122@mail.rogue-research.com> References: <20150508144912.GA28235@megas.kitware.com> <20150508145641.1638151866@mail.rogue-research.com> <20150513212904.1433844122@mail.rogue-research.com> Message-ID: Fine by me. On Thu, May 14, 2015 at 7:29 AM, Sean McBride wrote: > On Fri, 8 May 2015 12:03:28 -0400, Berk Geveci said: > > >If you can leave it on on one of the dashboards, that should be good. > > So today I disable VTK_WRAP_TCL everywhere but 2 builds on Rogue7. > > Cheers, > > -- > ____________________________________________________________ > Sean McBride, B. Eng sean at rogue-research.com > Rogue Research www.rogue-research.com > Mac Software Developer Montr?al, Qu?bec, Canada > > > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From ali.hadimogullari at netcad.com.tr Thu May 14 06:59:05 2015 From: ali.hadimogullari at netcad.com.tr (alihadim) Date: Thu, 14 May 2015 03:59:05 -0700 (MST) Subject: [vtk-developers] Is this Bug? Vtk.VtkPoints InsertNextPoint For Celltype is Tetra. Message-ID: <1431601145281-5731909.post@n5.nabble.com> hi all, I created vtk.vtkUnstructuredGrid data. This picture is, I'm writing code for data copy and ouput picture is like under line(new data has changed!)I realized a situation. ?f I use code foreach (var item in Cell.Points) { points.InsertPoint(item.Id, item.X, item.Y, item.Z); tetra.GetPointIds().SetId(counter, item.Id); unstructuredGrid1.SetPoints(points); counter++; } I didnt't take for situation! Can you help me for situation? My Code; tk.vtkUnstructuredGrid unstructuredGrid1 = new vtk.vtkUnstructuredGrid(); vtk.vtkCellArray cellArray = new vtk.vtkCellArray(); vtk.vtkPoints points = new vtk.vtkPoints(); int counter = 0; foreach (INetcad3DCell Cell in Cells) { counter = 0; vtk.vtkTetra tetra = new vtk.vtkTetra(); foreach (var item in Cell.Points) { int ids = points.InsertNextPoint(item.X, item.Y, item.Z); tetra.GetPointIds().SetId(counter, ids); unstructuredGrid1.SetPoints(points); counter++; } cellArray.InsertNextCell(tetra); unstructuredGrid1.SetCells(10, cellArray); } -- View this message in context: http://vtk.1045678.n5.nabble.com/Is-this-Bug-Vtk-VtkPoints-InsertNextPoint-For-Celltype-is-Tetra-tp5731909.html Sent from the VTK - Dev mailing list archive at Nabble.com. From david.lonie at kitware.com Thu May 14 10:21:24 2015 From: david.lonie at kitware.com (David Lonie) Date: Thu, 14 May 2015 10:21:24 -0400 Subject: [vtk-developers] Antialiasing broken in Qt5 In-Reply-To: References: Message-ID: I setup a Qt5 build, and this is indeed a problem. It looks like we'll need to do some more work to get VTK to play nice with Qt5, at least on X11 (possibly other windowing systems as well). The root cause of the multisampling problem is that Qt5 no longer provides things like Q_WS_X11 and QX11Info, and the section of QVTKWidget::SetRenderWindow that initializes the GLX visual is inside a "#ifdef Q_WS_X11" block, and thus never gets called. It appears that all of the visual configuration (double buffering, stencil, MSAA, alpha planes, etc) are currently not being used when build against Qt5 on (at least) X11 as a result. For now, the only workaround I see is to stick with Qt4 until this can be addressed. I've filed a bug here: http://www.vtk.org/Bug/view.php?id=15469 Dave On Tue, May 12, 2015 at 8:32 AM, David Lonie wrote: > Bumping -- can someone with a Qt5 build around do a quick test to see if > multisampling works in a QVTKWidget? Has anyone been working on Qt5 support > that might have an idea what's happening? > > On Thu, May 7, 2015 at 9:17 AM, David Lonie > wrote: > >> On Thu, May 7, 2015 at 8:31 AM, Christoph Kolb > > wrote: >> >>> your fix works for me in the RGrid example and also in SimpleView with >>> Qt4. >>> But not in Qt5. >>> If you run the SimpleView example with Qt5, multisampling is off again >>> which is inexplicable to me because in my understanding the QVTKWidget was >>> simply painting the GL buffer rendered by a vtkRenderWindow which should >>> already be antialiased... Is that wrong? >>> >> >> Hmm, I'm not super familiar with the Qt layer in VTK. Perhaps someone >> else on the list might know? >> >> Looking at the QVTKWidget implementation, I don't see why the Qt version >> would make a difference regarding MSAA. Let's see if someone on the list >> has any ideas, and I'll ask around to see what I can find out. >> >> Dave >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From marcus.hanwell at kitware.com Thu May 14 11:37:44 2015 From: marcus.hanwell at kitware.com (Marcus D. Hanwell) Date: Thu, 14 May 2015 11:37:44 -0400 Subject: [vtk-developers] Antialiasing broken in Qt5 In-Reply-To: References: Message-ID: Marcus D. Hanwell, Ph.D. Technical Leader, Kitware Inc. (518) 881-4937 On Thu, May 14, 2015 at 10:21 AM, David Lonie wrote: > I setup a Qt5 build, and this is indeed a problem. > > It looks like we'll need to do some more work to get VTK to play nice with > Qt5, at least on X11 (possibly other windowing systems as well). The root > cause of the multisampling problem is that Qt5 no longer provides things > like Q_WS_X11 and QX11Info, and the section of QVTKWidget::SetRenderWindow > that initializes the GLX visual is inside a "#ifdef Q_WS_X11" block, and > thus never gets called. It appears that all of the visual configuration > (double buffering, stencil, MSAA, alpha planes, etc) are currently not being > used when build against Qt5 on (at least) X11 as a result. > > For now, the only workaround I see is to stick with Qt4 until this can be > addressed. I've filed a bug here: > > http://www.vtk.org/Bug/view.php?id=15469 > > Dave > > On Tue, May 12, 2015 at 8:32 AM, David Lonie > wrote: >> >> Bumping -- can someone with a Qt5 build around do a quick test to see if >> multisampling works in a QVTKWidget? Has anyone been working on Qt5 support >> that might have an idea what's happening? >> >> On Thu, May 7, 2015 at 9:17 AM, David Lonie >> wrote: >>> >>> On Thu, May 7, 2015 at 8:31 AM, Christoph Kolb >>> wrote: >>>> >>>> your fix works for me in the RGrid example and also in SimpleView with >>>> Qt4. >>>> But not in Qt5. >>>> If you run the SimpleView example with Qt5, multisampling is off again >>>> which is inexplicable to me because in my understanding the QVTKWidget was >>>> simply painting the GL buffer rendered by a vtkRenderWindow which should >>>> already be antialiased... Is that wrong? >>> >>> >>> Hmm, I'm not super familiar with the Qt layer in VTK. Perhaps someone >>> else on the list might know? >>> >>> Looking at the QVTKWidget implementation, I don't see why the Qt version >>> would make a difference regarding MSAA. Let's see if someone on the list has >>> any ideas, and I'll ask around to see what I can find out. >>> >>> Dave >> >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > From marcus.hanwell at kitware.com Thu May 14 11:39:32 2015 From: marcus.hanwell at kitware.com (Marcus D. Hanwell) Date: Thu, 14 May 2015 11:39:32 -0400 Subject: [vtk-developers] Antialiasing broken in Qt5 In-Reply-To: References: Message-ID: Good to know, we need to do more testing with Qt 5 it seems, the API is pretty close but a lot fo the way they do platform abstraction chanegd (moving into plugins for each platform). I have ParaView build with Qt 5 here, and can try to dig into this a little more if I can find some time. On Thu, May 14, 2015 at 10:21 AM, David Lonie wrote: > I setup a Qt5 build, and this is indeed a problem. > > It looks like we'll need to do some more work to get VTK to play nice with > Qt5, at least on X11 (possibly other windowing systems as well). The root > cause of the multisampling problem is that Qt5 no longer provides things > like Q_WS_X11 and QX11Info, and the section of QVTKWidget::SetRenderWindow > that initializes the GLX visual is inside a "#ifdef Q_WS_X11" block, and > thus never gets called. It appears that all of the visual configuration > (double buffering, stencil, MSAA, alpha planes, etc) are currently not being > used when build against Qt5 on (at least) X11 as a result. > > For now, the only workaround I see is to stick with Qt4 until this can be > addressed. I've filed a bug here: > > http://www.vtk.org/Bug/view.php?id=15469 > > Dave > > On Tue, May 12, 2015 at 8:32 AM, David Lonie > wrote: >> >> Bumping -- can someone with a Qt5 build around do a quick test to see if >> multisampling works in a QVTKWidget? Has anyone been working on Qt5 support >> that might have an idea what's happening? >> >> On Thu, May 7, 2015 at 9:17 AM, David Lonie >> wrote: >>> >>> On Thu, May 7, 2015 at 8:31 AM, Christoph Kolb >>> wrote: >>>> >>>> your fix works for me in the RGrid example and also in SimpleView with >>>> Qt4. >>>> But not in Qt5. >>>> If you run the SimpleView example with Qt5, multisampling is off again >>>> which is inexplicable to me because in my understanding the QVTKWidget was >>>> simply painting the GL buffer rendered by a vtkRenderWindow which should >>>> already be antialiased... Is that wrong? >>> >>> >>> Hmm, I'm not super familiar with the Qt layer in VTK. Perhaps someone >>> else on the list might know? >>> >>> Looking at the QVTKWidget implementation, I don't see why the Qt version >>> would make a difference regarding MSAA. Let's see if someone on the list has >>> any ideas, and I'll ask around to see what I can find out. >>> >>> Dave >> >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > From danieldaf2000 at gmail.com Thu May 14 16:34:16 2015 From: danieldaf2000 at gmail.com (Daniel Alejandro Fuentes) Date: Thu, 14 May 2015 17:34:16 -0300 Subject: [vtk-developers] Export model with texture Message-ID: Hi, I have a simple question, but I can't find how do it. If I have a poly data like that: (https://db.tt/HYaA0zFA) with only one difference, the texture is generated dynamically by vtk (using an array with values inside polydata). I want to export to a file, the texture with his mapping points, to associate it to another cylinder made in other tools outside VTK For instance, create a cylinder in 3DMax, and import the image generated in VTK like a material - and that is other topic, but I'm first only want to export the texture) This is possible? Thanks regards Daniel F. -------------- next part -------------- An HTML attachment was scrubbed... URL: From weifeng0715 at gmail.com Thu May 14 16:37:27 2015 From: weifeng0715 at gmail.com (weifeng0715) Date: Thu, 14 May 2015 13:37:27 -0700 (MST) Subject: [vtk-developers] Export model with texture In-Reply-To: References: Message-ID: <1431635847924-5731919.post@n5.nabble.com> A nice model -- View this message in context: http://vtk.1045678.n5.nabble.com/Export-model-with-texture-tp5731917p5731919.html Sent from the VTK - Dev mailing list archive at Nabble.com. From rostislav.khlebnikov at kcl.ac.uk Mon May 18 10:27:26 2015 From: rostislav.khlebnikov at kcl.ac.uk (Rostislav Khlebnikov) Date: Mon, 18 May 2015 15:27:26 +0100 Subject: [vtk-developers] vtkGeometryFilter and vtkUnstructuredGridBase Message-ID: <5559F6CE.8020407@kcl.ac.uk> Dear VTK developers, I have come across an issue when using vtkGeometryFilter on an adaptor of my dataset which uses vtkUnstructuredGridBase. Apparently, the vtkGeometryFilter has not been adapted to use the vtkUnstructuredGridBase interface and simply uses a static_cast in its UnstructuredGridExecute() method. Was this class overlooked during the transition to vtkUnstructuredGridBase? For now I can probably use the vtkDataSetSurfaceFilter filter as a workaround, but I assume that this is a bug and it should probably be fixed at some point. Thank you, Rostislav. From david.thompson at kitware.com Mon May 18 22:36:15 2015 From: david.thompson at kitware.com (David Thompson) Date: Mon, 18 May 2015 22:36:15 -0400 Subject: [vtk-developers] Class design for spline visualizations In-Reply-To: References: <32159C29-5A99-4818-970A-166B2F74A178@kitware.com> <3C513D9F-71D5-4D1F-B35F-C82A45CD5BB0@kitware.com> <20150420131200.GA450@megas.kitware.com> Message-ID: <8ABE4DD7-1ABC-4E73-8485-6723EB219B58@kitware.com> Hi Lin, Sorry for the slow reply. > Is there any dataset for precomputed Bezier interpolation? I'm currently comparing the result with my manual calculating. In this way I can not test many examples and it's quite low efficient. I've pushed a merge request to the project that adds a couple simple test cases. I'll add some more over the next few days. You can run the test by building VTK with the VTK_WRAP_PYTHON option turned ON and then running: make ./bin/vtkpython /path/to/src/Filters/Bezier/Testing/Python/PatchInterpolation.py If you uncomment the lines below the "For debugging, ..." message in PatchInterpolation.py, running the test will create some files (named bezier-circle.vtk and bezier-line.vtk) that you can load into ParaView. 1. As I mentioned earlier, it would be great to do image-based testing. A good exercise would be to modify the Python test into an image test version. 2. Another good exercise would be to generate control points for other conic sections such as hyperbolas, parabolas, and the more generate case of ellipses. I recommend "The NURBS Book" by Les Piegl; the circle quadrant example in the Python test is from pp. 26--32 of the book. It would be really nice to have a utility that would create control points given a few shape parameters. For example: ctrlPts, prange = ellipse(major_radius=2, minor_radius=1) ctrlPts, prange = hyperbola(semi_major_axis=2/3, eccentricity=1) Once we have the 1-, 2-, and 3-d Bezier interpolation tested, we can work on converting B-splines into B?zier patches and testing that. David > > On Mon, Apr 27, 2015 at 1:46 PM, David Thompson wrote: > Hi Lin, > > > ... I changed the method to compute binomial coefficient from vtkMath::Binomial to vtkMath::Factorial using our memoization improvement and tried to merge from Lin.Ma/filter-bezier to Spline/filter-bezier. > > Great! I can see that you were able to merge to the branch. > > > What do you think is the proper thing to do next? > > Right now, it looks like TestPatchInterpolation is modifying the array holding control point coordinates. I think it would be a good idea to write the interpolated points to a separate array and then make the test verify that Bernstein polynomial is being computed properly. > > There are 2 ways to verify things: value tests and image tests. > > 1. Value testing. Interpolate a few different r values on a few different sets of control points and compare the resulting point coordinates to values you know are good. The comparison must allow for small differences due to the differences in floating-point arithmetic implementations on different platforms. > > 2. Image testing. Plot the interpolated points and compare the rendering of the interpolated points to one you have verified is correct. While not as accurate as value testing, it can often be easier to debug a failing test with a rendered image. VTK provides utilities for comparing images (also allowing for small differences due to floating-point math, OpenGL implementations, and so on). The image baselines that get compared to your test's rendering are stored outside of the git repository to keep the repository from getting bloated. Instead, the MD5 sum of the baseline images are stored in the git repository and the images are stored separately on Kitware's servers, which can be queried to find a file with a given MD5 sum. > > Please take a look at this documentation on adding test data and baseline images to VTK: > > https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/data.md > > and see if you can add an image-based test of the patch interpolation. > > David > From majcjc at gmail.com Mon May 18 22:45:36 2015 From: majcjc at gmail.com (Lin M) Date: Mon, 18 May 2015 22:45:36 -0400 Subject: [vtk-developers] Class design for spline visualizations In-Reply-To: <8ABE4DD7-1ABC-4E73-8485-6723EB219B58@kitware.com> References: <32159C29-5A99-4818-970A-166B2F74A178@kitware.com> <3C513D9F-71D5-4D1F-B35F-C82A45CD5BB0@kitware.com> <20150420131200.GA450@megas.kitware.com> <8ABE4DD7-1ABC-4E73-8485-6723EB219B58@kitware.com> Message-ID: Hi Dr. Thompson Thanks! I'll look into that and implement the test asap. Best, Lin On Mon, May 18, 2015 at 10:36 PM, David Thompson wrote: > Hi Lin, > > Sorry for the slow reply. > > > Is there any dataset for precomputed Bezier interpolation? I'm currently > comparing the result with my manual calculating. In this way I can not test > many examples and it's quite low efficient. > > I've pushed a merge request to the project that adds a couple simple test > cases. I'll add some more over the next few days. You can run the test by > building VTK with the VTK_WRAP_PYTHON option turned ON and then running: > > make > ./bin/vtkpython > /path/to/src/Filters/Bezier/Testing/Python/PatchInterpolation.py > > If you uncomment the lines below the "For debugging, ..." message in > PatchInterpolation.py, running the test will create some files (named > bezier-circle.vtk and bezier-line.vtk) that you can load into ParaView. > > 1. As I mentioned earlier, it would be great to do image-based testing. A > good exercise would be to modify the Python test into an image test version. > > 2. Another good exercise would be to generate control points for other > conic sections such as hyperbolas, parabolas, and the more generate case of > ellipses. I recommend "The NURBS Book" by Les Piegl; the circle quadrant > example in the Python test is from pp. 26--32 of the book. It would be > really nice to have a utility that would create control points given a few > shape parameters. For example: > > ctrlPts, prange = ellipse(major_radius=2, minor_radius=1) > ctrlPts, prange = hyperbola(semi_major_axis=2/3, eccentricity=1) > > Once we have the 1-, 2-, and 3-d Bezier interpolation tested, we can work > on converting B-splines into B?zier patches and testing that. > > David > > > > > On Mon, Apr 27, 2015 at 1:46 PM, David Thompson < > david.thompson at kitware.com> wrote: > > Hi Lin, > > > > > ... I changed the method to compute binomial coefficient from > vtkMath::Binomial to vtkMath::Factorial using our memoization improvement > and tried to merge from Lin.Ma/filter-bezier to Spline/filter-bezier. > > > > Great! I can see that you were able to merge to the branch. > > > > > What do you think is the proper thing to do next? > > > > Right now, it looks like TestPatchInterpolation is modifying the array > holding control point coordinates. I think it would be a good idea to write > the interpolated points to a separate array and then make the test verify > that Bernstein polynomial is being computed properly. > > > > There are 2 ways to verify things: value tests and image tests. > > > > 1. Value testing. Interpolate a few different r values on a few > different sets of control points and compare the resulting point > coordinates to values you know are good. The comparison must allow for > small differences due to the differences in floating-point arithmetic > implementations on different platforms. > > > > 2. Image testing. Plot the interpolated points and compare the rendering > of the interpolated points to one you have verified is correct. While not > as accurate as value testing, it can often be easier to debug a failing > test with a rendered image. VTK provides utilities for comparing images > (also allowing for small differences due to floating-point math, OpenGL > implementations, and so on). The image baselines that get compared to your > test's rendering are stored outside of the git repository to keep the > repository from getting bloated. Instead, the MD5 sum of the baseline > images are stored in the git repository and the images are stored > separately on Kitware's servers, which can be queried to find a file with a > given MD5 sum. > > > > Please take a look at this documentation on adding test data and > baseline images to VTK: > > > > > https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/data.md > > > > and see if you can add an image-based test of the patch interpolation. > > > > David > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.thompson at kitware.com Tue May 19 13:52:37 2015 From: david.thompson at kitware.com (David Thompson) Date: Tue, 19 May 2015 13:52:37 -0400 Subject: [vtk-developers] Class design for spline visualizations In-Reply-To: References: <32159C29-5A99-4818-970A-166B2F74A178@kitware.com> <3C513D9F-71D5-4D1F-B35F-C82A45CD5BB0@kitware.com> <20150420131200.GA450@megas.kitware.com> <8ABE4DD7-1ABC-4E73-8485-6723EB219B58@kitware.com> Message-ID: <8CC007FF-63D3-43E0-998F-E01C7706DA27@kitware.com> Hi Lin, A few additional things that might help: 1. When you are done reviewing the merge request I assigned to you, please click "Accept merge request" or add a "+1" comment so that it will become part of the splines/filter-bezier branch. 2. A good pattern to follow for the image-based test is Filters/Sources/Testing/Python/TestPlatonicSolids.py . You can see how it obtains the path to img_file and calls vtk.test.Testing.compareImage to perform a rendering to compare. The baseline image that the rendering is compared against is not stored in the VTK git repo. Instead, MD5 checksums of images are stored in the git repo and the images are uploaded separately. See https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/data.md for a description of how to generate a test image, add its MD5 sum, and upload it with your merge request. 3. If you are going to generate helper methods to create conic sections, then be aware that you'll have to return multiple sets of control points because ellipses cannot be represented with a single patch (it is best to return one patch per quadrant) because of the way they are parameterized. David > On May 18, 2015, at 10:45 PM, Lin M wrote: > > Hi Dr. Thompson > > Thanks! I'll look into that and implement the test asap. > > Best, > Lin > > On Mon, May 18, 2015 at 10:36 PM, David Thompson wrote: > Hi Lin, > > Sorry for the slow reply. > > > Is there any dataset for precomputed Bezier interpolation? I'm currently comparing the result with my manual calculating. In this way I can not test many examples and it's quite low efficient. > > I've pushed a merge request to the project that adds a couple simple test cases. I'll add some more over the next few days. You can run the test by building VTK with the VTK_WRAP_PYTHON option turned ON and then running: > > make > ./bin/vtkpython /path/to/src/Filters/Bezier/Testing/Python/PatchInterpolation.py > > If you uncomment the lines below the "For debugging, ..." message in PatchInterpolation.py, running the test will create some files (named bezier-circle.vtk and bezier-line.vtk) that you can load into ParaView. > > 1. As I mentioned earlier, it would be great to do image-based testing. A good exercise would be to modify the Python test into an image test version. > > 2. Another good exercise would be to generate control points for other conic sections such as hyperbolas, parabolas, and the more generate case of ellipses. I recommend "The NURBS Book" by Les Piegl; the circle quadrant example in the Python test is from pp. 26--32 of the book. It would be really nice to have a utility that would create control points given a few shape parameters. For example: > > ctrlPts, prange = ellipse(major_radius=2, minor_radius=1) > ctrlPts, prange = hyperbola(semi_major_axis=2/3, eccentricity=1) > > Once we have the 1-, 2-, and 3-d Bezier interpolation tested, we can work on converting B-splines into B?zier patches and testing that. > > David > > > > > On Mon, Apr 27, 2015 at 1:46 PM, David Thompson wrote: > > Hi Lin, > > > > > ... I changed the method to compute binomial coefficient from vtkMath::Binomial to vtkMath::Factorial using our memoization improvement and tried to merge from Lin.Ma/filter-bezier to Spline/filter-bezier. > > > > Great! I can see that you were able to merge to the branch. > > > > > What do you think is the proper thing to do next? > > > > Right now, it looks like TestPatchInterpolation is modifying the array holding control point coordinates. I think it would be a good idea to write the interpolated points to a separate array and then make the test verify that Bernstein polynomial is being computed properly. > > > > There are 2 ways to verify things: value tests and image tests. > > > > 1. Value testing. Interpolate a few different r values on a few different sets of control points and compare the resulting point coordinates to values you know are good. The comparison must allow for small differences due to the differences in floating-point arithmetic implementations on different platforms. > > > > 2. Image testing. Plot the interpolated points and compare the rendering of the interpolated points to one you have verified is correct. While not as accurate as value testing, it can often be easier to debug a failing test with a rendered image. VTK provides utilities for comparing images (also allowing for small differences due to floating-point math, OpenGL implementations, and so on). The image baselines that get compared to your test's rendering are stored outside of the git repository to keep the repository from getting bloated. Instead, the MD5 sum of the baseline images are stored in the git repository and the images are stored separately on Kitware's servers, which can be queried to find a file with a given MD5 sum. > > > > Please take a look at this documentation on adding test data and baseline images to VTK: > > > > https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/data.md > > > > and see if you can add an image-based test of the patch interpolation. > > > > David > > > > From andrew.amaclean at gmail.com Wed May 20 02:32:03 2015 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Wed, 20 May 2015 16:32:03 +1000 Subject: [vtk-developers] Need, help regarding the conversion of squadViewer.tcl to Python. Message-ID: So far I have a rough working version, see attached, that seems to do everything that the Tcl version does. However I have a problem in that the following message is generated on exit: "A TkRenderWidget is being destroyed before it associated vtkRenderWindow is destroyed.This is very bad and usually due to the order in which objects are being destroyed.Always destroy the vtkRenderWindow before destroying the user interface components." If you look at OnClosing(), I have deleted any attached renderers , then the render window and finally destroyed the root. Does anyone know what more I need to do in order to remove this error message? As far as I can see the vtkRenderWindow is destroyed. Thanks for any help. Andrew -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: squadViewer.py Type: text/x-python Size: 4831 bytes Desc: not available URL: From max.sagebaum at scicomp.uni-kl.de Wed May 20 04:58:05 2015 From: max.sagebaum at scicomp.uni-kl.de (Max Sagebaum) Date: Wed, 20 May 2015 08:58:05 +0000 Subject: [vtk-developers] Changing floating point Types in VTK In-Reply-To: References: <1429513478.7444.5.camel@localhost> <1431332565.2896.5.camel@localhost> Message-ID: <1432112285.13957.15.camel@scicomp.uni-kl.de> Hello David, I have set up a gitlab repository with the version we have modified. I hope the gitlab repository is ok for you. The clone id for the repo is: > git at gitlab.com:MaxSagebaum/vtk-5.10.1-FloatModified.git We started our modification with the 5.10.1 version of vtk. As we needed just the packages verdict, kwsys, vtkCommon, vtkFiltering and vtkGraphics only these are modified and build for our purposes. I provided an install script, which shows the basic steps to setup everything. The script shows the installation of 3 variants. Basically VTK_unmod and VTK_double are the same. Only in VTK_adolc the floating point type is exchanged with the ADOL-c AD type. We have also done this for the dco AD tool but this tool is not freely available. If you Have a look at the files Common/adDefines*, you will see the tool specific implementations we had to do. The one for ADOL-c is quite big because I inlined all the includes we would normally need. The file Common/adDefinesDouble.h is very small which means that for the normal floating point type not that much has changed. Cheers Max On Tue, 2015-05-12 at 09:56 -0600, David Gobbi wrote: > Hi Max, > > > From your description, it sounds like this change would be very > labour-intensive to maintain, since all future uses of floating-point > numbers in VTK would have to follow new rules. But I can definitely > understand the benefit of "plug-in" floating point types (I've even > used some VTK algorithms with custom fixed-point types in the past). > > > Can you host your changes somewhere so that interested parties can try > them out and provide feedback? > > > - David > > > > On Mon, May 11, 2015 at 2:22 AM, Max Sagebaum > wrote: > Dear developers, > > we had asked for your opinions about a typedef for the > floating point > types in vtk and if we make this change if it would be > accepted. Until > now we have received no answer. We would appreciate it, if we > could get > some insights about the acceptance of the changes we want to > make. > > Best regards, > > Max Sagebaum > > On Mon, 2015-04-20 at 09:04 +0200, Max Sagebaum wrote: > > Dear developers, > > we are currently using parts of the VTK Version 5.10 for our > CFD > > Postprocessing Tool. We have successfully modified theses > parts to > > facilitate an AD-Tool (Algorithmic Differentiation) to > differentiate > > these code parts (intention is to not just get absolute > values for our > > CFD-results, but also evaluate sensitivities/gradients). > Caused by > > further developments in our tool we would like to go with > newer > > VTK-Versions, which means repeating the changes in the code > parts > > facilitating AD. We would like to implement these changes > into the > > VTK-trunk, to avoid reprogramming and to offer the > possibility of using > > AD to everyone. We would like to explain the changes in > short and ask > > you to judge if such changes are likely to be accepted or if > there is an > > interest in making VTK ?AD-able?. If not, we would avoid the > presumably > > laborious implementation and would not put it into the > Git/Develop loop. > > > > There are two main changes we had to make. To get the > gradients of a > > program, the AD-Tool defines new AD floating point types > which take care > > of the derivative computation. In order to use these AD > types in VTK we > > needed to create two typedefs for float and double. Then > every usage of > > float and double in VTK was replaced by the new typedefs. > With this > > change, it is also possible to other types in VTK. E.g. > complex values. > > > > The second change we made, was to rename every 'static_cast' > call to a > > new function 'perform_cast'. Basically 'perfom_cast' just > calls > > 'static_cast'. If you use other types than float or double > 'static_cast' > > will complain that the conversion from eg. 'MyFloatType' to > 'int' does > > not exist. 'perfom_cast' was specialized for the AD types > and therefore > > the casts could be done. During this process we checked most > of the > > occurrences of 'static_cast' and validated that the usage > will not break > > the differentiation. > > There are two other solutions to our approach. We could > implement > > conversion operators for the AD types, which enables > 'static_cast' to do > > the conversion. But this is mostly discouraged by the tool > developers. > > If the conversion operators are implemented, the compiler > starts to > > implicit convert the AD types and very weird things can > happen. > > The second approach would define these operators as explicit > which would > > prevent the compiler from implicitly converting them. But > then VTK would > > need to be compiled with C++11 enabled or if the user > changes these > > types he also has to enable C++11 if necessary. > > > > Is the any interest on the developers or users side to use > VTK with AD > > or other floating point types? > > Thanks for your opinions and judgment! > > > > Max Sagebaum > > > > > -- > Max Sagebaum > > Chair for Scientific Computing, > TU Kaiserslautern, > Bldg/Geb 34, Paul-Ehrlich-Strasse, > 67663 Kaiserslautern, Germany > > Phone: +49 (0)631 205 5638 > Fax: +49 (0)631 205 3056 > Email: max.sagebaum at scicomp.uni-kl.de > URL: www.scicomp.uni-kl.de > > > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: > http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > > -- Max Sagebaum Chair for Scientific Computing, TU Kaiserslautern, Bldg/Geb 34, Paul-Ehrlich-Strasse, 67663 Kaiserslautern, Germany Phone: +49 (0)631 205 5638 Fax: +49 (0)631 205 3056 Email: max.sagebaum at scicomp.uni-kl.de URL: www.scicomp.uni-kl.de From david.lonie at kitware.com Wed May 20 09:44:18 2015 From: david.lonie at kitware.com (David Lonie) Date: Wed, 20 May 2015 09:44:18 -0400 Subject: [vtk-developers] vtkGeometryFilter and vtkUnstructuredGridBase In-Reply-To: <5559F6CE.8020407@kcl.ac.uk> References: <5559F6CE.8020407@kcl.ac.uk> Message-ID: On Mon, May 18, 2015 at 10:27 AM, Rostislav Khlebnikov < rostislav.khlebnikov at kcl.ac.uk> wrote: > Dear VTK developers, > > I have come across an issue when using vtkGeometryFilter on an adaptor of > my dataset which uses vtkUnstructuredGridBase. Apparently, the > vtkGeometryFilter has not been adapted to use the vtkUnstructuredGridBase > interface and simply uses a static_cast in its > UnstructuredGridExecute() method. Was this class overlooked during the > transition to vtkUnstructuredGridBase? For now I can probably use the > vtkDataSetSurfaceFilter filter as a workaround, but I assume that this is a > bug and it should probably be fixed at some point > At this point, there are a lot of filters that won't work with the vtkUnstructuredGridBase and vtkMappedDataArray interfaces. These are newer, experimental features that are currently only used in a handful of applications. If you end up needing to adapt any filters, etc to use them, consider sharing the modifications on gitlab so we can improve support. More info: http://www.vtk.org/Wiki/VTK/InSituDataStructures Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From johnrim20 at gmail.com Thu May 21 03:35:56 2015 From: johnrim20 at gmail.com (John R) Date: Thu, 21 May 2015 13:05:56 +0530 Subject: [vtk-developers] How do I know whether VTK is installed in my machine or not? Message-ID: Hello, I am trying to install VTK in my machine, previously my college usually used installing this VTK in my machine. Since this VTK is not displaying in program and features of control panel, how do we confirm whether it is installed in machine or not? because the VTK may not be working if environment variable setting is wrong or may be with many other reasons but actually it may be there in the background!! However, VTK installation status has to be identified with its directory. Also I read that when we install we have to always check whether it is already installed for avoiding the duplicate conflict. Similarly what is the procedure to delete/uninstall the VTK completely form the machine, I mean there should not have any conflict on fresh installation and VTK calling in my programs. Can anyone please help? -------------- next part -------------- An HTML attachment was scrubbed... URL: From rostislav.khlebnikov at kcl.ac.uk Thu May 21 08:19:40 2015 From: rostislav.khlebnikov at kcl.ac.uk (Rostislav Khlebnikov) Date: Thu, 21 May 2015 13:19:40 +0100 Subject: [vtk-developers] vtkGeometryFilter and vtkUnstructuredGridBase In-Reply-To: References: <5559F6CE.8020407@kcl.ac.uk> Message-ID: <555DCD5C.8070108@kcl.ac.uk> Thanks for clearing that up, Dave. I will take a look at the filters that I need and share my changes if I do any. Rostislav. On 20/05/2015 14:44, David Lonie wrote: > On Mon, May 18, 2015 at 10:27 AM, Rostislav Khlebnikov > > wrote: > > Dear VTK developers, > > I have come across an issue when using vtkGeometryFilter on an > adaptor of my dataset which uses vtkUnstructuredGridBase. > Apparently, the vtkGeometryFilter has not been adapted to use the > vtkUnstructuredGridBase interface and simply uses a > static_cast in its > UnstructuredGridExecute() method. Was this class overlooked during > the transition to vtkUnstructuredGridBase? For now I can probably > use the vtkDataSetSurfaceFilter filter as a workaround, but I > assume that this is a bug and it should probably be fixed at some > point > > > At this point, there are a lot of filters that won't work with the > vtkUnstructuredGridBase and vtkMappedDataArray interfaces. These are > newer, experimental features that are currently only used in a handful > of applications. If you end up needing to adapt any filters, etc to > use them, consider sharing the modifications on gitlab so we can > improve support. > > More info: http://www.vtk.org/Wiki/VTK/InSituDataStructures > > Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From rostislav.khlebnikov at kcl.ac.uk Thu May 21 12:22:26 2015 From: rostislav.khlebnikov at kcl.ac.uk (Rostislav Khlebnikov) Date: Thu, 21 May 2015 17:22:26 +0100 Subject: [vtk-developers] vtkPicker picking "visible" parts of assemblies marked as invisible Message-ID: <555E0642.9070503@kcl.ac.uk> Dear VTK developers, I am using vtkCellPicker (and consequently vtkPicker) to pick cells on objects. However, apparently, if a prop assembly is marked as invisible, it is still possible to pick the parts of assembly marked invisible if these parts are not explicitly marked invisible themselves. This happens in case a pick list is used, i.e. line vtkPicker.cxx:L278 is executed (not sure whether the same would happen if pick lists are not used). In any case, checking whether prop obtained in line 294 of vtkPicker.cxx is visible and pickable before initializing path traversal, should fix the problem. So my question is: - is it supposed to behave like this? (I doubt it as it is rather unintuitive) - should I make a fix for this? - If yes - is it possible to make such a small fix (probably two lines of code) in some simple way? All best, Rostislav. From pieper at isomics.com Thu May 21 12:47:17 2015 From: pieper at isomics.com (Steve Pieper) Date: Thu, 21 May 2015 12:47:17 -0400 Subject: [vtk-developers] vtkPicker picking "visible" parts of assemblies marked as invisible In-Reply-To: <555E0642.9070503@kcl.ac.uk> References: <555E0642.9070503@kcl.ac.uk> Message-ID: Hi Rostislav - Yes, this is a nasty issue introduced by the vtkPickeringManager. I ran into this last year [1] and put a workaround in our version of VTK [2] but it doesn't solve the whole problem. I didn't propose this back to VTK-proper because widget needs to be fixed in order for this to work. Maybe there's a better way? The bug report includes simple instructions on how to reproduce the issue. -Steve [1] http://na-mic.org/Bug/view.php?id=3808 [2] https://github.com/Slicer/VTK/commit/539b56d2334cf292d3fbfc18cef9543a56fb9362 On Thu, May 21, 2015 at 12:22 PM, Rostislav Khlebnikov < rostislav.khlebnikov at kcl.ac.uk> wrote: > Dear VTK developers, > > I am using vtkCellPicker (and consequently vtkPicker) to pick cells on > objects. However, apparently, if a prop assembly is marked as invisible, it > is still possible to pick the parts of assembly marked invisible if these > parts are not explicitly marked invisible themselves. This happens in case > a pick list is used, i.e. line vtkPicker.cxx:L278 is executed (not sure > whether the same would happen if pick lists are not used). In any case, > checking whether prop obtained in line 294 of vtkPicker.cxx is visible and > pickable before initializing path traversal, should fix the problem. > > So my question is: > - is it supposed to behave like this? (I doubt it as it is rather > unintuitive) > - should I make a fix for this? > - If yes - is it possible to make such a small fix (probably two lines > of code) in some simple way? > > All best, > Rostislav. > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Thu May 21 13:54:00 2015 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Thu, 21 May 2015 13:54:00 -0400 Subject: [vtk-developers] Maintainer for mirkwood.dlrsoftware Message-ID: Folks, I am trying to track down the maintainer for the VTK dashboard machine: mirkwood.dlrsoftware. If you maintain this machine, can you please email me. Thanks Utkarsh From utkarsh.ayachit at kitware.com Thu May 21 15:05:44 2015 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Thu, 21 May 2015 15:05:44 -0400 Subject: [vtk-developers] Maintainer for mirkwood.dlrsoftware In-Reply-To: References: Message-ID: I've found the maintainer (it's Dave Cole). Thanks everyone! Utkarsh On Thu, May 21, 2015 at 1:54 PM, Utkarsh Ayachit wrote: > Folks, > > I am trying to track down the maintainer for the VTK dashboard > machine: mirkwood.dlrsoftware. > > If you maintain this machine, can you please email me. > > Thanks > Utkarsh From ashray.malhotra.1994 at gmail.com Thu May 21 15:47:12 2015 From: ashray.malhotra.1994 at gmail.com (Ashray Malhotra) Date: Fri, 22 May 2015 01:17:12 +0530 Subject: [vtk-developers] XCode upgrade breaks VTK build process(Suspected reason for build fail) Message-ID: Hello, I was trying to build VTK but it showed me some errors today. I think the error might be related to the fact that I upgraded my XCode to version 6.3.2 last night and the error log(http://tinyurl.com/jwf4jky) suggests that. I tried building VTK after a warning fix, but it didn't work. I also tried building the current master branch and also v6.2.0 but none of them was successfully. I am new to VTK and hence was trying to run through the tutorials( http://tinyurl.com/m2kb3g4) to learn VTK but when I cmake the first tutorial, it shows me that vtkRendering module isn't available. Is it because the build process failed? Note that I have built VTK successfully many times on my machine, so isn't the previous successful build used to run the code in an event the new build fails? Please let me know where I am going wrong. Thanks a lot. -- Regards Ashray Malhotra GSOC Student -------------- next part -------------- An HTML attachment was scrubbed... URL: From lonni.besancon at gmail.com Fri May 22 07:32:00 2015 From: lonni.besancon at gmail.com (=?UTF-8?Q?Lonni_Besan=C3=A7on?=) Date: Fri, 22 May 2015 04:32:00 -0700 (MST) Subject: [vtk-developers] VTK and VTK for mobile Message-ID: <1432294320654-5731975.post@n5.nabble.com> Hello, I'm completely new to the VTK world. I'm a PhD student in computer science and I would like to be able to use VTK for both mobile and desktop. I've read this news here: post that explains that soon VES will be deprecated. As building is complicated to say the least, I would love to avoid both building and configuring and environment for VES if it's not useful anymore. Has anyone tried to use VTK for mobile development without VES? Also I am having some difficulties while trying to configure with Cmake VTK. What should I check when trying to configure (i'm only interested in a c++ desktop program and an android application)? Finally I have some issues with JOGL since Cmake tells me it's missing even though it's not in my path (I'm using Windows btw ). Thanks a lot for reading and thanks in advance for the help you will provide. Best, -- View this message in context: http://vtk.1045678.n5.nabble.com/VTK-and-VTK-for-mobile-tp5731975.html Sent from the VTK - Dev mailing list archive at Nabble.com. From majcjc at gmail.com Fri May 22 23:15:34 2015 From: majcjc at gmail.com (Lin M) Date: Fri, 22 May 2015 23:15:34 -0400 Subject: [vtk-developers] Class design for spline visualizations In-Reply-To: <8CC007FF-63D3-43E0-998F-E01C7706DA27@kitware.com> References: <32159C29-5A99-4818-970A-166B2F74A178@kitware.com> <3C513D9F-71D5-4D1F-B35F-C82A45CD5BB0@kitware.com> <20150420131200.GA450@megas.kitware.com> <8ABE4DD7-1ABC-4E73-8485-6723EB219B58@kitware.com> <8CC007FF-63D3-43E0-998F-E01C7706DA27@kitware.com> Message-ID: Hi Dr. Thompson I changed the python test to baseline image and followed the instructions in the VTK Data page, but running CMake doesn't seem to make the .md5 files. Do you have any idea about that? I outputed two images named bezier-circle.png and bezier-line.png and put them in source-tree/Filters/Bezier/Testing/Data/Baseline. Best, Lin On Tue, May 19, 2015 at 1:52 PM, David Thompson wrote: > Hi Lin, > > A few additional things that might help: > > 1. When you are done reviewing the merge request I assigned to you, please > click "Accept merge request" or add a "+1" comment so that it will become > part of the splines/filter-bezier branch. > > 2. A good pattern to follow for the image-based test is > Filters/Sources/Testing/Python/TestPlatonicSolids.py . You can see how it > obtains the path to img_file and calls vtk.test.Testing.compareImage to > perform a rendering to compare. The baseline image that the rendering is > compared against is not stored in the VTK git repo. Instead, MD5 checksums > of images are stored in the git repo and the images are uploaded > separately. See > > > https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/data.md > > for a description of how to generate a test image, add its MD5 sum, and > upload it with your merge request. > > 3. If you are going to generate helper methods to create conic sections, > then be aware that you'll have to return multiple sets of control points > because ellipses cannot be represented with a single patch (it is best to > return one patch per quadrant) because of the way they are parameterized. > > David > > > On May 18, 2015, at 10:45 PM, Lin M wrote: > > > > Hi Dr. Thompson > > > > Thanks! I'll look into that and implement the test asap. > > > > Best, > > Lin > > > > On Mon, May 18, 2015 at 10:36 PM, David Thompson < > david.thompson at kitware.com> wrote: > > Hi Lin, > > > > Sorry for the slow reply. > > > > > Is there any dataset for precomputed Bezier interpolation? I'm > currently comparing the result with my manual calculating. In this way I > can not test many examples and it's quite low efficient. > > > > I've pushed a merge request to the project that adds a couple simple > test cases. I'll add some more over the next few days. You can run the test > by building VTK with the VTK_WRAP_PYTHON option turned ON and then running: > > > > make > > ./bin/vtkpython > /path/to/src/Filters/Bezier/Testing/Python/PatchInterpolation.py > > > > If you uncomment the lines below the "For debugging, ..." message in > PatchInterpolation.py, running the test will create some files (named > bezier-circle.vtk and bezier-line.vtk) that you can load into ParaView. > > > > 1. As I mentioned earlier, it would be great to do image-based testing. > A good exercise would be to modify the Python test into an image test > version. > > > > 2. Another good exercise would be to generate control points for other > conic sections such as hyperbolas, parabolas, and the more generate case of > ellipses. I recommend "The NURBS Book" by Les Piegl; the circle quadrant > example in the Python test is from pp. 26--32 of the book. It would be > really nice to have a utility that would create control points given a few > shape parameters. For example: > > > > ctrlPts, prange = ellipse(major_radius=2, minor_radius=1) > > ctrlPts, prange = hyperbola(semi_major_axis=2/3, eccentricity=1) > > > > Once we have the 1-, 2-, and 3-d Bezier interpolation tested, we can > work on converting B-splines into B?zier patches and testing that. > > > > David > > > > > > > > On Mon, Apr 27, 2015 at 1:46 PM, David Thompson < > david.thompson at kitware.com> wrote: > > > Hi Lin, > > > > > > > ... I changed the method to compute binomial coefficient from > vtkMath::Binomial to vtkMath::Factorial using our memoization improvement > and tried to merge from Lin.Ma/filter-bezier to Spline/filter-bezier. > > > > > > Great! I can see that you were able to merge to the branch. > > > > > > > What do you think is the proper thing to do next? > > > > > > Right now, it looks like TestPatchInterpolation is modifying the array > holding control point coordinates. I think it would be a good idea to write > the interpolated points to a separate array and then make the test verify > that Bernstein polynomial is being computed properly. > > > > > > There are 2 ways to verify things: value tests and image tests. > > > > > > 1. Value testing. Interpolate a few different r values on a few > different sets of control points and compare the resulting point > coordinates to values you know are good. The comparison must allow for > small differences due to the differences in floating-point arithmetic > implementations on different platforms. > > > > > > 2. Image testing. Plot the interpolated points and compare the > rendering of the interpolated points to one you have verified is correct. > While not as accurate as value testing, it can often be easier to debug a > failing test with a rendered image. VTK provides utilities for comparing > images (also allowing for small differences due to floating-point math, > OpenGL implementations, and so on). The image baselines that get compared > to your test's rendering are stored outside of the git repository to keep > the repository from getting bloated. Instead, the MD5 sum of the baseline > images are stored in the git repository and the images are stored > separately on Kitware's servers, which can be queried to find a file with a > given MD5 sum. > > > > > > Please take a look at this documentation on adding test data and > baseline images to VTK: > > > > > > > https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/data.md > > > > > > and see if you can add an image-based test of the patch interpolation. > > > > > > David > > > > > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.thompson at kitware.com Sat May 23 00:16:27 2015 From: david.thompson at kitware.com (David Thompson) Date: Sat, 23 May 2015 00:16:27 -0400 Subject: [vtk-developers] Class design for spline visualizations In-Reply-To: References: <32159C29-5A99-4818-970A-166B2F74A178@kitware.com> <3C513D9F-71D5-4D1F-B35F-C82A45CD5BB0@kitware.com> <20150420131200.GA450@megas.kitware.com> <8ABE4DD7-1ABC-4E73-8485-6723EB219B58@kitware.com> <8CC007FF-63D3-43E0-998F-E01C7706DA27@kitware.com> Message-ID: Hi Lin, I believe VTK expects each test to generate a single baseline image whose filename matches the Python script name (e.g., TestSynchronizedTemplates3D.py must have its baseline image named TestSynchronizedTemplates3D.png in the Data/Baselines directory). David > On May 22, 2015, at 23:15, Lin M wrote: > > Hi Dr. Thompson > > I changed the python test to baseline image and followed the instructions in the VTK Data page, but running CMake doesn't seem to make the .md5 files. Do you have any idea about that? > > I outputed two images named bezier-circle.png and bezier-line.png and put them in source-tree/Filters/Bezier/Testing/Data/Baseline. > > Best, > Lin > > >> On Tue, May 19, 2015 at 1:52 PM, David Thompson wrote: >> Hi Lin, >> >> A few additional things that might help: >> >> 1. When you are done reviewing the merge request I assigned to you, please click "Accept merge request" or add a "+1" comment so that it will become part of the splines/filter-bezier branch. >> >> 2. A good pattern to follow for the image-based test is Filters/Sources/Testing/Python/TestPlatonicSolids.py . You can see how it obtains the path to img_file and calls vtk.test.Testing.compareImage to perform a rendering to compare. The baseline image that the rendering is compared against is not stored in the VTK git repo. Instead, MD5 checksums of images are stored in the git repo and the images are uploaded separately. See >> >> https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/data.md >> >> for a description of how to generate a test image, add its MD5 sum, and upload it with your merge request. >> >> 3. If you are going to generate helper methods to create conic sections, then be aware that you'll have to return multiple sets of control points because ellipses cannot be represented with a single patch (it is best to return one patch per quadrant) because of the way they are parameterized. >> >> David >> >> > On May 18, 2015, at 10:45 PM, Lin M wrote: >> > >> > Hi Dr. Thompson >> > >> > Thanks! I'll look into that and implement the test asap. >> > >> > Best, >> > Lin >> > >> > On Mon, May 18, 2015 at 10:36 PM, David Thompson wrote: >> > Hi Lin, >> > >> > Sorry for the slow reply. >> > >> > > Is there any dataset for precomputed Bezier interpolation? I'm currently comparing the result with my manual calculating. In this way I can not test many examples and it's quite low efficient. >> > >> > I've pushed a merge request to the project that adds a couple simple test cases. I'll add some more over the next few days. You can run the test by building VTK with the VTK_WRAP_PYTHON option turned ON and then running: >> > >> > make >> > ./bin/vtkpython /path/to/src/Filters/Bezier/Testing/Python/PatchInterpolation.py >> > >> > If you uncomment the lines below the "For debugging, ..." message in PatchInterpolation.py, running the test will create some files (named bezier-circle.vtk and bezier-line.vtk) that you can load into ParaView. >> > >> > 1. As I mentioned earlier, it would be great to do image-based testing. A good exercise would be to modify the Python test into an image test version. >> > >> > 2. Another good exercise would be to generate control points for other conic sections such as hyperbolas, parabolas, and the more generate case of ellipses. I recommend "The NURBS Book" by Les Piegl; the circle quadrant example in the Python test is from pp. 26--32 of the book. It would be really nice to have a utility that would create control points given a few shape parameters. For example: >> > >> > ctrlPts, prange = ellipse(major_radius=2, minor_radius=1) >> > ctrlPts, prange = hyperbola(semi_major_axis=2/3, eccentricity=1) >> > >> > Once we have the 1-, 2-, and 3-d Bezier interpolation tested, we can work on converting B-splines into B?zier patches and testing that. >> > >> > David >> > >> > > >> > > On Mon, Apr 27, 2015 at 1:46 PM, David Thompson wrote: >> > > Hi Lin, >> > > >> > > > ... I changed the method to compute binomial coefficient from vtkMath::Binomial to vtkMath::Factorial using our memoization improvement and tried to merge from Lin.Ma/filter-bezier to Spline/filter-bezier. >> > > >> > > Great! I can see that you were able to merge to the branch. >> > > >> > > > What do you think is the proper thing to do next? >> > > >> > > Right now, it looks like TestPatchInterpolation is modifying the array holding control point coordinates. I think it would be a good idea to write the interpolated points to a separate array and then make the test verify that Bernstein polynomial is being computed properly. >> > > >> > > There are 2 ways to verify things: value tests and image tests. >> > > >> > > 1. Value testing. Interpolate a few different r values on a few different sets of control points and compare the resulting point coordinates to values you know are good. The comparison must allow for small differences due to the differences in floating-point arithmetic implementations on different platforms. >> > > >> > > 2. Image testing. Plot the interpolated points and compare the rendering of the interpolated points to one you have verified is correct. While not as accurate as value testing, it can often be easier to debug a failing test with a rendered image. VTK provides utilities for comparing images (also allowing for small differences due to floating-point math, OpenGL implementations, and so on). The image baselines that get compared to your test's rendering are stored outside of the git repository to keep the repository from getting bloated. Instead, the MD5 sum of the baseline images are stored in the git repository and the images are stored separately on Kitware's servers, which can be queried to find a file with a given MD5 sum. >> > > >> > > Please take a look at this documentation on adding test data and baseline images to VTK: >> > > >> > > https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/data.md >> > > >> > > and see if you can add an image-based test of the patch interpolation. >> > > >> > > David >> > > >> > >> > >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Tue May 26 08:18:53 2015 From: berk.geveci at kitware.com (Berk Geveci) Date: Tue, 26 May 2015 08:18:53 -0400 Subject: [vtk-developers] CFP: SC '15 Scientific Visualization Showcase Message-ID: Hi folks, The Call for Participation for the SC '15 Scientific Visualization Showcase is out. This is a great opportunity for the community to highlight the wonderful visualization work going on. Please consider submitting an entry (or more). http://sc15.supercomputing.org/program/scientific-visualization-showcase SC15?s Visualization and Data Analytics Showcase Program provides a forum for the year's most instrumental movies in HPC. Six finalists will compete for the Best Visualization Award, and each finalist will present his or her movie during a dedicated session at SC15 in a 15-minute presentation. Movies are judged based on how their movie illuminates science, by the quality of the movie, and for innovations in the process used for creating the movie. Best, -berk -------------- next part -------------- An HTML attachment was scrubbed... URL: From t.kilgus at Dkfz-Heidelberg.de Tue May 26 11:50:06 2015 From: t.kilgus at Dkfz-Heidelberg.de (Kilgus, Thomas) Date: Tue, 26 May 2015 17:50:06 +0200 Subject: [vtk-developers] Antialiasing broken in Qt5 In-Reply-To: References: Message-ID: <57EE86D11538B44096C712532DBB6C5A012EF303CBB7@DKFZEX01.ad.dkfz-heidelberg.de> Hi Marcus and David, I would love to make this run with Qt5 for a demo application. Is there any (straightforward) job I can take care of to help tracking down the issue? Regards, Thomas -----Urspr?ngliche Nachricht----- Von: vtk-developers [mailto:vtk-developers-bounces at vtk.org] Im Auftrag von Marcus D. Hanwell Gesendet: Donnerstag, 14. Mai 2015 17:40 An: David Lonie Cc: VTK Developers Betreff: Re: [vtk-developers] Antialiasing broken in Qt5 Good to know, we need to do more testing with Qt 5 it seems, the API is pretty close but a lot fo the way they do platform abstraction chanegd (moving into plugins for each platform). I have ParaView build with Qt 5 here, and can try to dig into this a little more if I can find some time. On Thu, May 14, 2015 at 10:21 AM, David Lonie wrote: > I setup a Qt5 build, and this is indeed a problem. > > It looks like we'll need to do some more work to get VTK to play nice > with Qt5, at least on X11 (possibly other windowing systems as well). > The root cause of the multisampling problem is that Qt5 no longer > provides things like Q_WS_X11 and QX11Info, and the section of > QVTKWidget::SetRenderWindow that initializes the GLX visual is inside > a "#ifdef Q_WS_X11" block, and thus never gets called. It appears that > all of the visual configuration (double buffering, stencil, MSAA, > alpha planes, etc) are currently not being used when build against Qt5 on (at least) X11 as a result. > > For now, the only workaround I see is to stick with Qt4 until this can > be addressed. I've filed a bug here: > > http://www.vtk.org/Bug/view.php?id=15469 > > Dave > > On Tue, May 12, 2015 at 8:32 AM, David Lonie > wrote: >> >> Bumping -- can someone with a Qt5 build around do a quick test to see >> if multisampling works in a QVTKWidget? Has anyone been working on >> Qt5 support that might have an idea what's happening? >> >> On Thu, May 7, 2015 at 9:17 AM, David Lonie >> wrote: >>> >>> On Thu, May 7, 2015 at 8:31 AM, Christoph Kolb >>> wrote: >>>> >>>> your fix works for me in the RGrid example and also in SimpleView >>>> with Qt4. >>>> But not in Qt5. >>>> If you run the SimpleView example with Qt5, multisampling is off >>>> again which is inexplicable to me because in my understanding the >>>> QVTKWidget was simply painting the GL buffer rendered by a >>>> vtkRenderWindow which should already be antialiased... Is that wrong? >>> >>> >>> Hmm, I'm not super familiar with the Qt layer in VTK. Perhaps >>> someone else on the list might know? >>> >>> Looking at the QVTKWidget implementation, I don't see why the Qt >>> version would make a difference regarding MSAA. Let's see if someone >>> on the list has any ideas, and I'll ask around to see what I can find out. >>> >>> Dave >> >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: > http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Search the list archives at: http://markmail.org/search/?q=vtk-developers Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/vtk-developers From david.lonie at kitware.com Tue May 26 12:35:56 2015 From: david.lonie at kitware.com (David Lonie) Date: Tue, 26 May 2015 12:35:56 -0400 Subject: [vtk-developers] Antialiasing broken in Qt5 In-Reply-To: <57EE86D11538B44096C712532DBB6C5A012EF303CBB7@DKFZEX01.ad.dkfz-heidelberg.de> References: <57EE86D11538B44096C712532DBB6C5A012EF303CBB7@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: On Tue, May 26, 2015 at 11:50 AM, Kilgus, Thomas < t.kilgus at dkfz-heidelberg.de> wrote: > Hi Marcus and David, > > I would love to make this run with Qt5 for a demo application. Is there > any (straightforward) job I can take care of to help tracking down the > issue? > The issue is that the QVTKWidget has some platform specific code to initialize the render window. Trouble is, it goes through a convenience API provided by Qt (Q_WS_X11, QX11Info, etc) to detect and handle the X11 backend, and these interfaces/preprocessor defs are not available in Qt5. At a minimum, the Qt/X11 code would need to be rewritten to use pure X11 APIs to get this working. I don't think anyone has started on this if you wanted to make a pass at it. Best, Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From ashray.malhotra.1994 at gmail.com Tue May 26 17:00:56 2015 From: ashray.malhotra.1994 at gmail.com (Ashray Malhotra) Date: Wed, 27 May 2015 02:30:56 +0530 Subject: [vtk-developers] XCode upgrade breaks VTK build process(Suspected reason for build fail) In-Reply-To: References: Message-ID: It worked! "git clean" came to the rescue! Regards Ashray Malhotra On Fri, May 22, 2015 at 1:17 AM, Ashray Malhotra < ashray.malhotra.1994 at gmail.com> wrote: > Hello, > > I was trying to build VTK but it showed me some errors today. I think the > error might be related to the fact that I upgraded my XCode to version > 6.3.2 last night and the error log(http://tinyurl.com/jwf4jky) suggests > that. > > I tried building VTK after a warning fix, but it didn't work. I also tried > building the current master branch and also v6.2.0 but none of them was > successfully. > > I am new to VTK and hence was trying to run through the tutorials( > http://tinyurl.com/m2kb3g4) to learn VTK but when I cmake the first > tutorial, it shows me that vtkRendering module isn't available. Is it > because the build process failed? Note that I have built VTK successfully > many times on my machine, so isn't the previous successful build used to > run the code in an event the new build fails? > > Please let me know where I am going wrong. > > Thanks a lot. > > -- > Regards > Ashray Malhotra > GSOC Student > -- Regards Ashray Malhotra -------------- next part -------------- An HTML attachment was scrubbed... URL: From mathieu.westphal at kitware.com Wed May 27 10:04:22 2015 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Wed, 27 May 2015 16:04:22 +0200 Subject: [vtk-developers] Bug with pcoords[2] in vtkQuad::EvaluatePosition() Message-ID: I've just submitted a bug in mantis http://www.vtk.org/Bug/view.php?id=15491 pcoords[2] is not overwrited when i think should. The thing is, this but may be present in every 2D cell type. I've checked vtkTriangle, but this one seems ok, pcoords[2] is overwriten. What do you think about it ? Mathieu Westphal -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Wed May 27 11:45:49 2015 From: berk.geveci at kitware.com (Berk Geveci) Date: Wed, 27 May 2015 11:45:49 -0400 Subject: [vtk-developers] Bug with pcoords[2] in vtkQuad::EvaluatePosition() In-Reply-To: References: Message-ID: Hi Mathieu, I don't see that issue in the tracker... -berk On Wed, May 27, 2015 at 10:04 AM, Mathieu Westphal < mathieu.westphal at kitware.com> wrote: > I've just submitted a bug in mantis > http://www.vtk.org/Bug/view.php?id=15491 > > pcoords[2] is not overwrited when i think should. > > The thing is, this but may be present in every 2D cell type. > I've checked vtkTriangle, but this one seems ok, pcoords[2] is overwriten. > > What do you think about it ? > > Mathieu Westphal > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From joachim.pouderoux at kitware.com Wed May 27 11:48:36 2015 From: joachim.pouderoux at kitware.com (Joachim Pouderoux) Date: Wed, 27 May 2015 17:48:36 +0200 Subject: [vtk-developers] Bug with pcoords[2] in vtkQuad::EvaluatePosition() In-Reply-To: References: Message-ID: Sorry, here is the correct entry link: http://www.vtk.org/Bug/view.php?id=15493 *Joachim Pouderoux* *PhD, Technical Expert* *Kitware SAS * 2015-05-27 17:45 GMT+02:00 Berk Geveci : > Hi Mathieu, > > I don't see that issue in the tracker... > > -berk > > > On Wed, May 27, 2015 at 10:04 AM, Mathieu Westphal < > mathieu.westphal at kitware.com> wrote: > >> I've just submitted a bug in mantis >> http://www.vtk.org/Bug/view.php?id=15491 >> >> pcoords[2] is not overwrited when i think should. >> >> The thing is, this but may be present in every 2D cell type. >> I've checked vtkTriangle, but this one seems ok, pcoords[2] is overwriten. >> >> What do you think about it ? >> >> Mathieu Westphal >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Wed May 27 12:10:31 2015 From: berk.geveci at kitware.com (Berk Geveci) Date: Wed, 27 May 2015 12:10:31 -0400 Subject: [vtk-developers] Bug with pcoords[2] in vtkQuad::EvaluatePosition() In-Reply-To: References: Message-ID: Ah! I confirm that this is a bug. Any code that generically works on 2D and 3D cells will trip over this in mixed 2D-3D cells situations as well as if the outer code does not initialize pcoords to 0 initially. So any cell type that uses a 2D parametric coordinate system should initialize the 3rd value to 0. Please submit a fix for quad and I'll review/approve it. If you have some cycles, I recommend checking the other 2D cells too... On Wed, May 27, 2015 at 11:48 AM, Joachim Pouderoux < joachim.pouderoux at kitware.com> wrote: > Sorry, here is the correct entry link: > http://www.vtk.org/Bug/view.php?id=15493 > > *Joachim Pouderoux* > > *PhD, Technical Expert* > *Kitware SAS * > > > 2015-05-27 17:45 GMT+02:00 Berk Geveci : > >> Hi Mathieu, >> >> I don't see that issue in the tracker... >> >> -berk >> >> >> On Wed, May 27, 2015 at 10:04 AM, Mathieu Westphal < >> mathieu.westphal at kitware.com> wrote: >> >>> I've just submitted a bug in mantis >>> http://www.vtk.org/Bug/view.php?id=15491 >>> >>> pcoords[2] is not overwrited when i think should. >>> >>> The thing is, this but may be present in every 2D cell type. >>> I've checked vtkTriangle, but this one seems ok, pcoords[2] is >>> overwriten. >>> >>> What do you think about it ? >>> >>> Mathieu Westphal >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >>> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From mathieu.westphal at kitware.com Thu May 28 03:40:25 2015 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Thu, 28 May 2015 09:40:25 +0200 Subject: [vtk-developers] Bug with pcoords[2] in vtkQuad::EvaluatePosition() In-Reply-To: References: Message-ID: Here is the results of my enquiries on different cell types for evaluatePosition: vtkEmptyCell : pcoords not set at all, nor any output parameters. vtkVertex : pcoords[2] is not set vtkPolyVertex : pcoords[1] and pcoords[2] are not set vtkPolygon : pcoords[2] is not set vtkQuad : pcoords[2] is not set All other vtkCell implementation does set all pcoords, dist2 and closestPoints Do we set it to 0 ? do you know why vtkTriangle compute it this way when this is a 2D cell? (vtkTriangle.cxx:142) Mathieu Westphal On Wed, May 27, 2015 at 6:10 PM, Berk Geveci wrote: > Ah! I confirm that this is a bug. Any code that generically works on 2D > and 3D cells will trip over this in mixed 2D-3D cells situations as well as > if the outer code does not initialize pcoords to 0 initially. So any cell > type that uses a 2D parametric coordinate system should initialize the 3rd > value to 0. Please submit a fix for quad and I'll review/approve it. If you > have some cycles, I recommend checking the other 2D cells too... > > On Wed, May 27, 2015 at 11:48 AM, Joachim Pouderoux < > joachim.pouderoux at kitware.com> wrote: > >> Sorry, here is the correct entry link: >> http://www.vtk.org/Bug/view.php?id=15493 >> >> *Joachim Pouderoux* >> >> *PhD, Technical Expert* >> *Kitware SAS * >> >> >> 2015-05-27 17:45 GMT+02:00 Berk Geveci : >> >>> Hi Mathieu, >>> >>> I don't see that issue in the tracker... >>> >>> -berk >>> >>> >>> On Wed, May 27, 2015 at 10:04 AM, Mathieu Westphal < >>> mathieu.westphal at kitware.com> wrote: >>> >>>> I've just submitted a bug in mantis >>>> http://www.vtk.org/Bug/view.php?id=15491 >>>> >>>> pcoords[2] is not overwrited when i think should. >>>> >>>> The thing is, this but may be present in every 2D cell type. >>>> I've checked vtkTriangle, but this one seems ok, pcoords[2] is >>>> overwriten. >>>> >>>> What do you think about it ? >>>> >>>> Mathieu Westphal >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: >>>> http://markmail.org/search/?q=vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://public.kitware.com/mailman/listinfo/vtk-developers >>>> >>>> >>>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From mathieu.westphal at kitware.com Thu May 28 05:36:36 2015 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Thu, 28 May 2015 11:36:36 +0200 Subject: [vtk-developers] Bug with pcoords[2] in vtkQuad::EvaluatePosition() In-Reply-To: References: Message-ID: It seems some methods have not been thought with the 'output param must be set' mindset i've managed to fix most methods in all vtkCell implementation (i've mainly Check linear 2D cells, as other implementation seemed to be alright ) but i've left the Contour and Clip methods out, not knowing if it should reset some parameters. i've encountered some pcoords[0] = -10 ( really old code, 1994 ), is it relevant in any way ? See my new merge request : https://gitlab.kitware.com/vtk/vtk/merge_requests/247 please let me know what you think, i hope that i've not overdone it. Mathieu Westphal PS : subId for non composite cell should be set to -1 instead of 0 shouldn't it ? On Thu, May 28, 2015 at 9:40 AM, Mathieu Westphal < mathieu.westphal at kitware.com> wrote: > Here is the results of my enquiries on different cell types for > evaluatePosition: > vtkEmptyCell : pcoords not set at all, nor any output parameters. > vtkVertex : pcoords[2] is not set > vtkPolyVertex : pcoords[1] and pcoords[2] are not set > vtkPolygon : pcoords[2] is not set > vtkQuad : pcoords[2] is not set > > All other vtkCell implementation does set all pcoords, dist2 and > closestPoints > > Do we set it to 0 ? do you know why vtkTriangle compute it this way when > this is a 2D cell? (vtkTriangle.cxx:142) > > Mathieu Westphal > > On Wed, May 27, 2015 at 6:10 PM, Berk Geveci > wrote: > >> Ah! I confirm that this is a bug. Any code that generically works on 2D >> and 3D cells will trip over this in mixed 2D-3D cells situations as well as >> if the outer code does not initialize pcoords to 0 initially. So any cell >> type that uses a 2D parametric coordinate system should initialize the 3rd >> value to 0. Please submit a fix for quad and I'll review/approve it. If you >> have some cycles, I recommend checking the other 2D cells too... >> >> On Wed, May 27, 2015 at 11:48 AM, Joachim Pouderoux < >> joachim.pouderoux at kitware.com> wrote: >> >>> Sorry, here is the correct entry link: >>> http://www.vtk.org/Bug/view.php?id=15493 >>> >>> *Joachim Pouderoux* >>> >>> *PhD, Technical Expert* >>> *Kitware SAS * >>> >>> >>> 2015-05-27 17:45 GMT+02:00 Berk Geveci : >>> >>>> Hi Mathieu, >>>> >>>> I don't see that issue in the tracker... >>>> >>>> -berk >>>> >>>> >>>> On Wed, May 27, 2015 at 10:04 AM, Mathieu Westphal < >>>> mathieu.westphal at kitware.com> wrote: >>>> >>>>> I've just submitted a bug in mantis >>>>> http://www.vtk.org/Bug/view.php?id=15491 >>>>> >>>>> pcoords[2] is not overwrited when i think should. >>>>> >>>>> The thing is, this but may be present in every 2D cell type. >>>>> I've checked vtkTriangle, but this one seems ok, pcoords[2] is >>>>> overwriten. >>>>> >>>>> What do you think about it ? >>>>> >>>>> Mathieu Westphal >>>>> >>>>> _______________________________________________ >>>>> Powered by www.kitware.com >>>>> >>>>> Visit other Kitware open-source projects at >>>>> http://www.kitware.com/opensource/opensource.html >>>>> >>>>> Search the list archives at: >>>>> http://markmail.org/search/?q=vtk-developers >>>>> >>>>> Follow this link to subscribe/unsubscribe: >>>>> http://public.kitware.com/mailman/listinfo/vtk-developers >>>>> >>>>> >>>>> >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: >>>> http://markmail.org/search/?q=vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://public.kitware.com/mailman/listinfo/vtk-developers >>>> >>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From t.kilgus at Dkfz-Heidelberg.de Thu May 28 05:51:01 2015 From: t.kilgus at Dkfz-Heidelberg.de (Kilgus, Thomas) Date: Thu, 28 May 2015 11:51:01 +0200 Subject: [vtk-developers] Antialiasing broken in Qt5 In-Reply-To: References: <57EE86D11538B44096C712532DBB6C5A012EF303CBB7@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: <57EE86D11538B44096C712532DBB6C5A012EF303CD76@DKFZEX01.ad.dkfz-heidelberg.de> I am not sure if I get this right. I should remove the Qt dependency from the initialization of the QVTKWidget? But this is widget is Qt dependent per definition? I guess I would not really know what I am doing, since I have no experience with X11. But I could start to make the code compile and check if there is any Qt5 migration guide for these interfaces and defs, if that helps. Regards, Thomas Von: David Lonie [mailto:david.lonie at kitware.com] Gesendet: Dienstag, 26. Mai 2015 18:36 An: Kilgus, Thomas Cc: Marcus D. Hanwell; VTK Developers Betreff: Re: [vtk-developers] Antialiasing broken in Qt5 On Tue, May 26, 2015 at 11:50 AM, Kilgus, Thomas > wrote: Hi Marcus and David, I would love to make this run with Qt5 for a demo application. Is there any (straightforward) job I can take care of to help tracking down the issue? The issue is that the QVTKWidget has some platform specific code to initialize the render window. Trouble is, it goes through a convenience API provided by Qt (Q_WS_X11, QX11Info, etc) to detect and handle the X11 backend, and these interfaces/preprocessor defs are not available in Qt5. At a minimum, the Qt/X11 code would need to be rewritten to use pure X11 APIs to get this working. I don't think anyone has started on this if you wanted to make a pass at it. Best, Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Thu May 28 05:53:39 2015 From: will.schroeder at kitware.com (Will Schroeder) Date: Thu, 28 May 2015 05:53:39 -0400 Subject: [vtk-developers] Bug with pcoords[2] in vtkQuad::EvaluatePosition() In-Reply-To: References: Message-ID: On Thu, May 28, 2015 at 3:40 AM, Mathieu Westphal < mathieu.westphal at kitware.com> wrote: > Do we set it to 0 ? do you know why vtkTriangle compute it this way when > this is a 2D cell? (vtkTriangle.cxx:142) I believe this (1-r-s) his follows from the isoparametric coordinates for triangular elements. Check any standard finite element reference. -- William J. Schroeder, PhD Kitware, Inc. 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Thu May 28 06:06:05 2015 From: will.schroeder at kitware.com (Will Schroeder) Date: Thu, 28 May 2015 06:06:05 -0400 Subject: [vtk-developers] Bug with pcoords[2] in vtkQuad::EvaluatePosition() In-Reply-To: References: Message-ID: On Thu, May 28, 2015 at 5:36 AM, Mathieu Westphal < mathieu.westphal at kitware.com> wrote: > i've encountered some pcoords[0] = -10 ( really old code, 1994 ), is it > relevant in any way ? Here's my guess: Often in finite element (or some parameterized) formulations the parameter t is assumed to lie in the range (-1<=t<=1). It could be that when this code was first written that was the assumption; only later did we adjust the parameterization to (0,1). If this was the case, then "marking" the point to lie outside the parameter range then a value < -1 was used (i.e., -10). I'm not sure why you feel that you have to change this to -1 since the number is arbitrary.... W -- William J. Schroeder, PhD Kitware, Inc. 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lonie at kitware.com Thu May 28 08:15:57 2015 From: david.lonie at kitware.com (David Lonie) Date: Thu, 28 May 2015 08:15:57 -0400 Subject: [vtk-developers] Antialiasing broken in Qt5 In-Reply-To: <57EE86D11538B44096C712532DBB6C5A012EF303CD76@DKFZEX01.ad.dkfz-heidelberg.de> References: <57EE86D11538B44096C712532DBB6C5A012EF303CBB7@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF303CD76@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: On Thu, May 28, 2015 at 5:51 AM, Kilgus, Thomas wrote: > I am not sure if I get this right. I should remove the Qt dependency from > the initialization of the QVTKWidget? But this is widget is Qt dependent > per definition? I guess I would not really know what I am doing, since I > have no experience with X11. But I could start to make the code compile and > check if there is any Qt5 migration guide for these interfaces and defs, if > that helps. > The entire Qt dependency doesn't need to be removed, just the Qt/X11 specific stuff that is deprecated for Qt 5. I'm sure this will eventually become a big enough priority for a team here to address it, but I have no idea when that would happen. Until then, treat Qt5 support as experimental -- you'll be venturing into uncharted waters outside of Qt4, and some parts may require assembly :) Cheers, Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Thu May 28 08:51:33 2015 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Thu, 28 May 2015 08:51:33 -0400 Subject: [vtk-developers] Antialiasing broken in Qt5 In-Reply-To: References: <57EE86D11538B44096C712532DBB6C5A012EF303CBB7@DKFZEX01.ad.dkfz-heidelberg.de> <57EE86D11538B44096C712532DBB6C5A012EF303CD76@DKFZEX01.ad.dkfz-heidelberg.de> Message-ID: Just a side note: we'll be looking into this "soon" since ParaView will be using Qt 5 by default for the binaries we distribute for the next release. Utkarsh On Thu, May 28, 2015 at 8:15 AM, David Lonie wrote: > On Thu, May 28, 2015 at 5:51 AM, Kilgus, Thomas > wrote: >> >> I am not sure if I get this right. I should remove the Qt dependency from >> the initialization of the QVTKWidget? But this is widget is Qt dependent per >> definition? I guess I would not really know what I am doing, since I have no >> experience with X11. But I could start to make the code compile and check if >> there is any Qt5 migration guide for these interfaces and defs, if that >> helps. > > > The entire Qt dependency doesn't need to be removed, just the Qt/X11 > specific stuff that is deprecated for Qt 5. I'm sure this will eventually > become a big enough priority for a team here to address it, but I have no > idea when that would happen. Until then, treat Qt5 support as experimental > -- you'll be venturing into uncharted waters outside of Qt4, and some parts > may require assembly :) > > Cheers, > Dave > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > From mathieu.westphal at kitware.com Thu May 28 08:56:41 2015 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Thu, 28 May 2015 14:56:41 +0200 Subject: [vtk-developers] Bug with pcoords[2] in vtkQuad::EvaluatePosition() In-Reply-To: References: Message-ID: I agree, i'v talk too fast, there is confusion between pcoord and weights in vtkTriangle, i am correcting it right now and will add a commit and will test thoroughly. I agree, it became more than a bug fix, but if i could make this old code more coherent it would be nice. I understand what you say about folks depending an this old code, however the vtkTriangle code is not coherent with documentation and the definition of parametric coords in VTK. About the -10 thing, well we should choose an arbitrary value to apply everywhere in in vtkCell for the case when a pcoords cannot be computed and stick to it -10 or -1 is not a problem to me. I would gladly talk on the phone anytime. Mathieu Westphal On Thu, May 28, 2015 at 2:47 PM, Will Schroeder wrote: > > On Thu, May 28, 2015 at 8:10 AM, Mathieu Westphal < > mathieu.westphal at kitware.com> wrote: > >> I do agree about your point, however the current >> vtkTriangle::evaluatePosition implementation compute r and s in the plane >> defined by the triangle, using only the projected point to compute them, so >> they are not isoparametric becau > > > I recommend that you look at the code more carefully. The pcoords[2] value > is used later in the code to determine isoparametric coords (the > weights[3]) and to determine the closest point in EvaluatePosition. At the > conclusion of this computation, you could probably set pcoords[2]=0.0; > hopefully you are testing these changes thoroughly (I'm sorry I don't have > the time to test at the moment). I'm worried that you are on a path to make > somewhat arbitrary changes that go beyond just making a bug fix, there may > be folks out there that depend on the current behavior (for example setting > value -10 rather than -1). > > We may need to get on the phone at some point since this is complex enough > that email may not hack it. > > W > > > -- > William J. Schroeder, PhD > Kitware, Inc. > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > -------------- next part -------------- An HTML attachment was scrubbed... URL: From mathieu.westphal at kitware.com Thu May 28 09:22:12 2015 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Thu, 28 May 2015 15:22:12 +0200 Subject: [vtk-developers] vtkTriangle::IntersectWithLine hard test bug Message-ID: In vtkTriangle IntersectWithLine there is a "hard" part for when the easy test have not been able to compute intersection vtkTriangle.cxx:530 However, the only way to reach this part of the code is when the test (evaluatePosition) line 516 returns -1. The only way for vtkTriangle::evaluatePosition to return -1 is when the triangle is flat ( degenerated ), and in that case, pcoords are forced to zero. Then the following three tests, 539, 544, 555 will never succeed. So it looks like this "hard" code never succeed into finding intersection, which is not very important. Also degenerated triangle cannot be interessected, which is important. What do you think about it ? Mathieu Westphal -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Thu May 28 09:58:05 2015 From: will.schroeder at kitware.com (Will Schroeder) Date: Thu, 28 May 2015 09:58:05 -0400 Subject: [vtk-developers] vtkTriangle::IntersectWithLine hard test bug In-Reply-To: References: Message-ID: In the past I have encountered situations where picking (or some other operation that depends on intersect with line) failed due to degenerate triangles. So I suggest that we have to build a test to explicitly test for it. For example, say you read in some polygonal soup that includes degenerate triangles (maybe zero area "needles" or even triangles collapsed to a point). Now you want to visually identify these bad triangles via picking, etc. For example you run a shrink filter that isolates the triangles so you can clearly see them (even if they are degenerate). If you remove the degenerate intersection code you may never be able to select these degenerate triangles (if using intersect with line). W On Thu, May 28, 2015 at 9:22 AM, Mathieu Westphal < mathieu.westphal at kitware.com> wrote: > In vtkTriangle IntersectWithLine there is a "hard" part for when the easy > test have not been able to compute intersection > vtkTriangle.cxx:530 > > However, the only way to reach this part of the code is when the test > (evaluatePosition) line 516 returns -1. > > The only way for vtkTriangle::evaluatePosition to return -1 is when the > triangle is flat ( degenerated ), and in that case, pcoords are forced to > zero. > > Then the following three tests, 539, 544, 555 will never succeed. > > So it looks like this "hard" code never succeed into finding intersection, > which is not very important. > Also degenerated triangle cannot be interessected, which is important. > > What do you think about it ? > > Mathieu Westphal > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -- William J. Schroeder, PhD Kitware, Inc. 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Thu May 28 10:09:44 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 28 May 2015 10:09:44 -0400 Subject: [vtk-developers] vtkTriangle::IntersectWithLine hard test bug In-Reply-To: References: Message-ID: According to this coverage report, http://lorensen.github.io/VTKCodeCoverage/VTK/Common/DataModel/vtkTriangle.cxx.gcov.html the "hard" code is never tested. On Thu, May 28, 2015 at 9:58 AM, Will Schroeder wrote: > In the past I have encountered situations where picking (or some other > operation that depends on intersect with line) failed due to degenerate > triangles. So I suggest that we have to build a test to explicitly test for > it. > > For example, say you read in some polygonal soup that includes degenerate > triangles (maybe zero area "needles" or even triangles collapsed to a > point). Now you want to visually identify these bad triangles via picking, > etc. For example you run a shrink filter that isolates the triangles so you > can clearly see them (even if they are degenerate). If you remove the > degenerate intersection code you may never be able to select these > degenerate triangles (if using intersect with line). > > W > > On Thu, May 28, 2015 at 9:22 AM, Mathieu Westphal > wrote: >> >> In vtkTriangle IntersectWithLine there is a "hard" part for when the easy >> test have not been able to compute intersection >> vtkTriangle.cxx:530 >> >> However, the only way to reach this part of the code is when the test >> (evaluatePosition) line 516 returns -1. >> >> The only way for vtkTriangle::evaluatePosition to return -1 is when the >> triangle is flat ( degenerated ), and in that case, pcoords are forced to >> zero. >> >> Then the following three tests, 539, 544, 555 will never succeed. >> >> So it looks like this "hard" code never succeed into finding intersection, >> which is not very important. >> Also degenerated triangle cannot be interessected, which is important. >> >> What do you think about it ? >> >> Mathieu Westphal >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> > > > > -- > William J. Schroeder, PhD > Kitware, Inc. > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- Unpaid intern in BillsBasement at noware dot com From lonni.besancon at gmail.com Thu May 28 10:29:14 2015 From: lonni.besancon at gmail.com (=?UTF-8?Q?Lonni_Besan=C3=A7on?=) Date: Thu, 28 May 2015 07:29:14 -0700 (MST) Subject: [vtk-developers] VTK, CMake error with android build Message-ID: <1432823354028-5732043.post@n5.nabble.com> Hello, I am trying to build VTK on a MACOS X machine. I want to be able to develop on mobile so that I checked the android support when cmaking. Without that option, everything is working fine, but with the android option I finally get the error that you can see in the two screenshots. I really don't know how to fix it and would like to get some help. Thanks in advance Best, Lonni -- View this message in context: http://vtk.1045678.n5.nabble.com/VTK-CMake-error-with-android-build-tp5732043.html Sent from the VTK - Dev mailing list archive at Nabble.com. From lonni.besancon at gmail.com Thu May 28 10:30:12 2015 From: lonni.besancon at gmail.com (=?UTF-8?Q?Lonni_Besan=C3=A7on?=) Date: Thu, 28 May 2015 07:30:12 -0700 (MST) Subject: [vtk-developers] VTK, CMake error with android build In-Reply-To: <1432823354028-5732043.post@n5.nabble.com> References: <1432823354028-5732043.post@n5.nabble.com> Message-ID: <1432823412633-5732044.post@n5.nabble.com> Looks like there was an error on my first screenshot which should have been: -- View this message in context: http://vtk.1045678.n5.nabble.com/VTK-CMake-error-with-android-build-tp5732043p5732044.html Sent from the VTK - Dev mailing list archive at Nabble.com. From dave.demarle at kitware.com Thu May 28 22:51:54 2015 From: dave.demarle at kitware.com (David E DeMarle) Date: Thu, 28 May 2015 22:51:54 -0400 Subject: [vtk-developers] VTK, CMake error with android build In-Reply-To: <1432823412633-5732044.post@n5.nabble.com> References: <1432823354028-5732043.post@n5.nabble.com> <1432823412633-5732044.post@n5.nabble.com> Message-ID: Hmm, looks like a bug in VTK with that specific compiler toolchain to me. What specific OSX and Xcode versions do you have? Mind sending us the CMakeCache.txt file in your build tree where this is failing? thanks David E DeMarle Kitware, Inc. R&D Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4909 On Thu, May 28, 2015 at 10:30 AM, Lonni Besan?on wrote: > Looks like there was an error on my first screenshot which should have > been: > < > http://vtk.1045678.n5.nabble.com/file/n5732044/Screen_Shot_2015-05-28_at_16.png > > > > > > -- > View this message in context: > http://vtk.1045678.n5.nabble.com/VTK-CMake-error-with-android-build-tp5732043p5732044.html > Sent from the VTK - Dev mailing list archive at Nabble.com. > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From lonni.besancon at gmail.com Fri May 29 03:45:58 2015 From: lonni.besancon at gmail.com (=?UTF-8?Q?Lonni_Besan=C3=A7on?=) Date: Fri, 29 May 2015 00:45:58 -0700 (MST) Subject: [vtk-developers] VTK, CMake error with android build In-Reply-To: References: <1432823354028-5732043.post@n5.nabble.com> <1432823412633-5732044.post@n5.nabble.com> Message-ID: <1432885558912-5732052.post@n5.nabble.com> I'm using Yosemite and Version 6.3.1 of Xcode. Sure the CMakeCache follows. Thanks for helping out. -- View this message in context: http://vtk.1045678.n5.nabble.com/VTK-CMake-error-with-android-build-tp5732043p5732052.html Sent from the VTK - Dev mailing list archive at Nabble.com. From lonni.besancon at gmail.com Fri May 29 03:47:35 2015 From: lonni.besancon at gmail.com (=?UTF-8?Q?Lonni_Besan=C3=A7on?=) Date: Fri, 29 May 2015 00:47:35 -0700 (MST) Subject: [vtk-developers] VTK, CMake error with android build In-Reply-To: <1432885558912-5732052.post@n5.nabble.com> References: <1432823354028-5732043.post@n5.nabble.com> <1432823412633-5732044.post@n5.nabble.com> <1432885558912-5732052.post@n5.nabble.com> Message-ID: <1432885655008-5732053.post@n5.nabble.com> Not sure if the CMakeCache was included or not. In case it was not, I try again. Feel free to remove this post if it was included in the end. CMakeCache.txt -- View this message in context: http://vtk.1045678.n5.nabble.com/VTK-CMake-error-with-android-build-tp5732043p5732053.html Sent from the VTK - Dev mailing list archive at Nabble.com. From andrew.amaclean at gmail.com Fri May 29 04:14:13 2015 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Fri, 29 May 2015 18:14:13 +1000 Subject: [vtk-developers] Statistics Friday Message-ID: Hi All, Well Thursday here. I have been working on a little program to trawl the testing directories in VTK. If you are interested, here are some preliminary results. In summary, there are 2040 tests of which 1925 are actually tested, 37 tests are disabled in the CmakeLists.txt file whilst there are 72 tests that are never appear in the CmakeLists.txt files. There are good reasons for some tests never appearing in the CmakeLists.txt file as some of these may be called by other tests e.g. backdrop.py, backdrop.tcl. If you want to know what these tests are please see the appropriately named attachments. All tests. ---------------------------------------- Unique Cxx tests : 1046 Total number of Cxx tests : 1060 ---------------------------------------- Unique Python tests : 95 Total number of Python tests : 537 ---------------------------------------- Unique Tcl tests : 8 Total number of Tcl tests : 443 ---------------------------------------- Total number of unique tests : 1149 Total number of tests : 2040 ---------------------------------------- ---------------------------------------- Enabled tests. ---------------------------------------- Unique Cxx tests : 972 Total number of Cxx tests : 986 ---------------------------------------- Unique Python tests : 95 Total number of Python tests : 514 ---------------------------------------- Unique Tcl tests : 14 Total number of Tcl tests : 425 ---------------------------------------- Total number of unique tests : 1081 Total number of tests : 1925 ---------------------------------------- ---------------------------------------- Disabled tests. ---------------------------------------- Unique Cxx tests : 23 Total number of Cxx tests : 23 ---------------------------------------- Unique Python tests : 10 Total number of Python tests : 10 ---------------------------------------- Unique Tcl tests : 4 Total number of Tcl tests : 4 ---------------------------------------- Total number of unique tests : 37 Total number of tests : 37 ---------------------------------------- ---------------------------------------- Not in CmakeLists.txt. ---------------------------------------- Unique Cxx tests : 51 Total number of Cxx tests : 51 ---------------------------------------- Unique Python tests : 5 Total number of Python tests : 7 ---------------------------------------- Unique Tcl tests : 12 Total number of Tcl tests : 14 ---------------------------------------- Total number of unique tests : 68 Total number of tests : 72 ---------------------------------------- Regards Andrew -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: Disabledtests.txt.zip Type: application/zip Size: 794 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: TestsNotInCmakeLists.txt.zip Type: application/zip Size: 1124 bytes Desc: not available URL: From dave.demarle at kitware.com Fri May 29 10:20:45 2015 From: dave.demarle at kitware.com (David E DeMarle) Date: Fri, 29 May 2015 10:20:45 -0400 Subject: [vtk-developers] Statistics Friday In-Reply-To: References: Message-ID: Nice! Would be great to have your little program that trawls the directories in $VTKSRC/Utilities/Maintenance. David E DeMarle Kitware, Inc. R&D Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4909 On Fri, May 29, 2015 at 4:14 AM, Andrew Maclean wrote: > Hi All, > Well Thursday here. > > I have been working on a little program to trawl the testing directories > in VTK. > > If you are interested, here are some preliminary results. > In summary, there are 2040 tests of which 1925 are actually tested, 37 > tests are disabled in the CmakeLists.txt file whilst there are 72 tests > that are never appear in the CmakeLists.txt files. There are good reasons > for some tests never appearing in the CmakeLists.txt file as some of these > may be called by other tests e.g. backdrop.py, backdrop.tcl. > > If you want to know what these tests are please see the appropriately > named attachments. > > > All tests. > ---------------------------------------- > Unique Cxx tests : 1046 > Total number of Cxx tests : 1060 > ---------------------------------------- > Unique Python tests : 95 > Total number of Python tests : 537 > ---------------------------------------- > Unique Tcl tests : 8 > Total number of Tcl tests : 443 > ---------------------------------------- > Total number of unique tests : 1149 > Total number of tests : 2040 > ---------------------------------------- > > ---------------------------------------- > Enabled tests. > ---------------------------------------- > Unique Cxx tests : 972 > Total number of Cxx tests : 986 > ---------------------------------------- > Unique Python tests : 95 > Total number of Python tests : 514 > ---------------------------------------- > Unique Tcl tests : 14 > Total number of Tcl tests : 425 > ---------------------------------------- > Total number of unique tests : 1081 > Total number of tests : 1925 > ---------------------------------------- > > ---------------------------------------- > Disabled tests. > ---------------------------------------- > Unique Cxx tests : 23 > Total number of Cxx tests : 23 > ---------------------------------------- > Unique Python tests : 10 > Total number of Python tests : 10 > ---------------------------------------- > Unique Tcl tests : 4 > Total number of Tcl tests : 4 > ---------------------------------------- > Total number of unique tests : 37 > Total number of tests : 37 > ---------------------------------------- > > ---------------------------------------- > Not in CmakeLists.txt. > ---------------------------------------- > Unique Cxx tests : 51 > Total number of Cxx tests : 51 > ---------------------------------------- > Unique Python tests : 5 > Total number of Python tests : 7 > ---------------------------------------- > Unique Tcl tests : 12 > Total number of Tcl tests : 14 > ---------------------------------------- > Total number of unique tests : 68 > Total number of tests : 72 > ---------------------------------------- > > > Regards > Andrew > -- > ___________________________________________ > Andrew J. P. Maclean > > ___________________________________________ > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Fri May 29 10:50:11 2015 From: berk.geveci at kitware.com (Berk Geveci) Date: Fri, 29 May 2015 10:50:11 -0400 Subject: [vtk-developers] ANNOUNCE: Kitware is hiring Message-ID: Hi folks, We are looking to hire visualization developers to our Scientific Computing team. If you are a talented visualization researcher and developer with strong C++ skills, please consider applying. You will join a great team and work on many interesting and challenging technical problems - always aiming to deliver robust and widely used software solutions. For the full posting see: http://tinyurl.com/l8sgvzw JOB DESCRIPTION Kitware is seeking to hire highly skilled Research and Development Engineers (R&D Engineers) to join our Scientific Computing team and contribute to our scientific and information visualization efforts. Candidates will work to develop and improve leading visualization software solutions. Kitware collaborates on a multitude of basic and applied research and development projects. Our collaborators include the top universities from around the world, national research labs, medical device manufacturers, car manufacturers, oil and gas companies, financial institutes, and many others. The projects range from extending our open source C++ libraries and applications, such as VTK, ParaView, and CMake, to developing proprietary domain-specific vertical applications for a wide array of platforms including web and mobile devices. By joining our team you will participate in a dynamic work environment with exceptionally talented and friendly coworkers who are committed to high-quality development practices. You will collaborate with esteemed researchers from around the world by: * Designing and developing scalable data analysis and visualization tools for use by researchers and professionals from various domains; * Solving a wide array of problems ranging from developing distributed memory parallel algorithms for data analysis, optimizing distributed parallel codes to compiling and maintaining software on supercomputers. * Designing and developing tools to improve scientific data analysis workflows; * Contributing to and supporting our dynamic open source communities built around several of our open source tools. -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Fri May 29 17:06:08 2015 From: sean at rogue-research.com (Sean McBride) Date: Fri, 29 May 2015 17:06:08 -0400 Subject: [vtk-developers] Minor syntax error in vtk_common.cmake? Message-ID: <20150529210608.24644284@mail.rogue-research.com> Hi all, I don't see this on any dashboard, but when I build VTK by hand on Rogue7 I see this: CMake Warning (dev) at external/_scripts/builder7/VTK-Xcode-rel-x86_64.cmake:86 (include): Syntax Warning in cmake code at /Users/builder/external/_scripts/vtk_common.cmake:426:21 Argument not separated from preceding token by whitespace. This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at external/_scripts/builder7/VTK-Xcode-rel-x86_64.cmake:86 (include): Syntax Warning in cmake code at /Users/builder/external/_scripts/vtk_common.cmake:431:21 Argument not separated from preceding token by whitespace. This warning is for project developers. Use -Wno-dev to suppress it. Is there a wee syntax error in vtk_common.cmake? Sean From aashish.chaudhary at kitware.com Fri May 29 17:31:34 2015 From: aashish.chaudhary at kitware.com (Aashish Chaudhary) Date: Fri, 29 May 2015 17:31:34 -0400 Subject: [vtk-developers] Volume Rendering Update Message-ID: Folks, We made some recent improvements to VTK volume rendering including fixes to related components. Here is a list of those changes: 1) Now new GPU Volume Mapper respect Interpolation Type (Linear or Nearest). Default is Nearest as in the last GPU mapper. 2) Shading is now twice as fast as before. There will be another branch to make it even faster. 3) Fixed lighting bug (number of lights kept on increasing with change in volume property) 4) Saving and Restoring GL state properly for textures 5) Bias and Scale are now performed in Shader. 6) We changed some GL texture format information to support OpenGL 3 context 7) Fixed extensions were not reported correctly on GL2 context 8) Fixed few failing tests specifically on Mesa 9) Removed VolumeOpenGLNew module as it was not as usable with OpenGL2 getting ready for primetime 10) Added convenience API to SmartVolume Mapper 11) Cleaned up logic for dealing with context changes in Volume Mapper Please let us know if you have any questions. Thanks, -- *| Aashish Chaudhary | Technical Leader | Kitware Inc. * *| http://www.kitware.com/company/team/chaudhary.html * -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Sat May 30 02:37:06 2015 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Sat, 30 May 2015 16:37:06 +1000 Subject: [vtk-developers] Statistics Friday In-Reply-To: References: Message-ID: Hi Dave, Done, it has been tested using Python 3.4 and Python 2.7.8/9 in Linux and Windows. Please see: https://gitlab.kitware.com/vtk/vtk/merge_requests/255 Andrew On Sat, May 30, 2015 at 12:20 AM, David E DeMarle wrote: > Nice! > > Would be great to have your little program that trawls the directories in > $VTKSRC/Utilities/Maintenance. > > > > David E DeMarle > Kitware, Inc. > R&D Engineer > 21 Corporate Drive > Clifton Park, NY 12065-8662 > Phone: 518-881-4909 > > On Fri, May 29, 2015 at 4:14 AM, Andrew Maclean > wrote: > >> Hi All, >> Well Thursday here. >> >> I have been working on a little program to trawl the testing directories >> in VTK. >> >> If you are interested, here are some preliminary results. >> In summary, there are 2040 tests of which 1925 are actually tested, 37 >> tests are disabled in the CmakeLists.txt file whilst there are 72 tests >> that are never appear in the CmakeLists.txt files. There are good reasons >> for some tests never appearing in the CmakeLists.txt file as some of these >> may be called by other tests e.g. backdrop.py, backdrop.tcl. >> >> If you want to know what these tests are please see the appropriately >> named attachments. >> >> >> All tests. >> ---------------------------------------- >> Unique Cxx tests : 1046 >> Total number of Cxx tests : 1060 >> ---------------------------------------- >> Unique Python tests : 95 >> Total number of Python tests : 537 >> ---------------------------------------- >> Unique Tcl tests : 8 >> Total number of Tcl tests : 443 >> ---------------------------------------- >> Total number of unique tests : 1149 >> Total number of tests : 2040 >> ---------------------------------------- >> >> ---------------------------------------- >> Enabled tests. >> ---------------------------------------- >> Unique Cxx tests : 972 >> Total number of Cxx tests : 986 >> ---------------------------------------- >> Unique Python tests : 95 >> Total number of Python tests : 514 >> ---------------------------------------- >> Unique Tcl tests : 14 >> Total number of Tcl tests : 425 >> ---------------------------------------- >> Total number of unique tests : 1081 >> Total number of tests : 1925 >> ---------------------------------------- >> >> ---------------------------------------- >> Disabled tests. >> ---------------------------------------- >> Unique Cxx tests : 23 >> Total number of Cxx tests : 23 >> ---------------------------------------- >> Unique Python tests : 10 >> Total number of Python tests : 10 >> ---------------------------------------- >> Unique Tcl tests : 4 >> Total number of Tcl tests : 4 >> ---------------------------------------- >> Total number of unique tests : 37 >> Total number of tests : 37 >> ---------------------------------------- >> >> ---------------------------------------- >> Not in CmakeLists.txt. >> ---------------------------------------- >> Unique Cxx tests : 51 >> Total number of Cxx tests : 51 >> ---------------------------------------- >> Unique Python tests : 5 >> Total number of Python tests : 7 >> ---------------------------------------- >> Unique Tcl tests : 12 >> Total number of Tcl tests : 14 >> ---------------------------------------- >> Total number of unique tests : 68 >> Total number of tests : 72 >> ---------------------------------------- >> >> >> Regards >> Andrew >> -- >> ___________________________________________ >> Andrew J. P. Maclean >> >> ___________________________________________ >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From majcjc at gmail.com Sat May 30 13:54:21 2015 From: majcjc at gmail.com (Lin M) Date: Sat, 30 May 2015 13:54:21 -0400 Subject: [vtk-developers] Class design for spline visualizations In-Reply-To: References: <32159C29-5A99-4818-970A-166B2F74A178@kitware.com> <3C513D9F-71D5-4D1F-B35F-C82A45CD5BB0@kitware.com> <20150420131200.GA450@megas.kitware.com> <8ABE4DD7-1ABC-4E73-8485-6723EB219B58@kitware.com> <8CC007FF-63D3-43E0-998F-E01C7706DA27@kitware.com> Message-ID: Hi Dr. Thompson, I have written a helper function to generate control points for arbitrary ellipse and modified the PatchInterpolation.py test to image test which contains line, circle and ellipse. A question about the push the data. I followed the instruction in https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/data.md, but I didn't see the message when doing the commit step. Some/Module/Testing/Data/Baseline/MyTest.png.md5: Added content to Git at refs/data/MD5/... Some/Module/Testing/Data/Baseline/MyTest.png.md5: Added content to local store at .ExternalData/MD5/... Content link Some/Module/Testing/Data/Baseline/MyTest.png.md5 -> .ExternalData/MD5/... The image test runs correctly in my local machine. Best, Lin On Sat, May 23, 2015 at 12:16 AM, David Thompson wrote: > Hi Lin, > > I believe VTK expects each test to generate a single baseline image whose > filename matches the Python script name (e.g., > TestSynchronizedTemplates3D.py > must > have its baseline image named TestSynchronizedTemplates3D. > png > in the Data/Baselines directory). > > David > > On May 22, 2015, at 23:15, Lin M wrote: > > Hi Dr. Thompson > > I changed the python test to baseline image and followed the instructions > in the VTK Data page, but running CMake doesn't seem to make the .md5 > files. Do you have any idea about that? > > I outputed two images named bezier-circle.png and bezier-line.png and put > them in source-tree/Filters/Bezier/Testing/Data/Baseline. > > Best, > Lin > > > On Tue, May 19, 2015 at 1:52 PM, David Thompson < > david.thompson at kitware.com> wrote: > >> Hi Lin, >> >> A few additional things that might help: >> >> 1. When you are done reviewing the merge request I assigned to you, >> please click "Accept merge request" or add a "+1" comment so that it will >> become part of the splines/filter-bezier branch. >> >> 2. A good pattern to follow for the image-based test is >> Filters/Sources/Testing/Python/TestPlatonicSolids.py . You can see how it >> obtains the path to img_file and calls vtk.test.Testing.compareImage to >> perform a rendering to compare. The baseline image that the rendering is >> compared against is not stored in the VTK git repo. Instead, MD5 checksums >> of images are stored in the git repo and the images are uploaded >> separately. See >> >> >> https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/data.md >> >> for a description of how to generate a test image, add its MD5 sum, and >> upload it with your merge request. >> >> 3. If you are going to generate helper methods to create conic sections, >> then be aware that you'll have to return multiple sets of control points >> because ellipses cannot be represented with a single patch (it is best to >> return one patch per quadrant) because of the way they are parameterized. >> >> David >> >> > On May 18, 2015, at 10:45 PM, Lin M wrote: >> > >> > Hi Dr. Thompson >> > >> > Thanks! I'll look into that and implement the test asap. >> > >> > Best, >> > Lin >> > >> > On Mon, May 18, 2015 at 10:36 PM, David Thompson < >> david.thompson at kitware.com> wrote: >> > Hi Lin, >> > >> > Sorry for the slow reply. >> > >> > > Is there any dataset for precomputed Bezier interpolation? I'm >> currently comparing the result with my manual calculating. In this way I >> can not test many examples and it's quite low efficient. >> > >> > I've pushed a merge request to the project that adds a couple simple >> test cases. I'll add some more over the next few days. You can run the test >> by building VTK with the VTK_WRAP_PYTHON option turned ON and then running: >> > >> > make >> > ./bin/vtkpython >> /path/to/src/Filters/Bezier/Testing/Python/PatchInterpolation.py >> > >> > If you uncomment the lines below the "For debugging, ..." message in >> PatchInterpolation.py, running the test will create some files (named >> bezier-circle.vtk and bezier-line.vtk) that you can load into ParaView. >> > >> > 1. As I mentioned earlier, it would be great to do image-based testing. >> A good exercise would be to modify the Python test into an image test >> version. >> > >> > 2. Another good exercise would be to generate control points for other >> conic sections such as hyperbolas, parabolas, and the more generate case of >> ellipses. I recommend "The NURBS Book" by Les Piegl; the circle quadrant >> example in the Python test is from pp. 26--32 of the book. It would be >> really nice to have a utility that would create control points given a few >> shape parameters. For example: >> > >> > ctrlPts, prange = ellipse(major_radius=2, minor_radius=1) >> > ctrlPts, prange = hyperbola(semi_major_axis=2/3, eccentricity=1) >> > >> > Once we have the 1-, 2-, and 3-d Bezier interpolation tested, we can >> work on converting B-splines into B?zier patches and testing that. >> > >> > David >> > >> > > >> > > On Mon, Apr 27, 2015 at 1:46 PM, David Thompson < >> david.thompson at kitware.com> wrote: >> > > Hi Lin, >> > > >> > > > ... I changed the method to compute binomial coefficient from >> vtkMath::Binomial to vtkMath::Factorial using our memoization improvement >> and tried to merge from Lin.Ma/filter-bezier to Spline/filter-bezier. >> > > >> > > Great! I can see that you were able to merge to the branch. >> > > >> > > > What do you think is the proper thing to do next? >> > > >> > > Right now, it looks like TestPatchInterpolation is modifying the >> array holding control point coordinates. I think it would be a good idea to >> write the interpolated points to a separate array and then make the test >> verify that Bernstein polynomial is being computed properly. >> > > >> > > There are 2 ways to verify things: value tests and image tests. >> > > >> > > 1. Value testing. Interpolate a few different r values on a few >> different sets of control points and compare the resulting point >> coordinates to values you know are good. The comparison must allow for >> small differences due to the differences in floating-point arithmetic >> implementations on different platforms. >> > > >> > > 2. Image testing. Plot the interpolated points and compare the >> rendering of the interpolated points to one you have verified is correct. >> While not as accurate as value testing, it can often be easier to debug a >> failing test with a rendered image. VTK provides utilities for comparing >> images (also allowing for small differences due to floating-point math, >> OpenGL implementations, and so on). The image baselines that get compared >> to your test's rendering are stored outside of the git repository to keep >> the repository from getting bloated. Instead, the MD5 sum of the baseline >> images are stored in the git repository and the images are stored >> separately on Kitware's servers, which can be queried to find a file with a >> given MD5 sum. >> > > >> > > Please take a look at this documentation on adding test data and >> baseline images to VTK: >> > > >> > > >> https://gitlab.kitware.com/vtk/vtk/blob/master/Documentation/dev/git/data.md >> > > >> > > and see if you can add an image-based test of the patch interpolation. >> > > >> > > David >> > > >> > >> > >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: