From sean at rogue-research.com Fri Apr 1 10:10:02 2016 From: sean at rogue-research.com (Sean McBride) Date: Fri, 1 Apr 2016 10:10:02 -0400 Subject: [vtk-developers] [vtkusers] Removal of a deprecated function. In-Reply-To: References: Message-ID: <20160401141002.1942118972@mail.rogue-research.com> On Thu, 31 Mar 2016 22:51:00 -0400, David E DeMarle said: >+1 from me. No code is good code in my opinion. +1 from me too. In fact, maybe I'll do a little cleanup on a rainy day and purge of a bunch of stuff that has been long-deprecated. Would that be ok too? Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From dave.demarle at kitware.com Fri Apr 1 10:26:52 2016 From: dave.demarle at kitware.com (David E DeMarle) Date: Fri, 1 Apr 2016 10:26:52 -0400 Subject: [vtk-developers] [vtkusers] Removal of a deprecated function. In-Reply-To: <20160401141002.1942118972@mail.rogue-research.com> References: <20160401141002.1942118972@mail.rogue-research.com> Message-ID: +1 David E DeMarle Kitware, Inc. R&D Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4909 On Fri, Apr 1, 2016 at 10:10 AM, Sean McBride wrote: > On Thu, 31 Mar 2016 22:51:00 -0400, David E DeMarle said: > > >+1 from me. No code is good code in my opinion. > > +1 from me too. In fact, maybe I'll do a little cleanup on a rainy day > and purge of a bunch of stuff that has been long-deprecated. Would that be > ok too? > > Cheers, > > -- > ____________________________________________________________ > Sean McBride, B. Eng sean at rogue-research.com > Rogue Research www.rogue-research.com > Mac Software Developer Montr?al, Qu?bec, Canada > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From zack.galbreath at kitware.com Fri Apr 1 15:14:06 2016 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Fri, 1 Apr 2016 15:14:06 -0400 Subject: [vtk-developers] open.cdash.org upgrade Message-ID: I plan to upgrade open.cdash.org this coming Monday, April 4th, at 5pm EDT. I expect the site to be unavailable for an hour or so while I perform this upgrade. During this time CDash will not accept any incoming submissions. -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Fri Apr 1 18:45:30 2016 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Sat, 2 Apr 2016 09:45:30 +1100 Subject: [vtk-developers] [vtkusers] Removal of a deprecated function. In-Reply-To: References: <20160401141002.1942118972@mail.rogue-research.com> Message-ID: If you forget what you deprecated, this is a useful link: http://www.vtk.org/doc/nightly/html/deprecated.html Andrew On Sat, Apr 2, 2016 at 1:26 AM, David E DeMarle wrote: > +1 > > David E DeMarle > Kitware, Inc. > R&D Engineer > 21 Corporate Drive > Clifton Park, NY 12065-8662 > Phone: 518-881-4909 > > On Fri, Apr 1, 2016 at 10:10 AM, Sean McBride > wrote: > >> On Thu, 31 Mar 2016 22:51:00 -0400, David E DeMarle said: >> >> >+1 from me. No code is good code in my opinion. >> >> +1 from me too. In fact, maybe I'll do a little cleanup on a rainy day >> and purge of a bunch of stuff that has been long-deprecated. Would that be >> ok too? >> >> Cheers, >> >> -- >> ____________________________________________________________ >> Sean McBride, B. Eng sean at rogue-research.com >> Rogue Research www.rogue-research.com >> Mac Software Developer Montr?al, Qu?bec, Canada >> >> >> > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Sat Apr 2 16:12:27 2016 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Sun, 3 Apr 2016 06:12:27 +1000 Subject: [vtk-developers] Possible buildbot issue. In-Reply-To: References: Message-ID: Is anyone else having trouble accessing buildbot? I'm getting this message when accessing buildbot "buildbot.kitware.com?s server DNS address could not be found." using this link: https://buildbot.kitware.com/grid?branch=remove_deprecated_fn_in_vtkParametricRandomHills&category=vtk-expected . CDash is Ok. Andrew Maclean -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Sun Apr 3 11:17:17 2016 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Sun, 3 Apr 2016 11:17:17 -0400 Subject: [vtk-developers] Possible buildbot issue. In-Reply-To: References: Message-ID: Andrew, We have temporarily blocked buildbot from the outside world. A few potential security issues were spotted and hence this change was needed. Once those issues are addressed, we'll expose the builtbot to the public again. Utkarsh On Sat, Apr 2, 2016 at 4:12 PM, Andrew Maclean wrote: > Is anyone else having trouble accessing buildbot? > I'm getting this message when accessing buildbot "buildbot.kitware.com?s > server DNS address could not be found." using this link: > https://buildbot.kitware.com/grid?branch=remove_deprecated_fn_in_vtkParametricRandomHills&category=vtk-expected. > CDash is Ok. > > Andrew Maclean > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > From ken.martin at kitware.com Mon Apr 4 11:20:34 2016 From: ken.martin at kitware.com (Ken Martin) Date: Mon, 4 Apr 2016 11:20:34 -0400 Subject: [vtk-developers] vtkdiy warning In-Reply-To: References: Message-ID: Awesome! Thanks for following up with them. - ken On Mon, Mar 28, 2016 at 1:29 PM, Sujin Philip wrote: > Hi Ken, > > I talked with the diy2 developers and they said that they are working on > removing the warnings. > > Thanks > Sujin > > > On Fri, Mar 25, 2016 at 9:47 AM, Ken Martin > wrote: > >> >> There is a recurring warning on vtkdiy, if that module rings a bell for >> you, could you please take a look at the issue? >> >> ThirdParty/diy2/vtkdiy2/include/vtkdiy/assigner.hpp:20:31: warning: declaration of 'nblocks' shadows a member of 'this' >> >> >> Thanks! >> Ken >> >> -- >> Ken Martin PhD >> Chairman & CFO >> Kitware Inc. >> 28 Corporate Drive >> Clifton Park NY 12065 >> 518 371 3971 >> >> This communication, including all attachments, contains confidential and >> legally privileged information, and it is intended only for the use of the >> addressee. Access to this email by anyone else is unauthorized. If you are >> not the intended recipient, any disclosure, copying, distribution or any >> action taken in reliance on it is prohibited and may be unlawful. If you >> received this communication in error please notify us immediately and >> destroy the original message. Thank you. >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > -- Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 518 371 3971 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From zack.galbreath at kitware.com Mon Apr 4 18:49:32 2016 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Mon, 4 Apr 2016 18:49:32 -0400 Subject: [vtk-developers] open.cdash.org upgrade In-Reply-To: References: Message-ID: This upgrade is complete. I verified that logins, various page loads, and submissions are all working correctly, but please let me know if you encounter any unexpected behavior. On Fri, Apr 1, 2016 at 3:14 PM, Zack Galbreath wrote: > I plan to upgrade open.cdash.org this coming Monday, April 4th, at 5pm > EDT. I expect the site to be unavailable for an hour or so while I perform > this upgrade. During this time CDash will not accept any incoming > submissions. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From tharun160190 at gmail.com Wed Apr 6 01:32:10 2016 From: tharun160190 at gmail.com (Tharun) Date: Tue, 5 Apr 2016 22:32:10 -0700 (MST) Subject: [vtk-developers] Turn off the automatic selection of LOD of vtkLODActor Message-ID: <1459920730408-5737547.post@n5.nabble.com> I would like to turn off the automatic selection of LOD. Can anybody please help me with this? -- View this message in context: http://vtk.1045678.n5.nabble.com/Turn-off-the-automatic-selection-of-LOD-of-vtkLODActor-tp5737547.html Sent from the VTK - Dev mailing list archive at Nabble.com. From zack.galbreath at kitware.com Wed Apr 6 10:17:40 2016 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Wed, 6 Apr 2016 10:17:40 -0400 Subject: [vtk-developers] [ITK-dev] open.cdash.org upgrade In-Reply-To: <8C3D3CAF-8664-44B8-9ABF-861003F5A69B@mail.nih.gov> References: <8C3D3CAF-8664-44B8-9ABF-861003F5A69B@mail.nih.gov> Message-ID: On Wed, Apr 6, 2016 at 9:17 AM, Bradley Lowekamp wrote: > Hello Zack, > > I can?t seem to find the Notes with the dashboard submissions. I am > expected to see the attached CTest build scripts. I have place the GUI in > advanced view, but no notes? Where can they be? > Thanks for letting me know. I'll look into it & report back when this issue is fixed. -------------- next part -------------- An HTML attachment was scrubbed... URL: From mathieu.westphal at kitware.com Wed Apr 6 14:57:48 2016 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Wed, 6 Apr 2016 20:57:48 +0200 Subject: [vtk-developers] window to image magnification with chart. Message-ID: Hello in the screenshot example, all tiles are mixed up with vtk master. Any idea why ? http://www.vtk.org/Wiki/VTK/Examples/Cxx/Utilities/Screenshot the TestTiling works correctly. Mathieu Westphal -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: screenshot2.png Type: image/png Size: 55788 bytes Desc: not available URL: From zack.galbreath at kitware.com Wed Apr 6 15:17:46 2016 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Wed, 6 Apr 2016 15:17:46 -0400 Subject: [vtk-developers] [ITK-dev] open.cdash.org upgrade In-Reply-To: References: <8C3D3CAF-8664-44B8-9ABF-861003F5A69B@mail.nih.gov> Message-ID: On Wed, Apr 6, 2016 at 10:17 AM, Zack Galbreath wrote: > On Wed, Apr 6, 2016 at 9:17 AM, Bradley Lowekamp > wrote: > >> Hello Zack, >> >> I can?t seem to find the Notes with the dashboard submissions. I am >> expected to see the attached CTest build scripts. I have place the GUI in >> advanced view, but no notes? Where can they be? >> > This icon is back now. As before, you'll need to enable 'Advanced View' to see it (click the gear icon). -------------- next part -------------- An HTML attachment was scrubbed... URL: From tharun160190 at gmail.com Thu Apr 7 03:24:59 2016 From: tharun160190 at gmail.com (Tharun) Date: Thu, 7 Apr 2016 00:24:59 -0700 (MST) Subject: [vtk-developers] Turn off the automatic selection of LOD of vtkLODActor In-Reply-To: <1459920730408-5737547.post@n5.nabble.com> References: <1459920730408-5737547.post@n5.nabble.com> Message-ID: <1460013899560-5737564.post@n5.nabble.com> I have solved this by making the mapper static. -- View this message in context: http://vtk.1045678.n5.nabble.com/Turn-off-the-automatic-selection-of-LOD-of-vtkLODActor-tp5737547p5737564.html Sent from the VTK - Dev mailing list archive at Nabble.com. From joachim.pouderoux at kitware.com Thu Apr 7 09:19:58 2016 From: joachim.pouderoux at kitware.com (Joachim Pouderoux) Date: Thu, 7 Apr 2016 15:19:58 +0200 Subject: [vtk-developers] window to image magnification with chart. In-Reply-To: References: Message-ID: Mathieu, For info, I just tried the Screenshot example with VTK master, OpenGL2 backend on Windows and the example generates the correct image. *Joachim Pouderoux* *PhD, Technical Expert* *Kitware SAS * 2016-04-06 20:57 GMT+02:00 Mathieu Westphal : > Hello > > in the screenshot example, all tiles are mixed up with vtk master. > Any idea why ? > http://www.vtk.org/Wiki/VTK/Examples/Cxx/Utilities/Screenshot > > the TestTiling works correctly. > > Mathieu Westphal > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From joachim.pouderoux at kitware.com Thu Apr 7 10:19:15 2016 From: joachim.pouderoux at kitware.com (Joachim Pouderoux) Date: Thu, 7 Apr 2016 16:19:15 +0200 Subject: [vtk-developers] Compiling VTK7 with VS2015 and Qt5.6 In-Reply-To: References: Message-ID: Hi, Thanks, you are right. There is actually a pending merge request to fix the problem: https://gitlab.kitware.com/vtk/vtk/merge_requests/1358 Best, *Joachim Pouderoux* *PhD, Technical Expert* *Kitware SAS * 2016-03-18 0:36 GMT+01:00 Thales Luis Rodrigues Sabino : > Today I was able to successfully compile VTK7.0 with VS2015 and Qt5.6. > Since Qt5.6 has binaries available for VS2015 I decided to give it a try. > > The first error that appears was the error that 'unistd.h' was not defined > (it is also a unix file). Looking at the source code for the file > '\IO\LSDyna\private\LSDynaFamily.h (45)' one can note that the macro WIN32 > is not being defined. The reason is that in VS2015, as can been seen in > this page https://msdn.microsoft.com/en-us/library/b0084kay.aspx, the > correct macro to detect Windows is _WIN32. To fix this, I simply change my > cmake command line with the following > > cmake -DCMAKE_CXX_FLAGS="/DWIN32=1 /EHsc" > > The EHsc is to solve some warning about the exception handling system. > > Hope this can help. > > -- > Thales Luis Rodrigues Sabino > > PhD Student at PGMC-UFJF > Lattes | LinkedIn > | ResearchGate > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From shawn.waldon at kitware.com Fri Apr 8 09:40:13 2016 From: shawn.waldon at kitware.com (Shawn Waldon) Date: Fri, 8 Apr 2016 09:40:13 -0400 Subject: [vtk-developers] Test failure on dash3 Message-ID: Hi all, We have a test failure on master for the machine dash3. The failing test is vtkRenderingImageCxx-TestImageSliceMapperBackground. I'm not sure if it is a bad baseline a real issue on this machine. Does anyone know anything about this failure? Thanks, Shawn -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.gobbi at gmail.com Fri Apr 8 09:53:40 2016 From: david.gobbi at gmail.com (David Gobbi) Date: Fri, 8 Apr 2016 07:53:40 -0600 Subject: [vtk-developers] Test failure on dash3 In-Reply-To: References: Message-ID: Hi Shawn, I'll look into it and will add a new baseline if if the output is acceptable. - David On Fri, Apr 8, 2016 at 7:40 AM, Shawn Waldon wrote: > Hi all, > > We have a test failure on master for the machine dash3. The failing test > is vtkRenderingImageCxx-TestImageSliceMapperBackground. I'm not sure if it > is a bad baseline a real issue on this machine. Does anyone know anything > about this failure? > > Thanks, > Shawn > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Fri Apr 8 11:28:55 2016 From: ken.martin at kitware.com (Ken Martin) Date: Fri, 8 Apr 2016 11:28:55 -0400 Subject: [vtk-developers] Test failure on dash3 In-Reply-To: References: Message-ID: That is me, I thought I added a new baseline for it but maybe I forgot to commit it or something. - Ken On Fri, Apr 8, 2016 at 9:53 AM, David Gobbi wrote: > Hi Shawn, > > I'll look into it and will add a new baseline if if the output is > acceptable. > > - David > > On Fri, Apr 8, 2016 at 7:40 AM, Shawn Waldon > wrote: > >> Hi all, >> >> We have a test failure on master for the machine dash3. The failing test >> is vtkRenderingImageCxx-TestImageSliceMapperBackground. I'm not sure if it >> is a bad baseline a real issue on this machine. Does anyone know anything >> about this failure? >> >> Thanks, >> Shawn >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -- Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 518 371 3971 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Mon Apr 11 08:38:18 2016 From: ken.martin at kitware.com (Ken Martin) Date: Mon, 11 Apr 2016 08:38:18 -0400 Subject: [vtk-developers] OSGeo4W install path Message-ID: It seems the default install path for VTK on windows is now C:\OSGeo4W probably in some way related to Searching 16288 files for "OSGeo4W" C:\Users\ken.martin\Documents\vtk\VTK\ThirdParty\libproj4\vtklibproj4\cmake\Proj4InstallPath.cmake: 3 #---------------------------------------------- 4 if(WIN32) 5: if(DEFINED ENV{OSGEO4W_ROOT}) 6: set(OSGEO4W_ROOT_DIR $ENV{OSGEO4W_ROOT}) 7 else() 8: set(OSGEO4W_ROOT_DIR c:/OSGeo4W) 9 endif() 10: set(DEFAULT_PROJ_ROOT_DIR ${OSGEO4W_ROOT_DIR}) 11 endif() 12 if(UNIX) -- Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 518 371 3971 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Mon Apr 11 08:39:03 2016 From: ken.martin at kitware.com (Ken Martin) Date: Mon, 11 Apr 2016 08:39:03 -0400 Subject: [vtk-developers] Test failure on dash3 In-Reply-To: References: Message-ID: Should be fixed now - Ken On Fri, Apr 8, 2016 at 11:28 AM, Ken Martin wrote: > That is me, I thought I added a new baseline for it but maybe I forgot to > commit it or something. - Ken > > On Fri, Apr 8, 2016 at 9:53 AM, David Gobbi wrote: > >> Hi Shawn, >> >> I'll look into it and will add a new baseline if if the output is >> acceptable. >> >> - David >> >> On Fri, Apr 8, 2016 at 7:40 AM, Shawn Waldon >> wrote: >> >>> Hi all, >>> >>> We have a test failure on master for the machine dash3. The failing >>> test is vtkRenderingImageCxx-TestImageSliceMapperBackground. I'm not sure >>> if it is a bad baseline a real issue on this machine. Does anyone know >>> anything about this failure? >>> >>> Thanks, >>> Shawn >>> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > > > -- > Ken Martin PhD > Chairman & CFO > Kitware Inc. > 28 Corporate Drive > Clifton Park NY 12065 > 518 371 3971 > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > -- Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 518 371 3971 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From dan.lipsa at kitware.com Mon Apr 11 09:19:57 2016 From: dan.lipsa at kitware.com (Dan Lipsa) Date: Mon, 11 Apr 2016 09:19:57 -0400 Subject: [vtk-developers] OSGeo4W install path In-Reply-To: References: Message-ID: Hi Ken, I will take a look at this. Dan On Mon, Apr 11, 2016 at 8:38 AM, Ken Martin wrote: > It seems the default install path for VTK on windows is now C:\OSGeo4W > > probably in some way related to > > Searching 16288 files for "OSGeo4W" > > > C:\Users\ken.martin\Documents\vtk\VTK\ThirdParty\libproj4\vtklibproj4\cmake\Proj4InstallPath.cmake: > 3 #---------------------------------------------- > 4 if(WIN32) > 5: if(DEFINED ENV{OSGEO4W_ROOT}) > 6: set(OSGEO4W_ROOT_DIR $ENV{OSGEO4W_ROOT}) > 7 else() > 8: set(OSGEO4W_ROOT_DIR c:/OSGeo4W) > 9 endif() > 10: set(DEFAULT_PROJ_ROOT_DIR ${OSGEO4W_ROOT_DIR}) > 11 endif() > 12 if(UNIX) > > > > -- > Ken Martin PhD > Chairman & CFO > Kitware Inc. > 28 Corporate Drive > Clifton Park NY 12065 > 518 371 3971 > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From aashish.chaudhary at kitware.com Mon Apr 11 09:20:15 2016 From: aashish.chaudhary at kitware.com (Aashish Chaudhary) Date: Mon, 11 Apr 2016 09:20:15 -0400 Subject: [vtk-developers] OSGeo4W install path In-Reply-To: References: Message-ID: That is probably related to recent proj4 changes. @Dan could you please have a look at it. Thanks, On Mon, Apr 11, 2016 at 8:38 AM, Ken Martin wrote: > It seems the default install path for VTK on windows is now C:\OSGeo4W > > probably in some way related to > > Searching 16288 files for "OSGeo4W" > > > C:\Users\ken.martin\Documents\vtk\VTK\ThirdParty\libproj4\vtklibproj4\cmake\Proj4InstallPath.cmake: > 3 #---------------------------------------------- > 4 if(WIN32) > 5: if(DEFINED ENV{OSGEO4W_ROOT}) > 6: set(OSGEO4W_ROOT_DIR $ENV{OSGEO4W_ROOT}) > 7 else() > 8: set(OSGEO4W_ROOT_DIR c:/OSGeo4W) > 9 endif() > 10: set(DEFAULT_PROJ_ROOT_DIR ${OSGEO4W_ROOT_DIR}) > 11 endif() > 12 if(UNIX) > > > > -- > Ken Martin PhD > Chairman & CFO > Kitware Inc. > 28 Corporate Drive > Clifton Park NY 12065 > 518 371 3971 > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -- *| Aashish Chaudhary | Technical Leader | Kitware Inc. * *| http://www.kitware.com/company/team/chaudhary.html * -------------- next part -------------- An HTML attachment was scrubbed... URL: From shawn.waldon at kitware.com Mon Apr 11 11:10:55 2016 From: shawn.waldon at kitware.com (Shawn Waldon) Date: Mon, 11 Apr 2016 11:10:55 -0400 Subject: [vtk-developers] Test failure on dash3 In-Reply-To: References: Message-ID: Yes, it looks good now. Thanks Ken! On Mon, Apr 11, 2016 at 8:39 AM, Ken Martin wrote: > Should be fixed now - Ken > > On Fri, Apr 8, 2016 at 11:28 AM, Ken Martin > wrote: > >> That is me, I thought I added a new baseline for it but maybe I forgot to >> commit it or something. - Ken >> >> On Fri, Apr 8, 2016 at 9:53 AM, David Gobbi >> wrote: >> >>> Hi Shawn, >>> >>> I'll look into it and will add a new baseline if if the output is >>> acceptable. >>> >>> - David >>> >>> On Fri, Apr 8, 2016 at 7:40 AM, Shawn Waldon >>> wrote: >>> >>>> Hi all, >>>> >>>> We have a test failure on master for the machine dash3. The failing >>>> test is vtkRenderingImageCxx-TestImageSliceMapperBackground. I'm not sure >>>> if it is a bad baseline a real issue on this machine. Does anyone know >>>> anything about this failure? >>>> >>>> Thanks, >>>> Shawn >>>> >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >>> >> >> >> -- >> Ken Martin PhD >> Chairman & CFO >> Kitware Inc. >> 28 Corporate Drive >> Clifton Park NY 12065 >> 518 371 3971 >> >> This communication, including all attachments, contains confidential and >> legally privileged information, and it is intended only for the use of the >> addressee. Access to this email by anyone else is unauthorized. If you are >> not the intended recipient, any disclosure, copying, distribution or any >> action taken in reliance on it is prohibited and may be unlawful. If you >> received this communication in error please notify us immediately and >> destroy the original message. Thank you. >> > > > > -- > Ken Martin PhD > Chairman & CFO > Kitware Inc. > 28 Corporate Drive > Clifton Park NY 12065 > 518 371 3971 > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lonie at kitware.com Tue Apr 12 11:07:07 2016 From: david.lonie at kitware.com (David Lonie) Date: Tue, 12 Apr 2016 11:07:07 -0400 Subject: [vtk-developers] Dual Depth Peeling now in VTK Message-ID: Hi folks, Just wanted to share an improvement to VTK's transparency rendering. We've just merged[1] a new order-independent translucent render pass implementation for the OpenGL2 backend. Dual depth peeling[2] builds on the standard depth peeling algorithm by simultaneously peeling fragments from both the front and the back of the translucent geometry, blending them appropriately to compose the final image. In benchmarking a very large scene (10M triangles) with high depth complexity, the new implementation doubled the framerate compared to standard peeling (52% of the standard peeling time). The scene took 40+ geometry passes with standard depth peeling to get a perfect image, while the dual algorithm accomplished the same in 20 passes. The new implementation supports the same parameters as the old one (max number of peels and target occlusion ratio) and will be used automatically when depth peeling is enabled in vtkRenderer with the OpenGL2 backend. The catch is that it requires floating point texture support, which are omitted from many packaged mesa drivers due to licensing issues. In these cases, the renderer will fallback to the old standard peeling implementation gracefully. If anyone notices any blending issues with the new code please ping the mailing list. Cheers, Dave [1] https://gitlab.kitware.com/vtk/vtk/merge_requests/1409 [2] http://developer.download.nvidia.com/SDK/10/opengl/screenshots/samples/dual_depth_peeling.html -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lonie at kitware.com Tue Apr 12 11:44:24 2016 From: david.lonie at kitware.com (David Lonie) Date: Tue, 12 Apr 2016 11:44:24 -0400 Subject: [vtk-developers] Dual Depth Peeling now in VTK In-Reply-To: References: Message-ID: On Tue, Apr 12, 2016 at 11:42 AM, Adam Rankin wrote: > With regards to the drivers issue, does this mean that a card would have > to support the GL_ARB_texture_float extension? > Yep, exactly -- that's what we test for in the renderer when deciding a peeling algorithm. The old depth peeling implementation will still be used if it is missing. Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From a_shishkin at diatech.ru Wed Apr 13 04:20:56 2016 From: a_shishkin at diatech.ru (=?koi8-r?B?+8nby8nOIOEu4S4=?=) Date: Wed, 13 Apr 2016 11:20:56 +0300 Subject: [vtk-developers] FW: VTK7.0.0.0 under Ebarcadero XE2 Message-ID: <001b01d1955d$677b0e30$36712a90$@diatech.ru> ello! Can you help me? 1) In our work we successfully use VTK 5.8.0.0 with Embarcadero XE2. We created our own class, based on your class vtkCylinderSource. In our class we redefined procedure for RequestData event - our procedure generates our own points and cells. Now we need to cross two cylinders vtkCylinderSource and keep our points and cells - how can we do it? What class do you have for it? Using your vtkImplicitBoolean is impossible, because it doesn't keep our points and cells. 2)I can't install newest version of VTK7.0.0.0 under Ebarcadero XE2. During installation I have some errors, related to data type "Long Long". In spite of errors, installation ends successfully. But when compiled Make.exe with XE2 shell, it shows errors in compiled VTK7.0.0.0 modules (in files *.h,*.Cxx). Maybe new version of VTK7.0.0.0 is not compatible with Ebarcadero XE2? Or maybe you can send me instruction for installation? Thank you for help! Faithfully yours, Andrey. -------------- next part -------------- An HTML attachment was scrubbed... URL: From a_shishkin at diatech.ru Wed Apr 13 05:31:27 2016 From: a_shishkin at diatech.ru (=?koi8-r?B?+8nby8nOIOEu4S4=?=) Date: Wed, 13 Apr 2016 12:31:27 +0300 Subject: [vtk-developers] FW: VTK7.0.0.0 under Ebarcadero XE2 Message-ID: <002601d19567$412b1e50$c3815af0$@diatech.ru> Hello! Can you help me? 1) In our work we successfully use VTK 5.8.0.0 with Embarcadero XE2. We created our own class, based on your class vtkCylinderSource. In our class we redefined procedure for RequestData event - our procedure generates our own points and cells. Now we need to cross two cylinders vtkCylinderSource and keep our points and cells - how can we do it? What class do you have for it? Using your vtkImplicitBoolean is impossible, because it doesn't keep our points and cells. 2)I can't install newest version of VTK7.0.0.0 under Ebarcadero XE2. During installation I have some errors, related to data type "Long Long". In spite of errors, installation ends successfully. But when compiled Make.exe with XE2 shell, it shows errors in compiled VTK7.0.0.0 modules (in files *.h,*.Cxx). Maybe new version of VTK7.0.0.0 is not compatible with Ebarcadero XE2? Or maybe you can send me instruction for installation? Thank you for help! Faithfully yours, Andrey. -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lonie at kitware.com Wed Apr 13 11:16:33 2016 From: david.lonie at kitware.com (David Lonie) Date: Wed, 13 Apr 2016 11:16:33 -0400 Subject: [vtk-developers] Dashboard failures Message-ID: Anyone know what's up with the night dashboards? I bisected the osx errors ( https://open.cdash.org/viewBuildError.php?buildid=4320405) to this commit: commit d6fb76e4c0a4bdb6356ad9aa4dcfc45fc0ac58da Author: Fabian Wenzel Date: Fri Jan 22 14:57:43 2016 +0100 Combination of VTK_USE_X and VTK_USE_OSMESA possible Removed also VTK_OPENGL_HAS_OSMESA, since it was not used Looks like there are also new issues on MSVC, not sure if its the same commit causing them. -------------- next part -------------- An HTML attachment was scrubbed... URL: From dave.demarle at kitware.com Wed Apr 13 11:32:40 2016 From: dave.demarle at kitware.com (David E DeMarle) Date: Wed, 13 Apr 2016 11:32:40 -0400 Subject: [vtk-developers] Dashboard failures In-Reply-To: References: Message-ID: Ken and Fabian are looking at it. https://gitlab.kitware.com/vtk/vtk/merge_requests/1111 Let's revert tomorrow or before if necessary. David E DeMarle Kitware, Inc. R&D Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4909 On Wed, Apr 13, 2016 at 11:16 AM, David Lonie wrote: > Anyone know what's up with the night dashboards? I bisected the osx errors > (https://open.cdash.org/viewBuildError.php?buildid=4320405) to this > commit: > > commit d6fb76e4c0a4bdb6356ad9aa4dcfc45fc0ac58da > Author: Fabian Wenzel > Date: Fri Jan 22 14:57:43 2016 +0100 > > Combination of VTK_USE_X and VTK_USE_OSMESA possible > > Removed also VTK_OPENGL_HAS_OSMESA, since it was not used > > Looks like there are also new issues on MSVC, not sure if its the same > commit causing them. > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Wed Apr 13 14:35:58 2016 From: ken.martin at kitware.com (Ken Martin) Date: Wed, 13 Apr 2016 14:35:58 -0400 Subject: [vtk-developers] VTK Options Message-ID: Could these options be made advanced? They seem a tad advanced for the average VTK users to be deciding as a basic VTK option. VTK_DISPATCH_AOS_ARRAYS VTK_DISPATCH_SOA_ARRAYS VTK_DISPATCH_TYPED_ARRAYS VTK_WARN_ON_DISPATCH_FAILURE -- Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 518 371 3971 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Wed Apr 13 15:44:07 2016 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Wed, 13 Apr 2016 12:44:07 -0700 Subject: [vtk-developers] Dashboard failures In-Reply-To: References: Message-ID: this one is also burning me. i hope it can be reverted. On Wed, Apr 13, 2016 at 8:32 AM, David E DeMarle wrote: > Ken and Fabian are looking at it. > https://gitlab.kitware.com/vtk/vtk/merge_requests/1111 > > Let's revert tomorrow or before if necessary. > > > David E DeMarle > Kitware, Inc. > R&D Engineer > 21 Corporate Drive > Clifton Park, NY 12065-8662 > Phone: 518-881-4909 > > On Wed, Apr 13, 2016 at 11:16 AM, David Lonie > wrote: >> >> Anyone know what's up with the night dashboards? I bisected the osx errors >> (https://open.cdash.org/viewBuildError.php?buildid=4320405) to this commit: >> >> commit d6fb76e4c0a4bdb6356ad9aa4dcfc45fc0ac58da >> Author: Fabian Wenzel >> Date: Fri Jan 22 14:57:43 2016 +0100 >> >> Combination of VTK_USE_X and VTK_USE_OSMESA possible >> >> Removed also VTK_OPENGL_HAS_OSMESA, since it was not used >> >> Looks like there are also new issues on MSVC, not sure if its the same >> commit causing them. >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- Unpaid intern in BillsBasement at noware dot com From ken.martin at kitware.com Wed Apr 13 15:45:18 2016 From: ken.martin at kitware.com (Ken Martin) Date: Wed, 13 Apr 2016 15:45:18 -0400 Subject: [vtk-developers] Dashboard failures In-Reply-To: References: Message-ID: I reverted it just now so Fabian isn't under the gun to get a fix in and tested pronto - Ken On Wed, Apr 13, 2016 at 3:44 PM, Bill Lorensen wrote: > this one is also burning me. i hope it can be reverted. > > > On Wed, Apr 13, 2016 at 8:32 AM, David E DeMarle > wrote: > > Ken and Fabian are looking at it. > > https://gitlab.kitware.com/vtk/vtk/merge_requests/1111 > > > > Let's revert tomorrow or before if necessary. > > > > > > David E DeMarle > > Kitware, Inc. > > R&D Engineer > > 21 Corporate Drive > > Clifton Park, NY 12065-8662 > > Phone: 518-881-4909 > > > > On Wed, Apr 13, 2016 at 11:16 AM, David Lonie > > wrote: > >> > >> Anyone know what's up with the night dashboards? I bisected the osx > errors > >> (https://open.cdash.org/viewBuildError.php?buildid=4320405) to this > commit: > >> > >> commit d6fb76e4c0a4bdb6356ad9aa4dcfc45fc0ac58da > >> Author: Fabian Wenzel > >> Date: Fri Jan 22 14:57:43 2016 +0100 > >> > >> Combination of VTK_USE_X and VTK_USE_OSMESA possible > >> > >> Removed also VTK_OPENGL_HAS_OSMESA, since it was not used > >> > >> Looks like there are also new issues on MSVC, not sure if its the same > >> commit causing them. > >> > >> _______________________________________________ > >> Powered by www.kitware.com > >> > >> Visit other Kitware open-source projects at > >> http://www.kitware.com/opensource/opensource.html > >> > >> Search the list archives at: > http://markmail.org/search/?q=vtk-developers > >> > >> Follow this link to subscribe/unsubscribe: > >> http://public.kitware.com/mailman/listinfo/vtk-developers > >> > >> > > > > > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Search the list archives at: > http://markmail.org/search/?q=vtk-developers > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/vtk-developers > > > > > > > > -- > Unpaid intern in BillsBasement at noware dot com > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 518 371 3971 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Wed Apr 13 15:25:51 2016 From: sean at rogue-research.com (Sean McBride) Date: Wed, 13 Apr 2016 15:25:51 -0400 Subject: [vtk-developers] FW: VTK7.0.0.0 under Ebarcadero XE2 In-Reply-To: <002601d19567$412b1e50$c3815af0$@diatech.ru> References: <002601d19567$412b1e50$c3815af0$@diatech.ru> Message-ID: <20160413192551.1866194798@mail.rogue-research.com> On Wed, 13 Apr 2016 12:31:27 +0300, ?????? ?.?. said: >2)I can't install newest version of VTK7.0.0.0 under Ebarcadero XE2. During >installation I have some errors, related to data type "Long Long". You would need to tell us the exact errors given, we can't guess. :) 'long long' is technically new in C++11, but widely supported as an extension by most compilers I know. Also, XE2 is 5 years old. Perhaps you should consider updating your compiler... Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From bill.lorensen at gmail.com Wed Apr 13 16:01:43 2016 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Wed, 13 Apr 2016 13:01:43 -0700 Subject: [vtk-developers] Dashboard failures In-Reply-To: References: Message-ID: Great. Works for me. On Wed, Apr 13, 2016 at 12:45 PM, Ken Martin wrote: > I reverted it just now so Fabian isn't under the gun to get a fix in and > tested pronto - Ken > > On Wed, Apr 13, 2016 at 3:44 PM, Bill Lorensen > wrote: >> >> this one is also burning me. i hope it can be reverted. >> >> >> On Wed, Apr 13, 2016 at 8:32 AM, David E DeMarle >> wrote: >> > Ken and Fabian are looking at it. >> > https://gitlab.kitware.com/vtk/vtk/merge_requests/1111 >> > >> > Let's revert tomorrow or before if necessary. >> > >> > >> > David E DeMarle >> > Kitware, Inc. >> > R&D Engineer >> > 21 Corporate Drive >> > Clifton Park, NY 12065-8662 >> > Phone: 518-881-4909 >> > >> > On Wed, Apr 13, 2016 at 11:16 AM, David Lonie >> > wrote: >> >> >> >> Anyone know what's up with the night dashboards? I bisected the osx >> >> errors >> >> (https://open.cdash.org/viewBuildError.php?buildid=4320405) to this >> >> commit: >> >> >> >> commit d6fb76e4c0a4bdb6356ad9aa4dcfc45fc0ac58da >> >> Author: Fabian Wenzel >> >> Date: Fri Jan 22 14:57:43 2016 +0100 >> >> >> >> Combination of VTK_USE_X and VTK_USE_OSMESA possible >> >> >> >> Removed also VTK_OPENGL_HAS_OSMESA, since it was not used >> >> >> >> Looks like there are also new issues on MSVC, not sure if its the same >> >> commit causing them. >> >> >> >> _______________________________________________ >> >> Powered by www.kitware.com >> >> >> >> Visit other Kitware open-source projects at >> >> http://www.kitware.com/opensource/opensource.html >> >> >> >> Search the list archives at: >> >> http://markmail.org/search/?q=vtk-developers >> >> >> >> Follow this link to subscribe/unsubscribe: >> >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> >> >> > >> > >> > _______________________________________________ >> > Powered by www.kitware.com >> > >> > Visit other Kitware open-source projects at >> > http://www.kitware.com/opensource/opensource.html >> > >> > Search the list archives at: >> > http://markmail.org/search/?q=vtk-developers >> > >> > Follow this link to subscribe/unsubscribe: >> > http://public.kitware.com/mailman/listinfo/vtk-developers >> > >> > >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> > > > > -- > Ken Martin PhD > Chairman & CFO > Kitware Inc. > 28 Corporate Drive > Clifton Park NY 12065 > 518 371 3971 > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. -- Unpaid intern in BillsBasement at noware dot com From david.lonie at kitware.com Wed Apr 13 16:01:46 2016 From: david.lonie at kitware.com (David Lonie) Date: Wed, 13 Apr 2016 16:01:46 -0400 Subject: [vtk-developers] VTK Options In-Reply-To: References: Message-ID: On Wed, Apr 13, 2016 at 2:35 PM, Ken Martin wrote: > > Could these options be made advanced? They seem a tad advanced for the > average VTK users to be deciding as a basic VTK option. > > VTK_DISPATCH_AOS_ARRAYS > VTK_DISPATCH_SOA_ARRAYS > VTK_DISPATCH_TYPED_ARRAYS > VTK_WARN_ON_DISPATCH_FAILURE > Agreed. I'll push a patch for it. Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.gobbi at gmail.com Wed Apr 13 16:25:21 2016 From: david.gobbi at gmail.com (David Gobbi) Date: Wed, 13 Apr 2016 14:25:21 -0600 Subject: [vtk-developers] ExternalData and regression images Message-ID: Hi All, I've got a problem with ExternalData that is driving me crazy. CMake computed the md5 sum and "staged" the image, whatever that means: Filters/General/Testing/Data/Baseline/.ExternalData_MD5_9dcc0e95cafb270cddfd482186180ab5 How does it go from here to the midas database? Because that step just doesn't seem to be happening. This is specifically with respect to the following merge request: https://gitlab.kitware.com/vtk/vtk/merge_requests/1336 Cheers, - David -------------- next part -------------- An HTML attachment was scrubbed... URL: From mathieu.westphal at kitware.com Thu Apr 14 02:00:26 2016 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Thu, 14 Apr 2016 08:00:26 +0200 Subject: [vtk-developers] ExternalData and regression images In-Reply-To: References: Message-ID: Usually, what i need to do is : 1. Copy image into baseline directory 2. run cmake, check for "staged" output 3. run make, check for "download" output 4. git add the md5 file, which has now taken place of your file in baseline dir 5. Commit all you need to commit 6. git gitlab-push ( magic happens here ) Mathieu Westphal On Wed, Apr 13, 2016 at 10:25 PM, David Gobbi wrote: > Hi All, > > I've got a problem with ExternalData that is driving me crazy. CMake > computed the md5 sum and "staged" the image, whatever that means: > > > Filters/General/Testing/Data/Baseline/.ExternalData_MD5_9dcc0e95cafb270cddfd482186180ab5 > > How does it go from here to the midas database? Because that step just > doesn't seem to be happening. This is specifically with respect to the > following merge request: > > https://gitlab.kitware.com/vtk/vtk/merge_requests/1336 > > Cheers, > - David > > > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From cory.quammen at kitware.com Thu Apr 14 09:13:06 2016 From: cory.quammen at kitware.com (Cory Quammen) Date: Thu, 14 Apr 2016 09:13:06 -0400 Subject: [vtk-developers] ExternalData and regression images In-Reply-To: References: Message-ID: As Mathieu said, git gitlab-push does the magic. If you rebase and need to force push on a topic, you can do git gitlab-push -f Cory On Thu, Apr 14, 2016 at 2:00 AM, Mathieu Westphal wrote: > Usually, what i need to do is : > > 1. Copy image into baseline directory > 2. run cmake, check for "staged" output > 3. run make, check for "download" output > 4. git add the md5 file, which has now taken place of your file in baseline > dir > 5. Commit all you need to commit > 6. git gitlab-push ( magic happens here ) > > Mathieu Westphal > > On Wed, Apr 13, 2016 at 10:25 PM, David Gobbi wrote: >> >> Hi All, >> >> I've got a problem with ExternalData that is driving me crazy. CMake >> computed the md5 sum and "staged" the image, whatever that means: >> >> >> Filters/General/Testing/Data/Baseline/.ExternalData_MD5_9dcc0e95cafb270cddfd482186180ab5 >> >> How does it go from here to the midas database? Because that step just >> doesn't seem to be happening. This is specifically with respect to the >> following merge request: >> >> https://gitlab.kitware.com/vtk/vtk/merge_requests/1336 >> >> Cheers, >> - David >> >> >> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- Cory Quammen R&D Engineer Kitware, Inc. From a_shishkin at diatech.ru Thu Apr 14 09:50:26 2016 From: a_shishkin at diatech.ru (=?koi8-r?B?+8nby8nOIOEu4S4=?=) Date: Thu, 14 Apr 2016 16:50:26 +0300 Subject: [vtk-developers] vtkSphereSource vtkImplicitBoolean Message-ID: <000901d19654$99702d60$cc508820$@diatech.ru> Hello! Please let you help me solve the problem. We need to combine two or more intersected shell surface type objects, implemented as vtkPolyDataAlgorithm objects, in a single bound surface with initial points and cells of given objects but inner points (and cells) excluded. To test the possible workaround I have created two sample successors of vtkSphereSource class [vtkSphereSourceNew ] with reimplemented RequestData member function. The last generates its own points and cells. These two objects of vtkSphereSourceNew type are intersected in universe space. I try to use vtkImplicitBoolean function to combine in one united outer surface with inner points and cells excluded. Please inform me whether vtkImplicitDataSet class was used properly? The following test code will result in exception: vtkSmartPointer sphere1 = vtkSmartPointer::New(); sphere1->SetCenter(.9,0,0); vtkImplicitDataSet* Imsphere1 = vtkImplicitDataSet::New(); Imsphere2->SetDataSet(sphere1->GetOutput()); vtkSmartPointer sphere2 =vtkSmartPointer::New(); sphere2->SetCenter(-.9,0,0); vtkImplicitDataSet* Imsphere2 = vtkImplicitDataSet::New(); Imsphere2->SetDataSet(sphere2->GetOutput()); vtkSmartPointer implicitBoolean =vtkSmartPointer::New(); implicitBoolean->AddFunction(Imsphere1); implicitBoolean->AddFunction(Imsphere2); implicitBoolean->SetOperationTypeToUnion(); vtkSmartPointer sample = vtkSmartPointer::New(); sample->SetSampleDimensions(10,10,10); sample->SetImplicitFunction(implicitBoolean); double value = 3.0; double xmin = -value, xmax = value, ymin = -value, ymax = value, zmin = -value, zmax = value; sample->SetModelBounds(xmin, xmax, ymin, ymax, zmin, zmax); vtkSmartPointer contours =vtkSmartPointer::New(); contours->SetInputConnection(sample->GetOutputPort()); contours->GenerateValues(1, 1, 1); vtkSmartPointer mapper = vtkSmartPointer::New(); mapper->SetInputConnection(contours->GetOutputPort()); mapper->Update(); vtkSmartPointer actor = vtkSmartPointer::New(); actor->SetMapper(mapper); Thank you for help! Faithfully yours, Andrey. -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lonie at kitware.com Thu Apr 14 15:36:09 2016 From: david.lonie at kitware.com (David Lonie) Date: Thu, 14 Apr 2016 15:36:09 -0400 Subject: [vtk-developers] Mysterious gitlab message: "Restored source branch" Message-ID: Anyone else seen this? I've noticed this a couple of times in my merge requests lately, see the fifth comment here: https://gitlab.kitware.com/vtk/vtk/merge_requests/1425 Ben is trying to figure out what's going on there, and is looking for more samples. So if you notice this happen on your MRs, ping Ben Boeckel < ben.boeckel at kitware.com> and let him know. (For me, it happened right after I cleaned out a bunch of merged branches from my gitlab fork of VTK, though I didn't touch the one associated with the merge request). Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Thu Apr 14 15:44:26 2016 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Thu, 14 Apr 2016 15:44:26 -0400 Subject: [vtk-developers] Mysterious gitlab message: "Restored source branch" In-Reply-To: References: Message-ID: I've been noticing that since the latest gitlab upgrade. On Thu, Apr 14, 2016 at 3:36 PM, David Lonie wrote: > Anyone else seen this? > > I've noticed this a couple of times in my merge requests lately, see the > fifth comment here: > > https://gitlab.kitware.com/vtk/vtk/merge_requests/1425 > > Ben is trying to figure out what's going on there, and is looking for more > samples. So if you notice this happen on your MRs, ping Ben Boeckel > and let him know. > > (For me, it happened right after I cleaned out a bunch of merged branches > from my gitlab fork of VTK, though I didn't touch the one associated with > the merge request). > > Dave > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > From david.gobbi at gmail.com Thu Apr 14 17:40:51 2016 From: david.gobbi at gmail.com (David Gobbi) Date: Thu, 14 Apr 2016 15:40:51 -0600 Subject: [vtk-developers] ExternalData and regression images In-Reply-To: References: Message-ID: Thanks for the explanation. I did "git gitlab-push" yesterday when I first encountered this problem. And today I rebased the commit and did "git gitlab-push --force". The magic still didn't happen. Much unhappiness. But when I did everything over from scratch, it worked (as mentioned in my first email, this was someone else's MR, so I'm not sure what the order of operations was the first time around). - David On Thu, Apr 14, 2016 at 7:13 AM, Cory Quammen wrote: > As Mathieu said, > > git gitlab-push > > does the magic. If you rebase and need to force push on a topic, you can do > > git gitlab-push -f > > Cory > > On Thu, Apr 14, 2016 at 2:00 AM, Mathieu Westphal > wrote: > > Usually, what i need to do is : > > > > 1. Copy image into baseline directory > > 2. run cmake, check for "staged" output > > 3. run make, check for "download" output > > 4. git add the md5 file, which has now taken place of your file in > baseline > > dir > > 5. Commit all you need to commit > > 6. git gitlab-push ( magic happens here ) > > > > Mathieu Westphal > > > > On Wed, Apr 13, 2016 at 10:25 PM, David Gobbi > wrote: > >> > >> Hi All, > >> > >> I've got a problem with ExternalData that is driving me crazy. CMake > >> computed the md5 sum and "staged" the image, whatever that means: > >> > >> > >> > Filters/General/Testing/Data/Baseline/.ExternalData_MD5_9dcc0e95cafb270cddfd482186180ab5 > >> > >> How does it go from here to the midas database? Because that step just > >> doesn't seem to be happening. This is specifically with respect to the > >> following merge request: > >> > >> https://gitlab.kitware.com/vtk/vtk/merge_requests/1336 > >> > >> Cheers, > >> - David > >> > >> > >> > >> > >> > >> _______________________________________________ > >> Powered by www.kitware.com > >> > >> Visit other Kitware open-source projects at > >> http://www.kitware.com/opensource/opensource.html > >> > >> Search the list archives at: > http://markmail.org/search/?q=vtk-developers > >> > >> Follow this link to subscribe/unsubscribe: > >> http://public.kitware.com/mailman/listinfo/vtk-developers > >> > >> > > > > > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Search the list archives at: > http://markmail.org/search/?q=vtk-developers > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/vtk-developers > > > > > > > > -- > Cory Quammen > R&D Engineer > Kitware, Inc. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Thu Apr 14 18:10:38 2016 From: will.schroeder at kitware.com (Will Schroeder) Date: Thu, 14 Apr 2016 18:10:38 -0400 Subject: [vtk-developers] ExternalData and regression images In-Reply-To: References: Message-ID: IMO the workflow for creating regression test images could be significantly improved. The incantations require multiple, non-intuitive steps and on occasions (when things go wrong) the sacraficing of a goat. I'd really like a simple macro/function (in a python test for example) to create a regression test image, put it in the right place, and even upload it all in one shot. Simply "CreateRTImage(renWin,forceReplace)" which would create a new image if one is not available, otherwise do nothing, etc. And force a replacement if needed. Similarly simple processes for dropping in any alternative _1, _2, regression test images (cutting and pasting from the dashboard rt images). And ways to easily recover and move back and forth between md5 and png. I know some of this is available, but it takes a lot of documentation digestion to really understand the process which can be hard for newbies or those who code infrequently. Of most concern I think the process is cumbersome enough that it discourages adding new tests. Best, W On Thu, Apr 14, 2016 at 5:40 PM, David Gobbi wrote: > Thanks for the explanation. > > I did "git gitlab-push" yesterday when I first encountered this problem. > And today I rebased the commit and did "git gitlab-push --force". The > magic still didn't happen. Much unhappiness. > > But when I did everything over from scratch, it worked (as mentioned > in my first email, this was someone else's MR, so I'm not sure what > the order of operations was the first time around). > > - David > > On Thu, Apr 14, 2016 at 7:13 AM, Cory Quammen > wrote: > >> As Mathieu said, >> >> git gitlab-push >> >> does the magic. If you rebase and need to force push on a topic, you can >> do >> >> git gitlab-push -f >> >> Cory >> >> On Thu, Apr 14, 2016 at 2:00 AM, Mathieu Westphal >> wrote: >> > Usually, what i need to do is : >> > >> > 1. Copy image into baseline directory >> > 2. run cmake, check for "staged" output >> > 3. run make, check for "download" output >> > 4. git add the md5 file, which has now taken place of your file in >> baseline >> > dir >> > 5. Commit all you need to commit >> > 6. git gitlab-push ( magic happens here ) >> > >> > Mathieu Westphal >> > >> > On Wed, Apr 13, 2016 at 10:25 PM, David Gobbi >> wrote: >> >> >> >> Hi All, >> >> >> >> I've got a problem with ExternalData that is driving me crazy. CMake >> >> computed the md5 sum and "staged" the image, whatever that means: >> >> >> >> >> >> >> Filters/General/Testing/Data/Baseline/.ExternalData_MD5_9dcc0e95cafb270cddfd482186180ab5 >> >> >> >> How does it go from here to the midas database? Because that step just >> >> doesn't seem to be happening. This is specifically with respect to the >> >> following merge request: >> >> >> >> https://gitlab.kitware.com/vtk/vtk/merge_requests/1336 >> >> >> >> Cheers, >> >> - David >> >> >> >> >> >> >> >> >> >> >> >> _______________________________________________ >> >> Powered by www.kitware.com >> >> >> >> Visit other Kitware open-source projects at >> >> http://www.kitware.com/opensource/opensource.html >> >> >> >> Search the list archives at: >> http://markmail.org/search/?q=vtk-developers >> >> >> >> Follow this link to subscribe/unsubscribe: >> >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> >> >> > >> > >> > _______________________________________________ >> > Powered by www.kitware.com >> > >> > Visit other Kitware open-source projects at >> > http://www.kitware.com/opensource/opensource.html >> > >> > Search the list archives at: >> http://markmail.org/search/?q=vtk-developers >> > >> > Follow this link to subscribe/unsubscribe: >> > http://public.kitware.com/mailman/listinfo/vtk-developers >> > >> > >> >> >> >> -- >> Cory Quammen >> R&D Engineer >> Kitware, Inc. >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.amaclean at gmail.com Thu Apr 14 18:29:26 2016 From: andrew.amaclean at gmail.com (Andrew Maclean) Date: Fri, 15 Apr 2016 08:29:26 +1000 Subject: [vtk-developers] ExternalData and regression images (Will Schroeder) Message-ID: A good suggestion Will. +1 Andrew > ---------- Forwarded message ---------- > From: Will Schroeder > To: David Gobbi > Cc: VTK Developers > Date: Thu, 14 Apr 2016 18:10:38 -0400 > Subject: Re: [vtk-developers] ExternalData and regression images > IMO the workflow for creating regression test images could be > significantly improved. The incantations require multiple, non-intuitive > steps and on occasions (when things go wrong) the sacraficing of a goat. > I'd really like a simple macro/function (in a python test for example) to > create a regression test image, put it in the right place, and even upload > it all in one shot. Simply "CreateRTImage(renWin,forceReplace)" which would > create a new image if one is not available, otherwise do nothing, etc. And > force a replacement if needed. > > Similarly simple processes for dropping in any alternative _1, _2, > regression test images (cutting and pasting from the dashboard rt images). > And ways to easily recover and move back and forth between md5 and png. I > know some of this is available, but it takes a lot > of documentation digestion to really understand the process which can be > hard for newbies or those who code infrequently. Of most concern I think > the process is cumbersome enough that it discourages adding new tests. > > Best, > W > > On Thu, Apr 14, 2016 at 5:40 PM, David Gobbi > wrote: > >> Thanks for the explanation. >> >> I did "git gitlab-push" yesterday when I first encountered this problem. >> And today I rebased the commit and did "git gitlab-push --force". The >> magic still didn't happen. Much unhappiness. >> >> But when I did everything over from scratch, it worked (as mentioned >> in my first email, this was someone else's MR, so I'm not sure what >> the order of operations was the first time around). >> >> - David >> >> On Thu, Apr 14, 2016 at 7:13 AM, Cory Quammen >> wrote: >> >>> As Mathieu said, >>> >>> git gitlab-push >>> >>> does the magic. If you rebase and need to force push on a topic, you can >>> do >>> >>> git gitlab-push -f >>> >>> Cory >>> >>> On Thu, Apr 14, 2016 at 2:00 AM, Mathieu Westphal >>> wrote: >>> > Usually, what i need to do is : >>> > >>> > 1. Copy image into baseline directory >>> > 2. run cmake, check for "staged" output >>> > 3. run make, check for "download" output >>> > 4. git add the md5 file, which has now taken place of your file in >>> baseline >>> > dir >>> > 5. Commit all you need to commit >>> > 6. git gitlab-push ( magic happens here ) >>> > >>> > Mathieu Westphal >>> > >>> > On Wed, Apr 13, 2016 at 10:25 PM, David Gobbi >>> wrote: >>> >> >>> >> Hi All, >>> >> >>> >> I've got a problem with ExternalData that is driving me crazy. CMake >>> >> computed the md5 sum and "staged" the image, whatever that means: >>> >> >>> >> >>> >> >>> Filters/General/Testing/Data/Baseline/.ExternalData_MD5_9dcc0e95cafb270cddfd482186180ab5 >>> >> >>> >> How does it go from here to the midas database? Because that step just >>> >> doesn't seem to be happening. This is specifically with respect to the >>> >> following merge request: >>> >> >>> >> https://gitlab.kitware.com/vtk/vtk/merge_requests/1336 >>> >> >>> >> Cheers, >>> >> - David >>> >> >>> >> >>> >> >>> >> >>> >> >>> >> _______________________________________________ >>> >> Powered by www.kitware.com >>> >> >>> >> Visit other Kitware open-source projects at >>> >> http://www.kitware.com/opensource/opensource.html >>> >> >>> >> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >> >>> >> Follow this link to subscribe/unsubscribe: >>> >> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >> >>> >> >>> > >>> > >>> > _______________________________________________ >>> > Powered by www.kitware.com >>> > >>> > Visit other Kitware open-source projects at >>> > http://www.kitware.com/opensource/opensource.html >>> > >>> > Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> > >>> > Follow this link to subscribe/unsubscribe: >>> > http://public.kitware.com/mailman/listinfo/vtk-developers >>> > >>> > >>> >>> >>> >>> -- >>> Cory Quammen >>> R&D Engineer >>> Kitware, Inc. >>> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > > > -- > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > -- ___________________________________________ Andrew J. P. Maclean ___________________________________________ -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Thu Apr 14 19:32:53 2016 From: ken.martin at kitware.com (Ken Martin) Date: Thu, 14 Apr 2016 19:32:53 -0400 Subject: [vtk-developers] ExternalData and regression images In-Reply-To: References: Message-ID: CTest script/C++ executable maybe for those who do not have python? I have plenty of goats so I'm good, just a thought. :-) On Thu, Apr 14, 2016 at 6:10 PM, Will Schroeder wrote: > IMO the workflow for creating regression test images could be > significantly improved. The incantations require multiple, non-intuitive > steps and on occasions (when things go wrong) the sacraficing of a goat. > I'd really like a simple macro/function (in a python test for example) to > create a regression test image, put it in the right place, and even upload > it all in one shot. Simply "CreateRTImage(renWin,forceReplace)" which would > create a new image if one is not available, otherwise do nothing, etc. And > force a replacement if needed. > > Similarly simple processes for dropping in any alternative _1, _2, > regression test images (cutting and pasting from the dashboard rt images). > And ways to easily recover and move back and forth between md5 and png. I > know some of this is available, but it takes a lot > of documentation digestion to really understand the process which can be > hard for newbies or those who code infrequently. Of most concern I think > the process is cumbersome enough that it discourages adding new tests. > > Best, > W > > On Thu, Apr 14, 2016 at 5:40 PM, David Gobbi > wrote: > >> Thanks for the explanation. >> >> I did "git gitlab-push" yesterday when I first encountered this problem. >> And today I rebased the commit and did "git gitlab-push --force". The >> magic still didn't happen. Much unhappiness. >> >> But when I did everything over from scratch, it worked (as mentioned >> in my first email, this was someone else's MR, so I'm not sure what >> the order of operations was the first time around). >> >> - David >> >> On Thu, Apr 14, 2016 at 7:13 AM, Cory Quammen >> wrote: >> >>> As Mathieu said, >>> >>> git gitlab-push >>> >>> does the magic. If you rebase and need to force push on a topic, you can >>> do >>> >>> git gitlab-push -f >>> >>> Cory >>> >>> On Thu, Apr 14, 2016 at 2:00 AM, Mathieu Westphal >>> wrote: >>> > Usually, what i need to do is : >>> > >>> > 1. Copy image into baseline directory >>> > 2. run cmake, check for "staged" output >>> > 3. run make, check for "download" output >>> > 4. git add the md5 file, which has now taken place of your file in >>> baseline >>> > dir >>> > 5. Commit all you need to commit >>> > 6. git gitlab-push ( magic happens here ) >>> > >>> > Mathieu Westphal >>> > >>> > On Wed, Apr 13, 2016 at 10:25 PM, David Gobbi >>> wrote: >>> >> >>> >> Hi All, >>> >> >>> >> I've got a problem with ExternalData that is driving me crazy. CMake >>> >> computed the md5 sum and "staged" the image, whatever that means: >>> >> >>> >> >>> >> >>> Filters/General/Testing/Data/Baseline/.ExternalData_MD5_9dcc0e95cafb270cddfd482186180ab5 >>> >> >>> >> How does it go from here to the midas database? Because that step just >>> >> doesn't seem to be happening. This is specifically with respect to the >>> >> following merge request: >>> >> >>> >> https://gitlab.kitware.com/vtk/vtk/merge_requests/1336 >>> >> >>> >> Cheers, >>> >> - David >>> >> >>> >> >>> >> >>> >> >>> >> >>> >> _______________________________________________ >>> >> Powered by www.kitware.com >>> >> >>> >> Visit other Kitware open-source projects at >>> >> http://www.kitware.com/opensource/opensource.html >>> >> >>> >> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >> >>> >> Follow this link to subscribe/unsubscribe: >>> >> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >> >>> >> >>> > >>> > >>> > _______________________________________________ >>> > Powered by www.kitware.com >>> > >>> > Visit other Kitware open-source projects at >>> > http://www.kitware.com/opensource/opensource.html >>> > >>> > Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> > >>> > Follow this link to subscribe/unsubscribe: >>> > http://public.kitware.com/mailman/listinfo/vtk-developers >>> > >>> > >>> >>> >>> >>> -- >>> Cory Quammen >>> R&D Engineer >>> Kitware, Inc. >>> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > > > -- > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -- Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 518 371 3971 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Thu Apr 14 19:34:44 2016 From: will.schroeder at kitware.com (Will Schroeder) Date: Thu, 14 Apr 2016 19:34:44 -0400 Subject: [vtk-developers] ExternalData and regression images In-Reply-To: References: Message-ID: +1 The whole external data magic is amazing the way it works, I'd just like to make it as easy as possible to add tests and RT images. On Thu, Apr 14, 2016 at 7:32 PM, Ken Martin wrote: > CTest script/C++ executable maybe for those who do not have python? I have > plenty of goats so I'm good, just a thought. :-) > > On Thu, Apr 14, 2016 at 6:10 PM, Will Schroeder < > will.schroeder at kitware.com> wrote: > >> IMO the workflow for creating regression test images could be >> significantly improved. The incantations require multiple, non-intuitive >> steps and on occasions (when things go wrong) the sacraficing of a goat. >> I'd really like a simple macro/function (in a python test for example) to >> create a regression test image, put it in the right place, and even upload >> it all in one shot. Simply "CreateRTImage(renWin,forceReplace)" which would >> create a new image if one is not available, otherwise do nothing, etc. And >> force a replacement if needed. >> >> Similarly simple processes for dropping in any alternative _1, _2, >> regression test images (cutting and pasting from the dashboard rt images). >> And ways to easily recover and move back and forth between md5 and png. I >> know some of this is available, but it takes a lot >> of documentation digestion to really understand the process which can be >> hard for newbies or those who code infrequently. Of most concern I think >> the process is cumbersome enough that it discourages adding new tests. >> >> Best, >> W >> >> On Thu, Apr 14, 2016 at 5:40 PM, David Gobbi >> wrote: >> >>> Thanks for the explanation. >>> >>> I did "git gitlab-push" yesterday when I first encountered this problem. >>> And today I rebased the commit and did "git gitlab-push --force". The >>> magic still didn't happen. Much unhappiness. >>> >>> But when I did everything over from scratch, it worked (as mentioned >>> in my first email, this was someone else's MR, so I'm not sure what >>> the order of operations was the first time around). >>> >>> - David >>> >>> On Thu, Apr 14, 2016 at 7:13 AM, Cory Quammen >>> wrote: >>> >>>> As Mathieu said, >>>> >>>> git gitlab-push >>>> >>>> does the magic. If you rebase and need to force push on a topic, you >>>> can do >>>> >>>> git gitlab-push -f >>>> >>>> Cory >>>> >>>> On Thu, Apr 14, 2016 at 2:00 AM, Mathieu Westphal >>>> wrote: >>>> > Usually, what i need to do is : >>>> > >>>> > 1. Copy image into baseline directory >>>> > 2. run cmake, check for "staged" output >>>> > 3. run make, check for "download" output >>>> > 4. git add the md5 file, which has now taken place of your file in >>>> baseline >>>> > dir >>>> > 5. Commit all you need to commit >>>> > 6. git gitlab-push ( magic happens here ) >>>> > >>>> > Mathieu Westphal >>>> > >>>> > On Wed, Apr 13, 2016 at 10:25 PM, David Gobbi >>>> wrote: >>>> >> >>>> >> Hi All, >>>> >> >>>> >> I've got a problem with ExternalData that is driving me crazy. CMake >>>> >> computed the md5 sum and "staged" the image, whatever that means: >>>> >> >>>> >> >>>> >> >>>> Filters/General/Testing/Data/Baseline/.ExternalData_MD5_9dcc0e95cafb270cddfd482186180ab5 >>>> >> >>>> >> How does it go from here to the midas database? Because that step >>>> just >>>> >> doesn't seem to be happening. This is specifically with respect to >>>> the >>>> >> following merge request: >>>> >> >>>> >> https://gitlab.kitware.com/vtk/vtk/merge_requests/1336 >>>> >> >>>> >> Cheers, >>>> >> - David >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> _______________________________________________ >>>> >> Powered by www.kitware.com >>>> >> >>>> >> Visit other Kitware open-source projects at >>>> >> http://www.kitware.com/opensource/opensource.html >>>> >> >>>> >> Search the list archives at: >>>> http://markmail.org/search/?q=vtk-developers >>>> >> >>>> >> Follow this link to subscribe/unsubscribe: >>>> >> http://public.kitware.com/mailman/listinfo/vtk-developers >>>> >> >>>> >> >>>> > >>>> > >>>> > _______________________________________________ >>>> > Powered by www.kitware.com >>>> > >>>> > Visit other Kitware open-source projects at >>>> > http://www.kitware.com/opensource/opensource.html >>>> > >>>> > Search the list archives at: >>>> http://markmail.org/search/?q=vtk-developers >>>> > >>>> > Follow this link to subscribe/unsubscribe: >>>> > http://public.kitware.com/mailman/listinfo/vtk-developers >>>> > >>>> > >>>> >>>> >>>> >>>> -- >>>> Cory Quammen >>>> R&D Engineer >>>> Kitware, Inc. >>>> >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >>> >> >> >> -- >> William J. Schroeder, PhD >> Kitware, Inc. - Building the World's Technical Computing Software >> 28 Corporate Drive >> Clifton Park, NY 12065 >> will.schroeder at kitware.com >> http://www.kitware.com >> (518) 881-4902 >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > > > -- > Ken Martin PhD > Chairman & CFO > Kitware Inc. > 28 Corporate Drive > Clifton Park NY 12065 > 518 371 3971 > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Thu Apr 14 20:04:55 2016 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 14 Apr 2016 17:04:55 -0700 Subject: [vtk-developers] ExternalData and regression images In-Reply-To: References: Message-ID: For C++ it is pretty easy. Python needs some work... On Thu, Apr 14, 2016 at 4:34 PM, Will Schroeder wrote: > +1 > > The whole external data magic is amazing the way it works, I'd just like to > make it as easy as possible to add tests and RT images. > > On Thu, Apr 14, 2016 at 7:32 PM, Ken Martin wrote: >> >> CTest script/C++ executable maybe for those who do not have python? I have >> plenty of goats so I'm good, just a thought. :-) >> >> On Thu, Apr 14, 2016 at 6:10 PM, Will Schroeder >> wrote: >>> >>> IMO the workflow for creating regression test images could be >>> significantly improved. The incantations require multiple, non-intuitive >>> steps and on occasions (when things go wrong) the sacraficing of a goat. I'd >>> really like a simple macro/function (in a python test for example) to create >>> a regression test image, put it in the right place, and even upload it all >>> in one shot. Simply "CreateRTImage(renWin,forceReplace)" which would create >>> a new image if one is not available, otherwise do nothing, etc. And force a >>> replacement if needed. >>> >>> Similarly simple processes for dropping in any alternative _1, _2, >>> regression test images (cutting and pasting from the dashboard rt images). >>> And ways to easily recover and move back and forth between md5 and png. I >>> know some of this is available, but it takes a lot of documentation >>> digestion to really understand the process which can be hard for newbies or >>> those who code infrequently. Of most concern I think the process is >>> cumbersome enough that it discourages adding new tests. >>> >>> Best, >>> W >>> >>> On Thu, Apr 14, 2016 at 5:40 PM, David Gobbi >>> wrote: >>>> >>>> Thanks for the explanation. >>>> >>>> I did "git gitlab-push" yesterday when I first encountered this problem. >>>> And today I rebased the commit and did "git gitlab-push --force". The >>>> magic still didn't happen. Much unhappiness. >>>> >>>> But when I did everything over from scratch, it worked (as mentioned >>>> in my first email, this was someone else's MR, so I'm not sure what >>>> the order of operations was the first time around). >>>> >>>> - David >>>> >>>> On Thu, Apr 14, 2016 at 7:13 AM, Cory Quammen >>>> wrote: >>>>> >>>>> As Mathieu said, >>>>> >>>>> git gitlab-push >>>>> >>>>> does the magic. If you rebase and need to force push on a topic, you >>>>> can do >>>>> >>>>> git gitlab-push -f >>>>> >>>>> Cory >>>>> >>>>> On Thu, Apr 14, 2016 at 2:00 AM, Mathieu Westphal >>>>> wrote: >>>>> > Usually, what i need to do is : >>>>> > >>>>> > 1. Copy image into baseline directory >>>>> > 2. run cmake, check for "staged" output >>>>> > 3. run make, check for "download" output >>>>> > 4. git add the md5 file, which has now taken place of your file in >>>>> > baseline >>>>> > dir >>>>> > 5. Commit all you need to commit >>>>> > 6. git gitlab-push ( magic happens here ) >>>>> > >>>>> > Mathieu Westphal >>>>> > >>>>> > On Wed, Apr 13, 2016 at 10:25 PM, David Gobbi >>>>> > wrote: >>>>> >> >>>>> >> Hi All, >>>>> >> >>>>> >> I've got a problem with ExternalData that is driving me crazy. >>>>> >> CMake >>>>> >> computed the md5 sum and "staged" the image, whatever that means: >>>>> >> >>>>> >> >>>>> >> >>>>> >> Filters/General/Testing/Data/Baseline/.ExternalData_MD5_9dcc0e95cafb270cddfd482186180ab5 >>>>> >> >>>>> >> How does it go from here to the midas database? Because that step >>>>> >> just >>>>> >> doesn't seem to be happening. This is specifically with respect to >>>>> >> the >>>>> >> following merge request: >>>>> >> >>>>> >> https://gitlab.kitware.com/vtk/vtk/merge_requests/1336 >>>>> >> >>>>> >> Cheers, >>>>> >> - David >>>>> >> >>>>> >> >>>>> >> >>>>> >> >>>>> >> >>>>> >> _______________________________________________ >>>>> >> Powered by www.kitware.com >>>>> >> >>>>> >> Visit other Kitware open-source projects at >>>>> >> http://www.kitware.com/opensource/opensource.html >>>>> >> >>>>> >> Search the list archives at: >>>>> >> http://markmail.org/search/?q=vtk-developers >>>>> >> >>>>> >> Follow this link to subscribe/unsubscribe: >>>>> >> http://public.kitware.com/mailman/listinfo/vtk-developers >>>>> >> >>>>> >> >>>>> > >>>>> > >>>>> > _______________________________________________ >>>>> > Powered by www.kitware.com >>>>> > >>>>> > Visit other Kitware open-source projects at >>>>> > http://www.kitware.com/opensource/opensource.html >>>>> > >>>>> > Search the list archives at: >>>>> > http://markmail.org/search/?q=vtk-developers >>>>> > >>>>> > Follow this link to subscribe/unsubscribe: >>>>> > http://public.kitware.com/mailman/listinfo/vtk-developers >>>>> > >>>>> > >>>>> >>>>> >>>>> >>>>> -- >>>>> Cory Quammen >>>>> R&D Engineer >>>>> Kitware, Inc. >>>> >>>> >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: >>>> http://markmail.org/search/?q=vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://public.kitware.com/mailman/listinfo/vtk-developers >>>> >>>> >>> >>> >>> >>> -- >>> William J. Schroeder, PhD >>> Kitware, Inc. - Building the World's Technical Computing Software >>> 28 Corporate Drive >>> Clifton Park, NY 12065 >>> will.schroeder at kitware.com >>> http://www.kitware.com >>> (518) 881-4902 >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >> >> >> >> -- >> Ken Martin PhD >> Chairman & CFO >> Kitware Inc. >> 28 Corporate Drive >> Clifton Park NY 12065 >> 518 371 3971 >> >> This communication, including all attachments, contains confidential and >> legally privileged information, and it is intended only for the use of the >> addressee. Access to this email by anyone else is unauthorized. If you are >> not the intended recipient, any disclosure, copying, distribution or any >> action taken in reliance on it is prohibited and may be unlawful. If you >> received this communication in error please notify us immediately and >> destroy the original message. Thank you. > > > > > -- > William J. Schroeder, PhD > Kitware, Inc. - Building the World's Technical Computing Software > 28 Corporate Drive > Clifton Park, NY 12065 > will.schroeder at kitware.com > http://www.kitware.com > (518) 881-4902 > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- Unpaid intern in BillsBasement at noware dot com From ken.martin at kitware.com Fri Apr 15 11:52:29 2016 From: ken.martin at kitware.com (Ken Martin) Date: Fri, 15 Apr 2016 11:52:29 -0400 Subject: [vtk-developers] vtkLODPointCloudMapper remote module Message-ID: Hiya folks, I have been playing with rendering point clouds using some LOD and multithreading techniques. One result of this is vtkLODPointCloudMapper and two supporting filters that reorganize the data into a better format for rendering. I have placed these items into a VTK remote module ( http://www.vtk.org/Wiki/VTK/Remote_Modules) and have attached the cmake file to pull it below. This module does rely on Will's vtkPointCloud module so make sure you have that and it is up to date first. This module includes a test which generates a synthetic point cloud. This test can be easily modified to adjust the number of points generated. In the image below I used 100 million points and included the vtkPointFillPass to fill small holes in the cloud, followed by a vtkEDLShadingPass to produce lighting effects based on the depth buffer. Sort of an interesting example of mixing point clouds with some render passes. The LOD Shader itself only implements a very small subset of VTKs capabilities as it was designed to test out some different approaches to rendering. I have included the description from the header file below to give you some idea of what the class does. [image: Inline image 1] Thanks! Ken // This mapper only implements a very small subset of VTK's features. // Consider it experimental and as a starting point for other uses. This // mapper is designed to take a multiblock point cloud of the form // typically produced by vtkHierachicalBinningFilter and run through // vtkPointCloudToMultiBlock followed by vtkMultiBlockToCompressed. If // the compressed stage is skipped it will be done by the mapper // internally. // // The result of these filters should be a multiblockdataset where the // first block contains a sampling of the points from the entire point // cloud. Additional blocks will contain smaller subdivisions. A common // arrangement is 1 grandparent + 8 parents + 64 children in an octree // arrangement for a total of 73 blocks. // // This mapper uses unsigned shorts to store the XYZ values and uses // either 3 unsigned chars for color or one unsigned short for single // valued scalars. When using single valued scalars the lookup table is // hardcoded. When there is no color or scalars a blue to yellow pseudo // coloring is done based on depth. // // This mapper uses timing and coverage metrics to determine what blocks // to draw and how much of any given block to draw to maintain the // desired render rate. On a laptop with a nvidia 2Gig 960M (midrange // card) I see around one billion points/sec for a dataset of 140 // million points with RGB color // // While this mapper can be fed through a normal VTK pipeline, it also // supports being fed data one piece at a time using the SetDataForPiece // method. The intent is that the file IO can be handled in one thread, a // piece at a time, while the rendering is handled in another thread. // SetDataForPiece is what you would use to pass data from the file IO // thread to the rendering thread. -- Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 518 371 3971 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image.jpg Type: image/jpeg Size: 154273 bytes Desc: not available URL: From david.gobbi at gmail.com Fri Apr 15 12:14:03 2016 From: david.gobbi at gmail.com (David Gobbi) Date: Fri, 15 Apr 2016 10:14:03 -0600 Subject: [vtk-developers] CDash items-per-page Message-ID: Hi All, Is there any way to set a preferred items-per-page for CDash? I'd much rather that CDash defaulted to always showing "all". Every time I have to click to see more (and then wait the update), it costs me a few seconds and a couple grey hairs. - David -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Fri Apr 15 12:18:05 2016 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 15 Apr 2016 09:18:05 -0700 Subject: [vtk-developers] CDash items-per-page In-Reply-To: References: Message-ID: +1 Especially annoying when viewing coverage. On Apr 15, 2016 9:14 AM, "David Gobbi" wrote: > Hi All, > > Is there any way to set a preferred items-per-page for CDash? > I'd much rather that CDash defaulted to always showing "all". > > Every time I have to click to see more (and then wait the update), > it costs me a few seconds and a couple grey hairs. > > - David > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.gobbi at gmail.com Fri Apr 15 12:24:10 2016 From: david.gobbi at gmail.com (David Gobbi) Date: Fri, 15 Apr 2016 10:24:10 -0600 Subject: [vtk-developers] CDash items-per-page In-Reply-To: References: Message-ID: Hey, it seems to remember when I select "All", so this isn't so bad! After selecting "All" once, everything is fine for future views. Except for the coverage view, it doesn't remember the setting. - David On Fri, Apr 15, 2016 at 10:18 AM, Bill Lorensen wrote: > +1 > Especially annoying when viewing coverage. > On Apr 15, 2016 9:14 AM, "David Gobbi" wrote: > >> Hi All, >> >> Is there any way to set a preferred items-per-page for CDash? >> I'd much rather that CDash defaulted to always showing "all". >> >> Every time I have to click to see more (and then wait the update), >> it costs me a few seconds and a couple grey hairs. >> >> - David >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From zack.galbreath at kitware.com Fri Apr 15 12:39:34 2016 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Fri, 15 Apr 2016 12:39:34 -0400 Subject: [vtk-developers] CDash items-per-page In-Reply-To: References: Message-ID: On Fri, Apr 15, 2016 at 12:24 PM, David Gobbi wrote: > Except for the coverage view, it doesn't remember the setting. Thanks for letting me know, I'm looking into it. -------------- next part -------------- An HTML attachment was scrubbed... URL: From aashish.chaudhary at kitware.com Fri Apr 15 13:08:18 2016 From: aashish.chaudhary at kitware.com (Aashish Chaudhary) Date: Fri, 15 Apr 2016 13:08:18 -0400 Subject: [vtk-developers] vtkLODPointCloudMapper remote module In-Reply-To: References: Message-ID: This looks great Ken! Thanks for the update. What dataset is this and where it came from? Thanks, On Fri, Apr 15, 2016 at 11:52 AM, Ken Martin wrote: > > Hiya folks, > > I have been playing with rendering point clouds using some LOD and > multithreading techniques. One result of this is vtkLODPointCloudMapper and > two supporting filters that reorganize the data into a better format for > rendering. I have placed these items into a VTK remote module ( > http://www.vtk.org/Wiki/VTK/Remote_Modules) and have attached the cmake > file to pull it below. This module does rely on Will's vtkPointCloud > module so make sure you have that and it is up to date first. This module > includes a test which generates a synthetic point cloud. This test can be > easily modified to adjust the number of points generated. In the image > below I used 100 million points and included the vtkPointFillPass to fill > small holes in the cloud, followed by a vtkEDLShadingPass to produce > lighting effects based on the depth buffer. Sort of an interesting example > of mixing point clouds with some render passes. > > The LOD Shader itself only implements a very small subset of VTKs > capabilities as it was designed to test out some different approaches to > rendering. I have included the description from the header file below to > give you some idea of what the class does. > > > [image: Inline image 1] > > Thanks! > Ken > > > // This mapper only implements a very small subset of VTK's features. > // Consider it experimental and as a starting point for other uses. This > // mapper is designed to take a multiblock point cloud of the form > // typically produced by vtkHierachicalBinningFilter and run through > // vtkPointCloudToMultiBlock followed by vtkMultiBlockToCompressed. If > // the compressed stage is skipped it will be done by the mapper > // internally. > // > // The result of these filters should be a multiblockdataset where the > // first block contains a sampling of the points from the entire point > // cloud. Additional blocks will contain smaller subdivisions. A common > // arrangement is 1 grandparent + 8 parents + 64 children in an octree > // arrangement for a total of 73 blocks. > // > // This mapper uses unsigned shorts to store the XYZ values and uses > // either 3 unsigned chars for color or one unsigned short for single > // valued scalars. When using single valued scalars the lookup table is > // hardcoded. When there is no color or scalars a blue to yellow pseudo > // coloring is done based on depth. > // > // This mapper uses timing and coverage metrics to determine what blocks > // to draw and how much of any given block to draw to maintain the > // desired render rate. On a laptop with a nvidia 2Gig 960M (midrange > // card) I see around one billion points/sec for a dataset of 140 > // million points with RGB color > // > // While this mapper can be fed through a normal VTK pipeline, it also > // supports being fed data one piece at a time using the SetDataForPiece > // method. The intent is that the file IO can be handled in one thread, a > // piece at a time, while the rendering is handled in another thread. > // SetDataForPiece is what you would use to pass data from the file IO > // thread to the rendering thread. > -- > Ken Martin PhD > Chairman & CFO > Kitware Inc. > 28 Corporate Drive > Clifton Park NY 12065 > 518 371 3971 > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -- *| Aashish Chaudhary | Technical Leader | Kitware Inc. * *| http://www.kitware.com/company/team/chaudhary.html * -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image.jpg Type: image/jpeg Size: 154273 bytes Desc: not available URL: From ken.martin at kitware.com Fri Apr 15 13:13:53 2016 From: ken.martin at kitware.com (Ken Martin) Date: Fri, 15 Apr 2016 13:13:53 -0400 Subject: [vtk-developers] vtkLODPointCloudMapper remote module In-Reply-To: References: Message-ID: It is synthetic data generated by the test - Ken On Fri, Apr 15, 2016 at 1:08 PM, Aashish Chaudhary < aashish.chaudhary at kitware.com> wrote: > This looks great Ken! Thanks for the update. What dataset is this and > where it came from? > > Thanks, > > > On Fri, Apr 15, 2016 at 11:52 AM, Ken Martin > wrote: > >> >> Hiya folks, >> >> I have been playing with rendering point clouds using some LOD and >> multithreading techniques. One result of this is vtkLODPointCloudMapper and >> two supporting filters that reorganize the data into a better format for >> rendering. I have placed these items into a VTK remote module ( >> http://www.vtk.org/Wiki/VTK/Remote_Modules) and have attached the cmake >> file to pull it below. This module does rely on Will's vtkPointCloud >> module so make sure you have that and it is up to date first. This module >> includes a test which generates a synthetic point cloud. This test can be >> easily modified to adjust the number of points generated. In the image >> below I used 100 million points and included the vtkPointFillPass to fill >> small holes in the cloud, followed by a vtkEDLShadingPass to produce >> lighting effects based on the depth buffer. Sort of an interesting example >> of mixing point clouds with some render passes. >> >> The LOD Shader itself only implements a very small subset of VTKs >> capabilities as it was designed to test out some different approaches to >> rendering. I have included the description from the header file below to >> give you some idea of what the class does. >> >> >> [image: Inline image 1] >> >> Thanks! >> Ken >> >> >> // This mapper only implements a very small subset of VTK's features. >> // Consider it experimental and as a starting point for other uses. This >> // mapper is designed to take a multiblock point cloud of the form >> // typically produced by vtkHierachicalBinningFilter and run through >> // vtkPointCloudToMultiBlock followed by vtkMultiBlockToCompressed. If >> // the compressed stage is skipped it will be done by the mapper >> // internally. >> // >> // The result of these filters should be a multiblockdataset where the >> // first block contains a sampling of the points from the entire point >> // cloud. Additional blocks will contain smaller subdivisions. A common >> // arrangement is 1 grandparent + 8 parents + 64 children in an octree >> // arrangement for a total of 73 blocks. >> // >> // This mapper uses unsigned shorts to store the XYZ values and uses >> // either 3 unsigned chars for color or one unsigned short for single >> // valued scalars. When using single valued scalars the lookup table is >> // hardcoded. When there is no color or scalars a blue to yellow pseudo >> // coloring is done based on depth. >> // >> // This mapper uses timing and coverage metrics to determine what blocks >> // to draw and how much of any given block to draw to maintain the >> // desired render rate. On a laptop with a nvidia 2Gig 960M (midrange >> // card) I see around one billion points/sec for a dataset of 140 >> // million points with RGB color >> // >> // While this mapper can be fed through a normal VTK pipeline, it also >> // supports being fed data one piece at a time using the SetDataForPiece >> // method. The intent is that the file IO can be handled in one thread, a >> // piece at a time, while the rendering is handled in another thread. >> // SetDataForPiece is what you would use to pass data from the file IO >> // thread to the rendering thread. >> -- >> Ken Martin PhD >> Chairman & CFO >> Kitware Inc. >> 28 Corporate Drive >> Clifton Park NY 12065 >> 518 371 3971 >> >> This communication, including all attachments, contains confidential and >> legally privileged information, and it is intended only for the use of the >> addressee. Access to this email by anyone else is unauthorized. If you are >> not the intended recipient, any disclosure, copying, distribution or any >> action taken in reliance on it is prohibited and may be unlawful. If you >> received this communication in error please notify us immediately and >> destroy the original message. Thank you. >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > > > -- > > > > *| Aashish Chaudhary | Technical Leader | Kitware Inc. * > *| http://www.kitware.com/company/team/chaudhary.html > * > -- Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 518 371 3971 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image.jpg Type: image/jpeg Size: 154273 bytes Desc: not available URL: From bill.lorensen at gmail.com Fri Apr 15 13:21:16 2016 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 15 Apr 2016 10:21:16 -0700 Subject: [vtk-developers] vtkLODPointCloudMapper remote module In-Reply-To: References: Message-ID: Ken, I don't see the attachment... On Fri, Apr 15, 2016 at 8:52 AM, Ken Martin wrote: > > Hiya folks, > > I have been playing with rendering point clouds using some LOD and > multithreading techniques. One result of this is vtkLODPointCloudMapper and > two supporting filters that reorganize the data into a better format for > rendering. I have placed these items into a VTK remote module ( > http://www.vtk.org/Wiki/VTK/Remote_Modules) and have attached the cmake > file to pull it below. This module does rely on Will's vtkPointCloud > module so make sure you have that and it is up to date first. This module > includes a test which generates a synthetic point cloud. This test can be > easily modified to adjust the number of points generated. In the image > below I used 100 million points and included the vtkPointFillPass to fill > small holes in the cloud, followed by a vtkEDLShadingPass to produce > lighting effects based on the depth buffer. Sort of an interesting example > of mixing point clouds with some render passes. > > The LOD Shader itself only implements a very small subset of VTKs > capabilities as it was designed to test out some different approaches to > rendering. I have included the description from the header file below to > give you some idea of what the class does. > > > [image: Inline image 1] > > Thanks! > Ken > > > // This mapper only implements a very small subset of VTK's features. > // Consider it experimental and as a starting point for other uses. This > // mapper is designed to take a multiblock point cloud of the form > // typically produced by vtkHierachicalBinningFilter and run through > // vtkPointCloudToMultiBlock followed by vtkMultiBlockToCompressed. If > // the compressed stage is skipped it will be done by the mapper > // internally. > // > // The result of these filters should be a multiblockdataset where the > // first block contains a sampling of the points from the entire point > // cloud. Additional blocks will contain smaller subdivisions. A common > // arrangement is 1 grandparent + 8 parents + 64 children in an octree > // arrangement for a total of 73 blocks. > // > // This mapper uses unsigned shorts to store the XYZ values and uses > // either 3 unsigned chars for color or one unsigned short for single > // valued scalars. When using single valued scalars the lookup table is > // hardcoded. When there is no color or scalars a blue to yellow pseudo > // coloring is done based on depth. > // > // This mapper uses timing and coverage metrics to determine what blocks > // to draw and how much of any given block to draw to maintain the > // desired render rate. On a laptop with a nvidia 2Gig 960M (midrange > // card) I see around one billion points/sec for a dataset of 140 > // million points with RGB color > // > // While this mapper can be fed through a normal VTK pipeline, it also > // supports being fed data one piece at a time using the SetDataForPiece > // method. The intent is that the file IO can be handled in one thread, a > // piece at a time, while the rendering is handled in another thread. > // SetDataForPiece is what you would use to pass data from the file IO > // thread to the rendering thread. > -- > Ken Martin PhD > Chairman & CFO > Kitware Inc. > 28 Corporate Drive > Clifton Park NY 12065 > 518 371 3971 > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -- Unpaid intern in BillsBasement at noware dot com -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image.jpg Type: image/jpeg Size: 154273 bytes Desc: not available URL: From ken.martin at kitware.com Fri Apr 15 13:52:48 2016 From: ken.martin at kitware.com (Ken Martin) Date: Fri, 15 Apr 2016 13:52:48 -0400 Subject: [vtk-developers] vtkLODPointCloudMapper remote module In-Reply-To: References: Message-ID: Oops, my first send was rejected and I forgot to attach it to the second try, here it is - Ken On Fri, Apr 15, 2016 at 1:21 PM, Bill Lorensen wrote: > Ken, > > I don't see the attachment... > > On Fri, Apr 15, 2016 at 8:52 AM, Ken Martin > wrote: > >> >> Hiya folks, >> >> I have been playing with rendering point clouds using some LOD and >> multithreading techniques. One result of this is vtkLODPointCloudMapper and >> two supporting filters that reorganize the data into a better format for >> rendering. I have placed these items into a VTK remote module ( >> http://www.vtk.org/Wiki/VTK/Remote_Modules) and have attached the cmake >> file to pull it below. This module does rely on Will's vtkPointCloud >> module so make sure you have that and it is up to date first. This module >> includes a test which generates a synthetic point cloud. This test can be >> easily modified to adjust the number of points generated. In the image >> below I used 100 million points and included the vtkPointFillPass to fill >> small holes in the cloud, followed by a vtkEDLShadingPass to produce >> lighting effects based on the depth buffer. Sort of an interesting example >> of mixing point clouds with some render passes. >> >> The LOD Shader itself only implements a very small subset of VTKs >> capabilities as it was designed to test out some different approaches to >> rendering. I have included the description from the header file below to >> give you some idea of what the class does. >> >> >> [image: Inline image 1] >> >> Thanks! >> Ken >> >> >> // This mapper only implements a very small subset of VTK's features. >> // Consider it experimental and as a starting point for other uses. This >> // mapper is designed to take a multiblock point cloud of the form >> // typically produced by vtkHierachicalBinningFilter and run through >> // vtkPointCloudToMultiBlock followed by vtkMultiBlockToCompressed. If >> // the compressed stage is skipped it will be done by the mapper >> // internally. >> // >> // The result of these filters should be a multiblockdataset where the >> // first block contains a sampling of the points from the entire point >> // cloud. Additional blocks will contain smaller subdivisions. A common >> // arrangement is 1 grandparent + 8 parents + 64 children in an octree >> // arrangement for a total of 73 blocks. >> // >> // This mapper uses unsigned shorts to store the XYZ values and uses >> // either 3 unsigned chars for color or one unsigned short for single >> // valued scalars. When using single valued scalars the lookup table is >> // hardcoded. When there is no color or scalars a blue to yellow pseudo >> // coloring is done based on depth. >> // >> // This mapper uses timing and coverage metrics to determine what blocks >> // to draw and how much of any given block to draw to maintain the >> // desired render rate. On a laptop with a nvidia 2Gig 960M (midrange >> // card) I see around one billion points/sec for a dataset of 140 >> // million points with RGB color >> // >> // While this mapper can be fed through a normal VTK pipeline, it also >> // supports being fed data one piece at a time using the SetDataForPiece >> // method. The intent is that the file IO can be handled in one thread, a >> // piece at a time, while the rendering is handled in another thread. >> // SetDataForPiece is what you would use to pass data from the file IO >> // thread to the rendering thread. >> -- >> Ken Martin PhD >> Chairman & CFO >> Kitware Inc. >> 28 Corporate Drive >> Clifton Park NY 12065 >> 518 371 3971 >> >> This communication, including all attachments, contains confidential and >> legally privileged information, and it is intended only for the use of the >> addressee. Access to this email by anyone else is unauthorized. If you are >> not the intended recipient, any disclosure, copying, distribution or any >> action taken in reliance on it is prohibited and may be unlawful. If you >> received this communication in error please notify us immediately and >> destroy the original message. Thank you. >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > > > -- > Unpaid intern in BillsBasement at noware dot com > -- Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 518 371 3971 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image.jpg Type: image/jpeg Size: 154273 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: vtkLODPointCloudMapper.remote.cmake Type: application/octet-stream Size: 249 bytes Desc: not available URL: From DLRdave at aol.com Fri Apr 15 13:55:46 2016 From: DLRdave at aol.com (David Cole) Date: Fri, 15 Apr 2016 13:55:46 -0400 Subject: [vtk-developers] CDash items-per-page In-Reply-To: References: Message-ID: "All" is fine for the default ..... as long as it's fast enough. Back in the day, all was far too slow, and it became "not the default" for just such reason. So, if it's default, may I respectfully request that it is blazingly fast? Thanks, David C. On Fri, Apr 15, 2016 at 12:39 PM, Zack Galbreath wrote: > On Fri, Apr 15, 2016 at 12:24 PM, David Gobbi wrote: >> >> Except for the coverage view, it doesn't remember the setting. > > > Thanks for letting me know, I'm looking into it. > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > From bill.lorensen at gmail.com Mon Apr 18 11:38:52 2016 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 18 Apr 2016 11:38:52 -0400 Subject: [vtk-developers] HDF5 fails to compile after checkin Message-ID: I get this error with my Mac clang compiler: [ 26%] Building C object ThirdParty/hdf5/vtkhdf5/src/CMakeFiles/H5detect.dir/H5detect.c.o /Users/lorensen/ProjectsGIT/VTK/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1364:39: error: expected ';' after top level declarator detect_C89_integers(void) HDF_NO_UBSAN ^ ; 1 error generated. make[2]: *** [ThirdParty/hdf5/vtkhdf5/src/CMakeFiles/H5detect.dir/H5detect.c.o] Error 1 make[1]: *** [ThirdParty/hdf5/vtkhdf5/src/CMakeFiles/H5detect.dir/all] Error 2 Bill -- Unpaid intern in BillsBasement at noware dot com From sean at rogue-research.com Mon Apr 18 11:40:08 2016 From: sean at rogue-research.com (Sean McBride) Date: Mon, 18 Apr 2016 11:40:08 -0400 Subject: [vtk-developers] HDF5 fails to compile after checkin In-Reply-To: References: Message-ID: <20160418154008.771181073@mail.rogue-research.com> On Mon, 18 Apr 2016 11:38:52 -0400, Bill Lorensen said: >I get this error with my Mac clang compiler: >[ 26%] Building C object >ThirdParty/hdf5/vtkhdf5/src/CMakeFiles/H5detect.dir/H5detect.c.o >/Users/lorensen/ProjectsGIT/VTK/ThirdParty/hdf5/vtkhdf5/src/H5detect.c: >1364:39: >error: expected ';' after top level declarator >detect_C89_integers(void) HDF_NO_UBSAN Bill, I'll take a look right away and either fix or revert shortly... Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From ken.martin at kitware.com Tue Apr 19 09:00:38 2016 From: ken.martin at kitware.com (Ken Martin) Date: Tue, 19 Apr 2016 09:00:38 -0400 Subject: [vtk-developers] Qt based sample point viewer application Message-ID: I have created a small sample application that renders point clouds using a Qt based interface. It is very rough and experimental but may be of use for folks as a starting point etc. Part of the motivation for creating it was to experiment with multithreaded applications and learn a bit about Qt. This application make requires the vtkPointCloud and vtkLODPointCloudMapper remote modules. I have used this app to render 200 million point clouds interactively on my laptop using LOD. FileIO is done in a different thread from the rendering. The remote module links are attached below you place them in your VTK/Remote directory and ten turn them on in CMake ala http://www.vtk.org/Wiki/VTK/Remote_Modules Thanks Ken [image: Inline image 1] -- Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 518 371 3971 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image.png Type: image/png Size: 77193 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: vtkPointView.remote.cmake Type: application/octet-stream Size: 226 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: vtkLODPointCloudMapper.remote.cmake Type: application/octet-stream Size: 249 bytes Desc: not available URL: From sean at rogue-research.com Thu Apr 21 11:49:27 2016 From: sean at rogue-research.com (Sean McBride) Date: Thu, 21 Apr 2016 11:49:27 -0400 Subject: [vtk-developers] vtkMINCImageAttributes regression in master vs 6.3, related to new vtkDataArray changes? Message-ID: <20160421154927.712380335@mail.rogue-research.com> Hi all, Just trying my app against VTK master and found a regression using vtkMINCImageAttributes that I suspect is related to the vtkDataArray change David Lonie wrote about March 7. I have a vtkMINCImageAttributes that I call GetAttributeValueAsString() on. That eventually goes into vtkMINCImageAttributes::ConvertDataArrayToString() which does this: if (dataType == VTK_CHAR) { vtkCharArray *charArray = vtkCharArray::SafeDownCast(array); return charArray->GetPointer(0); } and GetPointer is: template typename vtkAOSDataArrayTemplate::ValueType * vtkAOSDataArrayTemplate::GetPointer(vtkIdType valueIdx) { return this->Buffer->GetBuffer() + valueIdx; } and GetBuffer() returns null, which it doesn't in 6.3. I could dig further, but I'm hoping this will ring bells for someone... Thanks, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From david.lonie at kitware.com Thu Apr 21 12:05:30 2016 From: david.lonie at kitware.com (David Lonie) Date: Thu, 21 Apr 2016 12:05:30 -0400 Subject: [vtk-developers] vtkMINCImageAttributes regression in master vs 6.3, related to new vtkDataArray changes? In-Reply-To: <20160421154927.712380335@mail.rogue-research.com> References: <20160421154927.712380335@mail.rogue-research.com> Message-ID: On Thu, Apr 21, 2016 at 11:49 AM, Sean McBride wrote: > GetBuffer() returns null, which it doesn't in 6.3. vtkBuffer::GetBuffer should only return NULL when there's no data in the array, in which case the returned pointer should not be dereferenced anyway. What is the actual error you're seeing? Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Thu Apr 21 12:55:43 2016 From: sean at rogue-research.com (Sean McBride) Date: Thu, 21 Apr 2016 12:55:43 -0400 Subject: [vtk-developers] vtkMINCImageAttributes regression in master vs 6.3, related to new vtkDataArray changes? In-Reply-To: References: <20160421154927.712380335@mail.rogue-research.com> Message-ID: <20160421165543.426722891@mail.rogue-research.com> On Thu, 21 Apr 2016 12:05:30 -0400, David Lonie said: >> GetBuffer() returns null, which it doesn't in 6.3. > >vtkBuffer::GetBuffer should only return NULL when there's no data in the >array, in which case the returned pointer should not be dereferenced >anyway. What is the actual error you're seeing? Superficially, my problem is that in VTK 6.3 and earlier, with every MINC file we have in our testing collection, vtkMINCImageAttributes::GetAttributeValueAsString() never returns null, now with git master it sometimes does. My code is assuming (perhaps incorrectly?) that null is never returned, and I unconditionally dereference it and thus now crash. So to compare, I'm now stepping through in 6.3 where GetPointer is: T* GetPointer(vtkIdType id) { return this->Array + id; } here, this->Array is not null, but instead is a pointer to an empty string. Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From david.lonie at kitware.com Thu Apr 21 13:12:05 2016 From: david.lonie at kitware.com (David Lonie) Date: Thu, 21 Apr 2016 13:12:05 -0400 Subject: [vtk-developers] vtkMINCImageAttributes regression in master vs 6.3, related to new vtkDataArray changes? In-Reply-To: <20160421165543.426722891@mail.rogue-research.com> References: <20160421154927.712380335@mail.rogue-research.com> <20160421165543.426722891@mail.rogue-research.com> Message-ID: On Thu, Apr 21, 2016 at 12:55 PM, Sean McBride wrote: > On Thu, 21 Apr 2016 12:05:30 -0400, David Lonie said: > >> GetBuffer() returns null, which it doesn't in 6.3. > > > >vtkBuffer::GetBuffer should only return NULL when there's no data in the > >array, in which case the returned pointer should not be dereferenced > >anyway. What is the actual error you're seeing? > > Superficially, my problem is that in VTK 6.3 and earlier, with every MINC file we have in our testing collection, vtkMINCImageAttributes::GetAttributeValueAsString() never returns null, now with git master it sometimes does. My code is assuming (perhaps incorrectly?) that null is never returned, and I unconditionally dereference it and thus now crash. > > So to compare, I'm now stepping through in 6.3 where GetPointer is: > > T* GetPointer(vtkIdType id) { return this->Array + id; } > > here, this->Array is not null, but instead is a pointer to an empty string. I'd say that the issue is the unconditional dereference. We've never guaranteed that the returned pointer would not be null, and dereferencing it when the array is empty is asking for trouble and bad design IMO. I don't think we can even change it to always return a valid pointer. vtkAbstractArray::Initialize() is documented to 'release storage', which to me means that there should not be any memory allocated to the array afterwards. In this case, NULL is the only logical value that can be returned. Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lonie at kitware.com Thu Apr 21 13:18:05 2016 From: david.lonie at kitware.com (David Lonie) Date: Thu, 21 Apr 2016 13:18:05 -0400 Subject: [vtk-developers] vtkMINCImageAttributes regression in master vs 6.3, related to new vtkDataArray changes? In-Reply-To: References: <20160421154927.712380335@mail.rogue-research.com> <20160421165543.426722891@mail.rogue-research.com> Message-ID: On Thu, Apr 21, 2016 at 1:12 PM, David Lonie wrote: > I don't think we can even change it to always return a valid pointer. vtkAbstractArray::Initialize() is documented to 'release storage', which to me means that there should not be any memory allocated to the array afterwards. In this case, NULL is the only logical value that can be returned. I just checked the behavior of the old implementation: //--------------------------------------------------- // Release storage and reset array to initial state. template void vtkDataArrayTemplate::Initialize() { this->DeleteArray(); this->Array = 0; this->Size = 0; this->MaxId = -1; this->DataChanged(); } and T* GetPointer(vtkIdType id) { return this->Array + id; } Looks like 'dataArray->Initialize(); return dataArray->GetPointer(0);' would always return NULL, even for the old implementation. I think the proper fix here is to always either check that the array is not empty before calling GetPointer or explicitly checking the return value. Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Thu Apr 21 14:34:29 2016 From: sean at rogue-research.com (Sean McBride) Date: Thu, 21 Apr 2016 14:34:29 -0400 Subject: [vtk-developers] vtkMINCImageAttributes regression in master vs 6.3, related to new vtkDataArray changes? In-Reply-To: References: <20160421154927.712380335@mail.rogue-research.com> <20160421165543.426722891@mail.rogue-research.com> Message-ID: <20160421183429.2107064272@mail.rogue-research.com> On Thu, 21 Apr 2016 13:18:05 -0400, David Lonie said: >I think the proper fix here is to always either check that the array is not >empty before calling GetPointer or explicitly checking the return value. OK, so I think two changes are in order: 1) I improve my own code to defend against getting null back. 2) I change vtkMINCImageAttributes::ConvertDataArrayToString to return "" instead of null when GetPointer gives back null, thus restoring old behaviour. It seems the class' own internal usage doesn't expect null either, ex: os << this->ConvertDataArrayToString(array) << " ;\n"; (I confirmed that ostream's operator<< crashes if given null.) Will make a patch... Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From sean at rogue-research.com Thu Apr 21 16:48:07 2016 From: sean at rogue-research.com (Sean McBride) Date: Thu, 21 Apr 2016 16:48:07 -0400 Subject: [vtk-developers] vtkBuffer::Reallocate special case for OS X realloc() Message-ID: <20160421204807.1602120227@mail.rogue-research.com> Hi all, vtkBuffer::Reallocate() has this comment: // OS X's realloc does not free memory if the new block is smaller. This // is a very serious problem and causes huge amount of memory to be // wasted. Do not use realloc on the Mac. We've been profiling our app and this OS X-only workaround is a major performance killer for a use case involving blending 3D datasets. We measured a 250% runtime performance improvement of Render() in release builds by getting rid of this special-casing! Tonnes of time was being spent in malloc and std::copy. It seems entirely reasonable for realloc() to not automatically recoup the memory if the buffer is made smaller: for all it knows, you'll soon after realloc it bigger again. Also, for all we know the OS could recoup the memory later. This patch removes it, all tests still pass: Any objections? Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From david.gobbi at gmail.com Thu Apr 21 17:33:07 2016 From: david.gobbi at gmail.com (David Gobbi) Date: Thu, 21 Apr 2016 15:33:07 -0600 Subject: [vtk-developers] vtkBuffer::Reallocate special case for OS X realloc() In-Reply-To: <20160421204807.1602120227@mail.rogue-research.com> References: <20160421204807.1602120227@mail.rogue-research.com> Message-ID: On Thu, Apr 21, 2016 at 2:48 PM, Sean McBride wrote: > Hi all, > > vtkBuffer::Reallocate() has this comment: > > // OS X's realloc does not free memory if the new block is smaller. This > // is a very serious problem and causes huge amount of memory to be > // wasted. Do not use realloc on the Mac. > > We've been profiling our app and this OS X-only workaround is a major > performance killer for a use case involving blending 3D datasets. We > measured a 250% runtime performance improvement of Render() in release > builds by getting rid of this special-casing! Tonnes of time was being > spent in malloc and std::copy. > > It seems entirely reasonable for realloc() to not automatically recoup the > memory if the buffer is made smaller: for all it knows, you'll soon after > realloc it bigger again. Also, for all we know the OS could recoup the > memory later. > > This patch removes it, all tests still pass: > > > Any objections? > I agree. My guess is that this code was added to ensure that Squeeze() reclaims memory. If so, then vtkGenericDataArray::Squeeze() is the method that should have been tweaked, rather than vtkBuffer::Reallocate(). - David -------------- next part -------------- An HTML attachment was scrubbed... URL: From jfavre at cscs.ch Fri Apr 22 10:28:27 2016 From: jfavre at cscs.ch (Favre Jean) Date: Fri, 22 Apr 2016 14:28:27 +0000 Subject: [vtk-developers] SPH Interpolator Message-ID: <0EB9B6375711A04B820E6B6F5CCA9F68435E371F@MBX211.d.ethz.ch> Hello First of all, congrats on this new functionality. I am using it with results from an SPH simulation using the GADGET code[1] Our scientists are asking some pretty specific questions about the SPH kernels: Do you adopt a fixed kernel size for all particles or do you calculate it by adopting a certain number of neighbours? Do you use the scatter method (distributing each SPH particle on the grid) or the gather method (gathering the contribution of all SPH particles which are close enough to each grid point)? They further comment that "to calculate physical quantities, such as column density etc. , these details become important. For instance, it is important to know if the SPH interpolation scheme which is used is conserving the total mass or not when we map the mass from SPH distribution onto a uniform grid, which depend on the details of the SPH interpolation." If the Density and Mass arrays are set, [I use]: interpolator = vtkSPHInterpolator() interpolator.SetKernel(sphKernel) interpolator.SetDensityArrayName("Density") interpolator.SetMassArrayName("Mass") can I assume the above to be true? Thanks for clarifying these points. I anticipate some really good use of this new Interpolator. [1] http://wwwmpa.mpa-garching.mpg.de/gadget/ ----------------- Jean/CSCS -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Sat Apr 23 07:56:06 2016 From: will.schroeder at kitware.com (Will Schroeder) Date: Sat, 23 Apr 2016 07:56:06 -0400 Subject: [vtk-developers] SPH Interpolator In-Reply-To: <0EB9B6375711A04B820E6B6F5CCA9F68435E371F@MBX211.d.ethz.ch> References: <0EB9B6375711A04B820E6B6F5CCA9F68435E371F@MBX211.d.ethz.ch> Message-ID: Hey Jean- Here's a longer email than you'd probably like; hopefully it will give you a better idea of where this is heading. I want to emphasize that this a work in progress, and feedback from those more knowledgeable in this area is very welcome. The recent efforts are partly due to the generous support of a collastomer (collaborator/customer), and the personal interest of myself and others at Kitware. For example, besides the SPH additions, I've implemented a bunch of point cloud algorithms in the vtkPointCloud remote module, and Ken Martin has put together a kick-butt point cloud renderer (also a VTK remote module vtkLODPointCloudMapper). We've also got some efforts going on with VeloView , which is a derivative ParaView application for point cloud visualization and analysis. Finally, I've been reworking many algorithms using threaded approaches (vtkSMPTools) including the new vtkStaticPointLocator which is typically much faster than any other point locators and is critical to the speed of the SPH operations. (Caveat: I'm guessing that highly dynamic data where point densities vary by orders of magnitude e.g., astrophysics will require more work, probably a hierarchical static point locator much like an AMR grid.) Okay with that preamble behind me, the current thinking is to support three workflows. 1. Fixed kernel size / specified smoothing length h (also called spatial step). The cutoff distance (sphere around an interpolated point) is a function of the SPH kernel. For example, a quintic kernel has cutoff distance 3*h. The volume is approximated as h^3. This has been tested with real simulation data incompressible CFD and is being validated/verified against simulation data so I have confidence that we are in good shape here. So far we have implemented cubic, quartic and quintic SPH kernels. 2. Volume defined on a pointwise basis using a pair of mass/density arrays. The API is there to support this, but I believe the last I left it there is a touch more work to do to get it working correctly, and of course testing is necessary. We could really use some data to test this properly. It's probably a few hours work and I plan to get back to finishing it off once I return from some travel next week. 3. Currently in #1 the kernel neighbors are found in the cutoff sphere, with the sphere radius constant across each point. However it would be possible to support a variable radius per point through a provided external array. This is not hard to do, but I really need data before proceeding. My understanding from reading references like Price is that another, less desirable possibility for basis is to use N neighbors, rather than the neighbors contained in the cutoff sphere. I have done this in vtkPointInterpolator / vtkGeneralizedKernel classes, which are close cousin classes to vtkSPHInterpolator / vtkSPHKernel. So this could easily be extended to the SPH side as well. The current implementation uses a gather method, and is done in parallel using vtkSMPTools. For each point to be interpolated, the basis neighbors around the point are retrieved using a provided abstract point locator (typically an instance of vtkStaticPointLocator but others are possible). The provided kernel is then invoked to perform the interpolation. So you can see that a vtkSMPTools::For(0,npts,functor) works really well to thread the operation (typically TBB is used because I like the load balancing that it provides). So any suggestions you might have, or data you can provide would be more than welcome. Also note that more testing is desired, for example the cubic and quartic SPH kernels need more testing. Bill Lorensen has been helping a lot in that he is adding some unit tests for the generalized kernels and has already uncovered a couple of bugs (which have been fixed). Anyway I leave for a week of travel early this coming week. If you want to continue the conversation when I return in early May that would be great. Best, W On Fri, Apr 22, 2016 at 10:28 AM, Favre Jean wrote: > Hello > > First of all, congrats on this new functionality. I am using it with > results from an SPH simulation using the GADGET code[1] > > Our scientists are asking some pretty specific questions about the SPH > kernels: > > Do you adopt a fixed kernel size for all particles or do you calculate it > by adopting a certain number of neighbours? Do you use the scatter method > (distributing each SPH particle on the grid) or the gather method > (gathering the contribution of all SPH particles which are close enough to > each grid point)? > > They further comment that "to calculate physical quantities, such as > column density etc. , these details become important. For instance, it is > important to know if the SPH interpolation scheme which is used is > conserving the total mass or not when we map the mass from SPH distribution > onto a uniform grid, which depend on the details of the SPH interpolation." > > If the Density and Mass arrays are set, [I use]: > > interpolator = vtkSPHInterpolator() > interpolator.SetKernel(sphKernel) > interpolator.SetDensityArrayName("Density") > interpolator.SetMassArrayName("Mass") > > can I assume the above to be true? > > Thanks for clarifying these points. I anticipate some really good use of > this new Interpolator. > > [1] http://wwwmpa.mpa-garching.mpg.de/gadget/ > > ----------------- > Jean/CSCS > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From biddisco at cscs.ch Sat Apr 23 16:24:29 2016 From: biddisco at cscs.ch (Biddiscombe, John A.) Date: Sat, 23 Apr 2016 20:24:29 +0000 Subject: [vtk-developers] SPH Interpolator In-Reply-To: References: <0EB9B6375711A04B820E6B6F5CCA9F68435E371F@MBX211.d.ethz.ch> Message-ID: Will, >So far we have implemented cubic, quartic and quintic SPH kernels. There are more kernels you can easily adapt in the pv-meshless repo (they have been tested extensively over the years) https://github.com/biddisco/pv-meshless/tree/master/sph (the sph interpolation classes in there handle a variable kernel size per point) JB From: "vtk-developers-bounces at vtk.org" > on behalf of Will Schroeder > Date: Saturday 23 April 2016 at 13:56 To: Favre Jean > Cc: VTK Developers > Subject: Re: [vtk-developers] SPH Interpolator Hey Jean- Here's a longer email than you'd probably like; hopefully it will give you a better idea of where this is heading. I want to emphasize that this a work in progress, and feedback from those more knowledgeable in this area is very welcome. The recent efforts are partly due to the generous support of a collastomer (collaborator/customer), and the personal interest of myself and others at Kitware. For example, besides the SPH additions, I've implemented a bunch of point cloud algorithms in the vtkPointCloud remote module, and Ken Martin has put together a kick-butt point cloud renderer (also a VTK remote module vtkLODPointCloudMapper). We've also got some efforts going on with VeloView, which is a derivative ParaView application for point cloud visualization and analysis. Finally, I've been reworking many algorithms using threaded approaches (vtkSMPTools) including the new vtkStaticPointLocator which is typically much faster than any other point locators and is critical to the speed of the SPH operations. (Caveat: I'm guessing that highly dynamic data where point densities vary by orders of magnitude e.g., astrophysics will require more work, probably a hierarchical static point locator much like an AMR grid.) Okay with that preamble behind me, the current thinking is to support three workflows. 1. Fixed kernel size / specified smoothing length h (also called spatial step). The cutoff distance (sphere around an interpolated point) is a function of the SPH kernel. For example, a quintic kernel has cutoff distance 3*h. The volume is approximated as h^3. This has been tested with real simulation data incompressible CFD and is being validated/verified against simulation data so I have confidence that we are in good shape here. So far we have implemented cubic, quartic and quintic SPH kernels. 2. Volume defined on a pointwise basis using a pair of mass/density arrays. The API is there to support this, but I believe the last I left it there is a touch more work to do to get it working correctly, and of course testing is necessary. We could really use some data to test this properly. It's probably a few hours work and I plan to get back to finishing it off once I return from some travel next week. 3. Currently in #1 the kernel neighbors are found in the cutoff sphere, with the sphere radius constant across each point. However it would be possible to support a variable radius per point through a provided external array. This is not hard to do, but I really need data before proceeding. My understanding from reading references like Price is that another, less desirable possibility for basis is to use N neighbors, rather than the neighbors contained in the cutoff sphere. I have done this in vtkPointInterpolator / vtkGeneralizedKernel classes, which are close cousin classes to vtkSPHInterpolator / vtkSPHKernel. So this could easily be extended to the SPH side as well. The current implementation uses a gather method, and is done in parallel using vtkSMPTools. For each point to be interpolated, the basis neighbors around the point are retrieved using a provided abstract point locator (typically an instance of vtkStaticPointLocator but others are possible). The provided kernel is then invoked to perform the interpolation. So you can see that a vtkSMPTools::For(0,npts,functor) works really well to thread the operation (typically TBB is used because I like the load balancing that it provides). So any suggestions you might have, or data you can provide would be more than welcome. Also note that more testing is desired, for example the cubic and quartic SPH kernels need more testing. Bill Lorensen has been helping a lot in that he is adding some unit tests for the generalized kernels and has already uncovered a couple of bugs (which have been fixed). Anyway I leave for a week of travel early this coming week. If you want to continue the conversation when I return in early May that would be great. Best, W On Fri, Apr 22, 2016 at 10:28 AM, Favre Jean > wrote: Hello First of all, congrats on this new functionality. I am using it with results from an SPH simulation using the GADGET code[1] Our scientists are asking some pretty specific questions about the SPH kernels: Do you adopt a fixed kernel size for all particles or do you calculate it by adopting a certain number of neighbours? Do you use the scatter method (distributing each SPH particle on the grid) or the gather method (gathering the contribution of all SPH particles which are close enough to each grid point)? They further comment that "to calculate physical quantities, such as column density etc. , these details become important. For instance, it is important to know if the SPH interpolation scheme which is used is conserving the total mass or not when we map the mass from SPH distribution onto a uniform grid, which depend on the details of the SPH interpolation." If the Density and Mass arrays are set, [I use]: interpolator = vtkSPHInterpolator() interpolator.SetKernel(sphKernel) interpolator.SetDensityArrayName("Density") interpolator.SetMassArrayName("Mass") can I assume the above to be true? Thanks for clarifying these points. I anticipate some really good use of this new Interpolator. [1] http://wwwmpa.mpa-garching.mpg.de/gadget/ ----------------- Jean/CSCS _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Search the list archives at: http://markmail.org/search/?q=vtk-developers Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/vtk-developers -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From artur.jaskiewicz2 at gmail.com Mon Apr 25 09:26:20 2016 From: artur.jaskiewicz2 at gmail.com (Signum) Date: Mon, 25 Apr 2016 06:26:20 -0700 (MST) Subject: [vtk-developers] Problem with rendering 3D objects with OpenGL ES 2.0 Message-ID: <1461590780968-5737865.post@n5.nabble.com> Hello. I am porting VTK to Google Native Client (Pnacl) which fully supports OpenGL ES 2.0. I think most of the work I need for my application is done (e.g. vtkImageReslice works fine), but now I have a problem with rendering simple Sphere or Cube or anything in 3D. The problem is that front walls renders transparent. On included image, cube on the left is what it should look like, and cube on the right is problematic rendering on OpenGL ES 2.0 (Native Client). To better visualise this problem, I've recorded video: VTK rendering artifacts video Does anybody have any idea what goes wrong here? PS. I also asked this question on stackoverflow: http://stackoverflow.com/questions/36790966/vtk-rendering-artifacts-with-opengl-es-2-0 -- View this message in context: http://vtk.1045678.n5.nabble.com/Problem-with-rendering-3D-objects-with-OpenGL-ES-2-0-tp5737865.html Sent from the VTK - Dev mailing list archive at Nabble.com. From ken.martin at kitware.com Mon Apr 25 10:24:54 2016 From: ken.martin at kitware.com (Ken Martin) Date: Mon, 25 Apr 2016 10:24:54 -0400 Subject: [vtk-developers] Problem with rendering 3D objects with OpenGL ES 2.0 In-Reply-To: <1461590780968-5737865.post@n5.nabble.com> References: <1461590780968-5737865.post@n5.nabble.com> Message-ID: I do not believe the front wall is transparent. Looking at the images it appears that everything is being rendered but the zbuffering is off or backwards. I'm not sure what you had to change to do the port but that would be my guess, some change related to creating the window, maybe it is missing a depth buffer or it is setup oddly. Ken On Mon, Apr 25, 2016 at 9:26 AM, Signum wrote: > Hello. I am porting VTK to Google Native Client (Pnacl) which fully > supports > OpenGL ES 2.0. > I think most of the work I need for my application is done (e.g. > vtkImageReslice works fine), but now I have a problem with rendering simple > Sphere or Cube or anything in 3D. The problem is that front walls renders > transparent. > On included image, cube on the left is what it should look like, and cube > on > the right is problematic rendering on OpenGL ES 2.0 (Native Client). > > > To better visualise this problem, I've recorded video: VTK rendering > artifacts video > > Does anybody have any idea what goes wrong here? > > PS. I also asked this question on stackoverflow: > > http://stackoverflow.com/questions/36790966/vtk-rendering-artifacts-with-opengl-es-2-0 > < > http://stackoverflow.com/questions/36790966/vtk-rendering-artifacts-with-opengl-es-2-0 > > > > > > -- > View this message in context: > http://vtk.1045678.n5.nabble.com/Problem-with-rendering-3D-objects-with-OpenGL-ES-2-0-tp5737865.html > Sent from the VTK - Dev mailing list archive at Nabble.com. > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- Ken Martin PhD Chairman & CFO Kitware Inc. 28 Corporate Drive Clifton Park NY 12065 518 371 3971 This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From behollis at sci.utah.edu Mon Apr 25 12:59:26 2016 From: behollis at sci.utah.edu (Brad Hollister) Date: Mon, 25 Apr 2016 10:59:26 -0600 Subject: [vtk-developers] volume rendering composite blend mode with foreground traslucent polygons Message-ID: Vtk 7.x apparently can't render transparent foreground polygons with volume rendered voxels using composite blending. The transparent foreground polys get rendered behind volume rendered voxels (which is incorrect depth). If those same foreground polys are fully opaque, then the composite blending is fine. Any solutions, workarounds or fixes? Regards, Brad From sean at rogue-research.com Mon Apr 25 22:40:36 2016 From: sean at rogue-research.com (Sean McBride) Date: Mon, 25 Apr 2016 22:40:36 -0400 Subject: [vtk-developers] gitlab 500 error Message-ID: <20160426024036.1187333142@mail.rogue-research.com> Hi all, I did the usual git gitlab-push and it gave the usual output: ------------------ The topic has been pushed to your fork in GitLab. Visit https://gitlab.kitware.com/seanm/vtk/tree/c++11-delete-function to see the files. Visit https://gitlab.kitware.com/seanm/vtk/merge_requests/new?merge_request[source_branch]=c++11-delete-function to create a Merge Request if there is not one already. ------------------ But the 2nd URL gives error 500. Is it a problem with the + character maybe? Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From david.gobbi at gmail.com Mon Apr 25 22:48:36 2016 From: david.gobbi at gmail.com (David Gobbi) Date: Mon, 25 Apr 2016 20:48:36 -0600 Subject: [vtk-developers] gitlab 500 error In-Reply-To: <20160426024036.1187333142@mail.rogue-research.com> References: <20160426024036.1187333142@mail.rogue-research.com> Message-ID: Try using %2B instead of + in the url? On Mon, Apr 25, 2016 at 8:40 PM, Sean McBride wrote: > Hi all, > > I did the usual git gitlab-push and it gave the usual output: > > ------------------ > The topic has been pushed to your fork in GitLab. Visit > > https://gitlab.kitware.com/seanm/vtk/tree/c++11-delete-function > > to see the files. Visit > > > https://gitlab.kitware.com/seanm/vtk/merge_requests/new?merge_request[source_branch]=c++11-delete-function > > to create a Merge Request if there is not one already. > ------------------ > > But the 2nd URL gives error 500. Is it a problem with the + character > maybe? > > Cheers, > > -- > ____________________________________________________________ > Sean McBride, B. Eng sean at rogue-research.com > Rogue Research www.rogue-research.com > Mac Software Developer Montr?al, Qu?bec, Canada > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Mon Apr 25 22:58:25 2016 From: sean at rogue-research.com (Sean McBride) Date: Mon, 25 Apr 2016 22:58:25 -0400 Subject: [vtk-developers] gitlab 500 error In-Reply-To: References: <20160426024036.1187333142@mail.rogue-research.com> Message-ID: <20160426025825.117463914@mail.rogue-research.com> On Mon, 25 Apr 2016 20:48:36 -0600, David Gobbi said: >Try using %2B instead of + in the url? That worked, thanks. So I guess the gitlab-push script needs to be changed to percent-encode the URL it outputs...? Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From ben.boeckel at kitware.com Tue Apr 26 10:01:19 2016 From: ben.boeckel at kitware.com (Ben Boeckel) Date: Tue, 26 Apr 2016 10:01:19 -0400 Subject: [vtk-developers] gitlab 500 error In-Reply-To: <20160426025825.117463914@mail.rogue-research.com> References: <20160426024036.1187333142@mail.rogue-research.com> <20160426025825.117463914@mail.rogue-research.com> Message-ID: <20160426140119.GA27171@megas.kitware.com> On Mon, Apr 25, 2016 at 22:58:25 -0400, Sean McBride wrote: > That worked, thanks. So I guess the gitlab-push script needs to be > changed to percent-encode the URL it outputs...? Yes, but just the branch name. Unfortunately, there are no tools which are guaranteed to exist to use generically (neither Python nor Perl) :( . But I suppose Python[1] could be checked for and used if it is available since urlencode is in the standard library. --Ben [1]Perl will probably be there, but the required modules are less likely I imagine. From sean at rogue-research.com Tue Apr 26 10:43:37 2016 From: sean at rogue-research.com (Sean McBride) Date: Tue, 26 Apr 2016 10:43:37 -0400 Subject: [vtk-developers] gitlab 500 error In-Reply-To: <20160426140119.GA27171@megas.kitware.com> References: <20160426024036.1187333142@mail.rogue-research.com> <20160426025825.117463914@mail.rogue-research.com> <20160426140119.GA27171@megas.kitware.com> Message-ID: <20160426144337.1981676084@mail.rogue-research.com> On Tue, 26 Apr 2016 10:01:19 -0400, Ben Boeckel said: >On Mon, Apr 25, 2016 at 22:58:25 -0400, Sean McBride wrote: >> That worked, thanks. So I guess the gitlab-push script needs to be >> changed to percent-encode the URL it outputs...? > >Yes, but just the branch name. Unfortunately, there are no tools which >are guaranteed to exist to use generically (neither Python nor Perl) :( >. But I suppose Python[1] could be checked for and used if it is >available since urlencode is in the standard library. I think that would be a 99% solution. Given python's importance to VTK's own tests, I imagine most people working with gitlab will have it installed. Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From sean at rogue-research.com Tue Apr 26 14:58:09 2016 From: sean at rogue-research.com (Sean McBride) Date: Tue, 26 Apr 2016 14:58:09 -0400 Subject: [vtk-developers] vtkDataArray performance; vtkErrorMacro semantics Message-ID: <20160426185809.201556798@mail.rogue-research.com> Hi all, So we're continuing to profile our app to improve the performance of something, and I have another vtkDataArray question. This method: void vtkDataArray::SetTuple(vtkIdType dstTupleIdx, vtkIdType srcTupleIdx, vtkAbstractArray *source) starts with 3 checks. If they fail, it uses vtkErrorMacro and bails. First, what are the semantics of hitting vtkErrorMacro? Is it meant to be like an assertion, ie something that should be impossible, and therefore useful in debug but discardable in release? We've added assert(0) in the three branches, and our code never hits them and no VTK unit test does either. The 3 checks are individually fast, but the method is called so very very often that removing the 3 checks entirely gives us a full 20% runtime speedup of Render(), so I'm hoping it would be acceptable to wrap them in #ifndef NDEBUG, or otherwise remove them from release builds. Thanks, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From david.lonie at kitware.com Tue Apr 26 15:26:32 2016 From: david.lonie at kitware.com (David Lonie) Date: Tue, 26 Apr 2016 15:26:32 -0400 Subject: [vtk-developers] vtkDataArray performance; vtkErrorMacro semantics In-Reply-To: <20160426185809.201556798@mail.rogue-research.com> References: <20160426185809.201556798@mail.rogue-research.com> Message-ID: On Tue, Apr 26, 2016 at 2:58 PM, Sean McBride wrote: > Hi all, > > So we're continuing to profile our app to improve the performance of > something, and I have another vtkDataArray question. This method: > > void vtkDataArray::SetTuple(vtkIdType dstTupleIdx, vtkIdType srcTupleIdx, > vtkAbstractArray *source) > > starts with 3 checks. If they fail, it uses vtkErrorMacro and bails. > > First, what are the semantics of hitting vtkErrorMacro? Is it meant to be > like an assertion, ie something that should be impossible, and therefore > useful in debug but discardable in release? > I've often wondered this myself, I'm not aware of an 'official' interpretation of these. From context, it seems to usually be used to enforce a documented/logical constraint. I often use them as non-fatal asserts. I know the dashboards are configured to treat any output coming from vtkErrorMacro as a test failure. > We've added assert(0) in the three branches, and our code never hits them > and no VTK unit test does either. > Not surprising -- the method does nothing (and tests will fail) if it hits them :) > The 3 checks are individually fast, but the method is called so very very > often that removing the 3 checks entirely gives us a full 20% runtime > speedup of Render(), so I'm hoping it would be acceptable to wrap them in > #ifndef NDEBUG, or otherwise remove them from release builds. +1 to the idea. I'd love to see this wrapped up in a vtkAssertMacro or similar, as well as some clarification on the semantics of Warning/ErrorMacro. I think there was some discussion started by Kyle Lutz a few years back about whether or not to just use asserts in these situations, and there was some controversy around the idea and he abandoned the proposal in the end. I can't remember or imagine why people objected at the moment, but the thread should be in the archives. I'd actually prefer to remove that (and similar) methods completely (settle down folks, I'm not actually proposing this! I've learned to just accept these warts and not try to fix problematic APIs in VTK). They have performance problems beyond the sanity checks, the repeated dispatch calls add up, too. It's too fine-grained an action for the expense it occurs. It used to be worse, actually -- back when I was profiling some of these functions the vast majority of CPU time was spent in strcmp, because SafeDownCast was being used to test if the source arrays was a data array. I believe it was actually this method that made me add the vtkAbstractArray::FastDownCast system. Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: From berk.geveci at kitware.com Tue Apr 26 16:26:24 2016 From: berk.geveci at kitware.com (Berk Geveci) Date: Tue, 26 Apr 2016 16:26:24 -0400 Subject: [vtk-developers] vtkDataArray performance; vtkErrorMacro semantics In-Reply-To: References: <20160426185809.201556798@mail.rogue-research.com> Message-ID: I agree with Dave Lonie's later statement. At least, let's focus on removing the use of that method and others like it that are horrible. Also, having these methods do the dispatch in the superclass rather than being virtual is a horrible performance drag. I recently instrumented an implementation of the contour filter that spent 75% of its time in SetTuples() (yikes!). My suggestion would be to switch to a virtual call that assumes input & output arrays are of the same type and leaving it up to the filter to make sure that the types match once. If it is easier in the short term, I am fine with by making those checks conditional to DEBUG or replacing them with some sort of assert(). However, you are still leaving a lot of performance on the floor by keeping that dispatch there... Best, -berk On Tue, Apr 26, 2016 at 3:26 PM, David Lonie wrote: > On Tue, Apr 26, 2016 at 2:58 PM, Sean McBride > wrote: > >> Hi all, >> >> So we're continuing to profile our app to improve the performance of >> something, and I have another vtkDataArray question. This method: >> >> void vtkDataArray::SetTuple(vtkIdType dstTupleIdx, vtkIdType srcTupleIdx, >> vtkAbstractArray *source) >> >> starts with 3 checks. If they fail, it uses vtkErrorMacro and bails. >> >> First, what are the semantics of hitting vtkErrorMacro? Is it meant to >> be like an assertion, ie something that should be impossible, and therefore >> useful in debug but discardable in release? >> > > I've often wondered this myself, I'm not aware of an 'official' > interpretation of these. From context, it seems to usually be used to > enforce a documented/logical constraint. I often use them as non-fatal > asserts. > > I know the dashboards are configured to treat any output coming from > vtkErrorMacro as a test failure. > > >> We've added assert(0) in the three branches, and our code never hits them >> and no VTK unit test does either. >> > > Not surprising -- the method does nothing (and tests will fail) if it hits > them :) > > >> The 3 checks are individually fast, but the method is called so very very >> often that removing the 3 checks entirely gives us a full 20% runtime >> speedup of Render(), so I'm hoping it would be acceptable to wrap them in >> #ifndef NDEBUG, or otherwise remove them from release builds. > > > +1 to the idea. I'd love to see this wrapped up in a vtkAssertMacro or > similar, as well as some clarification on the semantics of > Warning/ErrorMacro. I think there was some discussion started by Kyle Lutz > a few years back about whether or not to just use asserts in these > situations, and there was some controversy around the idea and he abandoned > the proposal in the end. I can't remember or imagine why people objected at > the moment, but the thread should be in the archives. > > I'd actually prefer to remove that (and similar) methods completely > (settle down folks, I'm not actually proposing this! I've learned to just > accept these warts and not try to fix problematic APIs in VTK). They have > performance problems beyond the sanity checks, the repeated dispatch calls > add up, too. It's too fine-grained an action for the expense it occurs. It > used to be worse, actually -- back when I was profiling some of these > functions the vast majority of CPU time was spent in strcmp, because > SafeDownCast was being used to test if the source arrays was a data array. > I believe it was actually this method that made me add the > vtkAbstractArray::FastDownCast system. > > Dave > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From lasso at queensu.ca Tue Apr 26 16:46:57 2016 From: lasso at queensu.ca (Andras Lasso) Date: Tue, 26 Apr 2016 20:46:57 +0000 Subject: [vtk-developers] vtkDataArray performance; vtkErrorMacro semantics In-Reply-To: References: <20160426185809.201556798@mail.rogue-research.com> Message-ID: It?s great to have these safe get/set methods for testing and debugging. Please don?t remove them or the boundary checks. It would be useful to add to the documentation that these methods are not intended for bulk data access and what methods should be used instead. Andras From: vtk-developers [mailto:vtk-developers-bounces at vtk.org] On Behalf Of Berk Geveci Sent: Tuesday, April 26, 2016 4:26 PM To: David Lonie Cc: VTK Developers Subject: Re: [vtk-developers] vtkDataArray performance; vtkErrorMacro semantics I agree with Dave Lonie's later statement. At least, let's focus on removing the use of that method and others like it that are horrible. Also, having these methods do the dispatch in the superclass rather than being virtual is a horrible performance drag. I recently instrumented an implementation of the contour filter that spent 75% of its time in SetTuples() (yikes!). My suggestion would be to switch to a virtual call that assumes input & output arrays are of the same type and leaving it up to the filter to make sure that the types match once. If it is easier in the short term, I am fine with by making those checks conditional to DEBUG or replacing them with some sort of assert(). However, you are still leaving a lot of performance on the floor by keeping that dispatch there... Best, -berk On Tue, Apr 26, 2016 at 3:26 PM, David Lonie > wrote: On Tue, Apr 26, 2016 at 2:58 PM, Sean McBride > wrote: Hi all, So we're continuing to profile our app to improve the performance of something, and I have another vtkDataArray question. This method: void vtkDataArray::SetTuple(vtkIdType dstTupleIdx, vtkIdType srcTupleIdx, vtkAbstractArray *source) starts with 3 checks. If they fail, it uses vtkErrorMacro and bails. First, what are the semantics of hitting vtkErrorMacro? Is it meant to be like an assertion, ie something that should be impossible, and therefore useful in debug but discardable in release? I've often wondered this myself, I'm not aware of an 'official' interpretation of these. From context, it seems to usually be used to enforce a documented/logical constraint. I often use them as non-fatal asserts. I know the dashboards are configured to treat any output coming from vtkErrorMacro as a test failure. We've added assert(0) in the three branches, and our code never hits them and no VTK unit test does either. Not surprising -- the method does nothing (and tests will fail) if it hits them :) The 3 checks are individually fast, but the method is called so very very often that removing the 3 checks entirely gives us a full 20% runtime speedup of Render(), so I'm hoping it would be acceptable to wrap them in #ifndef NDEBUG, or otherwise remove them from release builds. +1 to the idea. I'd love to see this wrapped up in a vtkAssertMacro or similar, as well as some clarification on the semantics of Warning/ErrorMacro. I think there was some discussion started by Kyle Lutz a few years back about whether or not to just use asserts in these situations, and there was some controversy around the idea and he abandoned the proposal in the end. I can't remember or imagine why people objected at the moment, but the thread should be in the archives. I'd actually prefer to remove that (and similar) methods completely (settle down folks, I'm not actually proposing this! I've learned to just accept these warts and not try to fix problematic APIs in VTK). They have performance problems beyond the sanity checks, the repeated dispatch calls add up, too. It's too fine-grained an action for the expense it occurs. It used to be worse, actually -- back when I was profiling some of these functions the vast majority of CPU time was spent in strcmp, because SafeDownCast was being used to test if the source arrays was a data array. I believe it was actually this method that made me add the vtkAbstractArray::FastDownCast system. Dave _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Search the list archives at: http://markmail.org/search/?q=vtk-developers Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/vtk-developers -------------- next part -------------- An HTML attachment was scrubbed... URL: From pieper at isomics.com Tue Apr 26 19:34:48 2016 From: pieper at isomics.com (Steve Pieper) Date: Tue, 26 Apr 2016 19:34:48 -0400 Subject: [vtk-developers] vtkDataArray performance; vtkErrorMacro semantics In-Reply-To: References: <20160426185809.201556798@mail.rogue-research.com> Message-ID: Please also keep in mind the interactive python use case (like ipython or a slicer console) where you are exploring the API or testing code. A vtkErrorMacro message is very helpful. But an assert will either just bomb out if you are using a debug build or possibly lead to undefined behavior in a release build. -Steve On Tue, Apr 26, 2016 at 4:46 PM, Andras Lasso wrote: > It?s great to have these safe get/set methods for testing and debugging. > Please don?t remove them or the boundary checks. > > > > It would be useful to add to the documentation that these methods are not > intended for bulk data access and what methods should be used instead. > > > > Andras > > > > *From:* vtk-developers [mailto:vtk-developers-bounces at vtk.org] *On Behalf > Of *Berk Geveci > *Sent:* Tuesday, April 26, 2016 4:26 PM > *To:* David Lonie > *Cc:* VTK Developers > *Subject:* Re: [vtk-developers] vtkDataArray performance; vtkErrorMacro > semantics > > > > I agree with Dave Lonie's later statement. At least, let's focus on > removing the use of that method and others like it that are horrible. Also, > having these methods do the dispatch in the superclass rather than being > virtual is a horrible performance drag. I recently instrumented an > implementation of the contour filter that spent 75% of its time in > SetTuples() (yikes!). > > > > My suggestion would be to switch to a virtual call that assumes input & > output arrays are of the same type and leaving it up to the filter to make > sure that the types match once. > > > > If it is easier in the short term, I am fine with by making those checks > conditional to DEBUG or replacing them with some sort of assert(). However, > you are still leaving a lot of performance on the floor by keeping that > dispatch there... > > > > Best, > > -berk > > > > > > On Tue, Apr 26, 2016 at 3:26 PM, David Lonie > wrote: > > On Tue, Apr 26, 2016 at 2:58 PM, Sean McBride > wrote: > > Hi all, > > So we're continuing to profile our app to improve the performance of > something, and I have another vtkDataArray question. This method: > > void vtkDataArray::SetTuple(vtkIdType dstTupleIdx, vtkIdType srcTupleIdx, > vtkAbstractArray *source) > > starts with 3 checks. If they fail, it uses vtkErrorMacro and bails. > > First, what are the semantics of hitting vtkErrorMacro? Is it meant to be > like an assertion, ie something that should be impossible, and therefore > useful in debug but discardable in release? > > > > I've often wondered this myself, I'm not aware of an 'official' > interpretation of these. From context, it seems to usually be used to > enforce a documented/logical constraint. I often use them as non-fatal > asserts. > > > > I know the dashboards are configured to treat any output coming from > vtkErrorMacro as a test failure. > > > > We've added assert(0) in the three branches, and our code never hits them > and no VTK unit test does either. > > > > Not surprising -- the method does nothing (and tests will fail) if it hits > them :) > > > > The 3 checks are individually fast, but the method is called so very very > often that removing the 3 checks entirely gives us a full 20% runtime > speedup of Render(), so I'm hoping it would be acceptable to wrap them in > #ifndef NDEBUG, or otherwise remove them from release builds. > > > > +1 to the idea. I'd love to see this wrapped up in a vtkAssertMacro or > similar, as well as some clarification on the semantics of > Warning/ErrorMacro. I think there was some discussion started by Kyle Lutz > a few years back about whether or not to just use asserts in these > situations, and there was some controversy around the idea and he abandoned > the proposal in the end. I can't remember or imagine why people objected at > the moment, but the thread should be in the archives. > > > > I'd actually prefer to remove that (and similar) methods completely > (settle down folks, I'm not actually proposing this! I've learned to just > accept these warts and not try to fix problematic APIs in VTK). They have > performance problems beyond the sanity checks, the repeated dispatch calls > add up, too. It's too fine-grained an action for the expense it occurs. It > used to be worse, actually -- back when I was profiling some of these > functions the vast majority of CPU time was spent in strcmp, because > SafeDownCast was being used to test if the source arrays was a data array. > I believe it was actually this method that made me add the > vtkAbstractArray::FastDownCast system. > > > > Dave > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From Olivier.Commowick at inria.fr Thu Apr 28 09:32:21 2016 From: Olivier.Commowick at inria.fr (Olivier Commowick) Date: Thu, 28 Apr 2016 15:32:21 +0200 Subject: [vtk-developers] qtgraphicsview example crash with OpenGL2 Message-ID: Hi everyone, We would like to upgrade one of our projects to the new backend of VTK 7 (OpenGL2). We are using the QVTKGraphicsItem for the VTK visualisation in our Qt application. For some reason, when switching to OpenGL2 backend, the app crashes in vtkOpenGLRenderWindow::OpenGLInitState. I therefore tried the qtgraphicsview example of VTK, and it crashes as well. Here is part of the crash backlog: 0 ??? 000000000000000000 0 + 0 1 libvtkRenderingOpenGL2-7.0.1.dylib 0x0000000109ade96d vtkOpenGLRenderWindow::OpenGLInitState() + 93 (vtkOpenGLRenderWindow.cxx:328) 2 0x0000000103d5e7ac GraphicsView::drawBackground(QPainter*, QRectF const&) + 108 (GraphicsView.hpp:48) 3 org.qt-project.QtWidgets 0x000000010899fb8b QGraphicsView::paintEvent(QPaintEvent*) + 1099 4 org.qt-project.QtWidgets 0x000000010868f1bb QWidget::event(QEvent*) + 2123 5 org.qt-project.QtWidgets 0x000000010878276d QFrame::event(QEvent*) + 45 6 org.qt-project.QtWidgets 0x00000001088079fa QAbstractScrollArea::viewportEvent(QEvent*) + 170 7 org.qt-project.QtWidgets 0x000000010899d862 QGraphicsView::viewportEvent(QEvent*) + 1730 At line 328 in vtkOpenGLRenderWindow.cxx, there is this function : glBlendFuncSeparate(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA, GL_ONE,GL_ONE_MINUS_SRC_ALPHA); Would anyone have any idea why this crash is happening in this example ? As a side note, I have run all of this on OSX (macbook pro retina, 2012). Thanks in advance --- Olivier Commowick, Ph.D. Research Scientist INRIA Rennes - Bretagne Atlantique, VISAGES Team Campus de Beaulieu 35042 Rennes FRANCE Phone: +33 2 99 84 25 92 Email: Olivier.Commowick at inria.fr Web: http://olivier.commowick.org/ From berk.geveci at kitware.com Thu Apr 28 13:19:31 2016 From: berk.geveci at kitware.com (Berk Geveci) Date: Thu, 28 Apr 2016 13:19:31 -0400 Subject: [vtk-developers] vtkDataArray performance; vtkErrorMacro semantics In-Reply-To: References: <20160426185809.201556798@mail.rogue-research.com> Message-ID: Yeah but that's kicking the can to another method :-) Should we maintain a whole API for testing/debugging and then another for fast access? What guarantees then that folks will rewrite their filters/code to use the faster APIs after testing/debugging? As it is proven by the current set of VTK filters, people use whatever is convenient in writing their current filter and don't necessarily dig deep into what is the most efficient. I do understand the desire to do boundary checking etc. though. But then compiling in debug mode seems to be a decent compromise. I am somewhat on the fence on whether assert() or error macro is better in that case. It would be fairly easy to define the error macro such that it optionally asserts so maybe that's the way to go... In core data structures such as arrays and datasets, I'd like to see us moving in a direction that makes it easier to write performant and thread safe code. With the current set of methods, this is very hard to achieve because of its sprawling nature. By the way, the method in discussion does not do any boundary checking. Similar to other SetTuple() methods. InsertTuple() methods do boundary checking. In general, SetTuple() methods do not provide a safety net against developer errors for performance. For example: template void vtkDataArrayTemplate::SetTuple(vtkIdType i, const float* tuple) { vtkIdType loc = i * this->NumberOfComponents; for(int j=0; j < this->NumberOfComponents; ++j) { this->Array[loc+j] = static_cast(tuple[j]); } this->DataChanged(); } Obviously, there are many things that can wrong here. So, adding more checks that are debug mode only could actually make things safer overall and help us catch boundary condition issues. Best, -berk On Tue, Apr 26, 2016 at 4:46 PM, Andras Lasso wrote: > It?s great to have these safe get/set methods for testing and debugging. > Please don?t remove them or the boundary checks. > > > > It would be useful to add to the documentation that these methods are not > intended for bulk data access and what methods should be used instead. > > > > Andras > > > > *From:* vtk-developers [mailto:vtk-developers-bounces at vtk.org] *On Behalf > Of *Berk Geveci > *Sent:* Tuesday, April 26, 2016 4:26 PM > *To:* David Lonie > *Cc:* VTK Developers > *Subject:* Re: [vtk-developers] vtkDataArray performance; vtkErrorMacro > semantics > > > > I agree with Dave Lonie's later statement. At least, let's focus on > removing the use of that method and others like it that are horrible. Also, > having these methods do the dispatch in the superclass rather than being > virtual is a horrible performance drag. I recently instrumented an > implementation of the contour filter that spent 75% of its time in > SetTuples() (yikes!). > > > > My suggestion would be to switch to a virtual call that assumes input & > output arrays are of the same type and leaving it up to the filter to make > sure that the types match once. > > > > If it is easier in the short term, I am fine with by making those checks > conditional to DEBUG or replacing them with some sort of assert(). However, > you are still leaving a lot of performance on the floor by keeping that > dispatch there... > > > > Best, > > -berk > > > > > > On Tue, Apr 26, 2016 at 3:26 PM, David Lonie > wrote: > > On Tue, Apr 26, 2016 at 2:58 PM, Sean McBride > wrote: > > Hi all, > > So we're continuing to profile our app to improve the performance of > something, and I have another vtkDataArray question. This method: > > void vtkDataArray::SetTuple(vtkIdType dstTupleIdx, vtkIdType srcTupleIdx, > vtkAbstractArray *source) > > starts with 3 checks. If they fail, it uses vtkErrorMacro and bails. > > First, what are the semantics of hitting vtkErrorMacro? Is it meant to be > like an assertion, ie something that should be impossible, and therefore > useful in debug but discardable in release? > > > > I've often wondered this myself, I'm not aware of an 'official' > interpretation of these. From context, it seems to usually be used to > enforce a documented/logical constraint. I often use them as non-fatal > asserts. > > > > I know the dashboards are configured to treat any output coming from > vtkErrorMacro as a test failure. > > > > We've added assert(0) in the three branches, and our code never hits them > and no VTK unit test does either. > > > > Not surprising -- the method does nothing (and tests will fail) if it hits > them :) > > > > The 3 checks are individually fast, but the method is called so very very > often that removing the 3 checks entirely gives us a full 20% runtime > speedup of Render(), so I'm hoping it would be acceptable to wrap them in > #ifndef NDEBUG, or otherwise remove them from release builds. > > > > +1 to the idea. I'd love to see this wrapped up in a vtkAssertMacro or > similar, as well as some clarification on the semantics of > Warning/ErrorMacro. I think there was some discussion started by Kyle Lutz > a few years back about whether or not to just use asserts in these > situations, and there was some controversy around the idea and he abandoned > the proposal in the end. I can't remember or imagine why people objected at > the moment, but the thread should be in the archives. > > > > I'd actually prefer to remove that (and similar) methods completely > (settle down folks, I'm not actually proposing this! I've learned to just > accept these warts and not try to fix problematic APIs in VTK). They have > performance problems beyond the sanity checks, the repeated dispatch calls > add up, too. It's too fine-grained an action for the expense it occurs. It > used to be worse, actually -- back when I was profiling some of these > functions the vast majority of CPU time was spent in strcmp, because > SafeDownCast was being used to test if the source arrays was a data array. > I believe it was actually this method that made me add the > vtkAbstractArray::FastDownCast system. > > > > Dave > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Thu Apr 28 13:29:22 2016 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 28 Apr 2016 13:29:22 -0400 Subject: [vtk-developers] vtkDataArray performance; vtkErrorMacro semantics In-Reply-To: References: <20160426185809.201556798@mail.rogue-research.com> Message-ID: I would not want to see the error macros use asserts if built with debug. The new unit tests I've been writing also cover the error code and check that the error/warning text are correct. On Thu, Apr 28, 2016 at 1:19 PM, Berk Geveci wrote: > Yeah but that's kicking the can to another method :-) Should we maintain a > whole API for testing/debugging and then another for fast access? What > guarantees then that folks will rewrite their filters/code to use the faster > APIs after testing/debugging? As it is proven by the current set of VTK > filters, people use whatever is convenient in writing their current filter > and don't necessarily dig deep into what is the most efficient. > > I do understand the desire to do boundary checking etc. though. But then > compiling in debug mode seems to be a decent compromise. I am somewhat on > the fence on whether assert() or error macro is better in that case. It > would be fairly easy to define the error macro such that it optionally > asserts so maybe that's the way to go... > > In core data structures such as arrays and datasets, I'd like to see us > moving in a direction that makes it easier to write performant and thread > safe code. With the current set of methods, this is very hard to achieve > because of its sprawling nature. > > By the way, the method in discussion does not do any boundary checking. > Similar to other SetTuple() methods. InsertTuple() methods do boundary > checking. In general, SetTuple() methods do not provide a safety net against > developer errors for performance. For example: > > template > void vtkDataArrayTemplate::SetTuple(vtkIdType i, const float* tuple) > { > vtkIdType loc = i * this->NumberOfComponents; > for(int j=0; j < this->NumberOfComponents; ++j) > { > this->Array[loc+j] = static_cast(tuple[j]); > } > this->DataChanged(); > } > > Obviously, there are many things that can wrong here. So, adding more checks > that are debug mode only could actually make things safer overall and help > us catch boundary condition issues. > > Best, > -berk > > > > On Tue, Apr 26, 2016 at 4:46 PM, Andras Lasso wrote: >> >> It?s great to have these safe get/set methods for testing and debugging. >> Please don?t remove them or the boundary checks. >> >> >> >> It would be useful to add to the documentation that these methods are not >> intended for bulk data access and what methods should be used instead. >> >> >> >> Andras >> >> >> >> From: vtk-developers [mailto:vtk-developers-bounces at vtk.org] On Behalf Of >> Berk Geveci >> Sent: Tuesday, April 26, 2016 4:26 PM >> To: David Lonie >> Cc: VTK Developers >> Subject: Re: [vtk-developers] vtkDataArray performance; vtkErrorMacro >> semantics >> >> >> >> I agree with Dave Lonie's later statement. At least, let's focus on >> removing the use of that method and others like it that are horrible. Also, >> having these methods do the dispatch in the superclass rather than being >> virtual is a horrible performance drag. I recently instrumented an >> implementation of the contour filter that spent 75% of its time in >> SetTuples() (yikes!). >> >> >> >> My suggestion would be to switch to a virtual call that assumes input & >> output arrays are of the same type and leaving it up to the filter to make >> sure that the types match once. >> >> >> >> If it is easier in the short term, I am fine with by making those checks >> conditional to DEBUG or replacing them with some sort of assert(). However, >> you are still leaving a lot of performance on the floor by keeping that >> dispatch there... >> >> >> >> Best, >> >> -berk >> >> >> >> >> >> On Tue, Apr 26, 2016 at 3:26 PM, David Lonie >> wrote: >> >> On Tue, Apr 26, 2016 at 2:58 PM, Sean McBride >> wrote: >> >> Hi all, >> >> So we're continuing to profile our app to improve the performance of >> something, and I have another vtkDataArray question. This method: >> >> void vtkDataArray::SetTuple(vtkIdType dstTupleIdx, vtkIdType srcTupleIdx, >> vtkAbstractArray *source) >> >> starts with 3 checks. If they fail, it uses vtkErrorMacro and bails. >> >> First, what are the semantics of hitting vtkErrorMacro? Is it meant to be >> like an assertion, ie something that should be impossible, and therefore >> useful in debug but discardable in release? >> >> >> >> I've often wondered this myself, I'm not aware of an 'official' >> interpretation of these. From context, it seems to usually be used to >> enforce a documented/logical constraint. I often use them as non-fatal >> asserts. >> >> >> >> I know the dashboards are configured to treat any output coming from >> vtkErrorMacro as a test failure. >> >> >> >> We've added assert(0) in the three branches, and our code never hits them >> and no VTK unit test does either. >> >> >> >> Not surprising -- the method does nothing (and tests will fail) if it hits >> them :) >> >> >> >> The 3 checks are individually fast, but the method is called so very very >> often that removing the 3 checks entirely gives us a full 20% runtime >> speedup of Render(), so I'm hoping it would be acceptable to wrap them in >> #ifndef NDEBUG, or otherwise remove them from release builds. >> >> >> >> +1 to the idea. I'd love to see this wrapped up in a vtkAssertMacro or >> similar, as well as some clarification on the semantics of >> Warning/ErrorMacro. I think there was some discussion started by Kyle Lutz a >> few years back about whether or not to just use asserts in these situations, >> and there was some controversy around the idea and he abandoned the proposal >> in the end. I can't remember or imagine why people objected at the moment, >> but the thread should be in the archives. >> >> >> >> I'd actually prefer to remove that (and similar) methods completely >> (settle down folks, I'm not actually proposing this! I've learned to just >> accept these warts and not try to fix problematic APIs in VTK). They have >> performance problems beyond the sanity checks, the repeated dispatch calls >> add up, too. It's too fine-grained an action for the expense it occurs. It >> used to be worse, actually -- back when I was profiling some of these >> functions the vast majority of CPU time was spent in strcmp, because >> SafeDownCast was being used to test if the source arrays was a data array. I >> believe it was actually this method that made me add the >> vtkAbstractArray::FastDownCast system. >> >> >> >> Dave >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > -- Unpaid intern in BillsBasement at noware dot com From david.lonie at kitware.com Thu Apr 28 13:49:38 2016 From: david.lonie at kitware.com (David Lonie) Date: Thu, 28 Apr 2016 13:49:38 -0400 Subject: [vtk-developers] vtkDataArray performance; vtkErrorMacro semantics In-Reply-To: References: <20160426185809.201556798@mail.rogue-research.com> Message-ID: So we don't duplicate effort, Berk and I talked about this a bit and I'll push a change that moves the implementation for this method into the implementation classes to reduce dispatch overhead. I'll leave the checks as-is for now. On Thu, Apr 28, 2016 at 1:19 PM, Berk Geveci wrote: > Yeah but that's kicking the can to another method :-) Should we maintain a > whole API for testing/debugging and then another for fast access? What > guarantees then that folks will rewrite their filters/code to use the > faster APIs after testing/debugging? As it is proven by the current set of > VTK filters, people use whatever is convenient in writing their current > filter and don't necessarily dig deep into what is the most efficient. > > I do understand the desire to do boundary checking etc. though. But then > compiling in debug mode seems to be a decent compromise. I am somewhat on > the fence on whether assert() or error macro is better in that case. It > would be fairly easy to define the error macro such that it optionally > asserts so maybe that's the way to go... > > In core data structures such as arrays and datasets, I'd like to see us > moving in a direction that makes it easier to write performant and thread > safe code. With the current set of methods, this is very hard to achieve > because of its sprawling nature. > > By the way, the method in discussion does not do any boundary checking. > Similar to other SetTuple() methods. InsertTuple() methods do boundary > checking. In general, SetTuple() methods do not provide a safety net > against developer errors for performance. For example: > > template > void vtkDataArrayTemplate::SetTuple(vtkIdType i, const float* tuple) > { > vtkIdType loc = i * this->NumberOfComponents; > for(int j=0; j < this->NumberOfComponents; ++j) > { > this->Array[loc+j] = static_cast(tuple[j]); > } > this->DataChanged(); > } > > Obviously, there are many things that can wrong here. So, adding more > checks that are debug mode only could actually make things safer overall > and help us catch boundary condition issues. > > Best, > -berk > > > > On Tue, Apr 26, 2016 at 4:46 PM, Andras Lasso wrote: > >> It?s great to have these safe get/set methods for testing and debugging. >> Please don?t remove them or the boundary checks. >> >> >> >> It would be useful to add to the documentation that these methods are not >> intended for bulk data access and what methods should be used instead. >> >> >> >> Andras >> >> >> >> *From:* vtk-developers [mailto:vtk-developers-bounces at vtk.org] *On >> Behalf Of *Berk Geveci >> *Sent:* Tuesday, April 26, 2016 4:26 PM >> *To:* David Lonie >> *Cc:* VTK Developers >> *Subject:* Re: [vtk-developers] vtkDataArray performance; vtkErrorMacro >> semantics >> >> >> >> I agree with Dave Lonie's later statement. At least, let's focus on >> removing the use of that method and others like it that are horrible. Also, >> having these methods do the dispatch in the superclass rather than being >> virtual is a horrible performance drag. I recently instrumented an >> implementation of the contour filter that spent 75% of its time in >> SetTuples() (yikes!). >> >> >> >> My suggestion would be to switch to a virtual call that assumes input & >> output arrays are of the same type and leaving it up to the filter to make >> sure that the types match once. >> >> >> >> If it is easier in the short term, I am fine with by making those checks >> conditional to DEBUG or replacing them with some sort of assert(). However, >> you are still leaving a lot of performance on the floor by keeping that >> dispatch there... >> >> >> >> Best, >> >> -berk >> >> >> >> >> >> On Tue, Apr 26, 2016 at 3:26 PM, David Lonie >> wrote: >> >> On Tue, Apr 26, 2016 at 2:58 PM, Sean McBride >> wrote: >> >> Hi all, >> >> So we're continuing to profile our app to improve the performance of >> something, and I have another vtkDataArray question. This method: >> >> void vtkDataArray::SetTuple(vtkIdType dstTupleIdx, vtkIdType srcTupleIdx, >> vtkAbstractArray *source) >> >> starts with 3 checks. If they fail, it uses vtkErrorMacro and bails. >> >> First, what are the semantics of hitting vtkErrorMacro? Is it meant to >> be like an assertion, ie something that should be impossible, and therefore >> useful in debug but discardable in release? >> >> >> >> I've often wondered this myself, I'm not aware of an 'official' >> interpretation of these. From context, it seems to usually be used to >> enforce a documented/logical constraint. I often use them as non-fatal >> asserts. >> >> >> >> I know the dashboards are configured to treat any output coming from >> vtkErrorMacro as a test failure. >> >> >> >> We've added assert(0) in the three branches, and our code never hits them >> and no VTK unit test does either. >> >> >> >> Not surprising -- the method does nothing (and tests will fail) if it >> hits them :) >> >> >> >> The 3 checks are individually fast, but the method is called so very very >> often that removing the 3 checks entirely gives us a full 20% runtime >> speedup of Render(), so I'm hoping it would be acceptable to wrap them in >> #ifndef NDEBUG, or otherwise remove them from release builds. >> >> >> >> +1 to the idea. I'd love to see this wrapped up in a vtkAssertMacro or >> similar, as well as some clarification on the semantics of >> Warning/ErrorMacro. I think there was some discussion started by Kyle Lutz >> a few years back about whether or not to just use asserts in these >> situations, and there was some controversy around the idea and he abandoned >> the proposal in the end. I can't remember or imagine why people objected at >> the moment, but the thread should be in the archives. >> >> >> >> I'd actually prefer to remove that (and similar) methods completely >> (settle down folks, I'm not actually proposing this! I've learned to just >> accept these warts and not try to fix problematic APIs in VTK). They have >> performance problems beyond the sanity checks, the repeated dispatch calls >> add up, too. It's too fine-grained an action for the expense it occurs. It >> used to be worse, actually -- back when I was profiling some of these >> functions the vast majority of CPU time was spent in strcmp, because >> SafeDownCast was being used to test if the source arrays was a data array. >> I believe it was actually this method that made me add the >> vtkAbstractArray::FastDownCast system. >> >> >> >> Dave >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From zack.galbreath at kitware.com Fri Apr 29 09:40:24 2016 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Fri, 29 Apr 2016 09:40:24 -0400 Subject: [vtk-developers] open.cdash.org upgrade In-Reply-To: References: Message-ID: I just performed another (small) upgrade of open.cdash.org. This should help index.php and viewTest.php load more quickly. As always, let us know if you encounter any unexpected behavior while using CDash. On Mon, Apr 4, 2016 at 6:49 PM, Zack Galbreath wrote: > This upgrade is complete. I verified that logins, various page loads, and > submissions are all working correctly, but please let me know if you > encounter any unexpected behavior. > > On Fri, Apr 1, 2016 at 3:14 PM, Zack Galbreath > wrote: > >> I plan to upgrade open.cdash.org this coming Monday, April 4th, at 5pm >> EDT. I expect the site to be unavailable for an hour or so while I perform >> this upgrade. During this time CDash will not accept any incoming >> submissions. >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From shawn.waldon at kitware.com Fri Apr 29 09:58:58 2016 From: shawn.waldon at kitware.com (Shawn Waldon) Date: Fri, 29 Apr 2016 09:58:58 -0400 Subject: [vtk-developers] open.cdash.org upgrade In-Reply-To: References: Message-ID: Hi Zach, Tomviz is getting errors when you try to download the binaries again: Forbidden You don't have permission to access /upload/6694f9e2b25316bf86b934d5149e846f73245e52/tomviz-0.7.2-122-g6c7ae98-Darwin-64bit.dmg on this server. >From this build: https://open.cdash.org/viewFiles.php?buildid=4335796 Shawn On Fri, Apr 29, 2016 at 9:40 AM, Zack Galbreath wrote: > I just performed another (small) upgrade of open.cdash.org. This should > help index.php and viewTest.php load more quickly. > > As always, let us know if you encounter any unexpected behavior while > using CDash. > > On Mon, Apr 4, 2016 at 6:49 PM, Zack Galbreath > wrote: > >> This upgrade is complete. I verified that logins, various page loads, >> and submissions are all working correctly, but please let me know if you >> encounter any unexpected behavior. >> >> On Fri, Apr 1, 2016 at 3:14 PM, Zack Galbreath < >> zack.galbreath at kitware.com> wrote: >> >>> I plan to upgrade open.cdash.org this coming Monday, April 4th, at 5pm >>> EDT. I expect the site to be unavailable for an hour or so while I perform >>> this upgrade. During this time CDash will not accept any incoming >>> submissions. >>> >> >> > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From zack.galbreath at kitware.com Fri Apr 29 10:04:20 2016 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Fri, 29 Apr 2016 10:04:20 -0400 Subject: [vtk-developers] open.cdash.org upgrade In-Reply-To: References: Message-ID: On Fri, Apr 29, 2016 at 9:58 AM, Shawn Waldon wrote: > Hi Zach, > > Tomviz is getting errors when you try to download the binaries again: > Thanks for letting me know. This is fixed now. -------------- next part -------------- An HTML attachment was scrubbed... URL: From mathieu.westphal at kitware.com Fri Apr 29 10:07:28 2016 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Fri, 29 Apr 2016 16:07:28 +0200 Subject: [vtk-developers] VTK/Paraview Courses in June Message-ID: Hello Kitware will be holding a 2-day Advanced VTK and Advanced ParaView course on June 22th and 23th 2016 in Lyon, France. Please visit our web site for more information and registration details at Advanced VTK (English) : http://training.kitware.fr/browse/126 Advanced VTK (French) : http://formations.kitware.fr/browse/126 Advanced ParaView (English) : http://training.kitware.fr/browse/127 Advanced ParaView (French) : http://formations.kitware.fr/browse/127 Note that the course will be taught in English. If you have any question, please contact us at formations at http://www.kitware.fr Thank you, Mathieu Westphal -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lonie at kitware.com Tue Apr 5 12:39:11 2016 From: david.lonie at kitware.com (David Lonie) Date: Tue, 05 Apr 2016 16:39:11 -0000 Subject: [vtk-developers] [vtkusers] Two errors when compiling VTK. In-Reply-To: References: Message-ID: Thanks for the feedback. I'm looking into this now. Dave On Tue, Apr 5, 2016 at 12:17 PM, Zhao Li wrote: > Thanks for your reply. > I'm sorry to say that it seems that it doesn't work. > As follow > > > > > ------------------------------ > From: david.lonie at kitware.com > Date: Tue, 5 Apr 2016 10:31:51 -0400 > Subject: Re: [vtkusers] Two errors when compiling VTK. > To: livc at outlook.com > CC: vtkusers at vtk.org > > > This is a bug that slipped past our automated testing for debugging builds > on certain MSVC compilers. > > Can you try adding: > > #include > > to the top of VTK/Common/Core/vtkGenericDataArray.txx and let me know if > compilation works? I'm waiting to hear confirmation that this fixes the > issue before pushing the patch to master. > > Dave > > On Tue, Apr 5, 2016 at 10:19 AM, Zhao Li wrote: > > I'm new to VTK. > When I compile VTK in VS2013, I got two errors. > > Error4error C2668: '_wassert' : ambiguous call to overloaded > functionf:\vtk\vtk-7.1-src\common\core\vtkGenericDataArray.txx281vtkFiltersCore > > Error46error LNK1104: cannot open file > '..\..\..\lib\Debug\vtkFiltersCore-7.1.lib'F:\VTK\VTK-7.1-bin\Examples\DataManipulation\Cxx\LINKCube > > Help me please, thanks. > > With: > WIN10 VS2013Pro VTK7.1 Qt5.5.1 CMake3.5.1 > > THX!!! > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the VTK FAQ at: > http://www.vtk.org/Wiki/VTK_FAQ > > Search the list archives at: http://markmail.org/search/?q=vtkusers > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/vtkusers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: pic.JPG Type: image/jpeg Size: 243799 bytes Desc: not available URL: