From nztoddler at yahoo.com Mon Jul 2 01:44:22 2018 From: nztoddler at yahoo.com (Todd Martin) Date: Mon, 2 Jul 2018 05:44:22 +0000 (UTC) Subject: [vtk-developers] Multiple inheritance References: <486556535.1248987.1530510262667.ref@mail.yahoo.com> Message-ID: <486556535.1248987.1530510262667@mail.yahoo.com> Single inheritance languages like Java and C# utilize interfaces extensively. Python 2.7+ handles the same concept with abstract base classes, ABCs. Is there any interest in supporting interfaces in VTK via multiple inheritance from abstract classes (which do not inherit from vtkObject) while retaining the single inheritance model? In my view there are good reasons to do so. For example vtkCell has methods like GetNumberOfEdges(),?GetEdge(), GetNumberOfFaces(), GetFace() etc. which really only apply to multi-dimensional cells (both linear and non-linear); i.e. not points and lines. These methods are forced on the base class design by a single inheritance structure and the linear/non-linear cell sub-types. In my view it would be better if they were distributed across the sub-classes via the concept of interfaces. So I'm suggesting a limited use of multiple inheritance here, not a free-for-all approach. What do others think about this? For an example please see this merge request Add missing size hints and bug fix point arrays for non-linear cells (!4372) ? Merge Requests ? VTK / VTK | | | | | | | | | | | Add missing size hints and bug fix point arrays for non-linear cells (!4... I've added size hints for concrete public methods GetParametricCoords(), GetEdgePoints() and GetFacePoints() in ... | | | Todd Martin, PhD. Freelance Engineer/Software Architect. -------------- next part -------------- An HTML attachment was scrubbed... URL: From nztoddler at yahoo.com Mon Jul 2 03:26:32 2018 From: nztoddler at yahoo.com (Todd) Date: Mon, 02 Jul 2018 19:26:32 +1200 Subject: [vtk-developers] Failed tests In-Reply-To: <819640388.3124173.1530070848130@mail.yahoo.com> Message-ID: An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Mon Jul 2 11:11:41 2018 From: ken.martin at kitware.com (Ken Martin) Date: Mon, 2 Jul 2018 11:11:41 -0400 Subject: [vtk-developers] Failed tests In-Reply-To: References: <819640388.3124173.1530070848130@mail.yahoo.com> Message-ID: I'm not right now. Very busy time of year. But I'm keeping it in my inbox in case I get some free time. On Mon, Jul 2, 2018 at 3:26 AM, Todd wrote: > Is anyone looking at this? > > On 27 Jun 2018 3:40 p.m., Todd Martin via vtk-developers < > vtk-developers at public.kitware.com> wrote: > > With respect to the TestSpherePoints/TestSphereVertex tests the problem > seems to be in vtkOpenGLPolyDataMapper::ReplaceShaderNormal() with the > substituted text for the shader. When the following is commented out the > points show as squares. Otherwise they are altogether absent. > > //if (this->DrawingSpheres(*this->LastBoundBO, actor)) > //{ > // vtkShaderProgram::Substitute(FSSource, > // "//VTK::Normal::Dec", > // "uniform float ZCalcS;\n" > // "uniform float ZCalcR;\n" > // ); > // vtkShaderProgram::Substitute(FSSource, > // "//VTK::Normal::Impl", > > // " float xpos = 2.0*gl_PointCoord.x - 1.0;\n" > // " float ypos = 1.0 - 2.0*gl_PointCoord.y;\n" > // " float len2 = xpos*xpos+ ypos*ypos;\n" > // " if (len2 > 1.0) { discard; }\n" > // " vec3 normalVCVSOutput = normalize(\n" > // " vec3(2.0*gl_PointCoord.x - 1.0, 1.0 - 2.0*gl_PointCoord.y, > sqrt(1.0 - len2)));\n" > > // " gl_FragDepth = gl_FragCoord.z + normalVCVSOutput.z*ZCalcS* > ZCalcR;\n" > // " if (cameraParallel == 0) {\n" > // " float ZCalcQ = (normalVCVSOutput.z*ZCalcR - 1.0);\n" > // " gl_FragDepth = (ZCalcS - gl_FragCoord.z) / ZCalcQ + ZCalcS; }\n" > // ); > > // shaders[vtkShader::Fragment]->SetSource(FSSource); > // return; > //} > > > Todd Martin, PhD. > *Freelance Engineer/Software Architect.* > > > > On Wednesday, June 27, 2018, 11:58:35 AM GMT+12, Todd Martin via > vtk-developers wrote: > > > Here's what's happening with depth peeling, where the data path on my > machine is > D:\3RD_PARTY\Build-VTK8-1_64\ExternalData\Testing\Data > [image: Inline image] > > > > Todd Martin, PhD. > *Freelance Engineer/Software Architect.* > > > > On Wednesday, June 27, 2018, 11:38:00 AM GMT+12, Todd Martin < > nztoddler at yahoo.com> wrote: > > > > > On Wednesday, June 27, 2018, 1:02:24 AM GMT+12, Ken Martin < > ken.martin at kitware.com> wrote: > > > What graphics card model do you have? > > Actually its an integrated GPU. Not Radeon at all. > > Card name: Intel(R) HD Graphics 4600 > Manufacturer: Intel Corporation > Chip type: Intel(R) HD Graphics Family > DAC type: Internal > Device Type: Full Device (POST) > Device Key: Enum\PCI\VEN_8086&DEV_0416&SUBSYS_1940103C&REV_06 > Device Status: 0180200A [DN_DRIVER_LOADED|DN_STARTED| > DN_DISABLEABLE|DN_NT_ENUMERATOR|DN_NT_DRIVER] > Device Problem Code: No Problem > Driver Problem Code: Unknown > Display Memory: 2160 MB > Dedicated Memory: 112 MB > Shared Memory: 2048 MB > Current Mode: 1920 x 1080 (32 bit) (60Hz) > HDR Support: Not Supported > Display Topology: External > Display Color Space: DXGI_COLOR_SPACE_RGB_FULL_G22_NONE_P709 > Color Primaries: Red(0.648938,0.339367), Green(0.282727,0.603039), > Blue(0.143078,0.070813), White Point(0.313000,0.329602) > Display Luminance: Min Luminance = 0.500000, Max Luminance = > 270.000000, MaxFullFrameLuminance = 270.000000 > Monitor Name: AOC 2236 > Monitor Model: 2236 > Monitor Id: AOC2236 > Native Mode: 1920 x 1080(p) (60.000Hz) > Output Type: HD15 > Monitor Capabilities: HDR Not Supported > Display Pixel Format: DISPLAYCONFIG_PIXELFORMAT_32BPP > Advanced Color: Not Supported > Driver Name: igdumdim64.dll,igd10iumd64.dll,igd10iumd64.dll, > igd12umd64.dll > Driver File Version: 20.19.0015.4835 (English) > Driver Version: 20.19.15.4835 > DDI Version: 12 > Feature Levels: 11_1,11_0,10_1,10_0,9_3,9_2,9_1 > Driver Model: WDDM 2.0 > Graphics Preemption: Primitive > Compute Preemption: Thread group > Miracast: Supported > Hybrid Graphics GPU: Integrated > Power P-states: Not Supported > Virtualization: Not Supported > Block List: No Blocks > Catalog Attributes: Universal:N/A Declarative:N/A > Driver Attributes: Final Retail > Driver Date/Size: 16/10/2017 12:00:00 PM, 39861272 bytes > WHQL Logo'd: Yes > WHQL Date Stamp: Unknown > Device Identifier: {D7B78E66-4756-11CF-6F61-4F39BAC2D935} > Vendor ID: 0x8086 > Device ID: 0x0416 > SubSys ID: 0x1940103C > Revision ID: 0x0006 > Driver Strong Name: oem40.inf:5f63e534dd929195: > iHSWM_w10:20.19.15.4835:pci\ven_8086&dev_0416&subsys_1940103c > Rank Of Driver: 00D10001 > Video Accel: ModeMPEG2_A ModeMPEG2_C ModeWMV9_C ModeVC1_C > DXVA2 Modes: DXVA2_ModeMPEG2_VLD DXVA2_ModeMPEG2_IDCT > DXVA2_ModeVC1_D2010 DXVA2_ModeWMV9_IDCT DXVA2_ModeVC1_IDCT > DXVA2_ModeH264_VLD_NoFGT DXVA2_ModeH264_VLD_Stereo_Progressive_NoFGT > DXVA2_ModeH264_VLD_Stereo_NoFGT DXVA2_ModeH264_VLD_Multiview_NoFGT > DXVA2_ModeHEVC_VLD_Main > D3D9 Overlay: Supported > DXVA-HD: Supported > DDraw Status: Enabled > D3D Status: Enabled > AGP Status: Enabled > MPO MaxPlanes: 1 > MPO Caps: Not Supported > MPO Stretch: Not Supported > MPO Media Hints: Not Supported > MPO Formats: Not Supported > PanelFitter Caps: Not Supported > PanelFitter Stretch: Not Supported > > One thing you might try is commenting out this line in > vtkOpenGL2ContextDevice2D.cxx, it is around line 1169 > > // We can actually use point sprites here > comment this -> // if (this->RenderWindow->IsPointSpriteBugPresent()) > { > > Well that fixed the chart tests. Now there's just vtkRenderingOpenGL2Cxx > (spheres and verticies) and vtkRenderingVolumneOpenGL2Cxx (depth peeling). > I will investigate further. > > On Mon, Jun 25, 2018 at 7:14 PM Todd Martin wrote: > > I updated the graphics card drivers but it made no difference. > > What I did find is that if I explicitly set the plot points marker style > to either VTK_MARKER_CROSS or VTK_MARKER_SQUARE in the TestLinePlot2 test > it works; although it always draws squares. > > VTK_MARKER_PLUS, VTK_MARKER_CIRCLE and VTK_MARKER_DIAMOND produce nothing. > The default style is VTK_MARKER_CIRCLE > > > > Todd Martin, PhD. > *Freelance Engineer/Software Architect.* > > > > On Tuesday, June 26, 2018, 6:23:34 AM GMT+12, Ken Martin < > ken.martin at kitware.com> wrote: > > > In case no one has suggested this yet, have you made sure you have the > latest driver? That seems to often solve these types of issues. > > > > On Wed, Jun 20, 2018 at 9:45 PM Todd Martin via vtk-developers < > vtk-developers at public.kitware.com> wrote: > > Hi. > > I recently built and ran the VTK tests with VS2017 on a 64bit Windows 10 > laptop with a Radeon graphics card. > > 1>The following tests FAILED: > 1> 51 - vtkChartsCoreCxx-TestBagPlot (Failed) > 1> 59 - vtkChartsCoreCxx-TestChartBadPoints (Failed) > 1> 60 - vtkChartsCoreCxx-TestChartDouble (Failed) > 1> 61 - vtkChartsCoreCxx-TestChartDoubleColors (Failed) > 1> 62 - vtkChartsCoreCxx-TestChartMatrix (Failed) > 1> 65 - vtkChartsCoreCxx-TestChartsOn3D (Failed) > 1> 68 - vtkChartsCoreCxx-TestContext (Failed) > 1> 81 - vtkChartsCoreCxx-TestLegendHiddenPlots (Failed) > 1> 87 - vtkChartsCoreCxx-TestLinePlot2 (Failed) > 1> 88 - vtkChartsCoreCxx-TestLinePlotInteraction (Failed) > 1> 97 - vtkChartsCoreCxx-TestPlotMatrix (Failed) > 1> 100 - vtkChartsCoreCxx-TestScatterPlot (Failed) > 1> 102 - vtkChartsCoreCxx-TestScatterPlotMatrixVehicles (Failed) > 1> 103 - vtkChartsCoreCxx-TestScatterPlotMatrixVisible (Failed) > 1> 104 - vtkChartsCoreCxx-TestScientificPlot (Failed) > 1> 1186 - vtkRenderingOpenGL2Cxx-TestSpherePoints (Failed) > 1> 1187 - vtkRenderingOpenGL2Cxx-TestSphereVertex (Failed) > 1> 1220 - vtkRenderingVolumeCxx-TestGPURayCastDepthPeeling (Failed) > 1> 1221 - vtkRenderingVolumeCxx-TestGPURayCastDepthPeelingBlendModes > (Failed) > 1> 1222 - vtkRenderingVolumeCxx-TestGPURayCastDepthPeelingClip (Failed) > 1> 1223 - vtkRenderingVolumeCxx-TestGPURayCastDepthPeelingOpaque > (Failed) > 1> 1224 - vtkRenderingVolumeCxx-TestGPURayCastDepthPeelingTransVol > (Failed) > > With respect to vtkChartsCoreCxx and vtkRenderingOpenGL2Cxx the failures > all exhibit the same feature - no points/verticies. I have attached images > to illustrate the problem. I don't know if it is relevant, but I noticed an > inability to display points in SalomE (which uses VTK for displaying > meshes) many years ago after switching from a desktop machine with a Nvidia > graphics card to a laptop with a Radeon graphics card. I always assumed the > bug was in SalomE, but it might be this failure in VTK itself. > > > Todd Martin, PhD. > Freelance Engineer/Software Architect. > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > > > -- > Ken Martin PhD > Distinguished Engineer > Kitware Inc. > 101 East Weaver Street > > Carrboro, North Carolina > > 27510 USA > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > > > > -- > Ken Martin PhD > Distinguished Engineer > Kitware Inc. > 101 East Weaver Street > > Carrboro, North Carolina > > 27510 USA > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > > -- Ken Martin PhD Distinguished Engineer Kitware Inc. 101 East Weaver Street Carrboro, North Carolina 27510 USA This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From pdhahn at compintensehpc.com Mon Jul 2 17:07:18 2018 From: pdhahn at compintensehpc.com (Paul Douglas Hahn) Date: Mon, 2 Jul 2018 16:07:18 -0500 Subject: [vtk-developers] Multiple inheritance In-Reply-To: References: <486556535.1248987.1530510262667.ref@mail.yahoo.com> <486556535.1248987.1530510262667@mail.yahoo.com> Message-ID: revise "base classes" -> "interface classes" On 07/02/2018 04:04 PM, Paul Douglas Hahn wrote: > Just one caveat (you probably already know and agree with this). In my > experience using C++ multiple inheritance, I think you should try to > avoid situations where you have common base classes in the inheritance > pathways. Virtual base classes are the usual recommendation to resolve > certain problems that arise in such cases, but IMHO having experience > with that, I generally recommend against it. > > So I recommend your base classes should be of the "_mix-in_" interface > category, not relaying on any common base class. The approach works > fine for me in almost every situation. > > - Paul > > On 07/02/2018 12:44 AM, Todd Martin via vtk-developers wrote: >> Single inheritance languages like Java and C# utilize /interfaces/ >> extensively. Python 2.7+ handles the same concept with abstract base >> classes, ABCs. >> >> Is there any interest in supporting/interfaces/ in VTK via multiple >> inheritance from abstract classes (which do not inherit from >> vtkObject) while retaining the single inheritance model? >> >> In my view there are good reasons to do so. For example vtkCell has >> methods like GetNumberOfEdges(), GetEdge(), GetNumberOfFaces(), >> GetFace() etc. which really only apply to multi-dimensional cells >> (both linear and non-linear); i.e. not points and lines. These >> methods are forced on the base class design by a single inheritance >> structure and the linear/non-linear cell sub-types. In my view it >> would be better if they were distributed across the sub-classes via >> the concept of interfaces. So I'm suggesting a limited use of >> multiple inheritance here, not a free-for-all approach. What do >> others think about this? >> >> For an example please see this merge request Add missing size hints >> and bug fix point arrays for non-linear cells (!4372) ? Merge >> Requests ? VTK / VTK >> >> >> >> >> >> >> >> >> >> Add missing size hints and bug fix point arrays for non-linear >> cells (!4... >> >> I've added size hints for concrete public methods >> GetParametricCoords(), GetEdgePoints() and GetFacePoints() in ... >> >> >> >> >> >> Todd Martin, PhD. >> /Freelance Engineer/Software Architect./ >> >> >> >> _______________________________________________ >> Powered bywww.kitware.com >> >> Visit other Kitware open-source projects athttp://www.kitware.com/opensource/opensource.html >> >> Search the list archives at:http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://public.kitware.com/mailman/listinfo/vtk-developers >> > > > -- > Paul D. Hahn > CompIntense HPC, LLC -- Paul D. Hahn CompIntense HPC, LLC -------------- next part -------------- An HTML attachment was scrubbed... URL: From pdhahn at compintensehpc.com Mon Jul 2 17:04:59 2018 From: pdhahn at compintensehpc.com (Paul Douglas Hahn) Date: Mon, 2 Jul 2018 16:04:59 -0500 Subject: [vtk-developers] Multiple inheritance In-Reply-To: <486556535.1248987.1530510262667@mail.yahoo.com> References: <486556535.1248987.1530510262667.ref@mail.yahoo.com> <486556535.1248987.1530510262667@mail.yahoo.com> Message-ID: Just one caveat (you probably already know and agree with this). In my experience using C++ multiple inheritance, I think you should try to avoid situations where you have common base classes in the inheritance pathways. Virtual base classes are the usual recommendation to resolve certain problems that arise in such cases, but IMHO having experience with that, I generally recommend against it. So I recommend your base classes should be of the "_mix-in_" interface category, not relaying on any common base class. The approach works fine for me in almost every situation. - Paul On 07/02/2018 12:44 AM, Todd Martin via vtk-developers wrote: > Single inheritance languages like Java and C# utilize /interfaces/ > extensively. Python 2.7+ handles the same concept with abstract base > classes, ABCs. > > Is there any interest in supporting/interfaces/ in VTK via multiple > inheritance from abstract classes (which do not inherit from > vtkObject) while retaining the single inheritance model? > > In my view there are good reasons to do so. For example vtkCell has > methods like GetNumberOfEdges(), GetEdge(), GetNumberOfFaces(), > GetFace() etc. which really only apply to multi-dimensional cells > (both linear and non-linear); i.e. not points and lines. These methods > are forced on the base class design by a single inheritance structure > and the linear/non-linear cell sub-types. In my view it would be > better if they were distributed across the sub-classes via the concept > of interfaces. So I'm suggesting a limited use of multiple inheritance > here, not a free-for-all approach. What do others think about this? > > For an example please see this merge request Add missing size hints > and bug fix point arrays for non-linear cells (!4372) ? Merge Requests > ? VTK / VTK > > > > > > > > > Add missing size hints and bug fix point arrays for non-linear > cells (!4... > > I've added size hints for concrete public methods > GetParametricCoords(), GetEdgePoints() and GetFacePoints() in ... > > > > > > Todd Martin, PhD. > /Freelance Engineer/Software Architect./ > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > -- Paul D. Hahn CompIntense HPC, LLC -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Mon Jul 2 18:44:09 2018 From: ken.martin at kitware.com (Ken Martin) Date: Mon, 2 Jul 2018 18:44:09 -0400 Subject: [vtk-developers] eeloo Message-ID: Did someone update eeloo or change it's configuration somehow, resulting in lots of buildbot warnings? If so are you working on fixing them? It's been a bit yellow for a few days now. Thanks! Ken -- Ken Martin PhD Distinguished Engineer Kitware Inc. 101 East Weaver Street Carrboro, North Carolina 27510 USA This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From nztoddler at yahoo.com Mon Jul 2 19:31:55 2018 From: nztoddler at yahoo.com (Todd) Date: Tue, 03 Jul 2018 11:31:55 +1200 Subject: [vtk-developers] Multiple inheritance In-Reply-To: Message-ID: An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Mon Jul 2 23:06:55 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 2 Jul 2018 20:06:55 -0700 Subject: [vtk-developers] Multiple inheritance In-Reply-To: References: Message-ID: You may want to look at generic programming to solve your problem. http://www.cs.rpi.edu/~musser/gp/GPtutorial/GPtutorial-print.pdf On Mon, Jul 2, 2018 at 4:31 PM, Todd via vtk-developers < vtk-developers at public.kitware.com> wrote: > > > On 3 Jul 2018 9:07 a.m., Paul Douglas Hahn > wrote: > > revise "base classes" -> "interface classes" > > On 07/02/2018 04:04 PM, Paul Douglas Hahn wrote: > > Just one caveat (you probably already know and agree with this). In my > experience using C++ multiple inheritance, I think you should try to avoid > situations where you have common base classes in the inheritance pathways. > Virtual base classes are the usual recommendation to resolve certain > problems that arise in such cases, but IMHO having experience with that, I > generally recommend against it. > > So I recommend your base classes should be of the "*mix-in*" interface > category, not relaying on any common base class. The approach works fine > for me in almost every situation. > > > Thanks Paul. That sounds exactly like what I have done with the > vtkCellWithEdges and vtkCellWithFaces classes introduced in the > aforementioned merge request. > > > - Paul > > On 07/02/2018 12:44 AM, Todd Martin via vtk-developers wrote: > > Single inheritance languages like Java and C# utilize *interfaces* > extensively. Python 2.7+ handles the same concept with abstract base > classes, ABCs. > > Is there any interest in supporting* interfaces* in VTK via multiple > inheritance from abstract classes (which do not inherit from vtkObject) > while retaining the single inheritance model? > > In my view there are good reasons to do so. For example vtkCell has > methods like GetNumberOfEdges(), GetEdge(), GetNumberOfFaces(), GetFace() > etc. which really only apply to multi-dimensional cells (both linear and > non-linear); i.e. not points and lines. These methods are forced on the > base class design by a single inheritance structure and the > linear/non-linear cell sub-types. In my view it would be better if they > were distributed across the sub-classes via the concept of interfaces. So > I'm suggesting a limited use of multiple inheritance here, not a > free-for-all approach. What do others think about this? > > For an example please see this merge request Add missing size hints and > bug fix point arrays for non-linear cells (!4372) ? Merge Requests ? VTK / > VTK > > > > > Add missing size hints and bug fix point arrays for non-linear cells (!4... > > I've added size hints for concrete public methods GetParametricCoords(), > GetEdgePoints() and GetFacePoints() in ... > > > > > Todd Martin, PhD. > *Freelance Engineer/Software Architect.* > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe:https://public.kitware.com/mailman/listinfo/vtk-developers > > > > -- > Paul D. Hahn > CompIntense HPC, LLC > > > > -- > Paul D. Hahn > CompIntense HPC, LLC > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > > -- Unpaid intern in BillsParadise at noware dot com -------------- next part -------------- An HTML attachment was scrubbed... URL: From shawn.waldon at kitware.com Tue Jul 3 09:34:03 2018 From: shawn.waldon at kitware.com (Shawn Waldon) Date: Tue, 3 Jul 2018 09:34:03 -0400 Subject: [vtk-developers] eeloo In-Reply-To: References: Message-ID: eeloo was updated from fedora 26 to 28 since 26 end of life was at the beginning of June. And I was on vacation for the end of last week, so no I haven't looked at fixing them yet. I'll look at them this morning. Shawn On Mon, Jul 2, 2018 at 6:44 PM, Ken Martin wrote: > > Did someone update eeloo or change it's configuration somehow, resulting > in lots of buildbot warnings? If so are you working on fixing them? It's > been a bit yellow for a few days now. > > Thanks! > Ken > > > > -- > Ken Martin PhD > Distinguished Engineer > Kitware Inc. > 101 East Weaver Street > Carrboro, North Carolina > 27510 USA > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From shawn.waldon at kitware.com Tue Jul 3 11:22:36 2018 From: shawn.waldon at kitware.com (Shawn Waldon) Date: Tue, 3 Jul 2018 11:22:36 -0400 Subject: [vtk-developers] eeloo In-Reply-To: References: Message-ID: Hi, So after looking at these a bit, I think we are running into the same or very similar false positives as gdb did here: [1] All the errors I have looked through so far have been false positives. Do we prefer fixing these (changing our code just to work around the warnings) or just disabling those warnings on eeloo? Shawn [1]: http://sourceware-org.1504.n7.nabble.com/Fail-to-compile-GDB-with-recent-GCC-trunk-Werror-stringop-overflow-Werror-stringop-truncation-td483779.html On Tue, Jul 3, 2018 at 9:34 AM, Shawn Waldon wrote: > eeloo was updated from fedora 26 to 28 since 26 end of life was at the > beginning of June. And I was on vacation for the end of last week, so no I > haven't looked at fixing them yet. I'll look at them this morning. > > Shawn > > On Mon, Jul 2, 2018 at 6:44 PM, Ken Martin wrote: > >> >> Did someone update eeloo or change it's configuration somehow, resulting >> in lots of buildbot warnings? If so are you working on fixing them? It's >> been a bit yellow for a few days now. >> >> Thanks! >> Ken >> >> >> >> -- >> Ken Martin PhD >> Distinguished Engineer >> Kitware Inc. >> 101 East Weaver Street >> Carrboro, North Carolina >> 27510 USA >> >> This communication, including all attachments, contains confidential and >> legally privileged information, and it is intended only for the use of the >> addressee. Access to this email by anyone else is unauthorized. If you are >> not the intended recipient, any disclosure, copying, distribution or any >> action taken in reliance on it is prohibited and may be unlawful. If you >> received this communication in error please notify us immediately and >> destroy the original message. Thank you. >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://public.kitware.com/mailman/listinfo/vtk-developers >> >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Tue Jul 3 12:48:23 2018 From: ken.martin at kitware.com (Ken Martin) Date: Tue, 3 Jul 2018 12:48:23 -0400 Subject: [vtk-developers] eeloo In-Reply-To: References: Message-ID: I think that is a crazy warning gcc is producing and we should disable it. Way too many false positives with their approach. Can you change the compile flags on eeloo to remove that warning? On Tue, Jul 3, 2018 at 11:22 AM, Shawn Waldon wrote: > Hi, > > So after looking at these a bit, I think we are running into the same or > very similar false positives as gdb did here: [1] All the errors I have > looked through so far have been false positives. Do we prefer fixing these > (changing our code just to work around the warnings) or just disabling > those warnings on eeloo? > > Shawn > > [1]: http://sourceware-org.1504.n7.nabble.com/Fail-to-compile- > GDB-with-recent-GCC-trunk-Werror-stringop-overflow- > Werror-stringop-truncation-td483779.html > > On Tue, Jul 3, 2018 at 9:34 AM, Shawn Waldon > wrote: > >> eeloo was updated from fedora 26 to 28 since 26 end of life was at the >> beginning of June. And I was on vacation for the end of last week, so no I >> haven't looked at fixing them yet. I'll look at them this morning. >> >> Shawn >> >> On Mon, Jul 2, 2018 at 6:44 PM, Ken Martin >> wrote: >> >>> >>> Did someone update eeloo or change it's configuration somehow, resulting >>> in lots of buildbot warnings? If so are you working on fixing them? It's >>> been a bit yellow for a few days now. >>> >>> Thanks! >>> Ken >>> >>> >>> >>> -- >>> Ken Martin PhD >>> Distinguished Engineer >>> Kitware Inc. >>> 101 East Weaver Street >>> >>> Carrboro, North Carolina >>> >>> 27510 USA >>> >>> This communication, including all attachments, contains confidential and >>> legally privileged information, and it is intended only for the use of the >>> addressee. Access to this email by anyone else is unauthorized. If you are >>> not the intended recipient, any disclosure, copying, distribution or any >>> action taken in reliance on it is prohibited and may be unlawful. If you >>> received this communication in error please notify us immediately and >>> destroy the original message. Thank you. >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q= >>> vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >>> >> > -- Ken Martin PhD Distinguished Engineer Kitware Inc. 101 East Weaver Street Carrboro, North Carolina 27510 USA This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From nztoddler at yahoo.com Tue Jul 3 23:06:07 2018 From: nztoddler at yahoo.com (Todd Martin) Date: Wed, 4 Jul 2018 03:06:07 +0000 (UTC) Subject: [vtk-developers] Multiple inheritance In-Reply-To: References: Message-ID: <2025427128.2188974.1530673567874@mail.yahoo.com> Hi Bill I'm familiar with generics, but it doesn't address the issue here. Defining a base class with knowledge of the behaviour or attributes of its descendant classes is a violation of the Polymorphism principle. Todd Martin, PhD. Freelance Engineer/Software Architect. On Tuesday, July 3, 2018, 3:06:56 PM GMT+12, Bill Lorensen wrote: You may want to look at generic programming to solve your problem.http://www.cs.rpi.edu/~musser/gp/GPtutorial/GPtutorial-print.pdf On Mon, Jul 2, 2018 at 4:31 PM, Todd via vtk-developers wrote: On 3 Jul 2018 9:07 a.m., Paul Douglas Hahn wrote: revise "base classes" -> "interface classes" On 07/02/2018 04:04 PM, Paul Douglas Hahn wrote: Just one caveat (you probably already know and agree with this). In my experience using C++ multiple inheritance, I think you should try to avoid situations where you have common base classes in the inheritance pathways. Virtual base classes are the usual recommendation to resolve certain problems that arise in such cases, but IMHO having experience with that, I generally recommend against it. So I recommend your base classes should be of the "mix-in" interface category, not relaying on any common base class. The approach works fine for me in almost every situation. Thanks Paul. That sounds exactly like what I have done with the vtkCellWithEdges and vtkCellWithFaces classes introduced in the aforementioned merge request. - Paul On 07/02/2018 12:44 AM, Todd Martin via vtk-developers wrote: Single inheritance languages like Java and C# utilize interfaces extensively. Python 2.7+ handles the same concept with abstract base classes, ABCs. Is there any interest in supporting interfaces in VTK via multiple inheritance from abstract classes (which do not inherit from vtkObject) while retaining the single inheritance model? In my view there are good reasons to do so. For example vtkCell has methods like GetNumberOfEdges(),?GetEdge(), GetNumberOfFaces(), GetFace() etc. which really only apply to multi-dimensional cells (both linear and non-linear); i.e. not points and lines. These methods are forced on the base class design by a single inheritance structure and the linear/non-linear cell sub-types. In my view it would be better if they were distributed across the sub-classes via the concept of interfaces. So I'm suggesting a limited use of multiple inheritance here, not a free-for-all approach. What do others think about this? For an example please see this merge request Add missing size hints and bug fix point arrays for non-linear cells (!4372) ? Merge Requests ? VTK / VTK | | | | | | | | | | | Add missing size hints and bug fix point arrays for non-linear cells (!4... I've added size hints for concrete public methods GetParametricCoords(), GetEdgePoints() and GetFacePoints() in ... | | | Todd Martin, PhD. Freelance Engineer/Software Architect. ______________________________ _________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/ opensource/opensource.html Search the list archives at: http://markmail.org/search/?q= vtk-developers Follow this link to subscribe/unsubscribe: https://public.kitware.com/ mailman/listinfo/vtk- developers -- Paul D. Hahn CompIntense HPC, LLC -- Paul D. Hahn CompIntense HPC, LLC ______________________________ _________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/ opensource/opensource.html Search the list archives at: http://markmail.org/search/?q= vtk-developers Follow this link to subscribe/unsubscribe: https://public.kitware.com/ mailman/listinfo/vtk- developers -- Unpaid intern in BillsParadise at noware dot com -------------- next part -------------- An HTML attachment was scrubbed... URL: From will.schroeder at kitware.com Thu Jul 5 06:37:22 2018 From: will.schroeder at kitware.com (Will Schroeder) Date: Thu, 5 Jul 2018 06:37:22 -0400 Subject: [vtk-developers] Multiple inheritance In-Reply-To: <2025427128.2188974.1530673567874@mail.yahoo.com> References: <2025427128.2188974.1530673567874@mail.yahoo.com> Message-ID: I think what you proposes has a lot of merit. However I start getting twitchy when I think what this means in terms of wrapping code, potential API changes, documentation changes, etc. although maybe it has little impact. (FYI we actually did try multiple inheritance in the 1993-94 time frame when we first started implementing in C++ - a very bad experience due to the awful compilers at that time.) I think for something like this to move forward a proof of concept is required to better understand what the impact on VTK would be. On Tue, Jul 3, 2018 at 11:08 PM Todd Martin via vtk-developers < vtk-developers at public.kitware.com> wrote: > Hi Bill > > I'm familiar with generics, but it doesn't address the issue here. > Defining a base class with knowledge of the behaviour or attributes of its > descendant classes is a violation of the Polymorphism principle. > > Todd Martin, PhD. > *Freelance Engineer/Software Architect.* > > > > On Tuesday, July 3, 2018, 3:06:56 PM GMT+12, Bill Lorensen < > bill.lorensen at gmail.com> wrote: > > > You may want to look at generic programming to solve your problem. > http://www.cs.rpi.edu/~musser/gp/GPtutorial/GPtutorial-print.pdf > > On Mon, Jul 2, 2018 at 4:31 PM, Todd via vtk-developers < > vtk-developers at public.kitware.com> wrote: > > > > On 3 Jul 2018 9:07 a.m., Paul Douglas Hahn > wrote: > > revise "base classes" -> "interface classes" > > On 07/02/2018 04:04 PM, Paul Douglas Hahn wrote: > > Just one caveat (you probably already know and agree with this). In my > experience using C++ multiple inheritance, I think you should try to avoid > situations where you have common base classes in the inheritance pathways. > Virtual base classes are the usual recommendation to resolve certain > problems that arise in such cases, but IMHO having experience with that, I > generally recommend against it. > > So I recommend your base classes should be of the "*mix-in*" interface > category, not relaying on any common base class. The approach works fine > for me in almost every situation. > > > Thanks Paul. That sounds exactly like what I have done with the > vtkCellWithEdges and vtkCellWithFaces classes introduced in the > aforementioned merge request. > > > - Paul > > On 07/02/2018 12:44 AM, Todd Martin via vtk-developers wrote: > > Single inheritance languages like Java and C# utilize *interfaces* > extensively. Python 2.7+ handles the same concept with abstract base > classes, ABCs. > > Is there any interest in supporting* interfaces* in VTK via multiple > inheritance from abstract classes (which do not inherit from vtkObject) > while retaining the single inheritance model? > > In my view there are good reasons to do so. For example vtkCell has > methods like GetNumberOfEdges(), GetEdge(), GetNumberOfFaces(), GetFace() > etc. which really only apply to multi-dimensional cells (both linear and > non-linear); i.e. not points and lines. These methods are forced on the > base class design by a single inheritance structure and the > linear/non-linear cell sub-types. In my view it would be better if they > were distributed across the sub-classes via the concept of interfaces. So > I'm suggesting a limited use of multiple inheritance here, not a > free-for-all approach. What do others think about this? > > For an example please see this merge request Add missing size hints and > bug fix point arrays for non-linear cells (!4372) ? Merge Requests ? VTK / > VTK > > > > > Add missing size hints and bug fix point arrays for non-linear cells (!4... > > I've added size hints for concrete public methods GetParametricCoords(), > GetEdgePoints() and GetFacePoints() in ... > > > > > Todd Martin, PhD. > *Freelance Engineer/Software Architect.* > > > > ______________________________ _________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q= vtk-developers > > Follow this link to subscribe/unsubscribe:https://public.kitware.com/ mailman/listinfo/vtk- developers > > > > -- > Paul D. Hahn > CompIntense HPC, LLC > > > > -- > Paul D. Hahn > CompIntense HPC, LLC > > > > ______________________________ _________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > > Search the list archives at: http://markmail.org/search/?q= vtk-developers > > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/ mailman/listinfo/vtk- developers > > > > > > > -- > Unpaid intern in BillsParadise at noware dot com > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > -- William J. Schroeder, PhD Kitware, Inc. - Building the World's Technical Computing Software 28 Corporate Drive Clifton Park, NY 12065 will.schroeder at kitware.com http://www.kitware.com (518) 881-4902 -------------- next part -------------- An HTML attachment was scrubbed... URL: From nztoddler at yahoo.com Thu Jul 5 07:25:49 2018 From: nztoddler at yahoo.com (Todd) Date: Thu, 05 Jul 2018 23:25:49 +1200 Subject: [vtk-developers] Multiple inheritance In-Reply-To: Message-ID: An HTML attachment was scrubbed... URL: From dan.lipsa at kitware.com Thu Jul 5 07:46:27 2018 From: dan.lipsa at kitware.com (Dan Lipsa) Date: Thu, 5 Jul 2018 07:46:27 -0400 Subject: [vtk-developers] Eeloo has been updated In-Reply-To: References: Message-ID: Thanks Shaun, The new pdal seems to works fine. All pdal tests pass. Dan On Mon, Jun 25, 2018 at 10:35 AM Shawn Waldon wrote: > Hi all, > > The VTK buildbot dashboard 'eeloo' was updated from Fedora 26 to 28 last > Friday. This caused issues with the version of pdal we had built to test > that reader, so I have updated the PDAL to version 1.7.2 (latest). > > Dan & Aashish, > > If this is a problem let me know. The old pdal didn't work with the new > system jsoncpp, so I had to update it. VTK does build against the new > version... The old version of pdal was 1.6. > > Shawn > -------------- next part -------------- An HTML attachment was scrubbed... URL: From pbergeron at spiria.com Thu Jul 5 08:15:06 2018 From: pbergeron at spiria.com (Patrick Bergeron) Date: Thu, 5 Jul 2018 12:15:06 +0000 Subject: [vtk-developers] Merge request process ? Message-ID: <1DA42CDB-5B68-4BD8-B6EB-1619C158D218@spiria.com> I am wondering how was he merge request process works. There are about 140 mrs today. How do they get approved or declined? Do they stay in the queue forever? When do submitters get feedback about the mrs? Thanks Patrick Bergeron Sent from my iPhone From mathieu.westphal at kitware.com Thu Jul 5 08:26:35 2018 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Thu, 5 Jul 2018 14:26:35 +0200 Subject: [vtk-developers] Merge request process ? In-Reply-To: <1DA42CDB-5B68-4BD8-B6EB-1619C158D218@spiria.com> References: <1DA42CDB-5B68-4BD8-B6EB-1619C158D218@spiria.com> Message-ID: Hello Patrick, First a big thank you ! It is always great to have external contribution and I agree to say that our process shoudl be explained more clearly. If you think your Merge Request is ready to be tested and merged, please tag a VTK developpers on it so we can review it. Please read the VTK coding standard to be sure that your code is following it. https://docs.google.com/document/d/1nzinw-dR5JQRNi_gb8qwLL5PnkGMK2FETlQGLr10tZw/edit The easiest to know how to tag could be by using git blame on the file you are modifying. In any case you can always tag : @ken\-martin @berkgeveci @mwestphal @jpouderoux @allisonvacanti @demarle @dgobbi @cory.quammen @acbauer Just to name a few. You can also send an email on this mailing list asking for reviews and tests, while describing a little bit so people quickly reading their mail can know if they are interested or not. Once you have a total of "+2" on your MR, and tests passes, you can ask for a merge, and we will take care of it. Best regards, For those how want to take a look, here are Patrick's contributions https://gitlab.kitware.com/vtk/vtk/merge_requests/4451 https://gitlab.kitware.com/vtk/vtk/merge_requests/4452 https://gitlab.kitware.com/vtk/vtk/merge_requests/4461 https://gitlab.kitware.com/vtk/vtk/merge_requests/4462 https://gitlab.kitware.com/vtk/vtk/merge_requests/4463 Mathieu Westphal On Thu, Jul 5, 2018 at 2:15 PM, Patrick Bergeron wrote: > I am wondering how was he merge request process works. There are about 140 > mrs today. > > How do they get approved or declined? Do they stay in the queue forever? > When do submitters get feedback about the mrs? > > Thanks > Patrick Bergeron > > Sent from my iPhone > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From haocheng.liu at kitware.com Thu Jul 5 09:47:40 2018 From: haocheng.liu at kitware.com (Haocheng Liu) Date: Thu, 5 Jul 2018 09:47:40 -0400 Subject: [vtk-developers] Dejagore Message-ID: Hi, Dashboard machine Dejagore is broken due to a mysterious vtk-m related error. If no one is looking at this issue, I would tackle it. -- Best regards Haocheng Haocheng LIU Kitware, Inc. R&D Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4421 -------------- next part -------------- An HTML attachment was scrubbed... URL: From dan.lipsa at kitware.com Thu Jul 5 12:40:36 2018 From: dan.lipsa at kitware.com (Dan Lipsa) Date: Thu, 5 Jul 2018 12:40:36 -0400 Subject: [vtk-developers] Add pugixml to VTK In-Reply-To: References: <87FC3B44-C211-4882-A35E-ACCB8890A532@kitware.com> <3E8B5C57-7401-4F3F-88AE-343A3499C363@kitware.com> Message-ID: > > > I'm agnostic :) > > An idea would be to maybe try to eliminate expat at some point afterwards, > to bring it down to just two libs again? I don't think the speed advantage > of expat over libxml2 could really matter that much? (libxml2 has both a > SAX-like and a pull-style reader API). > Sounds good. I think the problem is finding the time to do it. libxml2 can then be the power horse for those who want 100% conformance and > possibility of validation, while pugi for those who need speedy DOM. > This was my thought about this as well. > I wonder what are the speed-requiring use cases for DOM parsing though? > Are you parsing many small docs or a few big ones? Is the XML parsing a > true bottleneck? > For citygml I am parsing a few large files. I am not sure where the bottleneck is as I have not implemented it. The processing, after parsing, seems pretty simple though - traversing the tree and moving the data into a VTK polydata. > Elvis > > >> >> On Wed, Jun 20, 2018 at 12:13 PM Robert Michael O'Bara < >> bob.obara at kitware.com> wrote: >> >>> SMTK and CMB use pugixml for years and have been very happy with it. >>> >>> Bob >>> >>> Sent from my iPad >>> >>> On Jun 20, 2018, at 12:07 PM, Jonathan Borduas < >>> jonathan.borduas at caboma.com> wrote: >>> >>> My 2 cents here is that speed is of the essence. Validating XML are good >>> for debugging, however I found that most don?t take the time to create an >>> XSD file to enable the validation. >>> >>> >>> >>> In most of our cases at Caboma, XML and meant to be human readable and >>> editable, but it is rare that we manually edit the structure of an XML >>> file. >>> >>> However, we do wait after .xml parsing when the files are 20mb+. We hope >>> that the community would move to the latest version of pugixml (1.9): by >>> looking at the changelogs, there was a lot of performance improvements >>> since version 1.4 (the current version used in ParaView). >>> https://pugixml.org/docs/manual.html#v1.5 >>> >>> >>> >>> Best >>> >>> >>> >>> Jonathan Borduas >>> >>> CTO, Caboma Inc. >>> >>> >>> >>> >>> >>> *From:* vtk-developers *On >>> Behalf Of *David E DeMarle >>> *Sent:* Wednesday, June 20, 2018 11:49 AM >>> *To:* Elvis Stansvik >>> *Cc:* vtkdev >>> *Subject:* Re: [vtk-developers] Add pugixml to VTK >>> >>> >>> >>> I was thinking more if there should be a push towards one single lib, >>> ... >>> >>> >>> >>> I for one would really like us to get down to just one xml parser in >>> VTK. The more the less merrier in terms of maintenance effort and project >>> complexity eh? >>> >>> >>> >>> David E DeMarle >>> Kitware, Inc. >>> Principal Engineer >>> 21 Corporate Drive >>> Clifton Park, NY 12065-8662 >>> Phone: 518-881-4909 >>> >>> >>> >>> >>> >>> On Tue, Jun 19, 2018 at 3:36 PM Elvis Stansvik < >>> elvis.stansvik at orexplore.com> wrote: >>> >>> 2018-06-16 8:37 GMT+02:00 Chiranjib Sur : >>> >>> My few cents... The disadvantage with pugixml is that it's a >>> non-validating parser. If I want to make full use of XML schema for any >>> custom developed plugin, it's a very poor choice then. >>> >>> >>> >>> Any thoughts? >>> >>> >>> >>> Also worth noting that it's a DOM-like parser only AFAIK, so if you want >>> to do streaming parsing in a push paradigm ? la SAX or a pull paradigm ? la >>> libxml2's reader interface, you'd need to turn to another library. Note >>> that may not be a problem if VTK already has libxml2 as a dep, since then >>> you could use that. I was thinking more if there should be a push towards >>> one single lib, then it might make sense to pick one that has both DOM and >>> streaming interfaces (don't know if that's a goal/consideration though). >>> >>> >>> >>> Elvis >>> >>> >>> >>> >>> >>> Thanks and regards, >>> Chiranjib >>> >>> ------ >>> Using hand held device. Sorry for the typo, if any. >>> >>> >>> >>> On Fri, Jun 15, 2018, 11:59 PM Utkarsh Ayachit < >>> utkarsh.ayachit at kitware.com> wrote: >>> >>> > I thought Ben Boeckel was working on a removing as many things from >>> ThirdParty as possible (and making them parts of a superbuild). So perhaps >>> the CityGML reader should live in a VTK module that requires an external >>> pugi? I know pugi is small, but... >>> >>> I am not sure that's correct. He was doing that for Python 3rd party >>> modules. Are you referring to that? >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: >>> http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://public.kitware.com/mailman/listinfo/vtk-developers >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: From elvis.stansvik at orexplore.com Fri Jul 6 09:27:45 2018 From: elvis.stansvik at orexplore.com (Elvis Stansvik) Date: Fri, 6 Jul 2018 15:27:45 +0200 Subject: [vtk-developers] Add pugixml to VTK In-Reply-To: References: <87FC3B44-C211-4882-A35E-ACCB8890A532@kitware.com> <3E8B5C57-7401-4F3F-88AE-343A3499C363@kitware.com> Message-ID: 2018-07-05 18:40 GMT+02:00 Dan Lipsa : >> >> I'm agnostic :) >> >> >> An idea would be to maybe try to eliminate expat at some point afterwards, >> to bring it down to just two libs again? I don't think the speed advantage >> of expat over libxml2 could really matter that much? (libxml2 has both a >> SAX-like and a pull-style reader API). > > Sounds good. I think the problem is finding the time to do it. Yes, this was more of a suggestion for something to aspire towards. Didn't mean it should block the addition of pugixml. > >> libxml2 can then be the power horse for those who want 100% conformance >> and possibility of validation, while pugi for those who need speedy DOM. > > > This was my thought about this as well. > > >> >> I wonder what are the speed-requiring use cases for DOM parsing though? >> Are you parsing many small docs or a few big ones? Is the XML parsing a true >> bottleneck? > > > For citygml I am parsing a few large files. I am not sure where the > bottleneck is as I have not implemented it. The processing, after parsing, > seems pretty simple though - traversing the tree and moving the data into a > VTK polydata. Alright. Maybe this could actually benefit from being done in a streaming fashion (? la libxml2's reader API)? Or will it be beneficial/easier to have access to the whole DOM in memory? Elvis > > >> >> Elvis >> >>> >>> >>> On Wed, Jun 20, 2018 at 12:13 PM Robert Michael O'Bara >>> wrote: >>>> >>>> SMTK and CMB use pugixml for years and have been very happy with it. >>>> >>>> Bob >>>> >>>> Sent from my iPad >>>> >>>> On Jun 20, 2018, at 12:07 PM, Jonathan Borduas >>>> wrote: >>>> >>>> My 2 cents here is that speed is of the essence. Validating XML are good >>>> for debugging, however I found that most don?t take the time to create an >>>> XSD file to enable the validation. >>>> >>>> >>>> >>>> In most of our cases at Caboma, XML and meant to be human readable and >>>> editable, but it is rare that we manually edit the structure of an XML file. >>>> >>>> However, we do wait after .xml parsing when the files are 20mb+. We hope >>>> that the community would move to the latest version of pugixml (1.9): by >>>> looking at the changelogs, there was a lot of performance improvements since >>>> version 1.4 (the current version used in ParaView). >>>> https://pugixml.org/docs/manual.html#v1.5 >>>> >>>> >>>> >>>> Best >>>> >>>> >>>> >>>> Jonathan Borduas >>>> >>>> CTO, Caboma Inc. >>>> >>>> >>>> >>>> >>>> >>>> From: vtk-developers On >>>> Behalf Of David E DeMarle >>>> Sent: Wednesday, June 20, 2018 11:49 AM >>>> To: Elvis Stansvik >>>> Cc: vtkdev >>>> Subject: Re: [vtk-developers] Add pugixml to VTK >>>> >>>> >>>> >>>> I was thinking more if there should be a push towards one single lib, >>>> ... >>>> >>>> >>>> >>>> I for one would really like us to get down to just one xml parser in >>>> VTK. The more the less merrier in terms of maintenance effort and project >>>> complexity eh? >>>> >>>> >>>> >>>> David E DeMarle >>>> Kitware, Inc. >>>> Principal Engineer >>>> 21 Corporate Drive >>>> Clifton Park, NY 12065-8662 >>>> Phone: 518-881-4909 >>>> >>>> >>>> >>>> >>>> >>>> On Tue, Jun 19, 2018 at 3:36 PM Elvis Stansvik >>>> wrote: >>>> >>>> 2018-06-16 8:37 GMT+02:00 Chiranjib Sur : >>>> >>>> My few cents... The disadvantage with pugixml is that it's a >>>> non-validating parser. If I want to make full use of XML schema for any >>>> custom developed plugin, it's a very poor choice then. >>>> >>>> >>>> >>>> Any thoughts? >>>> >>>> >>>> >>>> Also worth noting that it's a DOM-like parser only AFAIK, so if you want >>>> to do streaming parsing in a push paradigm ? la SAX or a pull paradigm ? la >>>> libxml2's reader interface, you'd need to turn to another library. Note that >>>> may not be a problem if VTK already has libxml2 as a dep, since then you >>>> could use that. I was thinking more if there should be a push towards one >>>> single lib, then it might make sense to pick one that has both DOM and >>>> streaming interfaces (don't know if that's a goal/consideration though). >>>> >>>> >>>> >>>> Elvis >>>> >>>> >>>> >>>> >>>> >>>> Thanks and regards, >>>> Chiranjib >>>> >>>> ------ >>>> Using hand held device. Sorry for the typo, if any. >>>> >>>> >>>> >>>> On Fri, Jun 15, 2018, 11:59 PM Utkarsh Ayachit >>>> wrote: >>>> >>>> > I thought Ben Boeckel was working on a removing as many things from >>>> > ThirdParty as possible (and making them parts of a superbuild). So perhaps >>>> > the CityGML reader should live in a VTK module that requires an external >>>> > pugi? I know pugi is small, but... >>>> >>>> I am not sure that's correct. He was doing that for Python 3rd party >>>> modules. Are you referring to that? >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: >>>> http://markmail.org/search/?q=vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> https://public.kitware.com/mailman/listinfo/vtk-developers >>>> >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: >>>> http://markmail.org/search/?q=vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> https://public.kitware.com/mailman/listinfo/vtk-developers >>>> >>>> >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: >>>> http://markmail.org/search/?q=vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> https://public.kitware.com/mailman/listinfo/vtk-developers >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: >>>> http://markmail.org/search/?q=vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> https://public.kitware.com/mailman/listinfo/vtk-developers >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: >>>> http://markmail.org/search/?q=vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> https://public.kitware.com/mailman/listinfo/vtk-developers >>>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://public.kitware.com/mailman/listinfo/vtk-developers >>> > From dan.lipsa at kitware.com Fri Jul 6 16:58:43 2018 From: dan.lipsa at kitware.com (Dan Lipsa) Date: Fri, 6 Jul 2018 16:58:43 -0400 Subject: [vtk-developers] Add pugixml to VTK In-Reply-To: References: <87FC3B44-C211-4882-A35E-ACCB8890A532@kitware.com> <3E8B5C57-7401-4F3F-88AE-343A3499C363@kitware.com> Message-ID: > > Alright. Maybe this could actually benefit from being done in a > streaming fashion (? la libxml2's reader API)? Or will it be > beneficial/easier to have access to the whole DOM in memory? > You are right - it could be implemented in streaming fashion. I think the trade off is - streaming: slower than dom, less memory than dom, possibly more complicated as you may need to store data for later. - dom: quickest, more memory than streaming, simplest way to access citygml data. For now I lean toward dom as our input data is tiled to start with so I don't expect really large files. I realize I have to revise the specs of the problem: I'll need to parse many medium size XML files. Dan -------------- next part -------------- An HTML attachment was scrubbed... URL: From elvis.stansvik at orexplore.com Fri Jul 6 17:55:59 2018 From: elvis.stansvik at orexplore.com (Elvis Stansvik) Date: Fri, 6 Jul 2018 23:55:59 +0200 Subject: [vtk-developers] Add pugixml to VTK In-Reply-To: References: <87FC3B44-C211-4882-A35E-ACCB8890A532@kitware.com> <3E8B5C57-7401-4F3F-88AE-343A3499C363@kitware.com> Message-ID: 2018-07-06 23:26 GMT+02:00 Jonathan Borduas : > Hi, > > Here?s a large xml (paraview statefile with 200+ sphere). It weighs 17.5 MB. > It takes 1-2 minutes to load with pugixml 1.4 on ParaView. Alright. That shows the time of XML parsing is minuscule compared to other things in that use case. That file parses in < 400 ms with libxml2 here, and I guess pugixml would be even faster. Elvis > > > > Best, > > > > Jonathan Borduas > > > > From: vtk-developers On Behalf > Of Dan Lipsa > Sent: Friday, July 06, 2018 4:59 PM > To: elvis.stansvik at orexplore.com > Cc: VTK Developers > Subject: Re: [vtk-developers] Add pugixml to VTK > > > > > > > Alright. Maybe this could actually benefit from being done in a > streaming fashion (? la libxml2's reader API)? Or will it be > beneficial/easier to have access to the whole DOM in memory? > > > > You are right - it could be implemented in streaming fashion. > > I think the trade off is > > - streaming: slower than dom, less memory than dom, possibly more > complicated as you may need to store data for later. > > - dom: quickest, more memory than streaming, simplest way to access citygml > data. > > > > For now I lean toward dom as our input data is tiled to start with so I > don't expect really large files. I realize I have to revise the specs of the > problem: > > I'll need to parse many medium size XML files. > > Dan > > From pbergeron at spiria.com Fri Jul 6 21:20:12 2018 From: pbergeron at spiria.com (Patrick Bergeron) Date: Sat, 7 Jul 2018 01:20:12 +0000 Subject: [vtk-developers] Add pugixml to VTK In-Reply-To: References: <87FC3B44-C211-4882-A35E-ACCB8890A532@kitware.com> <3E8B5C57-7401-4F3F-88AE-343A3499C363@kitware.com> , Message-ID: <1BEB88D0-94FE-446C-8BFB-6190E4F95BD2@spiria.com> Have you guys tried profiling what happens during those 2 minutes? > On Jul 6, 2018, at 17:56, Elvis Stansvik wrote: > > 2018-07-06 23:26 GMT+02:00 Jonathan Borduas : >> Hi, >> >> Here?s a large xml (paraview statefile with 200+ sphere). It weighs 17.5 MB. >> It takes 1-2 minutes to load with pugixml 1.4 on ParaView. > > Alright. That shows the time of XML parsing is minuscule compared to > other things in that use case. That file parses in < 400 ms with > libxml2 here, and I guess pugixml would be even faster. > > Elvis > >> >> >> >> Best, >> >> >> >> Jonathan Borduas >> >> >> >> From: vtk-developers On Behalf >> Of Dan Lipsa >> Sent: Friday, July 06, 2018 4:59 PM >> To: elvis.stansvik at orexplore.com >> Cc: VTK Developers >> Subject: Re: [vtk-developers] Add pugixml to VTK >> >> >> >> >> >> >> Alright. Maybe this could actually benefit from being done in a >> streaming fashion (? la libxml2's reader API)? Or will it be >> beneficial/easier to have access to the whole DOM in memory? >> >> >> >> You are right - it could be implemented in streaming fashion. >> >> I think the trade off is >> >> - streaming: slower than dom, less memory than dom, possibly more >> complicated as you may need to store data for later. >> >> - dom: quickest, more memory than streaming, simplest way to access citygml >> data. >> >> >> >> For now I lean toward dom as our input data is tiled to start with so I >> don't expect really large files. I realize I have to revise the specs of the >> problem: >> >> I'll need to parse many medium size XML files. >> >> Dan >> >> > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > From mathieu.westphal at kitware.com Sun Jul 8 21:54:44 2018 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Mon, 9 Jul 2018 03:54:44 +0200 Subject: [vtk-developers] openturns buildbot warnings In-Reply-To: References: Message-ID: It is fixed now ! Mathieu Westphal On Fri, Jun 8, 2018 at 2:50 PM, Ken Martin wrote: > Awesome, thanks! > > On Fri, Jun 8, 2018 at 8:48 AM, Mathieu Westphal < > mathieu.westphal at kitware.com> wrote: > >> Hi Ken, >> >> That is mine, we are experiencing errors with luigi on ParaView right >> now. I will fix these warnings once we fix the errors. >> >> Thanks for asking. >> >> Mathieu Westphal >> >> On Fri, Jun 8, 2018 at 2:44 PM, Ken Martin >> wrote: >> >>> >>> Ring a bell with anyone? Showed up on luigi ala >>> >>> https://open.cdash.org/viewBuildError.php?type=1&buildid=5409899 >>> >>> /usr/local/include/openturns/openturns/Collection.hxx:382:49: warning: unused parameter 'offset' [-Wunused-parameter] >>> inline String __str__(const String & offset = "") const >>> >>> etc >>> >>> -- >>> Ken Martin PhD >>> Distinguished Engineer >>> Kitware Inc. >>> 101 East Weaver Street >>> >>> Carrboro, North Carolina >>> >>> 27510 USA >>> >>> This communication, including all attachments, contains confidential and >>> legally privileged information, and it is intended only for the use of the >>> addressee. Access to this email by anyone else is unauthorized. If you are >>> not the intended recipient, any disclosure, copying, distribution or any >>> action taken in reliance on it is prohibited and may be unlawful. If you >>> received this communication in error please notify us immediately and >>> destroy the original message. Thank you. >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q= >>> vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://public.kitware.com/mailman/listinfo/vtk-developers >>> >>> >>> >> > > > -- > Ken Martin PhD > Distinguished Engineer > Kitware Inc. > 101 East Weaver Street > > Carrboro, North Carolina > > 27510 USA > > This communication, including all attachments, contains confidential and > legally privileged information, and it is intended only for the use of the > addressee. Access to this email by anyone else is unauthorized. If you are > not the intended recipient, any disclosure, copying, distribution or any > action taken in reliance on it is prohibited and may be unlawful. If you > received this communication in error please notify us immediately and > destroy the original message. Thank you. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From haocheng.liu at kitware.com Mon Jul 9 14:10:51 2018 From: haocheng.liu at kitware.com (Haocheng Liu) Date: Mon, 9 Jul 2018 14:10:51 -0400 Subject: [vtk-developers] Dejagore In-Reply-To: References: Message-ID: Hi, here is the fix MR for Dejagore. Once it's merged, Dajagore should be back online. On Thu, Jul 5, 2018 at 9:47 AM Haocheng Liu wrote: > Hi, > > Dashboard machine Dejagore is broken due to a mysterious vtk-m related > error. If no one is looking at this issue, I would tackle it. > > -- > Best regards > Haocheng > > Haocheng LIU > Kitware, Inc. > R&D Engineer > 21 Corporate Drive > Clifton Park, NY 12065-8662 > Phone: 518-881-4421 > -- Best regards Haocheng Haocheng LIU Kitware, Inc. R&D Engineer 21 Corporate Drive Clifton Park, NY 12065-8662 Phone: 518-881-4421 -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Mon Jul 9 15:55:44 2018 From: ken.martin at kitware.com (Ken Martin) Date: Mon, 9 Jul 2018 15:55:44 -0400 Subject: [vtk-developers] Dejagore In-Reply-To: References: Message-ID: Awesome, thanks Haocheng! On Mon, Jul 9, 2018 at 2:10 PM, Haocheng Liu wrote: > Hi, here is the fix MR > for > Dejagore. Once it's merged, Dajagore should be back online. > > On Thu, Jul 5, 2018 at 9:47 AM Haocheng Liu > wrote: > >> Hi, >> >> Dashboard machine Dejagore is broken due to a mysterious vtk-m related >> error. If no one is looking at this issue, I would tackle it. >> >> -- >> Best regards >> Haocheng >> >> Haocheng LIU >> Kitware, Inc. >> R&D Engineer >> 21 Corporate Drive >> Clifton Park, NY 12065-8662 >> Phone: 518-881-4421 >> > > > -- > Best regards > Haocheng > > Haocheng LIU > Kitware, Inc. > R&D Engineer > 21 Corporate Drive > Clifton Park, NY 12065-8662 > Phone: 518-881-4421 > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > > -- Ken Martin PhD Distinguished Engineer Kitware Inc. 101 East Weaver Street Carrboro, North Carolina 27510 USA This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Tue Jul 10 10:08:06 2018 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Tue, 10 Jul 2018 10:08:06 -0400 Subject: [vtk-developers] Filters and active attributes Message-ID: Folks, I have a philosophical question. Suppose I am writing a filter that takes in an input dataset and generates a new vector field for the input. Such a filter will do something like the following in its RequestData: output->ShallowCopy(input); output->GetPointData()->SetVectors(newVectors); Now the question is this: if the input had an active vectors array set, what should the output look like? Should it (a) drop the input vectors array entirely or should it (b) pass the input vectors array, just not flag it as active vectors and instead mark my "newVectors" as the active vectors. My vote is (b), currently most filters do (a). The curious side effect of A is that if I apply a filter like vtkGlyph3D to a dataset, the output will have arrays passed on from the input based on whether or not they were marked as active attributes on the input! The change to fix this is quite non-intrusive. We simply change the behavior of SetAttribute/SetVector etc. in vtkDataSetAttributes. Thanks in advance Utkarsh From mathieu.westphal at kitware.com Tue Jul 10 21:57:37 2018 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Wed, 11 Jul 2018 03:57:37 +0200 Subject: [vtk-developers] Filters and active attributes In-Reply-To: References: Message-ID: My vote is definitelly (b), but I may be influenced by the fact I'm working on VTK mostly trough ParaView where this kind of behavior is most of the time not expected. Mathieu Westphal On Tue, Jul 10, 2018 at 4:08 PM, Utkarsh Ayachit < utkarsh.ayachit at kitware.com> wrote: > Folks, > > I have a philosophical question. Suppose I am writing a filter that > takes in an input dataset and generates a new vector field for the > input. Such a filter will do something like the following in its > RequestData: > > output->ShallowCopy(input); > output->GetPointData()->SetVectors(newVectors); > > Now the question is this: if the input had an active vectors array > set, what should the output look like? Should it (a) drop the input > vectors array entirely or should it (b) pass the input vectors array, > just not flag it as active vectors and instead mark my "newVectors" as > the active vectors. > > My vote is (b), currently most filters do (a). The curious side effect > of A is that if I apply a filter like vtkGlyph3D to a dataset, the > output will have arrays passed on from the input based on whether or > not they were marked as active attributes on the input! > > The change to fix this is quite non-intrusive. We simply change the > behavior of SetAttribute/SetVector etc. in vtkDataSetAttributes. > > Thanks in advance > > Utkarsh > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From cory.quammen at kitware.com Wed Jul 11 15:15:57 2018 From: cory.quammen at kitware.com (Cory Quammen) Date: Wed, 11 Jul 2018 15:15:57 -0400 Subject: [vtk-developers] Filters and active attributes In-Reply-To: References: Message-ID: +1 for (b) as well. There is no reason an array should disappear simply because it was marked as active in the input. I remember being stunned when first encountering this behavior and have had to work around it. I don't foresee any backwards compatibility issues with changing the behavior since arrays will be added to the output and will likely be ignored. Cory On Tue, Jul 10, 2018 at 9:58 PM Mathieu Westphal < mathieu.westphal at kitware.com> wrote: > My vote is definitelly (b), but I may be influenced by the fact I'm > working on VTK mostly trough ParaView where this kind of behavior is most > of the time not expected. > > Mathieu Westphal > > On Tue, Jul 10, 2018 at 4:08 PM, Utkarsh Ayachit < > utkarsh.ayachit at kitware.com> wrote: > >> Folks, >> >> I have a philosophical question. Suppose I am writing a filter that >> takes in an input dataset and generates a new vector field for the >> input. Such a filter will do something like the following in its >> RequestData: >> >> output->ShallowCopy(input); >> output->GetPointData()->SetVectors(newVectors); >> >> Now the question is this: if the input had an active vectors array >> set, what should the output look like? Should it (a) drop the input >> vectors array entirely or should it (b) pass the input vectors array, >> just not flag it as active vectors and instead mark my "newVectors" as >> the active vectors. >> >> My vote is (b), currently most filters do (a). The curious side effect >> of A is that if I apply a filter like vtkGlyph3D to a dataset, the >> output will have arrays passed on from the input based on whether or >> not they were marked as active attributes on the input! >> >> The change to fix this is quite non-intrusive. We simply change the >> behavior of SetAttribute/SetVector etc. in vtkDataSetAttributes. >> >> Thanks in advance >> >> Utkarsh >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://public.kitware.com/mailman/listinfo/vtk-developers >> >> > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > -- Cory Quammen Staff R&D Engineer Kitware, Inc. -------------- next part -------------- An HTML attachment was scrubbed... URL: From yuri at rawbw.com Wed Jul 11 16:09:35 2018 From: yuri at rawbw.com (Yuri) Date: Wed, 11 Jul 2018 13:09:35 -0700 Subject: [vtk-developers] [question] How to build only pythin binding, and nothing else? Message-ID: <644e7b6e-4684-24ca-de39-e624f8fe6070@rawbw.com> I need this for FreeBSD port for python to be built separately. Thanks, Yuri From yuri at rawbw.com Thu Jul 12 04:42:33 2018 From: yuri at rawbw.com (Yuri) Date: Thu, 12 Jul 2018 01:42:33 -0700 Subject: [vtk-developers] configure breaks when Qt5 is used Message-ID: <5065a07c-e974-560f-fb31-38ee9a7a3e75@rawbw.com> Configure in 8.1.1 fails with errors: CMake Error at /usr/local/lib/cmake/Qt5Core/Qt5CoreMacros.cmake:123 (file): ? Error evaluating generator expression: ??? $ ? Target "QVTKWidgetPlugin" not found. Call Stack (most recent call first): ? /usr/local/lib/cmake/Qt5Core/Qt5CoreMacros.cmake:187 (qt5_create_moc_command) ? GUISupport/Qt/CMakeLists.txt:148 (qt5_wrap_cpp) CMake Error at /usr/local/lib/cmake/Qt5Core/Qt5CoreMacros.cmake:123 (file): ? Error evaluating generator expression: ??? $ ? Target "QVTKWidgetPlugin" not found. when these arguments are passed: -DVTK_QT_VERSION:STRING="5" -DCMAKE_PREFIX_PATH:STRING=${LOCALBASE}/lib/qt5 -DVTK_Group_Qt:BOOL=ON Yuri From utkarsh.ayachit at kitware.com Sun Jul 15 09:56:38 2018 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Sun, 15 Jul 2018 09:56:38 -0400 Subject: [vtk-developers] Filters and active attributes In-Reply-To: References: Message-ID: Thanks folks! Since there seem to be no objections to the proposal (b), I'll create an MR in the near future and see if that exposes any legitimate reasons for the original implementation (a). Utkarsh On Wed, Jul 11, 2018 at 3:16 PM Cory Quammen wrote: > > +1 for (b) as well. There is no reason an array should disappear simply because it was marked as active in the input. I remember being stunned when first encountering this behavior and have had to work around it. I don't foresee any backwards compatibility issues with changing the behavior since arrays will be added to the output and will likely be ignored. > > Cory > > On Tue, Jul 10, 2018 at 9:58 PM Mathieu Westphal wrote: >> >> My vote is definitelly (b), but I may be influenced by the fact I'm working on VTK mostly trough ParaView where this kind of behavior is most of the time not expected. >> >> Mathieu Westphal >> >> On Tue, Jul 10, 2018 at 4:08 PM, Utkarsh Ayachit wrote: >>> >>> Folks, >>> >>> I have a philosophical question. Suppose I am writing a filter that >>> takes in an input dataset and generates a new vector field for the >>> input. Such a filter will do something like the following in its >>> RequestData: >>> >>> output->ShallowCopy(input); >>> output->GetPointData()->SetVectors(newVectors); >>> >>> Now the question is this: if the input had an active vectors array >>> set, what should the output look like? Should it (a) drop the input >>> vectors array entirely or should it (b) pass the input vectors array, >>> just not flag it as active vectors and instead mark my "newVectors" as >>> the active vectors. >>> >>> My vote is (b), currently most filters do (a). The curious side effect >>> of A is that if I apply a filter like vtkGlyph3D to a dataset, the >>> output will have arrays passed on from the input based on whether or >>> not they were marked as active attributes on the input! >>> >>> The change to fix this is quite non-intrusive. We simply change the >>> behavior of SetAttribute/SetVector etc. in vtkDataSetAttributes. >>> >>> Thanks in advance >>> >>> Utkarsh >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://public.kitware.com/mailman/listinfo/vtk-developers >>> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html >> >> Search the list archives at: http://markmail.org/search/?q=vtk-developers >> >> Follow this link to subscribe/unsubscribe: >> https://public.kitware.com/mailman/listinfo/vtk-developers >> > > > -- > Cory Quammen > Staff R&D Engineer > Kitware, Inc. From pbergeron at spiria.com Sun Jul 15 14:56:34 2018 From: pbergeron at spiria.com (Patrick Bergeron) Date: Sun, 15 Jul 2018 18:56:34 +0000 Subject: [vtk-developers] Filters and active attributes In-Reply-To: References: , Message-ID: <77FDF158-87B4-41B7-B9AD-7B44FF14255A@spiria.com> Please forgive my newbiness, but what happens when you have a long chain of filters? Will the output have 25 Unused arrays? Sent from my iPhone > On Jul 15, 2018, at 09:57, Utkarsh Ayachit wrote: > > Thanks folks! Since there seem to be no objections to the proposal > (b), I'll create an MR in the near future and see if that exposes any > legitimate reasons for the original implementation (a). > > Utkarsh > >> On Wed, Jul 11, 2018 at 3:16 PM Cory Quammen wrote: >> >> +1 for (b) as well. There is no reason an array should disappear simply because it was marked as active in the input. I remember being stunned when first encountering this behavior and have had to work around it. I don't foresee any backwards compatibility issues with changing the behavior since arrays will be added to the output and will likely be ignored. >> >> Cory >> >>> On Tue, Jul 10, 2018 at 9:58 PM Mathieu Westphal wrote: >>> >>> My vote is definitelly (b), but I may be influenced by the fact I'm working on VTK mostly trough ParaView where this kind of behavior is most of the time not expected. >>> >>> Mathieu Westphal >>> >>>> On Tue, Jul 10, 2018 at 4:08 PM, Utkarsh Ayachit wrote: >>>> >>>> Folks, >>>> >>>> I have a philosophical question. Suppose I am writing a filter that >>>> takes in an input dataset and generates a new vector field for the >>>> input. Such a filter will do something like the following in its >>>> RequestData: >>>> >>>> output->ShallowCopy(input); >>>> output->GetPointData()->SetVectors(newVectors); >>>> >>>> Now the question is this: if the input had an active vectors array >>>> set, what should the output look like? Should it (a) drop the input >>>> vectors array entirely or should it (b) pass the input vectors array, >>>> just not flag it as active vectors and instead mark my "newVectors" as >>>> the active vectors. >>>> >>>> My vote is (b), currently most filters do (a). The curious side effect >>>> of A is that if I apply a filter like vtkGlyph3D to a dataset, the >>>> output will have arrays passed on from the input based on whether or >>>> not they were marked as active attributes on the input! >>>> >>>> The change to fix this is quite non-intrusive. We simply change the >>>> behavior of SetAttribute/SetVector etc. in vtkDataSetAttributes. >>>> >>>> Thanks in advance >>>> >>>> Utkarsh >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> https://public.kitware.com/mailman/listinfo/vtk-developers >>>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://public.kitware.com/mailman/listinfo/vtk-developers >>> >> >> >> -- >> Cory Quammen >> Staff R&D Engineer >> Kitware, Inc. > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > From utkarsh.ayachit at kitware.com Sun Jul 15 15:38:04 2018 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Sun, 15 Jul 2018 15:38:04 -0400 Subject: [vtk-developers] Filters and active attributes In-Reply-To: <77FDF158-87B4-41B7-B9AD-7B44FF14255A@spiria.com> References: <77FDF158-87B4-41B7-B9AD-7B44FF14255A@spiria.com> Message-ID: Patrick, Consider this, even now, if you have a long chain of filters and the first source added M arrays, all M, except may be an active attribute or two, will get propagated through to the output. On Sun, Jul 15, 2018 at 2:56 PM Patrick Bergeron wrote: > > Please forgive my newbiness, but what happens when you have a long chain of filters? > > Will the output have 25 Unused arrays? > > Sent from my iPhone > > > On Jul 15, 2018, at 09:57, Utkarsh Ayachit wrote: > > > > Thanks folks! Since there seem to be no objections to the proposal > > (b), I'll create an MR in the near future and see if that exposes any > > legitimate reasons for the original implementation (a). > > > > Utkarsh > > > >> On Wed, Jul 11, 2018 at 3:16 PM Cory Quammen wrote: > >> > >> +1 for (b) as well. There is no reason an array should disappear simply because it was marked as active in the input. I remember being stunned when first encountering this behavior and have had to work around it. I don't foresee any backwards compatibility issues with changing the behavior since arrays will be added to the output and will likely be ignored. > >> > >> Cory > >> > >>> On Tue, Jul 10, 2018 at 9:58 PM Mathieu Westphal wrote: > >>> > >>> My vote is definitelly (b), but I may be influenced by the fact I'm working on VTK mostly trough ParaView where this kind of behavior is most of the time not expected. > >>> > >>> Mathieu Westphal > >>> > >>>> On Tue, Jul 10, 2018 at 4:08 PM, Utkarsh Ayachit wrote: > >>>> > >>>> Folks, > >>>> > >>>> I have a philosophical question. Suppose I am writing a filter that > >>>> takes in an input dataset and generates a new vector field for the > >>>> input. Such a filter will do something like the following in its > >>>> RequestData: > >>>> > >>>> output->ShallowCopy(input); > >>>> output->GetPointData()->SetVectors(newVectors); > >>>> > >>>> Now the question is this: if the input had an active vectors array > >>>> set, what should the output look like? Should it (a) drop the input > >>>> vectors array entirely or should it (b) pass the input vectors array, > >>>> just not flag it as active vectors and instead mark my "newVectors" as > >>>> the active vectors. > >>>> > >>>> My vote is (b), currently most filters do (a). The curious side effect > >>>> of A is that if I apply a filter like vtkGlyph3D to a dataset, the > >>>> output will have arrays passed on from the input based on whether or > >>>> not they were marked as active attributes on the input! > >>>> > >>>> The change to fix this is quite non-intrusive. We simply change the > >>>> behavior of SetAttribute/SetVector etc. in vtkDataSetAttributes. > >>>> > >>>> Thanks in advance > >>>> > >>>> Utkarsh > >>>> _______________________________________________ > >>>> Powered by www.kitware.com > >>>> > >>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > >>>> > >>>> Search the list archives at: http://markmail.org/search/?q=vtk-developers > >>>> > >>>> Follow this link to subscribe/unsubscribe: > >>>> https://public.kitware.com/mailman/listinfo/vtk-developers > >>>> > >>> > >>> _______________________________________________ > >>> Powered by www.kitware.com > >>> > >>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > >>> > >>> Search the list archives at: http://markmail.org/search/?q=vtk-developers > >>> > >>> Follow this link to subscribe/unsubscribe: > >>> https://public.kitware.com/mailman/listinfo/vtk-developers > >>> > >> > >> > >> -- > >> Cory Quammen > >> Staff R&D Engineer > >> Kitware, Inc. > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > > > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > > > Follow this link to subscribe/unsubscribe: > > https://public.kitware.com/mailman/listinfo/vtk-developers > > From pbergeron at spiria.com Sun Jul 15 15:54:18 2018 From: pbergeron at spiria.com (Patrick Bergeron) Date: Sun, 15 Jul 2018 19:54:18 +0000 Subject: [vtk-developers] Filters and active attributes In-Reply-To: References: <77FDF158-87B4-41B7-B9AD-7B44FF14255A@spiria.com>, Message-ID: <8FF44D15-2AE9-4EDF-91A3-09474ECE71B0@spiria.com> Ok. Sent from my iPhone > On Jul 15, 2018, at 15:38, Utkarsh Ayachit wrote: > > Patrick, > > Consider this, even now, if you have a long chain of filters and the > first source added M arrays, all M, except may be an active attribute > or two, will get propagated through to the output. >> On Sun, Jul 15, 2018 at 2:56 PM Patrick Bergeron wrote: >> >> Please forgive my newbiness, but what happens when you have a long chain of filters? >> >> Will the output have 25 Unused arrays? >> >> Sent from my iPhone >> >>> On Jul 15, 2018, at 09:57, Utkarsh Ayachit wrote: >>> >>> Thanks folks! Since there seem to be no objections to the proposal >>> (b), I'll create an MR in the near future and see if that exposes any >>> legitimate reasons for the original implementation (a). >>> >>> Utkarsh >>> >>>> On Wed, Jul 11, 2018 at 3:16 PM Cory Quammen wrote: >>>> >>>> +1 for (b) as well. There is no reason an array should disappear simply because it was marked as active in the input. I remember being stunned when first encountering this behavior and have had to work around it. I don't foresee any backwards compatibility issues with changing the behavior since arrays will be added to the output and will likely be ignored. >>>> >>>> Cory >>>> >>>>> On Tue, Jul 10, 2018 at 9:58 PM Mathieu Westphal wrote: >>>>> >>>>> My vote is definitelly (b), but I may be influenced by the fact I'm working on VTK mostly trough ParaView where this kind of behavior is most of the time not expected. >>>>> >>>>> Mathieu Westphal >>>>> >>>>>> On Tue, Jul 10, 2018 at 4:08 PM, Utkarsh Ayachit wrote: >>>>>> >>>>>> Folks, >>>>>> >>>>>> I have a philosophical question. Suppose I am writing a filter that >>>>>> takes in an input dataset and generates a new vector field for the >>>>>> input. Such a filter will do something like the following in its >>>>>> RequestData: >>>>>> >>>>>> output->ShallowCopy(input); >>>>>> output->GetPointData()->SetVectors(newVectors); >>>>>> >>>>>> Now the question is this: if the input had an active vectors array >>>>>> set, what should the output look like? Should it (a) drop the input >>>>>> vectors array entirely or should it (b) pass the input vectors array, >>>>>> just not flag it as active vectors and instead mark my "newVectors" as >>>>>> the active vectors. >>>>>> >>>>>> My vote is (b), currently most filters do (a). The curious side effect >>>>>> of A is that if I apply a filter like vtkGlyph3D to a dataset, the >>>>>> output will have arrays passed on from the input based on whether or >>>>>> not they were marked as active attributes on the input! >>>>>> >>>>>> The change to fix this is quite non-intrusive. We simply change the >>>>>> behavior of SetAttribute/SetVector etc. in vtkDataSetAttributes. >>>>>> >>>>>> Thanks in advance >>>>>> >>>>>> Utkarsh >>>>>> _______________________________________________ >>>>>> Powered by www.kitware.com >>>>>> >>>>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html >>>>>> >>>>>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>>>>> >>>>>> Follow this link to subscribe/unsubscribe: >>>>>> https://public.kitware.com/mailman/listinfo/vtk-developers >>>>>> >>>>> >>>>> _______________________________________________ >>>>> Powered by www.kitware.com >>>>> >>>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html >>>>> >>>>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>>>> >>>>> Follow this link to subscribe/unsubscribe: >>>>> https://public.kitware.com/mailman/listinfo/vtk-developers >>>>> >>>> >>>> >>>> -- >>>> Cory Quammen >>>> Staff R&D Engineer >>>> Kitware, Inc. >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html >>> >>> Search the list archives at: http://markmail.org/search/?q=vtk-developers >>> >>> Follow this link to subscribe/unsubscribe: >>> https://public.kitware.com/mailman/listinfo/vtk-developers >>> From dan.lipsa at kitware.com Tue Jul 17 09:54:05 2018 From: dan.lipsa at kitware.com (Dan Lipsa) Date: Tue, 17 Jul 2018 09:54:05 -0400 Subject: [vtk-developers] Add pugixml to VTK In-Reply-To: <1BEB88D0-94FE-446C-8BFB-6190E4F95BD2@spiria.com> References: <87FC3B44-C211-4882-A35E-ACCB8890A532@kitware.com> <3E8B5C57-7401-4F3F-88AE-343A3499C363@kitware.com> <1BEB88D0-94FE-446C-8BFB-6190E4F95BD2@spiria.com> Message-ID: Hi all, I have 4 responses so far, all for adding pugixml to VTK. I'll go ahead and do it. ParaView, CMB and SMTK would benefit as they'll have less maintenance cost and VTK will have access to pugi. On Fri, Jul 6, 2018 at 9:20 PM Patrick Bergeron wrote: > Have you guys tried profiling what happens during those 2 minutes? > > > On Jul 6, 2018, at 17:56, Elvis Stansvik > wrote: > > > > 2018-07-06 23:26 GMT+02:00 Jonathan Borduas >: > >> Hi, > >> > >> Here?s a large xml (paraview statefile with 200+ sphere). It weighs > 17.5 MB. > >> It takes 1-2 minutes to load with pugixml 1.4 on ParaView. > > > Indeed, this seem like a long time. Do you mind filing a bug report and attaching the state file. Not sure what is the reason for this. > > Alright. That shows the time of XML parsing is minuscule compared to > > other things in that use case. That file parses in < 400 ms with > > libxml2 here, and I guess pugixml would be even faster. > > > Elvis > > > >> > >> > >> > >> Best, > >> > >> > >> > >> Jonathan Borduas > >> > >> > >> > >> From: vtk-developers On > Behalf > >> Of Dan Lipsa > >> Sent: Friday, July 06, 2018 4:59 PM > >> To: elvis.stansvik at orexplore.com > >> Cc: VTK Developers > >> Subject: Re: [vtk-developers] Add pugixml to VTK > >> > >> > >> > >> > >> > >> > >> Alright. Maybe this could actually benefit from being done in a > >> streaming fashion (? la libxml2's reader API)? Or will it be > >> beneficial/easier to have access to the whole DOM in memory? > >> > >> > >> > >> You are right - it could be implemented in streaming fashion. > >> > >> I think the trade off is > >> > >> - streaming: slower than dom, less memory than dom, possibly more > >> complicated as you may need to store data for later. > >> > >> - dom: quickest, more memory than streaming, simplest way to access > citygml > >> data. > >> > >> > >> > >> For now I lean toward dom as our input data is tiled to start with so I > >> don't expect really large files. I realize I have to revise the specs > of the > >> problem: > >> > >> I'll need to parse many medium size XML files. > >> > >> Dan > >> > >> > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > > > Search the list archives at: > http://markmail.org/search/?q=vtk-developers > > > > Follow this link to subscribe/unsubscribe: > > https://public.kitware.com/mailman/listinfo/vtk-developers > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From axkibe at gmail.com Thu Jul 19 06:58:27 2018 From: axkibe at gmail.com (Axel Kittenberger) Date: Thu, 19 Jul 2018 12:58:27 +0200 Subject: [vtk-developers] Patch for vtkJPEGReader Message-ID: The JPEGReader in 8.1.1 crashes when the output vertical extend is smaller than the whole image. Reason is: outExt[2] and [3] weren't even looked at in the code and it always filled up the whole vertical size going out of allocated outPtr size. Below patch fixes it for me. I also posted this in the bug tracker, but dunno what is the supposed way for this. Kind regards, Axel diff -ru VTK-8.1.1.org/IO/Image/vtkJPEGReader.cxx VTK-8.1.1/IO/Image/vtkJPEGReader.cxx --- VTK-8.1.1.org/IO/Image/vtkJPEGReader.cxx 2018-05-11 16:34:24.000000000 +0200 +++ VTK-8.1.1/IO/Image/vtkJPEGReader.cxx 2018-07-19 12:37:04.697053464 +0200 @@ -295,19 +295,23 @@ // read the bulk data long outSize = cinfo.output_components*(outExt[1] - outExt[0] + 1); + unsigned int line = cinfo.output_height - 1; + outPtr += outSize*(outExt[3] - outExt[2] - 1); while (cinfo.output_scanline < cinfo.output_height) { JDIMENSION linesRead = jpeg_read_scanlines(&cinfo, row_pointers, maxChunk); // copy the data into the outPtr - OT *outPtr2 = outPtr + (cinfo.output_height - cinfo.output_scanline)*outInc[1]; - for (unsigned int i = 0; i < linesRead; ++i) + for (unsigned int i = linesRead; i > 0; --i) { - memcpy(outPtr2, - row_pointers[linesRead - i - 1] - + outExt[0]*cinfo.output_components, - outSize); - outPtr2 += outInc[1]; + if( line >= outExt[2] && line < outExt[3] ) + { + memcpy(outPtr, + row_pointers[i - 1] + outExt[0]*cinfo.output_components, + outSize); + outPtr -= outInc[1]; + } + line--; } } This code raises the segfault without above patch: #include #include int main( int argc, char** argv ) { vtkJPEGReader * reader = vtkJPEGReader::New( ); reader->SetFileName( "test.jpg" ); reader->UpdateInformation( ); vtkImageClip * clip = vtkImageClip::New( ); clip->SetInputConnection( reader->GetOutputPort( ) ); clip->SetOutputWholeExtent( 0, 10, 0, 10, 0, 1 ); clip->Update( ); return 0; } test.jpg being any large enough image. -------------- next part -------------- An HTML attachment was scrubbed... URL: From ken.martin at kitware.com Thu Jul 19 11:50:05 2018 From: ken.martin at kitware.com (Ken Martin) Date: Thu, 19 Jul 2018 11:50:05 -0400 Subject: [vtk-developers] Patch for vtkJPEGReader In-Reply-To: References: Message-ID: Thanks for the nice report Axel. I created a MR, now in testing to fix this. On Thu, Jul 19, 2018 at 6:58 AM, Axel Kittenberger wrote: > The JPEGReader in 8.1.1 crashes when the output vertical extend is smaller > than the whole image. Reason is: outExt[2] and [3] weren't even looked at > in the code and it always filled up the whole vertical size going out of > allocated outPtr size. > > Below patch fixes it for me. I also posted this in the bug tracker, but > dunno what is the supposed way for this. > > Kind regards, Axel > > diff -ru VTK-8.1.1.org/IO/Image/vtkJPEGReader.cxx VTK-8.1.1/IO/Image/ > vtkJPEGReader.cxx > --- VTK-8.1.1.org/IO/Image/vtkJPEGReader.cxx 2018-05-11 > 16:34:24.000000000 +0200 > +++ VTK-8.1.1/IO/Image/vtkJPEGReader.cxx 2018-07-19 12:37:04.697053464 > +0200 > @@ -295,19 +295,23 @@ > > // read the bulk data > long outSize = cinfo.output_components*(outExt[1] - outExt[0] + 1); > + unsigned int line = cinfo.output_height - 1; > + outPtr += outSize*(outExt[3] - outExt[2] - 1); > while (cinfo.output_scanline < cinfo.output_height) > { > JDIMENSION linesRead = jpeg_read_scanlines(&cinfo, row_pointers, > maxChunk); > > // copy the data into the outPtr > - OT *outPtr2 = outPtr + (cinfo.output_height - > cinfo.output_scanline)*outInc[1]; > - for (unsigned int i = 0; i < linesRead; ++i) > + for (unsigned int i = linesRead; i > 0; --i) > { > - memcpy(outPtr2, > - row_pointers[linesRead - i - 1] > - + outExt[0]*cinfo.output_components, > - outSize); > - outPtr2 += outInc[1]; > + if( line >= outExt[2] && line < outExt[3] ) > + { > + memcpy(outPtr, > + row_pointers[i - 1] + outExt[0]*cinfo.output_components, > + outSize); > + outPtr -= outInc[1]; > + } > + line--; > } > } > > > This code raises the segfault without above patch: > > #include > #include > > int main( int argc, char** argv ) > { > vtkJPEGReader * reader = vtkJPEGReader::New( ); > reader->SetFileName( "test.jpg" ); > reader->UpdateInformation( ); > > vtkImageClip * clip = vtkImageClip::New( ); > clip->SetInputConnection( reader->GetOutputPort( ) ); > clip->SetOutputWholeExtent( 0, 10, 0, 10, 0, 1 ); > clip->Update( ); > > return 0; > } > > test.jpg being any large enough image. > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > > -- Ken Martin PhD Distinguished Engineer Kitware Inc. 101 East Weaver Street Carrboro, North Carolina 27510 USA This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message. Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Tue Jul 24 19:41:31 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 24 Jul 2018 16:41:31 -0700 Subject: [vtk-developers] Gitlab access Message-ID: Has something changed on gitlab. I get [VTK(AddCollisionDetectionFilter)] git gitlab-push Fetching gitlab master Fetching origin master Pushing to gitlab GitLab: Your SSH key type is forbidden. Must be RSA, ECDSA, or ED25519. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. [VTK(AddCollisionDetectionFilter)] -- Unpaid intern in BillsParadise at noware dot com From bill.lorensen at gmail.com Tue Jul 24 23:57:01 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 24 Jul 2018 20:57:01 -0700 Subject: [vtk-developers] Gitlab access In-Reply-To: References: Message-ID: Had to switch to RSA. Ok now. On Tue, Jul 24, 2018, 4:41 PM Bill Lorensen wrote: > Has something changed on gitlab. I get > > [VTK(AddCollisionDetectionFilter)] git gitlab-push > > Fetching gitlab master > > Fetching origin master > > Pushing to gitlab > > GitLab: Your SSH key type is forbidden. Must be RSA, ECDSA, or ED25519. > > fatal: Could not read from remote repository. > > > Please make sure you have the correct access rights > > and the repository exists. > > > [VTK(AddCollisionDetectionFilter)] > > > -- > Unpaid intern in BillsParadise at noware dot com > -------------- next part -------------- An HTML attachment was scrubbed... URL: From prabhu at aero.iitb.ac.in Wed Jul 25 19:19:14 2018 From: prabhu at aero.iitb.ac.in (Prabhu Ramachandran) Date: Wed, 25 Jul 2018 19:19:14 -0400 Subject: [vtk-developers] Script to extract the external data into actual files? Message-ID: Hi all, The VTK data files are convenient but all the newer data is only in the form of the ExternalData database.? Is there a simple script or command that will give me the actual file without me having to either run the tests or using cmake? cheers, Prabhu -------------- next part -------------- An HTML attachment was scrubbed... URL: From mathieu.westphal at kitware.com Thu Jul 26 03:38:48 2018 From: mathieu.westphal at kitware.com (Mathieu Westphal) Date: Thu, 26 Jul 2018 09:38:48 +0200 Subject: [vtk-developers] Script to extract the external data into actual files? In-Reply-To: References: Message-ID: Hi; That is a very good question and we should document this process. Just go there and search for your file : https://data.kitware.com/ Alternatively, you can use the attached script this way : ./wgetVTKData.sh /path/to/VTK/sources/ file it is just a one liner that does wget https://www.paraview.org/files/ExternalData/SHA512/`cat $1/Testing/Data/$2.sha512` -O $2 Best regards, Mathieu Westphal On Thu, Jul 26, 2018 at 1:19 AM, Prabhu Ramachandran wrote: > Hi all, > > The VTK data files are convenient but all the newer data is only in the > form of the ExternalData database. Is there a simple script or command > that will give me the actual file without me having to either run the tests > or using cmake? > > cheers, > > Prabhu > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/ > opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: wgetVTKData.sh Type: application/x-shellscript Size: 94 bytes Desc: not available URL: From prabhu at aero.iitb.ac.in Thu Jul 26 20:40:17 2018 From: prabhu at aero.iitb.ac.in (Prabhu Ramachandran) Date: Thu, 26 Jul 2018 20:40:17 -0400 Subject: [vtk-developers] Script to extract the external data into actual files? In-Reply-To: References: Message-ID: Hi, That is very handy, thank you! cheers, Prabhu On 7/26/18 3:38 AM, Mathieu Westphal wrote: > Hi; > > That is a very good question and we should document this process. > Just go there and search for your file : > https://data.kitware.com/ > > Alternatively, you can use the attached script this way : > ./wgetVTKData.sh /path/to/VTK/sources/ file > > it is just a one liner that does? > wget https://www.paraview.org/files/ExternalData/SHA512/`cat > > $1/Testing/Data/$2.sha512` -O $2 > > Best regards, > > > Mathieu Westphal > > On Thu, Jul 26, 2018 at 1:19 AM, Prabhu Ramachandran > wrote: > > Hi all, > > The VTK data files are convenient but all the newer data is only in the > form of the ExternalData database.? Is there a simple script or command > that will give me the actual file without me having to either run the > tests or using cmake? > > cheers, > > Prabhu > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Fri Jul 27 21:10:59 2018 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 27 Jul 2018 18:10:59 -0700 Subject: [vtk-developers] New vtkCollisionDetectionFilter progress Message-ID: Folks, The code has been converted to new VTK style. It also compiles. The code needs a lot more testing. I've started a unit test to try and get 1005 verified code. Then I'll\ add a functional test that demonstrates the filter. More documentation is needed and I'll add that as I understand the code better after writing the unit test. Here is the current MR: https://gitlab.kitware.com/vtk/vtk/merge_requests/4527 Stay tuned. Bill -- Unpaid intern in BillsParadise at noware dot com From prabhu at aero.iitb.ac.in Sun Jul 29 19:15:28 2018 From: prabhu at aero.iitb.ac.in (Prabhu Ramachandran) Date: Sun, 29 Jul 2018 19:15:28 -0400 Subject: [vtk-developers] A bug in vtkPythonAlgorithm Message-ID: Hi all, vtkPythonAlgorithm is very nice and along with the dataset adapter code is really very convenient for Python users. I just found a bug with the vtkPythonAlgorithm.? I haven't had the chance to look at the error or debug it but thought I'd quickly share the issue.? Basically if any of the required methods raise an exception, you get a segfault and no error/traceback.? Attached is a simple example based on Berk's really nice blog post. I've left one incorrect line of code in the ProcessRequest method to show the segfault but this error could have been in any of the methods and you'll end up with a segfault. I've left these commented out.? I tested this with VTK 8.1.1 but not with master. Thank you! cheers, Prabhu -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: vtk_alg.py Type: text/x-python-script Size: 1104 bytes Desc: not available URL: From utkarsh.ayachit at kitware.com Mon Jul 30 11:34:04 2018 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Mon, 30 Jul 2018 11:34:04 -0400 Subject: [vtk-developers] A bug in vtkPythonAlgorithm In-Reply-To: References: Message-ID: Prabhu, With `master` (v8.1.1-2403-g4ba8e48), the script doesn't seem to segfault. I suspect this may have fixed it: https://gitlab.kitware.com/vtk/vtk/commit/4b477bb56784adf4fb345757f158036f16b0e747 Utkarsh On Sun, Jul 29, 2018 at 7:15 PM Prabhu Ramachandran wrote: > > Hi all, > > > vtkPythonAlgorithm is very nice and along with the dataset adapter code is really very convenient for Python users. > > I just found a bug with the vtkPythonAlgorithm. I haven't had the chance to look at the error or debug it but thought I'd quickly share the issue. Basically if any of the required methods raise an exception, you get a segfault and no error/traceback. Attached is a simple example based on Berk's really nice blog post. > > I've left one incorrect line of code in the ProcessRequest method to show the segfault but this error could have been in any of the methods and you'll end up with a segfault. I've left these commented out. I tested this with VTK 8.1.1 but not with master. > > Thank you! > > cheers, > > Prabhu > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html > > Search the list archives at: http://markmail.org/search/?q=vtk-developers > > Follow this link to subscribe/unsubscribe: > https://public.kitware.com/mailman/listinfo/vtk-developers > From prabhu at aero.iitb.ac.in Mon Jul 30 15:45:26 2018 From: prabhu at aero.iitb.ac.in (Prabhu Ramachandran) Date: Mon, 30 Jul 2018 15:45:26 -0400 Subject: [vtk-developers] A bug in vtkPythonAlgorithm In-Reply-To: References: Message-ID: <23c41fa4-90fb-3e55-372b-7ff3c9545500@aero.iitb.ac.in> On 7/30/18 11:34 AM, Utkarsh Ayachit wrote: > Prabhu, > > With `master` (v8.1.1-2403-g4ba8e48), the script doesn't seem to > segfault. I suspect this may have fixed it: > https://gitlab.kitware.com/vtk/vtk/commit/4b477bb56784adf4fb345757f158036f16b0e747 > Thank you for checking and the fix!? Fancy time machine you have there. :) cheers, Prabhu -------------- next part -------------- An HTML attachment was scrubbed... URL: From utkarsh.ayachit at kitware.com Mon Jul 30 15:48:28 2018 From: utkarsh.ayachit at kitware.com (Utkarsh Ayachit) Date: Mon, 30 Jul 2018 15:48:28 -0400 Subject: [vtk-developers] A bug in vtkPythonAlgorithm In-Reply-To: <23c41fa4-90fb-3e55-372b-7ff3c9545500@aero.iitb.ac.in> References: <23c41fa4-90fb-3e55-372b-7ff3c9545500@aero.iitb.ac.in> Message-ID: > Thank you for checking and the fix! Fancy time machine you have there. :) Haha! I think this is more due to my spoon-bending clairvoyance ;).