View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0010019ParaViewBugpublic2009-12-09 14:432016-08-12 09:57
ReporterBerk Geveci 
Assigned ToKitware Robot 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0010019: Fix geometry filter for distributed multi-block datasets
DescriptionThe following e-mail exchange explains the issue:

Hi Paul,

This is a good start but it is not a full implementation. It is legitimate for some nodes to have NULL nodes and other non-NULL ones. Your code would break if that were the case because it skips empty (NULL) blocks. For example if I had the following dataset:

proc 0:

root -> polydata

proc 1:

root -> NULL

the first process would execute ExecuteBlock() once and the second one never causing communication issues and possible deadlock. The right fix is to make ExecuteBlock() and all the functions it calls work with NULL datasets and to turn off SkipEmptyNodes.

Also, some of the code in this filter relies on WholeExtent being set correctly. Essentially, WholeExtent is the (structured) extent of the whole dataset as if you gathered it on one proc. This is normally set by the reader for singleton datasets but not multi-block datasets. We should probably add support for adding this as meta-data (i.e. making GetWholeExtent() work) and fixing all multi-block readers that read structured data in parallel.

I will create a bug entry for this.

-berk

On Mon, Dec 7, 2009 at 12:50 PM, Edwards, Paul <Paul.Edwards3@rolls-royce.com> wrote:
> Hi Berk,
>
>
> Below is the patch to fix the outline in parallel for composite datasets. I
> just did as you said in your email ;)
>
> Thanks,
>
> Paul
>
> Index: ./Servers/Filters/vtkPVGeometryFilter.cxx
>
> ===================================================================
>
> RCS file:
> /cvsroot/ParaView3/ParaView3/Servers/Filters/vtkPVGeometryFilter.cxx,v
>
> retrieving revision 1.98
>
> diff -b -r1.98 vtkPVGeometryFilter.cxx
>
> 607a608,609
>
>> iter->SkipEmptyNodesOn();
>
>>
>
> 622c624
>
> < this->ExecuteBlock(block, tmpOut, 0);
>
> ---
>
>> this->ExecuteBlock(block, tmpOut, 1);
>
TagsNo tags attached.
Project
Topic Name
Type
Attached Files

 Relationships

  Notes
(0037757)
Kitware Robot (administrator)
2016-08-12 09:57

 Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current ParaView Issues page linked in the banner at the top of this page.

 Issue History
Date Modified Username Field Change
2009-12-09 14:43 Berk Geveci New Issue
2009-12-09 14:46 Berk Geveci Target Version => 4.0
2016-08-12 09:57 Kitware Robot Note Added: 0037757
2016-08-12 09:57 Kitware Robot Status expired => closed
2016-08-12 09:57 Kitware Robot Resolution open => moved
2016-08-12 09:57 Kitware Robot Assigned To => Kitware Robot

Copyright © 2000 - 2018 MantisBT Team