(0021406)
Utkarsh Ayachit (administrator)
2010-07-16 09:06

commit 0b11bb43307c6269d3f2e0e55aa451b047708b43
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Wed Jul 14 17:13:38 2010 -0400

    Add ability to vtkSMRenderView to reuse hardware selector buffer.

    This is the first step is enabling prop picking. Now vtkSMRenderView reuses the
    selection buffer as much as possible. This will make prop picking faster in
    general.

commit b7d21439fe00fc315835f93ef1a6c0a7aefa39b2
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Thu Jul 15 10:55:26 2010 -0400

    Added support to pick a source by clicking on it in a render view.

    * Removing obsolete vtkSMRenderViewProxy::Pick(). No one was using it. We can
      add it back if needed.
    * Added support to vtkSMRenderViewProxy to Pick a representation.
    * Added new pqObjectPickingBehavior that adds support to pick an object on click
      and then make it the active object. This is only supported for render views.
    * Added support to pqRubberBandHelper to pick by adding a new mode.
    * Added a "Pick Object" button to the selection toolbar as a convenience if
      users don't realize that they can simply click-to-pick.

commit c95940136dc12bdec191b981c69a7b3ec6bd6447
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Thu Jul 15 13:54:03 2010 -0400

    Added test for new "pick-to-select" code.

    This also fixes a debug message that was getting raised when a new view was
    created. For some reason pqObjectBuilder was not calling CreateVTKObjects()
    before registering a view. Don't see any reason for that. So fixed it and that
    solves the issue.

commit f6ae98b97d83dc4fa4ae67556254706733bd2702
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Thu Jul 15 15:02:25 2010 -0400

    Fixed issues with pick-to-select in client-server mode.

    * vtkSMRenderViewProxy was using PROP() from selection to determine if the
      representation was selected. That's incorrect in client-server mode since the
      PROP() ptr is not valid. Fixed to use PROP_ID().
    * vtkSMRenderViewProxy was resetting clipping range on every render. That was
      causing the camera to be modified and hence clearing the cache selection
      buffer. And that clearing was happening as we were capturing the color buffers
      for hardware selection! Fixed that.

commit 62a5267e1def1450a1cb05fc7a10d9ab5663f2fd
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Thu Jul 15 15:13:52 2010 -0400

    BUG: removal of ResetCameraClippingRange was incorrect.

    The issues were obvious when playing pv.Calculator test. Fixed by calling the
    correct version of the ResetCameraClippingRange() function.

(0021407)
Utkarsh Ayachit (administrator)
2010-07-16 09:07

To test this feature, simply click on a source in 3D view, if surface selection is working on that machine, then the picked object will become active.

(0021451)
Alan Scott (manager)
2010-07-21 20:44

Works great. Tested remote server, trunk, linux.

Issue History
Date Modified	Username	Field	Change
2010-07-16 09:04	Utkarsh Ayachit	New Issue
2010-07-16 09:04	Utkarsh Ayachit	Status	backlog => tabled
2010-07-16 09:04	Utkarsh Ayachit	Assigned To	=> Utkarsh Ayachit
2010-07-16 09:06	Utkarsh Ayachit	Note Added: 0021406
2010-07-16 09:06	Utkarsh Ayachit	Status	tabled => @80@
2010-07-16 09:06	Utkarsh Ayachit	Fixed in Version	=> 3.10
2010-07-16 09:06	Utkarsh Ayachit	Resolution	open => fixed
2010-07-16 09:07	Utkarsh Ayachit	Note Added: 0021407
2010-07-21 20:44	Alan Scott	Note Added: 0021451
2010-07-21 20:44	Alan Scott	Status	@80@ => closed
2011-06-16 13:10	Zack Galbreath	Category	Feature Request => Feature

Notes
(0021406) Utkarsh Ayachit (administrator) 2010-07-16 09:06	commit 0b11bb43307c6269d3f2e0e55aa451b047708b43 Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Wed Jul 14 17:13:38 2010 -0400 Add ability to vtkSMRenderView to reuse hardware selector buffer. This is the first step is enabling prop picking. Now vtkSMRenderView reuses the selection buffer as much as possible. This will make prop picking faster in general. commit b7d21439fe00fc315835f93ef1a6c0a7aefa39b2 Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Thu Jul 15 10:55:26 2010 -0400 Added support to pick a source by clicking on it in a render view. * Removing obsolete vtkSMRenderViewProxy::Pick(). No one was using it. We can add it back if needed. * Added support to vtkSMRenderViewProxy to Pick a representation. * Added new pqObjectPickingBehavior that adds support to pick an object on click and then make it the active object. This is only supported for render views. * Added support to pqRubberBandHelper to pick by adding a new mode. * Added a "Pick Object" button to the selection toolbar as a convenience if users don't realize that they can simply click-to-pick. commit c95940136dc12bdec191b981c69a7b3ec6bd6447 Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Thu Jul 15 13:54:03 2010 -0400 Added test for new "pick-to-select" code. This also fixes a debug message that was getting raised when a new view was created. For some reason pqObjectBuilder was not calling CreateVTKObjects() before registering a view. Don't see any reason for that. So fixed it and that solves the issue. commit f6ae98b97d83dc4fa4ae67556254706733bd2702 Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Thu Jul 15 15:02:25 2010 -0400 Fixed issues with pick-to-select in client-server mode. * vtkSMRenderViewProxy was using PROP() from selection to determine if the representation was selected. That's incorrect in client-server mode since the PROP() ptr is not valid. Fixed to use PROP_ID(). * vtkSMRenderViewProxy was resetting clipping range on every render. That was causing the camera to be modified and hence clearing the cache selection buffer. And that clearing was happening as we were capturing the color buffers for hardware selection! Fixed that. commit 62a5267e1def1450a1cb05fc7a10d9ab5663f2fd Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Thu Jul 15 15:13:52 2010 -0400 BUG: removal of ResetCameraClippingRange was incorrect. The issues were obvious when playing pv.Calculator test. Fixed by calling the correct version of the ResetCameraClippingRange() function.

(0021407) Utkarsh Ayachit (administrator) 2010-07-16 09:07	To test this feature, simply click on a source in 3D view, if surface selection is working on that machine, then the picked object will become active.

(0021451) Alan Scott (manager) 2010-07-21 20:44	Works great. Tested remote server, trunk, linux.

Relationships