View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0011094

VTK

(No Category)

public

2010-08-04 11:52

2016-08-12 09:55

Reporter

lesmana

Assigned To

Kitware Robot

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

moved

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0011094: LocalUserOptions.cmake included twice if doing in-source build

Description

using vtk-5.6.0.tar.gz

CMakeLists.txt line 1078 and 1079
INCLUDE(${VTK_BINARY_DIR}/LocalUserOptions.cmake OPTIONAL)
INCLUDE(${VTK_SOURCE_DIR}/LocalUserOptions.cmake OPTIONAL)

if doing out-of-source build this will work fine. but if doing in-source builds it will include LocalUserOptions.cmake twice.

workaround: use include guard in LocalUserOptions.cmake

if(NOT LOCALUSEROPTIONS_INCLUDED)
  set(LOCALUSEROPTIONS_INCLUDED TRUE)
  #content
  ...
endif(NOT LOCALUSEROPTIONS_INCLUDED)

fix suggestion: if binary dir and source dir are identical include only once

if(${VTK_BINARY_DIR} STREQUAL ${VTK_SOURCE_DIR})
INCLUDE(${VTK_BINARY_DIR}/LocalUserOptions.cmake OPTIONAL)
else(${VTK_BINARY_DIR} STREQUAL ${VTK_SOURCE_DIR})
INCLUDE(${VTK_BINARY_DIR}/LocalUserOptions.cmake OPTIONAL)
INCLUDE(${VTK_SOURCE_DIR}/LocalUserOptions.cmake OPTIONAL)
endif(${VTK_BINARY_DIR} STREQUAL ${VTK_SOURCE_DIR})

Tags

No tags attached.

Project

Type

Attached Files

Relationships

Notes
(0037189) Kitware Robot (administrator) 2016-08-12 09:55	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current VTK Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2010-08-04 11:52	lesmana	New Issue
2011-06-16 13:11	Zack Galbreath	Category	=> (No Category)
2016-08-12 09:55	Kitware Robot	Note Added: 0037189
2016-08-12 09:55	Kitware Robot	Status	expired => closed
2016-08-12 09:55	Kitware Robot	Resolution	open => moved
2016-08-12 09:55	Kitware Robot	Assigned To	=> Kitware Robot