| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0012208 | VTK | (No Category) | public | 2011-05-19 14:20 | 2013-04-05 20:26 | ||||
| Reporter | Johannes Feist | ||||||||
| Assigned To | Utkarsh Ayachit | ||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0012208: ExodusIIReader handles requested time wrongly | ||||||||
| Description | The ExodusIIReader seems to handle the time that is requested from the pipeline (via UPDATE_TIME_STEPS) wrongly. Specifically, in the routine vtkExodusIIReader::RequestData(vtkInformation* vtkNotUsed(request), vtkInformationVector** vtkNotUsed(inputVector), vtkInformationVector* outputVector), there is an int timeStep that is set to this->TimeStep in the beginning. Afterwards, this->TimeStep is updated to the value closest to the requested UPDATA_TIME_STEP. Then, however, timeStep is used as the time step for which data is requested, instead of this->TimeStep. I.e., one always gets the data from the time step that was correct in the _previous_ call of RequestData. The following patch fixes this: --- orig/VTK/Hybrid/vtkExodusIIReader.cxx 2010-09-27 16:40:04.000000000 -0400 +++ VTK/Hybrid/vtkExodusIIReader.cxx 2011-05-19 13:43:23.000000000 -0400 @@ -5593,7 +5593,7 @@ vtkMultiBlockDataSet *output = vtkMultiBlockDataSet::SafeDownCast( outInfo->Get( vtkDataObject::DATA_OBJECT() ) ); // Check if a particular time was requested. - int timeStep = this->TimeStep; + //int timeStep = this->TimeStep; if ( outInfo->Has( vtkStreamingDemandDrivenPipeline::UPDATE_TIME_STEPS() ) ) { // Get the requested time step. We only support requests of a single time step in this reader right now @@ -5670,8 +5670,8 @@ haveFastPath = true; } - //cout << "Requesting step " << timeStep << " for output " << output << "\n"; - this->Metadata->RequestData( timeStep, output ); + //cout << "Requesting step " << this->TimeStep << " for output " << output << "\n"; + this->Metadata->RequestData( this->TimeStep, output ); this->ProducedFastPathOutput = this->Metadata->ProducedFastPathOutput; // Restore previous fastpath values so we don't respond to old pipeline requests | ||||||||
| Tags | No tags attached. | ||||||||
| Project | |||||||||
| Type | |||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0026559) Utkarsh Ayachit (administrator) 2011-05-19 16:59 |
commit c189ee3efdadd1fef4a89530a57b277b44749780 Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Thu May 19 16:56:26 2011 -0400 Fixed BUG 0012208. Reader was using incorrect timestep value. Due to incorrect logic the reader ended up using obsolete timestep value. Fixed that. Change-Id: I756b5ac5aa11860ad6c188c7ed822b28a6005210 |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2011-05-19 14:20 | Johannes Feist | New Issue | |
| 2011-05-19 16:45 | Utkarsh Ayachit | Assigned To | => Utkarsh Ayachit |
| 2011-05-19 16:45 | Utkarsh Ayachit | Status | backlog => tabled |
| 2011-05-19 16:59 | Utkarsh Ayachit | Note Added: 0026559 | |
| 2011-05-19 16:59 | Utkarsh Ayachit | Status | tabled => @80@ |
| 2011-05-19 16:59 | Utkarsh Ayachit | Resolution | open => fixed |
| 2011-05-19 17:00 | Utkarsh Ayachit | Source_changeset_attached | => VTK master 3eeebc5f |
| 2011-05-19 17:00 | Utkarsh Ayachit | Source_changeset_attached | => VTK master c189ee3e |
| 2013-04-05 20:26 | Berk Geveci | Status | customer review => closed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |