(0035396)
Jean-Christophe Fillion-Robin (manager)
2015-10-27 14:26

From Lisa: Should be a relatively simple fix (compute new colors for the vertices of the background polygon based on what portion of the full viewport is being rendered). Of course, there could still be some artifact in the background gradient (depending on when OpenGL converts the float color to an unsigned char). The other option is to render that background polygon in 3D (I assume it is just being rendered in 2D to fill the current viewport), then it would just be part of the 3D scene and automatically work.

(0035435)
Max Smolens (developer)
2015-11-06 15:49

See https://gitlab.kitware.com/vtk/vtk/merge_requests/841 [^]

(0035524)
Max Smolens (developer)
2015-12-09 10:07

Merged in commit:
https://gitlab.kitware.com/vtk/vtk/commit/7794d4dc43875ccfa7b6bf525cdeaaa571945dd4 [^]

(0035538)
Nicole Aucoin (reporter)
2015-12-10 11:35

Does this fix the crash on Mac issue?

(0035539)
Max Smolens (developer)
2015-12-10 12:08

@nicole this fix was already in Slicer's fork of VTK. I believe the crash on Mac is only in the PR for high-resolution screenshots of the slice views:
https://github.com/Slicer/Slicer/pull/411 [^]

I don't think there's a VTK bug report for that crash yet.

(0035540)
Nicole Aucoin (reporter)
2015-12-10 12:26
edited on: 2015-12-10 12:27

Oops, sorry, got things confused. The crash was reported after you pointed me to this branch:
https://github.com/msmolens/Slicer/commit/0151ae842f3a74de2170712d930a1e6b0b088ec6 [^]
Found it, right where you'd posted above, I had made a comment on the Slicer pull request:
https://github.com/Slicer/Slicer/pull/411 [^]
I hadn't made a VTK bug report since you'd submitted that pull request fairly quickly.

(0037409)
Kitware Robot (administrator)
2016-08-12 09:55

Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current VTK Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2015-09-09 18:39	Nicole Aucoin	New Issue
2015-09-09 18:39	Nicole Aucoin	File Added: largeImageGradient.png
2015-09-09 18:40	Nicole Aucoin	File Added: RenderLargeImageGradient.py
2015-10-27 14:26	Jean-Christophe Fillion-Robin	Note Added: 0035396
2015-10-27 15:38	Jean-Christophe Fillion-Robin	Assigned To	=> Max Smolens
2015-11-06 15:49	Max Smolens	Note Added: 0035435
2015-12-09 10:07	Max Smolens	Note Added: 0035524
2015-12-09 10:07	Max Smolens	Resolution	open => fixed
2015-12-10 11:35	Nicole Aucoin	Note Added: 0035538
2015-12-10 12:08	Max Smolens	Note Added: 0035539
2015-12-10 12:26	Nicole Aucoin	Note Added: 0035540
2015-12-10 12:27	Nicole Aucoin	Note Edited: 0035540
2016-08-12 09:55	Kitware Robot	Note Added: 0037409
2016-08-12 09:55	Kitware Robot	Status	backlog => closed
2016-08-12 09:55	Kitware Robot	Resolution	fixed => moved

Notes
(0035396) Jean-Christophe Fillion-Robin (manager) 2015-10-27 14:26	From Lisa: Should be a relatively simple fix (compute new colors for the vertices of the background polygon based on what portion of the full viewport is being rendered). Of course, there could still be some artifact in the background gradient (depending on when OpenGL converts the float color to an unsigned char). The other option is to render that background polygon in 3D (I assume it is just being rendered in 2D to fill the current viewport), then it would just be part of the 3D scene and automatically work.

(0035435) Max Smolens (developer) 2015-11-06 15:49	See https://gitlab.kitware.com/vtk/vtk/merge_requests/841 [^]

(0035524) Max Smolens (developer) 2015-12-09 10:07	Merged in commit: https://gitlab.kitware.com/vtk/vtk/commit/7794d4dc43875ccfa7b6bf525cdeaaa571945dd4 [^]

(0035538) Nicole Aucoin (reporter) 2015-12-10 11:35	Does this fix the crash on Mac issue?

(0035539) Max Smolens (developer) 2015-12-10 12:08	@nicole this fix was already in Slicer's fork of VTK. I believe the crash on Mac is only in the PR for high-resolution screenshots of the slice views: https://github.com/Slicer/Slicer/pull/411 [^] I don't think there's a VTK bug report for that crash yet.

(0035540) Nicole Aucoin (reporter) 2015-12-10 12:26 edited on: 2015-12-10 12:27	Oops, sorry, got things confused. The crash was reported after you pointed me to this branch: https://github.com/msmolens/Slicer/commit/0151ae842f3a74de2170712d930a1e6b0b088ec6 [^] Found it, right where you'd posted above, I had made a comment on the Slicer pull request: https://github.com/Slicer/Slicer/pull/411 [^] I hadn't made a VTK bug report since you'd submitted that pull request fairly quickly.

(0037409) Kitware Robot (administrator) 2016-08-12 09:55	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current VTK Issues page linked in the banner at the top of this page.

Relationships