View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002402VTK(No Category)public2005-10-24 16:282016-08-12 09:54
ReporterBrad King 
Assigned ToBrad King 
PriorityhighSeverityfeatureReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0002402: Need interface for algorithms using internal pipelines
DescriptionCurrently filters using internal pipelines must manually invoke ProcessRequest on all the executives of the internal pipeline in the right order. This is verbose and hard to maintain. It also makes the signature of ProcessRequest ugly by adding the "int forward" argument.

We need a better interface to simplify use of internal pipelines.
TagsNo tags attached.
Project
Type
Attached Files

 Relationships

  Notes
(0003183)
Brad King (developer)
2005-10-24 16:28

I'm assigning this bug to myself.
(0003185)
Brad King (developer)
2005-10-24 16:43

A partial solution is to remove the forward argument from ProcessRequest and ComputePipelineMTime. SetSharedInputInformation and SetSharedOutputInformation have been added to provide minimal support for internal pipelines.

The following changes were made to VTK:

/cvsroot/VTK/VTK/Filtering/vtkCompositeDataPipeline.cxx,v <-- vtkCompositeDataPipeline.cxx
new revision: 1.31; previous revision: 1.30
/cvsroot/VTK/VTK/Filtering/vtkCompositeDataPipeline.h,v <-- vtkCompositeDataPipeline.h
new revision: 1.18; previous revision: 1.17
/cvsroot/VTK/VTK/Filtering/vtkDemandDrivenPipeline.cxx,v <-- vtkDemandDrivenPipeline.cxx
new revision: 1.42; previous revision: 1.41
/cvsroot/VTK/VTK/Filtering/vtkDemandDrivenPipeline.h,v <-- vtkDemandDrivenPipeline.h
new revision: 1.21; previous revision: 1.20
/cvsroot/VTK/VTK/Filtering/vtkExecutive.cxx,v <-- vtkExecutive.cxx
new revision: 1.29; previous revision: 1.28
/cvsroot/VTK/VTK/Filtering/vtkExecutive.h,v <-- vtkExecutive.h
new revision: 1.21; previous revision: 1.20
/cvsroot/VTK/VTK/Filtering/vtkStreamingDemandDrivenPipeline.cxx,v <-- vtkStreamingDemandDrivenPipeline.cxx
new revision: 1.37; previous revision: 1.36
/cvsroot/VTK/VTK/Filtering/vtkStreamingDemandDrivenPipeline.h,v <-- vtkStreamingDemandDrivenPipeline.h
new revision: 1.18; previous revision: 1.17
/cvsroot/VTK/VTK/Imaging/vtkImageImportExecutive.cxx,v <-- vtkImageImportExecutive.cxx
new revision: 1.3; previous revision: 1.2
/cvsroot/VTK/VTK/Imaging/vtkImageImportExecutive.h,v <-- vtkImageImportExecutive.h
new revision: 1.3; previous revision: 1.2
/cvsroot/VTK/VTK/Imaging/vtkImageOpenClose3D.cxx,v <-- vtkImageOpenClose3D.cxx
new revision: 1.32; previous revision: 1.31
/cvsroot/VTK/VTK/Rendering/Testing/Cxx/TestPriorityStreaming.cxx,v <-- TestPriorityStreaming.cxx
new revision: 1.3; previous revision: 1.2

and to ParaView:

/cvsroot/ParaView/ParaView/Servers/Filters/vtkUpdateSuppressorPipeline.cxx,v <-- vtkUpdateSuppressorPipeline.cxx
new revision: 1.5; previous revision: 1.4
/cvsroot/ParaView/ParaView/Servers/Filters/vtkUpdateSuppressorPipeline.h,v <-- vtkUpdateSuppressorPipeline.h
new revision: 1.4; previous revision: 1.3
(0003186)
Brad King (developer)
2005-10-24 16:46

I'm adding Ken to the CC list for this bug because he and I discussed the design changes.
(0003257)
David Cole (developer)
2005-11-17 14:51

These changes were made to merge this fix into the VTK-5-0 branch:

cvs -q up -j1.30 -j1.31 Filtering/vtkCompositeDataPipeline.cxx
cvs commit -m "ENH: Merge changes from main tree into VTK-5-0 branch. (cvs -q up -j1.30 -j1.31 Filtering/vtkCompositeDataPipeline.cxx)" Filtering/vtkCompositeDataPipeline.cxx
  /cvsroot/VTK/VTK/Filtering/vtkCompositeDataPipeline.cxx,v <-- vtkCompositeDataPipeline.cxx
  new revision: 1.23.2.2; previous revision: 1.23.2.1

cvs -q up -j1.17 -j1.18 Filtering/vtkCompositeDataPipeline.h
cvs commit -m "ENH: Merge changes from main tree into VTK-5-0 branch. (cvs -q up -j1.17 -j1.18 Filtering/vtkCompositeDataPipeline.h)" Filtering/vtkCompositeDataPipeline.h
  /cvsroot/VTK/VTK/Filtering/vtkCompositeDataPipeline.h,v <-- vtkCompositeDataPipeline.h
  new revision: 1.12.2.2; previous revision: 1.12.2.1

cvs -q up -j1.41 -j1.42 Filtering/vtkDemandDrivenPipeline.cxx
cvs commit -m "ENH: Merge changes from main tree into VTK-5-0 branch. (cvs -q up -j1.41 -j1.42 Filtering/vtkDemandDrivenPipeline.cxx)" Filtering/vtkDemandDrivenPipeline.cxx
  /cvsroot/VTK/VTK/Filtering/vtkDemandDrivenPipeline.cxx,v <-- vtkDemandDrivenPipeline.cxx
  new revision: 1.37.4.3; previous revision: 1.37.4.2

cvs -q up -j1.20 -j1.21 Filtering/vtkDemandDrivenPipeline.h
cvs commit -m "ENH: Merge changes from main tree into VTK-5-0 branch. (cvs -q up -j1.20 -j1.21 Filtering/vtkDemandDrivenPipeline.h)" Filtering/vtkDemandDrivenPipeline.h
  /cvsroot/VTK/VTK/Filtering/vtkDemandDrivenPipeline.h,v <-- vtkDemandDrivenPipeline.h
  new revision: 1.18.4.2; previous revision: 1.18.4.1

cvs -q up -j1.28 -j1.29 Filtering/vtkExecutive.cxx
cvs commit -m "ENH: Merge changes from main tree into VTK-5-0 branch. (cvs -q up -j1.28 -j1.29 Filtering/vtkExecutive.cxx)" Filtering/vtkExecutive.cxx
  /cvsroot/VTK/VTK/Filtering/vtkExecutive.cxx,v <-- vtkExecutive.cxx
  new revision: 1.27.4.2; previous revision: 1.27.4.1

cvs -q up -j1.20 -j1.21 Filtering/vtkExecutive.h
cvs commit -m "ENH: Merge changes from main tree into VTK-5-0 branch. (cvs -q up -j1.20 -j1.21 Filtering/vtkExecutive.h)" Filtering/vtkExecutive.h
  /cvsroot/VTK/VTK/Filtering/vtkExecutive.h,v <-- vtkExecutive.h
  new revision: 1.19.4.2; previous revision: 1.19.4.1

cvs -q up -j1.36 -j1.37 Filtering/vtkStreamingDemandDrivenPipeline.cxx
cvs commit -m "ENH: Merge changes from main tree into VTK-5-0 branch. (cvs -q up -j1.36 -j1.37 Filtering/vtkStreamingDemandDrivenPipeline.cxx)" Filtering/vtkStreamingDemandDrivenPipeline.cxx
  /cvsroot/VTK/VTK/Filtering/vtkStreamingDemandDrivenPipeline.cxx,v <-- vtkStreamingDemandDrivenPipeline.cxx
  new revision: 1.35.2.1; previous revision: 1.35

cvs -q up -j1.17 -j1.18 Filtering/vtkStreamingDemandDrivenPipeline.h
cvs commit -m "ENH: Merge changes from main tree into VTK-5-0 branch. (cvs -q up -j1.17 -j1.18 Filtering/vtkStreamingDemandDrivenPipeline.h)" Filtering/vtkStreamingDemandDrivenPipeline.h
  /cvsroot/VTK/VTK/Filtering/vtkStreamingDemandDrivenPipeline.h,v <-- vtkStreamingDemandDrivenPipeline.h
  new revision: 1.16.4.1; previous revision: 1.16

cvs -q up -j1.2 -j1.3 Imaging/vtkImageImportExecutive.cxx
cvs commit -m "ENH: Merge changes from main tree into VTK-5-0 branch. (cvs -q up -j1.2 -j1.3 Imaging/vtkImageImportExecutive.cxx)" Imaging/vtkImageImportExecutive.cxx
  /cvsroot/VTK/VTK/Imaging/vtkImageImportExecutive.cxx,v <-- vtkImageImportExecutive.cxx
  new revision: 1.2.6.1; previous revision: 1.2

cvs -q up -j1.2 -j1.3 Imaging/vtkImageImportExecutive.h
cvs commit -m "ENH: Merge changes from main tree into VTK-5-0 branch. (cvs -q up -j1.2 -j1.3 Imaging/vtkImageImportExecutive.h)" Imaging/vtkImageImportExecutive.h
  /cvsroot/VTK/VTK/Imaging/vtkImageImportExecutive.h,v <-- vtkImageImportExecutive.h
  new revision: 1.2.6.1; previous revision: 1.2

cvs -q up -j1.31 -j1.32 Imaging/vtkImageOpenClose3D.cxx
cvs commit -m "ENH: Merge changes from main tree into VTK-5-0 branch. (cvs -q up -j1.31 -j1.32 Imaging/vtkImageOpenClose3D.cxx)" Imaging/vtkImageOpenClose3D.cxx
  /cvsroot/VTK/VTK/Imaging/vtkImageOpenClose3D.cxx,v <-- vtkImageOpenClose3D.cxx
  new revision: 1.30.4.2; previous revision: 1.30.4.1

cvs -q up -j1.2 -j1.3 Rendering/Testing/Cxx/TestPriorityStreaming.cxx
  cvs update: file Rendering/Testing/Cxx/TestPriorityStreaming.cxx does not exist, but is present in revision 1.3
    NOTE:
      File ignored since it was added to CVS after branching VTK-5-0...
      ...and we did not merge in the CMakeLists file including it anyhow...
(0003258)
David Cole (developer)
2005-11-17 15:00

And this one too to get rid of the corresponding dashboard warnings...

cvs -q up -j1.31 -j1.32 Filtering/vtkCompositeDataPipeline.cxx
cvs commit -m "ENH: Merge changes from main tree into VTK-5-0 branch. (cvs -q up -j1.31 -j1.32 Filtering/vtkCompositeDataPipeline.cxx)" Filtering/vtkCompositeDataPipeline.cxx
  /cvsroot/VTK/VTK/Filtering/vtkCompositeDataPipeline.cxx,v <-- vtkCompositeDataPipeline.cxx
  new revision: 1.23.2.3; previous revision: 1.23.2.2
(0036803)
Kitware Robot (administrator)
2016-08-12 09:54

Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current VTK Issues page linked in the banner at the top of this page.

 Issue History
Date Modified Username Field Change
2011-06-16 13:11 Zack Galbreath Category => (No Category)
2016-08-12 09:54 Kitware Robot Note Added: 0036803
2016-08-12 09:54 Kitware Robot Status expired => closed
2016-08-12 09:54 Kitware Robot Resolution open => moved


Copyright © 2000 - 2018 MantisBT Team