View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005775

VTK

(No Category)

public

2007-09-25 03:30

2008-06-03 14:48

Reporter

emiliano79

Assigned To

Sean McBride

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0005775: vtkPLYReader does not work on win and mac ASCII ply files

Description

The vtkPLYReader is able to load ply files either in binary format or in ASCII format, but in the second case there is a problem with line termination characters. The vtkPLYReader reads only ASCII lines terminating with LF character (0x0A) according to unix-like operating systems: to achieve platform independence, it is supposed to works fine also on win and mac ASCII files. In the former the lines terminate with CR LF (0x0D 0x0A), in the latter lines terminate with CR (0x0D). So the vtkPLYReader has to recognize different line terminations as well.

Additional Information

I have modified the vtkPLY.cxx file to implement platform independent line termination reading.
Just replace this section in the vtkPLY.cxx file:

/* convert line-feed and tabs into spaces */
  /* (this guarentees that there will be a space before the */
  /* null character at the end of the string) */

  str[BIG_STRING-2] = ' ';
  str[BIG_STRING-1] = '\0';

  for (ptr = str, ptr2 = str_copy; *ptr != '\0'; ptr++, ptr2++) {
    *ptr2 = *ptr;

    if (*ptr == '\t') {
      *ptr = ' ';
      *ptr2 = ' ';
    }

    else if (*ptr == '\n') {
      *ptr = ' ';
      *ptr2 = '\0';
      break;
    }
  }

with:

  /* convert line-feed and tabs into spaces */
  /* (this guarentees that there will be a space before the */
  /* null character at the end of the string) */

  str[BIG_STRING-2] = ' ';
  str[BIG_STRING-1] = '\0';

  for (ptr = str, ptr2 = str_copy; *ptr != '\0'; ptr++, ptr2++) {
    *ptr2 = *ptr;

    if (*ptr == '\t') {
      *ptr = ' ';
      *ptr2 = ' ';
    }

/* -----------------------------------------------------------------------
    *-*-* PATCH *-*-* PATCH *-*-* PATCH *-*-* PATCH *-*-*
--------------------------------------------------------------------------
Patch to allow reading PLY files in Unix, Windows and Mac end line format
------------------------------------------------------------------------*/

    else if (*ptr == '\r') {
      *ptr = ' ';
      *ptr2 = '\0';
    }

/* -----------------------------------------------------------------------
    *-*-* PATCH *-*-* PATCH *-*-* PATCH *-*-* PATCH *-*-*
-------------------------------------------------------------------------/

    else if (*ptr == '\n') {
      *ptr = ' ';
      *ptr2 = '\0';
      break;
    }
  }

Tags

No tags attached.

Project

Type

Attached Files

plyPatch.txt [^] (2,289 bytes) 2007-11-12 15:36 [Show Content] [Hide Content]

? .DS_Store
? Rendering/.DS_Store
Index: IO/vtkPLY.cxx
===================================================================
RCS file: /cvsroot/VTK/VTK/IO/vtkPLY.cxx,v
retrieving revision 1.26
diff -r1.26 vtkPLY.cxx
83,85c83,85
< "char", "short", "int",
< "uchar", "ushort", "uint",
< "float", "double",
---
> "char", "short", "int", "int32",
> "uchar", "ushort", "uint", "uint8",
> "float", "float32", "double",
89c89
<   0, 1, 2, 4, 1, 2, 4, 4, 8
---
>   0, 1, 2, 4, 4, 1, 2, 4, 1, 4, 4, 8
1781a1782,1787
>   
>   char *pos = strstr(str, "vertex_index");
>   if (pos != NULL)
>   {
> 	strcpy(pos, "vertex_indices");
>   }
1795a1802,1805
> 	else if (*ptr == '\r') {
>       *ptr = ' ';
>       *ptr2 = '\0';
>     }
1871a1882,1885
> 	case PLY_UINT8:
>       puchar = (unsigned char *) item;
>       uint_value = *puchar;
>       return ((double) uint_value);
1880a1895
> 	case PLY_INT32:
1888a1904
> 	case PLY_FLOAT32:
1939a1956
> 	case PLY_INT32:
1945a1963
> 	case PLY_UINT8:
1962a1981
> 	case PLY_FLOAT32:
2004a2024
> 	case PLY_INT32:
2007a2028
> 	case PLY_UINT8:
2012a2034
> 	case PLY_FLOAT32:
2059a2082,2086
> 	case PLY_UINT8:
>       puchar = (unsigned char *) item;
>       uint_value = *puchar;
>       fprintf (fp, "%d ", uint_value);
>       return ((double) uint_value);
2070a2098
> 	case PLY_INT32:
2080a2109
> 	case PLY_FLOAT32:
2124a2154
> 	case PLY_UINT8:
2139a2170
> 	case PLY_INT32:
2149a2181
> 	case PLY_FLOAT32:
2200a2233
> 	case PLY_UINT8:
2224a2258
> 	case PLY_INT32:
2242a2277
> 	case PLY_FLOAT32:
2294a2330,2331
> 	case PLY_INT32:
> 	case PLY_UINT8:
2306a2344
> 	case PLY_FLOAT32:
2354a2393
> 	case PLY_UINT8:
2366a2406
> 	case PLY_INT32:
2374a2415
> 	case PLY_FLOAT32:
Index: IO/vtkPLY.h
===================================================================
RCS file: /cvsroot/VTK/VTK/IO/vtkPLY.h,v
retrieving revision 1.15
diff -r1.15 vtkPLY.h
80,85c80,88
< #define PLY_UCHAR      4
< #define PLY_USHORT     5
< #define PLY_UINT       6
< #define PLY_FLOAT      7
< #define PLY_DOUBLE     8
< #define PLY_END_TYPE   9
---
> #define PLY_INT32      4
> #define PLY_UCHAR      5
> #define PLY_USHORT     6
> #define PLY_UINT       7
> #define PLY_UINT8      8
> #define PLY_FLOAT      9
> #define PLY_FLOAT32    10
> #define PLY_DOUBLE     11
> #define PLY_END_TYPE   12

TestPLYReader.cxx [^] (2,441 bytes) 2007-11-12 16:58

TestPLYReader.png [^] (32,740 bytes) 2007-11-12 16:58

plyTestPatch.txt [^] (3,307 bytes) 2007-11-12 16:59 [Show Content] [Hide Content]

? .DS_Store
? IO/.DS_Store
? IO/Testing/.DS_Store
? IO/Testing/Cxx/.DS_Store
? IO/Testing/Cxx/TestPLYReader.cxx
? IO/Testing/Tcl/TestPLYReader.tcl
? Imaging/Testing/.DS_Store
? Rendering/.DS_Store
Index: IO/vtkPLY.cxx
===================================================================
RCS file: /cvsroot/VTK/VTK/IO/vtkPLY.cxx,v
retrieving revision 1.26
diff -r1.26 vtkPLY.cxx
83,85c83,85
< "char", "short", "int",
< "uchar", "ushort", "uint",
< "float", "double",
---
> "char", "short", "int", "int32",
> "uchar", "ushort", "uint", "uint8",
> "float", "float32", "double",
89c89
<   0, 1, 2, 4, 1, 2, 4, 4, 8
---
>   0, 1, 2, 4, 4, 1, 2, 4, 1, 4, 4, 8
1781a1782,1787
>   
>   char *pos = strstr(str, "vertex_index");
>   if (pos != NULL)
>   {
> 	strcpy(pos, "vertex_indices");
>   }
1795a1802,1805
> 	else if (*ptr == '\r') {
>       *ptr = ' ';
>       *ptr2 = '\0';
>     }
1871a1882,1885
> 	case PLY_UINT8:
>       puchar = (unsigned char *) item;
>       uint_value = *puchar;
>       return ((double) uint_value);
1880a1895
> 	case PLY_INT32:
1888a1904
> 	case PLY_FLOAT32:
1939a1956
> 	case PLY_INT32:
1945a1963
> 	case PLY_UINT8:
1962a1981
> 	case PLY_FLOAT32:
2004a2024
> 	case PLY_INT32:
2007a2028
> 	case PLY_UINT8:
2012a2034
> 	case PLY_FLOAT32:
2059a2082,2086
> 	case PLY_UINT8:
>       puchar = (unsigned char *) item;
>       uint_value = *puchar;
>       fprintf (fp, "%d ", uint_value);
>       return ((double) uint_value);
2070a2098
> 	case PLY_INT32:
2080a2109
> 	case PLY_FLOAT32:
2124a2154
> 	case PLY_UINT8:
2139a2170
> 	case PLY_INT32:
2149a2181
> 	case PLY_FLOAT32:
2200a2233
> 	case PLY_UINT8:
2224a2258
> 	case PLY_INT32:
2242a2277
> 	case PLY_FLOAT32:
2294a2330,2331
> 	case PLY_INT32:
> 	case PLY_UINT8:
2306a2344
> 	case PLY_FLOAT32:
2354a2393
> 	case PLY_UINT8:
2366a2406
> 	case PLY_INT32:
2374a2415
> 	case PLY_FLOAT32:
Index: IO/vtkPLY.h
===================================================================
RCS file: /cvsroot/VTK/VTK/IO/vtkPLY.h,v
retrieving revision 1.15
diff -r1.15 vtkPLY.h
80,85c80,88
< #define PLY_UCHAR      4
< #define PLY_USHORT     5
< #define PLY_UINT       6
< #define PLY_FLOAT      7
< #define PLY_DOUBLE     8
< #define PLY_END_TYPE   9
---
> #define PLY_INT32      4
> #define PLY_UCHAR      5
> #define PLY_USHORT     6
> #define PLY_UINT       7
> #define PLY_UINT8      8
> #define PLY_FLOAT      9
> #define PLY_FLOAT32    10
> #define PLY_DOUBLE     11
> #define PLY_END_TYPE   12
Index: IO/Testing/Cxx/CMakeLists.txt
===================================================================
RCS file: /cvsroot/VTK/VTK/IO/Testing/Cxx/CMakeLists.txt,v
retrieving revision 1.34
diff -r1.34 CMakeLists.txt
14c14
<   SET(ConditionalTests ${ConditionalTests} TestHyperOctreeIO.cxx)
---
>   SET(ConditionalTests ${ConditionalTests} TestHyperOctreeIO.cxx TestPLYReader.cxx)
69a70,73
>     ADD_TEST(TestPLYReader ${CXX_TEST_PATH}/${KIT}CxxTests
>          TestPLYReader -D ${VTK_DATA_ROOT}
>          -T ${VTK_BINARY_DIR}/Testing/Temporary
>          -V ${VTK_DATA_ROOT}/Baseline/${KIT}/TestPLYReader.png)
Index: IO/Testing/Tcl/CMakeLists.txt
===================================================================
RCS file: /cvsroot/VTK/VTK/IO/Testing/Tcl/CMakeLists.txt,v
retrieving revision 1.33
diff -r1.33 CMakeLists.txt
10a11
>       TestPLYReader

Relationships

Notes
(0009282) emiliano79 (reporter) 2007-09-25 03:46	The modified function in the vtkPLY.cxx file is the get_words() one.

(0009668) Mathieu Coursolle (reporter) 2007-11-12 15:38	Here is a patch with the proposed changed. It also contains the changes proposed in 5776. New file types are added (float32, int32 and uint8), to be able to open the stanford bunny: http://www-graphics.stanford.edu/data/3Dscanrep/ [^] It was tested on Intel Mac OS 10.5.

(0009669) Mathieu Coursolle (reporter) 2007-11-12 17:00	I attached a proposed test which loads the stanford bunny available at: ftp://graphics.stanford.edu/pub/3Dscanrep/bunny.tar.gz [^] I attached the test file: TestPLYReader.cxx the validation image: TestPLYReader.png as well as the updated patch file which include that test.

(0009686) Sean McBride (developer) 2007-11-15 10:50	We have just committed a fix for this in CVS, as of 2007-11-15 10:50 ish. Can you please confirm it is fixed? Thanks.

(0012229) Sean McBride (developer) 2008-06-03 14:48	Many months with no feedback from reporter. Closed.

Issue History
Date Modified	Username	Field	Change
2007-09-25 03:30	emiliano79	New Issue
2007-09-25 03:46	emiliano79	Note Added: 0009282
2007-11-12 15:36	Mathieu Coursolle	File Added: plyPatch.txt
2007-11-12 15:38	Mathieu Coursolle	Note Added: 0009668
2007-11-12 16:58	Mathieu Coursolle	File Added: TestPLYReader.cxx
2007-11-12 16:58	Mathieu Coursolle	File Added: TestPLYReader.png
2007-11-12 16:59	Mathieu Coursolle	File Added: plyTestPatch.txt
2007-11-12 17:00	Mathieu Coursolle	Note Added: 0009669
2007-11-14 12:38	Sean McBride	Status	backlog => tabled
2007-11-14 12:38	Sean McBride	Assigned To	=> Sean McBride
2007-11-15 10:50	Sean McBride	Status	tabled => @80@
2007-11-15 10:50	Sean McBride	Resolution	open => fixed
2007-11-15 10:50	Sean McBride	Note Added: 0009686
2008-06-03 14:48	Sean McBride	Status	@80@ => closed
2008-06-03 14:48	Sean McBride	Note Added: 0012229
2011-06-16 13:11	Zack Galbreath	Category	=> (No Category)