View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0008130VTK(No Category)public2008-11-20 14:482016-08-12 09:55
ReporterBenjamin Schindler 
Assigned ToKitware Robot 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0008130: Make vtkPointLocator::findClosestPointsWithinRadius thread-safe
DescriptionIt is reportet that findClosestsPointsWithinRadius is supposed to be thread-safe. Well, it's not in 5.2.

Changing line 920 from:

pt = this->DataSet->GetPoint(ptId);

to

this->DataSet->GetPoint(ptId, pt);

(and converting pt from double* to double[3])

Makes it work for me. I'm not yet sure whether the buckets used there are thread-safe (haven't had a look at it), but my code seems happy atm
TagsNo tags attached.
Project
Type
Attached Filespatch file icon 0001-Make-FindPointsWithinRadius-race-free.patch [^] (1,122 bytes) 2008-11-21 06:02 [Show Content]

 Relationships

  Notes
(0014158)
Benjamin Schindler (reporter)
2008-11-21 11:57

Ok, forget about it. The code is obviously still racy

I have a very big big dislike for this kind of design (Returning a pointer to an internal buffer which is a copy of data). I really would suggest to use something different. It also hurts performance to an extreme amount. I'm running some sph interpolation and have to run FindClosestPoints quite a lot.
On benchmarking, I figured that 50% (!!!!!) of the time in FindClosestPoints is spent during GetPoints creating completely unnecessary copies of data.
(0037040)
Kitware Robot (administrator)
2016-08-12 09:55

Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current VTK Issues page linked in the banner at the top of this page.

 Issue History
Date Modified Username Field Change
2008-11-20 14:48 Benjamin Schindler New Issue
2008-11-21 06:02 Benjamin Schindler File Added: 0001-Make-FindPointsWithinRadius-race-free.patch
2008-11-21 11:57 Benjamin Schindler Note Added: 0014158
2011-06-16 13:11 Zack Galbreath Category => (No Category)
2016-08-12 09:55 Kitware Robot Note Added: 0037040
2016-08-12 09:55 Kitware Robot Status expired => closed
2016-08-12 09:55 Kitware Robot Resolution open => moved
2016-08-12 09:55 Kitware Robot Assigned To => Kitware Robot


Copyright © 2000 - 2018 MantisBT Team