| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0009024 | ParaView | Bug | public | 2009-05-13 20:20 | 2009-07-31 19:18 | ||||
| Reporter | Alan Scott | ||||||||
| Assigned To | Julien Finet | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | |||||||||
| Target Version | 3.6.2 | Fixed in Version | |||||||
| Summary | 0009024: Calculator doesn't handle auto apply well. | ||||||||
| Description | * ParaView trunk, XP, local server. * Turn Edit/ Settings/ Auto Accept on. * Source/ Sphere. * Calculator. You will immediately see error messages. * Type the following in formula, slowly: coordsX/sqrt(4) <<Error >> Errors occur every key stroke. | ||||||||
| Tags | No tags attached. | ||||||||
| Project | |||||||||
| Topic Name | |||||||||
| Type | |||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0016910) Utkarsh Ayachit (administrator) 2009-07-19 09:42 |
Julien, we can address this bug by following fixes: * Make the ArrayCalculator accept empty functions as the trivial case and not produce any errors. * In the panel, use the editingFinished() signal from the QLineEdit instead of keyPress (or whatever it's using currently). |
|
(0016940) Julien Finet (developer) 2009-07-22 13:28 |
As it has been suggested, here is what has been done: Don't treat empty functions as errors. Process the "function" only when return key or enter is pressed. Qt/Components/pqCalculatorPanel.cxx: 1.25 VTK/Graphics/vtkArrayCalculator.cxx: 1.45 |
|
(0016948) Alan Scott (manager) 2009-07-22 19:21 |
Tested local client, Linux. Works great! |
|
(0016950) Utkarsh Ayachit (administrator) 2009-07-23 09:01 |
Committed to 3.6 branch Patch title (first comment line): BUG: Calculator with AutoApply generates too many errors. Don't treat empty functions as errors. Process the function only when return key or enter is pressed.MantisID:9024 Autocommit cvs commit -F .msg 'Qt/Components/pqCalculatorPanel.cxx' 'VTK/Graphics/vtkArrayCalculator.cxx' Committer: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Committer: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Commit to directory "ParaView3/VTK/Graphics" lies in external project VTK Committer: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> /cvsroot/ParaView3/ParaView3/Qt/Components/pqCalculatorPanel.cxx,v <-- Qt/Components/pqCalculatorPanel.cxx new revision: 1.24.2.1; previous revision: 1.24 /cvsroot/ParaView3/ParaView3/VTK/Graphics/vtkArrayCalculator.cxx,v <-- VTK/Graphics/vtkArrayCalculator.cxx new revision: 1.44.2.1; previous revision: 1.44 |
|
(0016954) Alan Scott (manager) 2009-07-23 13:05 |
I don't think that this works properly, at least on Linux. * ParaView 3.6 branch, Auto Accept on. Local server. * Open can.exo. * calculator. The can will immediately go away. * Change result to "fred". * Enter formula coordsX/sqrt(4), can comes back. Utkarsh - this isn't expected behavior, is it? |
|
(0016976) Julien Finet (developer) 2009-07-27 08:33 |
Calculator now outputs a dataset even if the "Function" is empty or invalid. File modified: VTK/Graphics/vtkArrayCalculator.cxx: 1.46 |
|
(0017043) Alan Scott (manager) 2009-07-31 19:18 |
Much better. Tested local server, Linux. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2009-05-13 20:20 | Alan Scott | New Issue | |
| 2009-05-14 09:13 | Ken Moreland | Target Version | => 3.8 |
| 2009-06-03 10:34 | Utkarsh Ayachit | Status | backlog => tabled |
| 2009-06-03 10:34 | Utkarsh Ayachit | Assigned To | => Julien Finet |
| 2009-07-19 09:38 | Utkarsh Ayachit | Priority | low => normal |
| 2009-07-19 09:38 | Utkarsh Ayachit | Target Version | 3.8 => 3.6.2 |
| 2009-07-19 09:42 | Utkarsh Ayachit | Note Added: 0016910 | |
| 2009-07-22 13:28 | Julien Finet | Note Added: 0016940 | |
| 2009-07-22 13:28 | Julien Finet | Status | tabled => @80@ |
| 2009-07-22 13:28 | Julien Finet | Resolution | open => fixed |
| 2009-07-22 19:21 | Alan Scott | Note Added: 0016948 | |
| 2009-07-22 19:21 | Alan Scott | Status | @80@ => closed |
| 2009-07-23 09:01 | Utkarsh Ayachit | Note Added: 0016950 | |
| 2009-07-23 13:05 | Alan Scott | Note Added: 0016954 | |
| 2009-07-23 13:05 | Alan Scott | Status | closed => tabled |
| 2009-07-27 08:33 | Julien Finet | Note Added: 0016976 | |
| 2009-07-27 08:33 | Julien Finet | Status | tabled => @80@ |
| 2009-07-31 19:18 | Alan Scott | Note Added: 0017043 | |
| 2009-07-31 19:18 | Alan Scott | Status | @80@ => closed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |