View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0015787

VTK

Bug

public

2015-10-16 14:15

2015-10-28 00:07

Reporter

Max Smolens

Assigned To

Alexis Girault

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0015787: Setting vtkCornerAnnotation text to empty string renders incorrectly

Description

After a text element of vtkCornerAnnotation has been set to a non-empty string and has been rendered, then setting the text element to an empty string results in incorrect rendering.

Result:
A rectangle is drawn with the bounds of the previous text element.

Expected result:
Nothing is drawn.

See attached file that's modified from the CornerAnnotation example [1].

Also see a proposed solution in the attached patch.

Reproduced with gitlab VTK as of commit 5158a4ce.

[1] http://www.vtk.org/Wiki/VTK/Examples/Cxx/Visualization/CornerAnnotation [^]

Tags

hackaton

Project

TBD

Type

incorrect functionality

Attached Files

CornerAnnotation.cxx [^] (2,011 bytes) 2015-10-16 14:15

vtkTextMapper-empty-string.patch [^] (487 bytes) 2015-10-16 14:15 [Show Content] [Hide Content]

diff --git a/Rendering/Core/vtkTextMapper.cxx b/Rendering/Core/vtkTextMapper.cxx
index 9f5b67b..b5df7eb 100644
--- a/Rendering/Core/vtkTextMapper.cxx
+++ b/Rendering/Core/vtkTextMapper.cxx
@@ -367,7 +367,7 @@ void vtkTextMapper::RenderOverlay(vtkViewport *viewport, vtkActor2D *actor)
   vtkDebugMacro(<<"RenderOverlay called");
 
   vtkRenderer *ren = NULL;
-  if (this->Input && this->Input[0])
+  if (this->Input)
     {
     vtkWindow *win = viewport->GetVTKWindow();
     if (!win)

CornerAnnotation.png [^] (14,357 bytes) 2015-10-16 14:18

Relationships

Notes
(0035312) Jean-Christophe Fillion-Robin (manager) 2015-10-19 15:38 edited on: 2015-10-19 15:39	@Max: Thanks for reporting the issue. To better understand the context, did you build VTK using OpenGL or OpenGL2 backend ?

(0035313) Jean-Christophe Fillion-Robin (manager) 2015-10-19 15:44	From Max comment posted on the associated Slicer issue: With the OpenGL backend it renders a white rectangle, like in Slicer. With the OpenGL2 backend it renders a black rectangle. See http://www.na-mic.org/Bug/view.php?id=4043#c13387 [^]

(0035402) Cory Quammen (developer) 2015-10-28 00:07	Fixed with gitlab merge request https://gitlab.kitware.com/vtk/vtk/merge_requests/794 [^]

Issue History
Date Modified	Username	Field	Change
2015-10-16 14:15	Max Smolens	New Issue
2015-10-16 14:15	Max Smolens	File Added: CornerAnnotation.cxx
2015-10-16 14:15	Max Smolens	File Added: vtkTextMapper-empty-string.patch
2015-10-16 14:18	Max Smolens	File Added: CornerAnnotation.png
2015-10-19 14:44	Utkarsh Ayachit	Tag Attached: Hackathon-Oct-2015
2015-10-19 14:50	Utkarsh Ayachit	Tag Detached: Hackathon-Oct-2015
2015-10-19 14:50	Utkarsh Ayachit	Tag Attached: hackaton
2015-10-19 15:38	Jean-Christophe Fillion-Robin	Note Added: 0035312
2015-10-19 15:39	Jean-Christophe Fillion-Robin	Note Edited: 0035312
2015-10-19 15:44	Jean-Christophe Fillion-Robin	Note Added: 0035313
2015-10-21 11:31	Alexis Girault	Note Added: 0035329
2015-10-21 11:39	Alexis Girault	Assigned To	=> Alexis Girault
2015-10-21 13:30	Alexis Girault	Note Deleted: 0035329
2015-10-21 13:34	Alexis Girault	Reproducibility	have not tried => always
2015-10-21 13:34	Alexis Girault	Status	backlog => gerrit review
2015-10-21 13:34	Alexis Girault	Category	(No Category) => Bug
2015-10-28 00:07	Cory Quammen	Note Added: 0035402
2015-10-28 00:07	Cory Quammen	Status	gerrit review => closed
2015-10-28 00:07	Cory Quammen	Resolution	open => fixed